From nobody Mon Sep 14 04:50:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1788878893; cv=none; d=zohomail.com; s=zohoarc; b=MbL7vz+MmEENk18jhaj7P2VSi0n+9lo15HNavY8tQfqYoYr3YFr9vlO6IMY5CiIl1fOhg9dje95fhX5FVW5EosZABCTs5dVG8Q8JqO4Pl/IIF7tfNmxF1ly9BUQQYUxbG8u1s8NXzV2BoU2WhsHTwW/ddINpwwgR+jmBHpOMUD8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788878893; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=J3+BpzWN4YpKL/MJIBlXDk6t8Dh35iSeP2zCTTwRHFA=; b=ZSQ9A8Mc+vxh4LB9c54IawI35CQ2x8s80owEfMsbmbhIZjKxMgkkm3QpEjqZtgTzJTIgX53P5wgPitSMFQxWljbhbaSube67dODumO9DsBItJKCw1mhr0q8IR6gH361NpNCqQYS8PLvoev3ix2yTqQTi0ihyJqmFWO0gXTVEW4E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1788878893514327.9868140462181; Tue, 8 Sep 2026 07:48:13 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1F0293F802; Tue, 8 Sep 2026 10:48:12 -0400 (EDT) Received: from [172.19.199.13] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 9E3E2417F9 for ; Tue, 8 Sep 2026 10:47:10 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B3C6A3F292; Tue, 8 Sep 2026 10:46:59 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 60E943F292 for ; Tue, 8 Sep 2026 10:46:58 -0400 (EDT) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-dsGk8sJTMcOwjcc8q5YQeA-1; Tue, 08 Sep 2026 10:46:56 -0400 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2043E1956095 for ; Tue, 8 Sep 2026 14:46:55 +0000 (UTC) Received: from berrange.csb (headnet03.pony-001.prod.iad2.dc.redhat.com [10.2.32.114]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 640311956042; Tue, 8 Sep 2026 14:46:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, RCVD_IN_SBL_CSS,SPF_HELO_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1788878817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=J3+BpzWN4YpKL/MJIBlXDk6t8Dh35iSeP2zCTTwRHFA=; b=M0yBfPswONpNKQzBAIShftxUi07Oxqeu8BKxa1TVd5wl2KrhiPmtWa562cbf355HzXwHXZ Tp74GydE+7bstuGODzAkSX8QxYUkyZrdStFVU0VLnYL7GAK7dcaGJj/6AZKmbnVtbhaQff caCNtuCDUFWk2WVJLwa7CxgILsxbOco= X-MC-Unique: dsGk8sJTMcOwjcc8q5YQeA-1 X-Mimecast-MFC-AGG-ID: dsGk8sJTMcOwjcc8q5YQeA_1788878815 To: devel@lists.libvirt.org Subject: [PATCH] src: stop using deprecated syntax for hv-crash argument Date: Tue, 8 Sep 2026 15:46:53 +0100 Message-ID: <20260908144653.443068-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3BAEcCzlgkE5DD0VgYEOTvyrtUZVAmp0_KtOEvq-wBw_1788878815 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: YBYT3DHC3V5MZMAPKSVM5MAFXD6XMTRT X-Message-ID-Hash: YBYT3DHC3V5MZMAPKSVM5MAFXD6XMTRT X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1788878898574158501 From: Daniel P. Berrang=C3=A9 QEMU historically accepted bare keywords as a short-cut for turning on a boolean option. This was deprecated quite a long time ago and most usage would trigger a warning from QEMU, but the -cpu arg is special and doesn't warn. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Peter Krempa --- src/qemu/qemu_command.c | 2 +- tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args | 2 +- tests/qemuxmlconfdata/panic-double.x86_64-latest.args | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index a07b915f4d..bcddb9c922 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6748,7 +6748,7 @@ qemuBuildCpuCommandLine(virCommand *cmd, =20 for (i =3D 0; i < def->npanics; i++) { if (def->panics[i]->model =3D=3D VIR_DOMAIN_PANIC_MODEL_HYPERV) { - virBufferAddLit(&buf, ",hv-crash"); + virBufferAddLit(&buf, ",hv-crash=3Don"); break; } } diff --git a/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args b/tests/= qemuxmlconfdata/hyperv-panic.x86_64-latest.args index ee0f8551c2..0182cc8e18 100644 --- a/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args +++ b/tests/qemuxmlconfdata/hyperv-panic.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Don \ -accel tcg \ --cpu qemu64,hv-crash \ +-cpu qemu64,hv-crash=3Don \ -m size=3D219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ -overcommit mem-lock=3Doff \ diff --git a/tests/qemuxmlconfdata/panic-double.x86_64-latest.args b/tests/= qemuxmlconfdata/panic-double.x86_64-latest.args index 9c5b3a7694..21ecaf4d84 100644 --- a/tests/qemuxmlconfdata/panic-double.x86_64-latest.args +++ b/tests/qemuxmlconfdata/panic-double.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Don \ -accel tcg \ --cpu qemu64,hv-crash \ +-cpu qemu64,hv-crash=3Don \ -m size=3D219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ -overcommit mem-lock=3Doff \ --=20 2.55.0