From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585253; cv=none; d=zohomail.com; s=zohoarc; b=fRycaypXrdn/YAiOHX7h34HyKJHHV14+G3WJbSB2ejHOBR/pDIwLxbo7NgCaprxlxBdgQ4DN/A4qIKh4itzifu1R1AEO+spZrcSUsxPzNO5LtyDbnMGMiuv6W+dpLiGPjOF4dhEFBX58sypUSrMM/ynmCQKTvxgnehFztgTEPT0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585253; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=hI/4kRcuHe18/qYKP2hOGxNnKh8pw1N2QjNp4C1E0DY=; b=WQexFl8OxSwkXPxSV8nl0FoNdgr1WQvKj6stnnY68UYvgDY69/6RMsktfz1Rf8WO6M452a4JQkvb81S7HA18mZtek9uTYkgirz+XVcmb45Q41Ns2oiXu9vujfk8duoCf6Oyt4PlLqZCTf31H0xbR9ZLpUTRQTGEQWFfHRuKi7xw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1787585253439667.7996260030676; Mon, 24 Aug 2026 08:27:33 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 162AF41DDC; Mon, 24 Aug 2026 11:27:32 -0400 (EDT) Received: from [172.19.199.13] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 69C8341A73 for ; Mon, 24 Aug 2026 11:25:25 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BF02A3F897; Mon, 24 Aug 2026 11:25:06 -0400 (EDT) Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2A2CE419C8 for ; Mon, 24 Aug 2026 11:25:06 -0400 (EDT) Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-69c108fee7fso5884585a12.3 for ; Mon, 24 Aug 2026 08:25:06 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e1d7399sm13500683a12.26.2026.08.24.08.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:03 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 5DD405F8BB; Mon, 24 Aug 2026 16:25:02 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585105; x=1788189905; darn=lists.libvirt.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hI/4kRcuHe18/qYKP2hOGxNnKh8pw1N2QjNp4C1E0DY=; b=pZdB3I4gpbRTPVTfBlA0jXznAM7s/n1zSUg3RV4wo/MJFXGZikKdXq1iwfF+HKOwVb SOmE9t5LVRsY6v4WKLsOTwhrwbG3474itJWvJkzLqa2708Zz0stGjzWmArJxywSFJLQg 6yti/ad/axTkDgRrUo95n8cDh+8ZwRyJH2gcLuqTTU+WHa5E0PaaX2Xd2FD3h05iELwM 4OAfgLvhou72waRKi7BpaXXwqHt0itj5DfC5hZGu9rBsDmDGarEK9Abhkjjqt+SCD5xL zX4zoxwmBsumNV6Zpm40Y0L4Le2oZrtHgirjuGoGQfW7qBxqceSIW3POByRHM6XV2JFH KfGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585105; x=1788189905; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hI/4kRcuHe18/qYKP2hOGxNnKh8pw1N2QjNp4C1E0DY=; b=WSKfTYeIlj7oVPeuby/pPFqfBmDmWziDJ0qIpcjAwZn9u/fZL7yQoA54J+tq5KY9lQ ZTPVe2IEPdeDXDyjDZYS2gwJbNZNlcSKX+pGy5L6cvJDKCNU1JWCw11us2bVsiBJPTk5 /kRCVG8aMNVzZRpmEhdD73Q23xjhUvhX9vOVfPJjI/Ya15mBSLqvXpoxLWfnq/VI+DNd U2a2QhKtjfFOYTMRUfxIRw7Y4leUcL36XSqf86ivGony5h6v70tpkcywDCJJdxQQG6Mb +NdfUjIUFMhqq6OjZvTCJv74vXzQJ4d7CtXqAc9H+/kyPFhXaTomj0r6d30xRbq925se zBGw== X-Forwarded-Encrypted: i=1; AHgh+Rrs/8eYi7UOJWNz1aDRdJeSKul4yvbaN/BcihTXq5u1L/GDyiTb0TrDuq6OtwfhmPoneuJIuQ==@lists.libvirt.org X-Gm-Message-State: AFuF++mZkQl5CF/N4ygYQabOjPK2E6ZtPEC0XoTLugN9fh7Q2Zaw64p0 KSgyERanXrK/cGAL6nHuK+IWAjW2id4qOlnsmCmixZ/Eb7P+/Ch7z5q0mkVzbXyPH04= X-Gm-Gg: AR+sD12mHgpHdcC1x8fWI2RwnL+R3uurAzjycL/EQ8NcY6rVUW/ROohCJv/9AqpfjuA j0ldY0KUx1o5vwDOoN3nXH3Dsj3u/UQ60SNuJnt+srQM+BULGriJtlYPlxBHBq+11jp/fpgqjrb IjWk815riW0+nA9ZS198+we+cceuig23tudxubi+JLEAwwtbUt8AuTFQZ0Rsl8g43fFe3/EPGQb qNC2KjsfplXdbBdZ1o1Zy+b0GcVdyvo8ja9UDLDW95B1bWH+f85unTnoZFuayUrvE27pGvwi/0V TM7nRd7BNQ5vdnlPgfw15xQe561HdzkkK5kPkxnZz7VYnNy33w/Fb/VKoKo14itU0kxrjhJnaCM bBd8xcR0BwVrY7q2JihSAnsChIA357iiFENx9a6et1qiSCmLxSca87Oe0x3isAvFKZWjPaxwQCF XROnEEfZGfCvbT4Ylq6TcCa4CQyGgS6a5PK+Mr+aLal9wvf2igqE2JO7LhoC1H X-Received: by 2002:a05:6402:501f:b0:698:6084:db7f with SMTP id 4fb4d7f45d1cf-6a582b5f1a2mr23050271a12.10.1787585104864; Mon, 24 Aug 2026 08:25:04 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:48 +0100 Subject: [PATCH v2 1/8] gitlab: use .base_meson_job_template for macOS jobs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-1-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=700; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=oLQW1QjvvZodHpTsPvGLeM5B3yePRIAQ/JBnkvtdcNQ=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJN3qf7wX053m0Vgz8GcZ4A0nHYUnlzOdQa5 ZawJlGLedOJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTQAKCRD70NsJWp4q RAulB/wOK/vInJTDlmAf73QpENyVwLMabK2Y4tqkw9Y5nrDa99Lvloe7cSUcJSkQ8NqSlnLmzV3 UWmJLJAsdS83UWIdLbyaBF41rKEI7/bdlkiUAaYqb/6k+03oM/XKgbEBucCraRgcjGHzalOz0x4 5mdgFZ6TuCEmV4p9Lxs2Rr/tv4UKNMTdNHt6049JYpgf7/HjI+OlwMebd4lu18V+3xfXD4N+1ZM WnInEaiIdzXrKvOAG/INgqRPhFhw0PIyKBCsmXwjdXAYl1VCaYnxeYP8yOlUOg7N+Qcz5DSA3el RZQEZcvDdrCPVATOSkXT4akAEDijBf1DxMMJMB9CiN/ATYuV X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Message-ID-Hash: LC3OCSWEV7SYLIZ6RVOWCOGUDN57FXRD X-Message-ID-Hash: LC3OCSWEV7SYLIZ6RVOWCOGUDN57FXRD X-MailFrom: alex.bennee@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585255208158500 This way we'll get more environmental information which will help with debugging. Reviewed-by: Pierrick Bouvier Message-ID: <20260723200904.224413-2-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/macos.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/macos.yml b/.gitlab-ci.d/macos.yml index 641a48b3832..bdb3eae18f0 100644 --- a/.gitlab-ci.d/macos.yml +++ b/.gitlab-ci.d/macos.yml @@ -1,5 +1,5 @@ .macos_job_template: - extends: .base_job_template + extends: .base_meson_job_template stage: build tags: - saas-macos-large-m2pro --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585123; cv=none; d=zohomail.com; s=zohoarc; b=LLgqjXf1b2LssY25hdqX++JEC0IA+1ZGzCn+ZFntALzvKcv+lhVCMak+1VZ20awDfcY4k4EU8fkxoS+mb2t9OgIalbCX8KNh8ZZ5Es+BXvqPtwQAyPRdbQZdtU6itZWNlA1dkzz9VxSZiBQPs+MtKbyXWcaRZBKkWrygBeCgFx0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585123; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pc/GOaaPlMM8Rx6IwwNSVab3AJ0ESXz+I20bcOy9tBo=; b=HZX15TfF6bPyr+452pNXVG6VnlYXrh23Amo1HEAku4TqwSwEgT7fGSmm7PufSt6QojNSma9Qv6zw31KQzqNniOUtTTo+9SuSbVa/3Np7mZc+r5rE8y/JvmtaRFC8TujyvrrwXdCWwPsobxPe7zE1/bNPwlHPG6H/kOC74xMX+m0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787585123248173.02623233646796; Mon, 24 Aug 2026 08:25:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWXt-0005Kb-KD; Mon, 24 Aug 2026 11:25:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWXs-0005De-55 for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:08 -0400 Received: from mail-ej1-x634.google.com ([2a00:1450:4864:20::634]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXq-0007Aj-A6 for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:07 -0400 Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-c20e70a0962so546242166b.2 for ; Mon, 24 Aug 2026 08:25:05 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249606a8fasm1465132966b.8.2026.08.24.08.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:03 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 608875F8FD; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585104; x=1788189904; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pc/GOaaPlMM8Rx6IwwNSVab3AJ0ESXz+I20bcOy9tBo=; b=jEnYjZ4PTL191QLfr721KUEkIoooDsPk+No4e7QmOL6Na6YS8pLtBt4zUNxcU/zgLR RKprX9aVEy8MR2H1/XaM4YTb+hcz0XFDc1+8gqohdp+XFLsVYG9wocOkmzA0my9YlwuU rlhh0oPVhJd24Ox94juXl4/AvBz+OqUtpXne/wbL+wddwDltXPLNcmUqPU1ATmp8j5tU l+tM/IcJDaslmEaLz7YbJw+HRlsyrIWAdoSbcmhtwc6gpYHS3cphK52Ylw90cLbNggal 0JPdXOhce1MNhvo17IRfS03OsuHrnKitVFIpt5cYpMsFAh8wy4SYtqDfbTrucbu/0UEW PIqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585104; x=1788189904; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pc/GOaaPlMM8Rx6IwwNSVab3AJ0ESXz+I20bcOy9tBo=; b=HijrVxZ99OBXZDv8mj28XhdsZAYI44NUavjhFe07O63sdsZi8BrgZeB7kf7Ifx5GR+ bAIRGv48VAbnXC/s/1CfZH4u4Zr1RZ/TcVcjy3VRQjrhNPNHy2/mnWxBklBnGoHnsUt2 yxe0TFNesJ4tz616fGroBDBhSujVVx4YmjpPXkUNgwQ6PDNlYq57MFQYTD2UyiohAiJF mjRTBQHsEipANVVFdrLsVcQ6LBUrXRCDebVy+3cEQWleZLU0v99180Nprv73dPvObycQ fszibCcnpAw2+ivaNIRUovTJ/6O4DkPjuqiOekdbR3ebqlWBZ/4XF8Xn9ADgm5epMKfy JZmw== X-Gm-Message-State: AFuF++kqJgZskyfz7UNVt8S+CD2PF698p5WPk+qMqEs/cOoyMxInL5t6 8SCYxNjFn7JRINXEdhhkOJide4i2xRXmd7grJqXqbNxpb2JraMJVALiL7TasPbHaZUU= X-Gm-Gg: AR+sD11CblUOE6BfRyOVfD4xdDMaZX0Or1O0DnempD3GRI9LNKVRJ60hOcVASGpBPAn av4+pHHFJPxwQm0q2GXkWQW9VsrcR8IYO4p+S30CIWPN4Sf5WuqGA+wnHAd+vBy5n8Db+n/2bMB Kz7gEFjDMofr8/9mLOce4VegEhDRMrB1HTEjobsvAhTquIZt+RpNx6SItck4GbYEPGchbl0GazD 9cK0XoOZPLNvsWy4ttXfQJ6rX4OZ7QdcOFdgihKJ80tDXmaSa1WzmRinG6ue4Fgw9CjbkvfQgVy 1C9mnP5h0kkDnmIV5wj8W0ryZLLwbMBq7w//B6ntenCXlu9WLB95YQGYzyyZmEtfdg5MaT0m6yP t81EOdatjX/C/TcInJJdH8qI70Y/aW4qPRGxTkbvSNBmLHujtAu1LWGe+r5PL5lG+WdI2WXbxn0 fAD/uh/wxO5YYRl9XlA/Qt/kLu6IhSStSEDGWkBE7NdbotF4U4y8orX8cH3FrB X-Received: by 2002:a17:906:6a25:b0:c16:12ff:dc8d with SMTP id a640c23a62f3a-c246a69a22fmr3123468166b.14.1787585104127; Mon, 24 Aug 2026 08:25:04 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:49 +0100 Subject: [PATCH v2 2/8] tests/arm: add explicit CFLAGS for system build MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-2-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1369; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=MJWvive3XIw267cYiTNdmu4ac2myJrVPkfmdAGEdR0E=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJNIbE5WMJ4v7LnQtMv6FVYwlBxKdGD0QOOr x5YJTvxZAKJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTQAKCRD70NsJWp4q RBChB/4jlOMnCgcSpBlSGkJ8E2S+1E4zQgaNj9Dp9pVaknv9fjSpt4gEPBwdPiMppN5Q/4ownut 0nmoS6j2OkprCTeJ8J389Fbi7D7GhNumamKmg9hoTXLHY0h6RCQc7tOyMozOkYbOPmWidfuOGaj HxBo5UmWCHFNT0MkjNhQdOykjSbm0xiXGxkUJNuR+rdpH6yEa6FMp0iZv3RVlQOBL3kfUjmGXd+ DZb5FlsY4+SKeEzobakfTvblv9rdONx0ZcwRwZfTXa4EOubjCtOfiB9YIoxI478TSjdEkP8Oz2S 1jTTnMLav2My3A2UbToPtIfySi4+oN/lEYfJA+Urmzp5qnsM X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::634; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585124557158500 The brew toolchain on macOS (arm-none-eabi-gcc) is a little different from the default on Debian (arm-linux-gnueabihf-gcc) as a result it defaults to an older architectural baseline (without isb's), assumes softfloat and will get confused by including stdint.h without being told it is compiling freestanding code. Make these all explicit so we can build arm-softmmu tests on macOS. The test-armv6m-undef is unaffected as it has it's very own build stanza. Reviewed-by: Pierrick Bouvier Message-ID: <20260723200904.224413-3-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/arm/Makefile.softmmu-target b/tests/tcg/arm/Makefile= .softmmu-target index b66074b0b43..3e8a9b4073e 100644 --- a/tests/tcg/arm/Makefile.softmmu-target +++ b/tests/tcg/arm/Makefile.softmmu-target @@ -29,7 +29,7 @@ ARM_TESTS+=3D$(patsubst $(ARM_SRC)/%.c, %, $(ARM_TEST_SRC= S)) CRT_PATH=3D$(ARM_SRC) LINK_SCRIPT=3D$(ARM_SRC)/kernel.ld LDFLAGS=3D-Wl,-T$(LINK_SCRIPT) -CFLAGS+=3D-nostdlib -ggdb -O0 $(MINILIB_INC) +CFLAGS+=3D-march=3Darmv7-a+fp -ffreestanding -nostdlib -ggdb -O0 $(MINILIB= _INC) LDFLAGS+=3D-static -nostdlib $(CRT_OBJS) $(MINILIB_OBJS) -lgcc =20 # building head blobs --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585157; cv=none; d=zohomail.com; s=zohoarc; b=P1KSuwIEku4yrRg1jT2EUUmA59q9ryNpgELyJhstzAJzhc80TvzeOOi+3HBWMRTqZsQosNwsb9BX16jH+eBMayBcvXGK0dcMaRzKT6i0kbyjXG4KtNOYMrI7AcPs1zt4at8VUeXoe3wt0dHJKGEbapn6TyaIOHfxmJmIZe+dgRw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585157; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zEBSWmDHcpbyAT5+oxLyqv+4C5kL0TnHpRS3uvgoVbI=; b=A/zuT1MDehSXK9aodmc9pOs/1at8eXwUi6la6tkOo/mA8ibvIL65XTmY/a7QjSCYHV4PocAlhmAlhgyKjgq2TCuXpsWNdkUQLuLE3nA6rOC+hzmZ0AJpGNTGODbb6tY0DmIvb2AUSe/iGlrP83EW6wVVr9uHd3yM7xjqXe9pbxc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787585157901594.3640667817983; Mon, 24 Aug 2026 08:25:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWXy-0005bY-83; Mon, 24 Aug 2026 11:25:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWXv-0005Sb-It for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:11 -0400 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXs-0007Bh-Of for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:11 -0400 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-6a0a4a28cbdso6397323a12.3 for ; Mon, 24 Aug 2026 08:25:08 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e001095sm9806117a12.6.2026.08.24.08.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:03 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 630795FA11; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585107; x=1788189907; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zEBSWmDHcpbyAT5+oxLyqv+4C5kL0TnHpRS3uvgoVbI=; b=jwtvpKCrwpYLN+4FtoeNfNykkRmFg6x/SUepBuNNRu80ibLt+YxhGPQ8/f86e0IMT2 Gv7PspdC5YTgpwZOP/QsOhqsQ9VygvCOuE6WUp2kmwRzKWRhcXj5x0xkG/gBe6w6h5Nv 0siaL2Nlvo8BlBT87/Wz3xpauVTtzTCGgHG/lSLlLd3vtOcPnnm3UEPQPJ/2bet0sXRx uWb0/iMGdkmLVx5eoOhaYxehjA5kHhDAMqWzbuQ3l7F1M7WSTFk7EkQD+dEWol49hROd MIYKHaUWXzfUm6gTrwMA4oRExntuPdAW09zibOUSSo4OS34k7tBYnZmr/FCwpT7437H9 JCPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585107; x=1788189907; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zEBSWmDHcpbyAT5+oxLyqv+4C5kL0TnHpRS3uvgoVbI=; b=FXKh/bENUsGjfSdibcEA4IVIUr8HIuA7yIrb3jCcAKtqFI46Zgjdf44u7cYv8j4bMn QPqpfrv8iNCjoU5vduaODDNdMlnWdHAI34jIWh4pzuJiWKmZG5DQipWw7fb5y7mUngy9 bBGvV7m0b6J/rQe4dCNxmSCuD3iYhi8u3oaLlKxWhqZTg/O9Dcme81hwwW9qsOIFUl6s l0v+D2b7BTwa6kCxuz1fwpXasm0IP/og7XwvnbVwbVYZkgDQdUuOWD1MS3lmxwpLboaJ OLlAn7VfcfgpMdFpTIE0O3rv7OSgTLuKv387qbaA1sMTeqXIjRKsSRX1UJRaUKLAwSVX 1V9A== X-Gm-Message-State: AFuF++kibfD3vvZq1Pac2l00ip/QT9yY4BIugEg9coxCM8/rjHmrsONc 3s1vMKG/AxCiyvqZdIGqMMrPCDV+lKWNDnipdEfenuQdNjLf+F8asNpgq8Wq8Y/rCBg= X-Gm-Gg: AR+sD12P6+Cod0qi6zn1ZnePYbU0GtIHFcR5aWGdIDPVfl6jj39ZuMczOxbZtK5SILU suYjAhkcS8f7I2GkcmCNpEZkEIArE0MMbq8obplgULbTX3ZiSdLTRrezCOeGPjCZZy6t2I9zDSf fqeRWQ/YupoD1569ST47uv5brioIx25/ydDWuU/098a1RrspVHymI/AE+JOq+3wsg66vICSwJXo 81q3LK9yZmhVKtaCer28eBLZJV3iIQaDAIZ01xr6LnHekOuyj4AiL6fCBYLf4nai+79Uwcco7+5 ScH2B7kizQkgxofsM2nP7xMqdoVcxLdX0WWJ4dP7leTgblDrEm/LUkZHfPWXGvooJQOpSdwceMF tscXq/FOR3yx51+F7cRqAyk4RzyGRUVVROLaQkfBc3lPjP8nO8t9T2CRg9N5rjTqLIIaiKyvn+z cdnK36/f+b9V8HwYMAMxRB6lOhZXJZkPz7F3psxGPObVKAUUf3NQ3KCrKheLHN X-Received: by 2002:a05:6402:1f4f:b0:6a0:6978:bee0 with SMTP id 4fb4d7f45d1cf-6a582b62783mr24037052a12.9.1787585106912; Mon, 24 Aug 2026 08:25:06 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:50 +0100 Subject: [PATCH v2 3/8] gitlab: add arm-softmmu tests to the macOS build MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-3-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1596; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=B9ZSx+meoWvdNqJq36oJBwbjPxCumeybg4Iya8CkY5Q=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJNnu7NhMoxC7BsjB9Zi+XIJSWsI3a7ytnwa j94NjxmHuOJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTQAKCRD70NsJWp4q RHjcB/wNGlY9qSB9kIBU3maa+79vGLdbJ2bOgAlw7VnFCdkASaXJsmK1+gE4nIrqak+Ah+f3Vfn Ki/UrABJsC2/EVzzPOD0Jx21xwdzwYT4mMcJUuWhwUpLE6A4zMPZNFs0G2LsQEA99z2E770Sc3p igV7R4ldS3BzjSIvy9mnB4hI/Z/pMXhm7YsmiMtM/8Rz8HhS21wbnxnkl+Kd0oOgAFlsWiK8Q8K TAonKqYIfe177YT2A0c6qpuxq3Q3JbsVKvjtn4G97TpFybCtya2qnWT902uq7fgoOCUyfxibcYf HOk8uvBJoCfeaVd1rgEFAwQeVl4mswo411ZqHR652ohbR0Se X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::531; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x531.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585158549158500 Now we have fixed the compiler issues lets have at it. Reviewed-by: Pierrick Bouvier Message-ID: <20260723200904.224413-4-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/macos.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/macos.yml b/.gitlab-ci.d/macos.yml index bdb3eae18f0..40b9b637b3b 100644 --- a/.gitlab-ci.d/macos.yml +++ b/.gitlab-ci.d/macos.yml @@ -22,7 +22,7 @@ - export PKG_CONFIG_PATH=3D"$PKG_CONFIG_PATH" - brew update - brew install $PKGS - - brew install aarch64-elf-gcc i686-elf-gcc x86_64-elf-gcc + - brew install arm-none-eabi-gcc aarch64-elf-gcc i686-elf-gcc x86_64-e= lf-gcc - if test -n "$PYPI_PKGS" ; then PYLIB=3D$($PYTHON -c 'import sysconfi= g; print(sysconfig.get_path("stdlib"))'); rm -f $PYLIB/EXTERNALLY-MANAGED; = $PIP3 install --break-system-packages $PYPI_PKGS ; fi script: - mkdir build @@ -40,8 +40,9 @@ aarch64-macos-15-build: PATH_EXTRA: /opt/homebrew/gettext/bin PKG_CONFIG_PATH: /opt/homebrew/curl/lib/pkgconfig:/opt/homebrew/ncurse= s/lib/pkgconfig:/opt/homebrew/readline/lib/pkgconfig CONFIGURE_ARGS: - --target-list=3Daarch64-softmmu,i386-softmmu,x86_64-softmmu + --target-list=3Daarch64-softmmu,arm-softmmu,i386-softmmu,x86_64-so= ftmmu --cross-prefix-aarch64=3Daarch64-elf- + --cross-prefix-arm=3Darm-none-eabi- --cross-prefix-i386=3Di686-elf- --cross-prefix-x86_64=3Dx86_64-elf- --disable-plugins --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585138; cv=none; d=zohomail.com; s=zohoarc; b=K3uXn4Ve8n5ksF5zATwKsaDTabEtvhpTwce+z0ZYl8uIBahD5buBdZ9YXZajM7yIsj+FRBzXYhlId9aPjiOyCepmXnbnsLDRlGe70MqemiQNvsfhlCbEkajAL/7AHJ9lMRkamF5hX1lF0edKgQbM1T699o0xMHjAxqcolbpp6Dk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585138; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WJwqaddlExuj8k565K3Q7CEWlxwfLdXIcKUzKJqIN0Y=; b=Tkh5+0sNa5u4FJ1SNRcmV1RSx1QEn/HabvIlZCP69FpOddbAA69q+rqSuHGZnO+tQ4GYrc48fzsb01MN5pB8IfnmDXQdZKAQbtRHxz4p7FT25Y8nqGrOAdI/PG+YEK6UJzte37uX7qlAxeBtiB48D//+jHAXdrhbQsnZrehp6lI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787585138003214.82298813006003; Mon, 24 Aug 2026 08:25:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWXy-0005bT-7e; Mon, 24 Aug 2026 11:25:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWXw-0005Xq-F5 for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:12 -0400 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXt-0007C5-EO for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:12 -0400 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-c214321dc32so711258166b.0 for ; Mon, 24 Aug 2026 08:25:08 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24d6f203acsm290790166b.24.2026.08.24.08.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:03 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 65CBD5FAE2; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585108; x=1788189908; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WJwqaddlExuj8k565K3Q7CEWlxwfLdXIcKUzKJqIN0Y=; b=SyFPXMnoDnR53e1dyUkanUcvDnbelCFvh3uwYlZ2E0rGUfHd1jnGGD/8zxRHDEShz0 iCTWtFrUc4JgT8KRA0wpzeHxQQgFv+mEEVv1f4YjTVhht9hIKwDIv0fpH+OKVhGixrE8 8LTgBaA8Bom/nmwtq4P11OkA+E2LkWaIdmqzSrXzHhpj9cVqnNobMGobD82mfhQy1KrD qI+FwvX3vWO25KR1XnD6jwS0ru+ewDQckVPK2aKMsGAUji+T0dxztzgR8iDWC19488Tw kXnUfaoOHolitmx/OtXXOoLIg7ZwkmDIJpw/j5srSB8r7NFVtjywtPrOT/eP8BUkXK4y 3qzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585108; x=1788189908; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WJwqaddlExuj8k565K3Q7CEWlxwfLdXIcKUzKJqIN0Y=; b=brw38iaWFBjswmU6Lfsv2ZOBNbMdjWbXxVKYPGZaM9O5yobIniPpWNdhDNzsQJz8AQ p2S7qkxnc9pwbcyunoK3ioax7ecps8/qhb7yIg5hRTW4cPywrKJbIVhc0PYWYXN+VyMF 6d8qEoFPFj4Ekhc42V4WV34YdsSjiNj6jhfpmynEKXcu/S0KUxShasSljKPtb50FvNMC f3Qh+Rm0M+Y6uKsv9yslsf1qCzQjETtMnjlxCVR5He0JBAe58SfxRq+DKjcpkWgQLN8W ppcpcDLjM87cnswwHHgBHrVFjonp+9zT8TGAy0Lt2UkB6nXaxMTk5isNUwhUfKyPhSTY 4Fkw== X-Gm-Message-State: AFuF++nYvgDSEvmnxg+5RkXhXuL+uEBFgvn4s8jXSRHvE4eiw4nWDHXh A6/U+0h7hVvKKbQJ4agZGyO61MNA6z0lQaM3Vqd6B6w/pJncPV/P+OcRrecY0H790h8= X-Gm-Gg: AR+sD13KyGjspsUsP2rbLdeJZ3WBpExtBNOiWtOet5Ga1GzbAVS9bXkXljFKhcEdFu8 qApo8Xj1i/U1bbJyU4+H+GB7RA7PsVwXslZQNe7uMxmr0kxxua2+5p1U6wMjY2UeHaTDJQ1avUD 13CLQ9RrjUKjPJa5Kopv1g7ay36kxiKM40ZVc1+WNDRLXwwA0tOhd3bPi2jCMXN6we0ZYZXG8M+ uHu6ZuIrQeYlj/uloxO9lDWDvBFHtDF4+q/KyAR3XRaeoRqC8BolrfNYDVmLMb8BfN5xthM840P fiXAtm6E/07jtvIyQLiOqO9Og5aj7+ylofKDZRoCy9oOUrIyNrKcWtSrfLKEYm8Si5sJdOvw6RV b89ccxBqgHWcPoJITUBvhvRjfOewYFLrszqFWPAs6zZXPQ8I/tednsbFXvDCCaZoa/ebHk3yXlU dQh3AEMdJ/UaZu28lQoJVNjJPxl8x2IqS5NyXnSQtwWbeG6r2BxauO2GJsCX84 X-Received: by 2002:a17:906:b286:b0:c21:752f:c44e with SMTP id a640c23a62f3a-c246a67492cmr2450696566b.16.1787585107685; Mon, 24 Aug 2026 08:25:07 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:51 +0100 Subject: [PATCH v2 4/8] char-fe: implement qemu_chr_fe_backend_name MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-4-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4652; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=16o9aOALfN4xkFpmwmkWkdn+kTLD6/M+CAi326lKzSg=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJNe6mH5ki8B16GAGABc2EqP9oIVS4aNDGSy nc9Kp0JtAyJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTQAKCRD70NsJWp4q RB3RB/4uLlgFy8NoIadYwryQpj1CzM+lWTx/wjpGU6SCyP/Y9PROSjqeVEpqtK/swiqZGGkwglG 6tb4qmDsfPU3+e1Hsl9XyjobW4ZODOLYlDyo/ja0RcoBbwDE02NgFt1Ub4dlf2X9Tlq+KulyYrD Fzvnp+7VVhew4VlBB4J3YhsoCVVV6vKq81K6H1rGuEtGt5xa0fdePb5MdouZTDihC2w0YqAJDCQ 39BaJtoOqFnuGCr6Psr3P/gFBOuboM03t1RqURLUzzFsGictFIXs4oLeZlo8Xq7joIet7hQflEU iNl8e56VoZV0bv/OxAuhk98cceJ9lizeHCwdHNm5kVE4+5uQ X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62b; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585140631158500 A number of chardev users where calling qemu_chr_fe_get_driver() which is discouraged as it blocks backend hotswap. As the pattern is common and need for the string is transitory add a helper and keep qemu_chr_fe_get_driver() for those that really need the funkiness of poking around the backend setup. Suggested-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Message-ID: <20260810153503.2652324-1-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- v2 - checkpatch fixes - r-b --- include/chardev/char-fe.h | 13 ++++++++++++- backends/cryptodev-vhost-user.c | 8 +------- backends/rng-egd.c | 8 +------- backends/vhost-user.c | 8 +------- hw/char/imx_serial.c | 4 ++-- 5 files changed, 17 insertions(+), 24 deletions(-) diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index 5f8a6df17dc..a82894e1d51 100644 --- a/include/chardev/char-fe.h +++ b/include/chardev/char-fe.h @@ -52,7 +52,8 @@ void qemu_chr_fe_deinit(CharFrontend *c, bool del); * associated Chardev. * Note: avoid this function as the driver should never be accessed direct= ly, * especially by the frontends that support chardevice hotswap. - * Consider qemu_chr_fe_backend_connected() to check for driver exis= tence + * Consider qemu_chr_fe_backend_connected() to check for driver + * existence or qemu_chr_fe_backend_name() if you need the name. */ Chardev *qemu_chr_fe_get_driver(CharFrontend *c); =20 @@ -70,6 +71,16 @@ bool qemu_chr_fe_backend_connected(CharFrontend *c); */ bool qemu_chr_fe_backend_open(CharFrontend *c); =20 +/** + * qemu_chr_fe_backend_name: + * + * Returns: caller freeable string or NULL + */ +static inline char *qemu_chr_fe_backend_name(CharFrontend *c) +{ + return (c->chr && c->chr->label) ? g_strdup(c->chr->label) : NULL; +} + /** * qemu_chr_fe_set_handlers_full: * @c: a CharFrontend diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-use= r.c index cc478d9902d..3334e280a27 100644 --- a/backends/cryptodev-vhost-user.c +++ b/backends/cryptodev-vhost-user.c @@ -373,13 +373,7 @@ cryptodev_vhost_user_get_chardev(Object *obj, Error **= errp) { CryptoDevBackendVhostUser *s =3D CRYPTODEV_BACKEND_VHOST_USER(obj); - Chardev *chr =3D qemu_chr_fe_get_driver(&s->chr); - - if (chr && chr->label) { - return g_strdup(chr->label); - } - - return NULL; + return qemu_chr_fe_backend_name(&s->chr); } =20 static void cryptodev_vhost_user_finalize(Object *obj) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 1d92bd71cf7..c2207f40c5c 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -126,13 +126,7 @@ static void rng_egd_set_chardev(Object *obj, const cha= r *value, Error **errp) static char *rng_egd_get_chardev(Object *obj, Error **errp) { RngEgd *s =3D RNG_EGD(obj); - Chardev *chr =3D qemu_chr_fe_get_driver(&s->chr); - - if (chr && chr->label) { - return g_strdup(chr->label); - } - - return NULL; + return qemu_chr_fe_backend_name(&s->chr); } =20 static void rng_egd_finalize(Object *obj) diff --git a/backends/vhost-user.c b/backends/vhost-user.c index 380d8250233..46dadb74800 100644 --- a/backends/vhost-user.c +++ b/backends/vhost-user.c @@ -152,13 +152,7 @@ static void set_chardev(Object *obj, const char *value= , Error **errp) static char *get_chardev(Object *obj, Error **errp) { VhostUserBackend *b =3D VHOST_USER_BACKEND(obj); - Chardev *chr =3D qemu_chr_fe_get_driver(&b->chr); - - if (chr && chr->label) { - return g_strdup(chr->label); - } - - return NULL; + return qemu_chr_fe_backend_name(&b->chr); } =20 static void vhost_user_backend_class_init(ObjectClass *oc, const void *dat= a) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index fb41ee2ac50..8ac4efbb5e9 100644 --- a/hw/char/imx_serial.c +++ b/hw/char/imx_serial.c @@ -278,10 +278,10 @@ static void imx_serial_write(void *opaque, hwaddr off= set, uint64_t value, unsigned size) { IMXSerialState *s =3D (IMXSerialState *)opaque; - Chardev *chr =3D qemu_chr_fe_get_driver(&s->chr); + g_autofree char *label =3D qemu_chr_fe_backend_name(&s->chr); unsigned char ch; =20 - trace_imx_serial_write(chr ? chr->label : "NODEV", offset, value); + trace_imx_serial_write(label ? label : "NODEV", offset, value); =20 switch (offset >> 2) { case 0x10: /* UTXD */ --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585210; cv=none; d=zohomail.com; s=zohoarc; b=NDeojDXuuIj5C5OcHxUxWJ1W90S9ClmtllXbWQOGwv+7UVMIh1qFA3naNmGWcgZIZgGE2/idwGnMTNhg1PMkan7LEtvgayqsxvBzxjPPQpVfHKL2WWTDGTHS+eye0mPpzyqGN+lgndJ/ozCwSrLNpPXMZ4hGCI9tSK8iXVQJPy8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585210; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Fk7uubtzSeMFSEdxFQAVJoDUo/ET1OY4igZB2LIiDIM=; b=D5bYz4iXia4rwMeuv94gA5aEObbu176ht35Vk64oKz5/UCSUMZnCkoJP/WeKLbrT0ErAnQgiiuBVoaaKpQe6PkatCFP9ak+uwd/HsAOriCMOvbI/FaHiA/Fv908TykyomtnCFweJBeTO/HDH2Dr9i3Li9YXBvkBn7hXv300K8yE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787585210032962.5409774001345; Mon, 24 Aug 2026 08:26:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWXz-0005cv-93; Mon, 24 Aug 2026 11:25:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWXx-0005Zz-J1 for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:13 -0400 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXu-0007Cm-8U for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:13 -0400 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-6a173ad7cf4so6596788a12.3 for ; Mon, 24 Aug 2026 08:25:09 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e0190d3sm8925819a12.9.2026.08.24.08.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:07 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 67F415FBD6; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585109; x=1788189909; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Fk7uubtzSeMFSEdxFQAVJoDUo/ET1OY4igZB2LIiDIM=; b=I0f1eib4qOtJSqp7XainhwAfcfiRjWIhqlNeSX/Viv+JIpQsx1OWa0LzHyfeovhSQS kOXsLIiZW7j2f0ewc7VKl3Kz6O1qAzGg0H48ry6Gf4cKCSoz/csRWYQCkkc7TlbBONcf ZYAepG1OQs1qXmYwMr2i7MVCurySeh4DXv/gfmyr7tI+znl3Fs50RpwS7lh4ZFDgre+h QgwbPjdd7hX43FtEg32Qh/ts5eR8RmKvPlyEFHsr8u1QSLi9/vp6cli8hDBg11tU/+mp U52+ITa9l2emUmDUrJgidNLnEDde14OyLXwEJ67rFjv/yNtf3HjpWAznL0U6FD9+vL2q xFAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585109; x=1788189909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Fk7uubtzSeMFSEdxFQAVJoDUo/ET1OY4igZB2LIiDIM=; b=TnH2hO3stHkWJfbVTGt5FTuaGOIP1b7A6WZLtFksbIjyEDz93Lm5arx3yD8ROacx+/ nPxgf6TkF8cmkbSm+xnevxG7VGS2tf099xblY6FAtyfDWFZqpxOyDwDN3nix5r7O44Z2 7vjBxZkuGHu4kopugve4w1xEKY5pk4Sl8JkGegD2LG6qZUfJDo07DROdoVQpzaXnSOQ7 gB6e5mw4q0SkWuucHsBIU5kQRE7G0exf3FasDbc3pIvHyvafxfNERkciXZ/feN2sJYnm cQVW4FiBkBIGEZqisHDffb3fq81fNrUDyssi4LZkcAeOXk+bBXekLZL91jeNm0eb3WjT ErMQ== X-Gm-Message-State: AFuF++nYM7qcTygkCc5RE2yMboD/vG70TmpVzHy4EKMGUzV2xlw7ooWX OxBZS7hCiutgmjusfbMaj8A3I4fUe+8mTw67dWZj7kOoF4JHhVzwqqLgTsoxhlNHjbw= X-Gm-Gg: AR+sD11KiOpqqoyAXsg2neKNEpnVYelMh4FJjcN0oRBo2oz8DUfALawUGm2Wfc0N7ng N+/nOEewpqoX6Fn1hIf8AjPHcivQhEVM93t4qKYMxpVSC8bZ+IRzPpC3lGsl5nLWMRwGv5Q7K+X w9URJLa9wwi6B8k3Tv0OBBWjrRwjp2HFkM2AnWdWz9kxY4rSqb08ek2wHJ0jD2UPju044V6dNvE NiY8ttuYAq3HiL+T78VnWzWhbhE9Kp5/bPCmSC6duUQIPCrDpAXaGhezP5xhzDKxByVCnxlDf6K OLId3cLSkZDRNCyJnOsXiG7gP/FHPvj1OhEb1tmrlMnKj150nmDakaO+n5lc8tkzcmR6eaq/kvl GEWCSEKgrENn5ZUCiET+KZJH3m0YZSI3bodFOAXpFyRP2ZmP3WYn8dxRtW9ZVWMGxAiVP0ndZSr jJm1MnXcxJjTBAX51YoJTPkxGTqXDHwiQug4SE8pFHE05btcLf8GhCrnX2GqY6i1QKvFs8JGY= X-Received: by 2002:a05:6402:5194:b0:6a0:8885:e6f0 with SMTP id 4fb4d7f45d1cf-6a582b05208mr20853357a12.3.1787585108696; Mon, 24 Aug 2026 08:25:08 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:52 +0100 Subject: [PATCH v2 5/8] hw/block: validate the fdc sector position fits within bounds MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-5-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4140; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=sswopZNOzgMSxJVdxe5RCz1lvwnKFsZ1cyXIF1SKEFY=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJN+F0qlykLLME6nQbEm0pkTrfuGaWtoZvQJ fyhgmMbh4GJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTQAKCRD70NsJWp4q RG9hB/0SkbGL7+5wJsXoKba+AlC+81HNfv36Mlo0M/4pvIULICfb4eM8re9m4u/tKYl9eccd5Wl TS1BoJxfgm/hTva7/FSKwD47nzQUgtkQwQxWDgiJokZouOiZW89Ob92S0l73HZalqwp75kNoWCP zmUwGli3/wa/9B/XbXaMRQ4K3+PEMMBrBQrk6vwFNWqRj0/3jzj7VowpuwovmxfgghuELOJdvv7 tgk854dgWTMikJego2vTAHpElNVVsvjSD3dP2kiYGIVd6ie4PB3gmwqKPneypq04YzQfWHC9LQ8 XmbwovKdVegMQwlaRwL+3hJb6PBB2fKvs12ji5tQNR6MceVb X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52a; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585210798158500 Previously the guest controlled the value of last_sec and wasn't particularly careful to check it didn't exceed the media size. We can't re-use drv->last_sec as that changes as we do operations so we set media_last_sect when the geometry is probed. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3800 Signed-off-by: Alex Benn=C3=A9e --- v2 - checkpatch - move check in fdctrl_handle_format_track before we set data_state --- hw/block/fdc-internal.h | 1 + hw/block/fdc.c | 30 ++++++++++++++++++++++++------ 2 files changed, 25 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc-internal.h b/hw/block/fdc-internal.h index e219623dc7a..3a39ac903c7 100644 --- a/hw/block/fdc-internal.h +++ b/hw/block/fdc-internal.h @@ -83,6 +83,7 @@ typedef struct FDrive { uint8_t max_track; /* Nb of tracks */ uint16_t bps; /* Bytes per sector */ uint8_t ro; /* Is read-only */ + uint8_t media_last_sect; /* Probed sector per track*/ uint8_t media_changed; /* Is media changed */ uint8_t media_rate; /* Data rate of medium */ =20 diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 1178b959a64..d20f749c1ab 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -192,6 +192,7 @@ static void fd_init(FDrive *drv) drv->max_track =3D 0; drv->ro =3D true; drv->media_changed =3D 1; + drv->media_last_sect =3D 0; } =20 #define NUM_SIDES(drv) ((drv)->flags & FDISK_DBL_SIDES ? 2 : 1) @@ -373,6 +374,7 @@ static int pick_geometry(FDrive *drv) } drv->max_track =3D parse->max_track; drv->last_sect =3D parse->last_sect; + drv->media_last_sect =3D parse->last_sect; drv->disk =3D parse->drive; drv->media_rate =3D parse->rate; return 0; @@ -1905,6 +1907,17 @@ static void fdctrl_handle_partid(FDCtrl *fdctrl, int= direction) fdctrl_to_result_phase(fdctrl, 1); } =20 +static bool fd_validate_last_sect(FDrive *drv, uint8_t new_last_sect_val) +{ + if (drv->media_validated && new_last_sect_val > drv->media_last_sect) { + qemu_log_mask(LOG_GUEST_ERROR, + "FDC: Guest attempted to set last_sect to %u, exceed= ing valid media max of %u\n", + new_last_sect_val, drv->media_last_sect); + return false; + } + return true; +} + static void fdctrl_handle_restore(FDCtrl *fdctrl, int direction) { FDrive *cur_drv =3D get_cur_drv(fdctrl); @@ -1919,6 +1932,10 @@ static void fdctrl_handle_restore(FDCtrl *fdctrl, in= t direction) /* timers */ fdctrl->timer0 =3D fdctrl->fifo[7]; fdctrl->timer1 =3D fdctrl->fifo[8]; + if (!fd_validate_last_sect(cur_drv, fdctrl->fifo[9])) { + fdctrl_stop_transfer(fdctrl, FD_SR0_ABNTERM, FD_SR1_EC, 0x00); + return; + } cur_drv->last_sect =3D fdctrl->fifo[9]; fdctrl->lock =3D fdctrl->fifo[10] >> 7; cur_drv->perpendicular =3D (fdctrl->fifo[10] >> 2) & 0xF; @@ -1976,6 +1993,12 @@ static void fdctrl_handle_format_track(FDCtrl *fdctr= l, int direction) =20 SET_CUR_DRV(fdctrl, fdctrl->fifo[1] & FD_DOR_SELMASK); cur_drv =3D get_cur_drv(fdctrl); + + if (!fd_validate_last_sect(cur_drv, fdctrl->fifo[3])) { + fdctrl_stop_transfer(fdctrl, FD_SR0_ABNTERM, FD_SR1_EC, 0x00); + return; + } + fdctrl->data_state |=3D FD_STATE_FORMAT; if (fdctrl->fifo[0] & 0x80) fdctrl->data_state |=3D FD_STATE_MULTI; @@ -1983,13 +2006,8 @@ static void fdctrl_handle_format_track(FDCtrl *fdctr= l, int direction) fdctrl->data_state &=3D ~FD_STATE_MULTI; cur_drv->bps =3D fdctrl->fifo[2] > 7 ? 16384 : 128 << fdctrl->fifo[2]; -#if 0 - cur_drv->last_sect =3D - cur_drv->flags & FDISK_DBL_SIDES ? fdctrl->fifo[3] : - fdctrl->fifo[3] / 2; -#else + cur_drv->last_sect =3D fdctrl->fifo[3]; -#endif /* TODO: implement format using DMA expected by the Bochs BIOS * and Linux fdformat (read 3 bytes per sector via DMA and fill * the sector with the specified fill byte --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585173; cv=none; d=zohomail.com; s=zohoarc; b=n0O23z+Dn/1n5OQ3KTUu6VAVyihZOWHagDVdqHzqaRXSowH2WqXSCxZI9vzTF3pKZ4qYtwmsuZNL85vsRZmvPxKyYvqngTTnuxHzI5xH0VBx0i280H+pyqfFD4y5kfeDaRbZfLPHTVhfPbOJf3NfczLyTTPhUgruiZ+hxYz3Bu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585173; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aUlRGxcy2rZEj1QS7x2oqaNrmrRAbDWz5zlA+zLfboE=; b=Hs+j6HhktNFVVN02nVtHX7wb8OAL+jFaxIyJWOnAPMXR1DrYhJcNKoHiSe7M6sdwAvJUdeoVTM7A2erNuWtuWX7R6RS9SvMPWpzCH6FqtsmfAfWQLkHFeBY/AWBzjxAIpUFwWFyh5uHE5EMOurqYatD+YktC7iCCmlT7ITVqlGI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787585173766419.1624541317939; Mon, 24 Aug 2026 08:26:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWY9-0005vX-A6; Mon, 24 Aug 2026 11:25:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWY4-0005mx-FI for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:21 -0400 Received: from mail-ed1-x532.google.com ([2a00:1450:4864:20::532]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXw-0007Ei-LR for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:20 -0400 Received: by mail-ed1-x532.google.com with SMTP id 4fb4d7f45d1cf-6a156627e22so8414562a12.1 for ; Mon, 24 Aug 2026 08:25:12 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c249689fa97sm1158371166b.57.2026.08.24.08.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:07 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6A8EE5FBDB; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585111; x=1788189911; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aUlRGxcy2rZEj1QS7x2oqaNrmrRAbDWz5zlA+zLfboE=; b=GUArX8v68kFiTj2HAh4hyygzD5zi6p7UbOhYUl2DipOZODKFs32UGEdbqiPXrAG1OU SxxD37P5vDdGRdOsrwKAdwcyHokVgkcxDeQtI0rJov4kr5D4qG7ZhztAsbAMrRFRredQ oAp1pdqLbg2GAVT8yK8znHIgcYqgi7jJywgMHRlrtMZpFUucXOuIUmHWeodW5Vpd9zkg tbK/NqQRlsPRRkW7OyrLEhLsYz+8Gsw3DjsjMFOR7CwNPeSzk6E753qxE093KA/MkvJF 2S51RsdvW6VqS2d+yYZKfwlJEkbMixHsSjdmXXrfHYndjIpfch2Wd1MurnzafMKewa9H Ruxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585111; x=1788189911; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aUlRGxcy2rZEj1QS7x2oqaNrmrRAbDWz5zlA+zLfboE=; b=ZgHPDxO12vogs+kbhJTcuIE3O7sRsm8h8jHmK3cDtTtJUDPFGciijNF0DY7R5uX9WW fLgT94un9cR8xRY1Xx3cLsP9izp47cb4JwAawFhLRkCHsTB43Z1uVeq5FwYvKuun2/rR 9v0CGvn2kxylGijmWomN5xoNLwqEM8gDTJCSY2qKZhJxX22rs2mWxFJXlDvQAk8oXaib wxbk7cmyJuweyJ1Gp0Bw1+XWskJkWPfbedo/TYHNuj/toc+Mmt0pwxNC0yWbrap0jMyO OmYvp7fzSBJiygcTQi5dXalpQRnJOEoeSWL2jFKMjyU7dtPpWBvtggnYhaxiWiy0s4Eh DxsQ== X-Gm-Message-State: AFuF++l8rhDFUl5Je0EO18nU83SB/Ahq4Do1ohbT948ZhFyWY9Nr3BQg 4ovRfWcn0QfIz4ePTJ9hHBIO5TtVF7o1URwo+/bzIC5jAVpxYM5OAx8z6QoJ0sVxMMU= X-Gm-Gg: AR+sD11bCUL+Pd2ijSpyY0P8X12QRZqxQFUkzI0rQiRESxTpZsCQvjzGgyiHAvu5EwV i0XicCDDMnax07QuqEfqg5I1PiqYmn36R4QHmK8eqKhEUlqlVa1n7VvQe/uR0j4PF8DS76XZ4VT tRtHP/PvToYp4po+HBlMVdQpfkb2BA5Dq2n84arcG90Rcp3JcsnWwnp9S5oX4khq+G58b8gVZKC w+fti6CkSOLAXIfncWZkuL0ssc3422cAgxj3/TCaqvftwtXkci/bFAyQsQ1Mla6ch0HmdEdUIEr e+sGYkcauFesDPIj3iWZq+l1kKXgXOKAuJ0mIJqwJ/2NKg4YzSxYdTHIgsd6WdEfWGy0AfAvjC+ pu2ah8UQ0BYCjE3PXHvrOeLn24k2ti3kukt3EXcwks1huJfS+fA8bxYc873pZiBPn5OhqQ5D4X7 15C8YInNE2u97S2rTvIfo+Ue9o3nhIhK3FpLWAhWraOQxK9j1AEP2sbOKXrtORKqypU+WwryM= X-Received: by 2002:a17:907:8dc9:b0:c16:6dac:a008 with SMTP id a640c23a62f3a-c246dc97d69mr2504648266b.8.1787585110895; Mon, 24 Aug 2026 08:25:10 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:53 +0100 Subject: [PATCH v2 6/8] tests/qtest: add test case for fdc sector overflow MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-6-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=10652; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=TVs3th5ucYmnjcYnTts8iJZexWW8EZ/0P70j7X/7Wy8=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJOwK5vH2h3meJq0WXNFYqlbOHUwPhp08X6A /maULgMqruJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTgAKCRD70NsJWp4q RH5OCACLczSMuPnc+l8KPp0/4nbAFmz7n9LqJ2qj3E7ihpqPRS+3nOTkt5wNsBlqntkixoXuU+5 nimRUWV8zVydIFXBg6E9RXfzh26Uq6fouO6aP7+NXL5wFY1pBwj5V9Uvah6Vq4eC1Ikp+U7cYZy 07OTB1nkgK2uIxvesea5DwJeXulFr4J1X+IUaXgManT3SJPdQ+/MjaimOIVna6fuvGPswBClxkn LrSaxWjyVDZRf4Mn6imnLG+z6Aligljp1n+UNiwcqeOya1ETDFKUPPlVGfSQgK+s3JS+ssHupWB gdRmn4MlRNym0IUc/qSJ+u1+cJEnz7f7U2gvL7h+k9BJeeeA X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::532; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x532.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585174665158501 Add a test case for #3800 where we check that the last sector is properly bounded by the physical media that is inserted. Link: https://gitlab.com/qemu-project/qemu/-/issues/3800 AI-used-for: initial draft of test Signed-off-by: Alex Benn=C3=A9e --- tests/qtest/fdc-test.c | 246 +++++++++++++++++++++++++++++++++++++++++++++= +++- 1 file changed, 241 insertions(+), 5 deletions(-) diff --git a/tests/qtest/fdc-test.c b/tests/qtest/fdc-test.c index 1e1dd8659d0..3f2642fe671 100644 --- a/tests/qtest/fdc-test.c +++ b/tests/qtest/fdc-test.c @@ -31,7 +31,8 @@ #define DRIVE_FLOPPY_BLANK \ "-drive if=3Dfloppy,file=3Dnull-co://,file.read-zeroes=3Don,format=3Dr= aw,size=3D1440k" =20 -#define TEST_IMAGE_SIZE 1440 * 1024 +#define TEST_IMAGE_1440KB (1440 * 1024) +#define TEST_IMAGE_720KB (720 * 1024) =20 #define FLOPPY_BASE 0x3f0 #define FLOPPY_IRQ 6 @@ -49,8 +50,11 @@ enum { enum { CMD_SENSE_INT =3D 0x08, CMD_READ_ID =3D 0x0a, + CMD_FORMAT_TRACK =3D 0x4d, CMD_SEEK =3D 0x0f, CMD_VERIFY =3D 0x16, + CMD_SAVE =3D 0x2e, + CMD_RESTORE =3D 0x4e, CMD_READ =3D 0xe6, CMD_RELATIVE_SEEK_OUT =3D 0x8f, CMD_RELATIVE_SEEK_IN =3D 0xcf, @@ -69,9 +73,11 @@ enum { ST0_IC_ABNTERM =3D 0x40, /* abnormal termination */ =20 ST1_MA =3D 0x01, /* missing address mark */ + ST1_EC =3D 0x80, /* end of cylinder / sector past last_sect */ }; =20 static char *test_image; +static char *test_image_720k; =20 #define assert_bit_set(data, mask) g_assert_cmphex((data) & (mask), =3D=3D= , (mask)) #define assert_bit_clear(data, mask) g_assert_cmphex((data) & (mask), =3D= =3D, 0) @@ -276,12 +282,17 @@ static void test_cmos(void) g_assert(cmos =3D=3D 0x40 || cmos =3D=3D 0x50); } =20 -static void media_insert(void) +static void media_insert_path(const char *path) { qtest_qmp_assert_success(global_qtest, "{'execute':'blockdev-change-medium', 'argume= nts':{" " 'id':'floppy0', 'filename': %s, 'format': '= raw' }}", - test_image); + path); +} + +static void media_insert(void) +{ + media_insert_path(test_image); } =20 static void media_eject(void) @@ -586,6 +597,222 @@ static void test_verify(void) g_assert(ret =3D=3D 0); } =20 +/* + * Query cur_drv->last_sect using the SAVE command (CMD_SAVE, 0x2e). + * Byte 8 of the 15 result bytes returned by CMD_SAVE holds last_sect. + */ +static uint8_t get_lastsect(void) +{ + uint8_t res[15]; + int i; + + floppy_send(CMD_SAVE); + for (i =3D 0; i < 15; i++) { + res[i] =3D floppy_recv(); + } + return res[8]; +} + +/* + * Attempt to set cur_drv->last_sect directly using the RESTORE command + * (CMD_RESTORE, 0x4e). + * While the 82078 datasheet describes RESTORE for restoring a previously + * saved state, a guest can issue raw RESTORE commands with arbitrary + * parameters without having issued SAVE. Parameter byte 9 is used by the + * controller to restore cur_drv->last_sect. + */ +static void fake_lastsect(uint8_t last_sect) +{ + floppy_send(CMD_RESTORE); + floppy_send(0); /* fifo[1] */ + floppy_send(0); /* fifo[2] */ + floppy_send(0); /* fifo[3]: drv0 track */ + floppy_send(0); /* fifo[4]: drv1 track */ + floppy_send(0); /* fifo[5]: drv2 track */ + floppy_send(0); /* fifo[6]: drv3 track */ + floppy_send(0); /* fifo[7]: timer0 */ + floppy_send(0); /* fifo[8]: timer1 */ + floppy_send(last_sect); /* fifo[9]: last_sect */ + floppy_send(0); /* fifo[10]: lock/perpendicular */ + floppy_send(0); /* fifo[11]: config */ + floppy_send(0); /* fifo[12]: precomp_trk */ + floppy_send(0); /* fifo[13]: pwrd */ + floppy_send(0); /* fifo[14] */ + floppy_send(0); /* fifo[15] */ + floppy_send(0); /* fifo[16] */ + floppy_send(0); /* fifo[17] */ +} + +static void send_format_track(uint8_t drive, uint8_t head, uint8_t last_se= ct, + uint8_t *st0_out, uint8_t *st1_out) +{ + uint8_t st0, st1; + + floppy_send(CMD_FORMAT_TRACK); + floppy_send((head << 2) | drive); + floppy_send(2); /* 512 bytes per sector */ + floppy_send(last_sect); /* sectors per track */ + floppy_send(0x1b); /* GAP length */ + floppy_send(0x00); /* filler byte */ + + g_assert(get_irq(FLOPPY_IRQ)); + st0 =3D floppy_recv(); + st1 =3D floppy_recv(); + floppy_recv(); /* st2 */ + floppy_recv(); /* track */ + floppy_recv(); /* head */ + floppy_recv(); /* sect */ + g_assert(get_irq(FLOPPY_IRQ)); + floppy_recv(); /* sz */ + g_assert(!get_irq(FLOPPY_IRQ)); + + if (st0_out) { + *st0_out =3D st0; + } + if (st1_out) { + *st1_out =3D st1; + } +} + +/* + * Test that guest cannot set last_sect beyond the probed media size + * via RESTORE or FORMAT TRACK commands (gitlab issue #3800). + */ +static void test_last_sect_bounds(void) +{ + uint8_t st0, st1; + + /* Start with 1.44 MB media inserted (last_sect =3D 18) */ + media_insert(); + send_seek(1); + send_seek(0); + + /* Valid last_sect values (<=3D 18) should succeed */ + fake_lastsect(18); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(get_lastsect(), =3D=3D, 18); + + fake_lastsect(9); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(get_lastsect(), =3D=3D, 9); + + /* Restoring to the default 18 */ + fake_lastsect(18); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(get_lastsect(), =3D=3D, 18); + + /* Invalid last_sect value (> 18) must fail */ + fake_lastsect(19); + g_assert(get_irq(FLOPPY_IRQ)); + st0 =3D floppy_recv(); + st1 =3D floppy_recv(); + floppy_recv(); /* st2 */ + floppy_recv(); /* track */ + floppy_recv(); /* head */ + floppy_recv(); /* sect */ + g_assert(get_irq(FLOPPY_IRQ)); + floppy_recv(); /* sz */ + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + /* Verify last_sect was not changed to 19 */ + g_assert_cmpint(get_lastsect(), =3D=3D, 18); + + /* FORMAT TRACK with valid last_sect (18) should succeed */ + send_format_track(0, 0, 18, &st0, &st1); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, 0); + g_assert_cmpint(st1, =3D=3D, 0); + + /* FORMAT TRACK with invalid last_sect (19) must fail */ + send_format_track(0, 0, 19, &st0, &st1); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + /* Change media to 720 kB floppy (last_sect =3D 9) */ + media_eject(); + media_insert_path(test_image_720k); + send_seek(1); + send_seek(0); + + /* Probed geometry now has last_sect =3D 9 */ + fake_lastsect(9); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(get_lastsect(), =3D=3D, 9); + + /* Values exceeding 9 (e.g. 10 or 18) must now fail */ + fake_lastsect(10); + g_assert(get_irq(FLOPPY_IRQ)); + st0 =3D floppy_recv(); + st1 =3D floppy_recv(); + floppy_recv(); + floppy_recv(); + floppy_recv(); + floppy_recv(); + g_assert(get_irq(FLOPPY_IRQ)); + floppy_recv(); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + fake_lastsect(18); + g_assert(get_irq(FLOPPY_IRQ)); + st0 =3D floppy_recv(); + st1 =3D floppy_recv(); + floppy_recv(); + floppy_recv(); + floppy_recv(); + floppy_recv(); + g_assert(get_irq(FLOPPY_IRQ)); + floppy_recv(); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + /* FORMAT TRACK on 720 kB floppy */ + send_format_track(0, 0, 9, &st0, &st1); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, 0); + g_assert_cmpint(st1, =3D=3D, 0); + + send_format_track(0, 0, 10, &st0, &st1); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + send_format_track(0, 0, 18, &st0, &st1); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + /* + * Change back to 1.44 MB floppy and verify last_sect =3D 18 is allowed + * again. + */ + media_eject(); + media_insert(); + send_seek(1); + send_seek(0); + + fake_lastsect(18); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(get_lastsect(), =3D=3D, 18); + + fake_lastsect(19); + g_assert(get_irq(FLOPPY_IRQ)); + st0 =3D floppy_recv(); + st1 =3D floppy_recv(); + floppy_recv(); + floppy_recv(); + floppy_recv(); + floppy_recv(); + g_assert(get_irq(FLOPPY_IRQ)); + floppy_recv(); + g_assert(!get_irq(FLOPPY_IRQ)); + g_assert_cmpint(st0 & ST0_IC_MASK, =3D=3D, ST0_IC_ABNTERM); + g_assert_cmpint(st1 & ST1_EC, =3D=3D, ST1_EC); + + /* Leave drive empty */ + media_eject(); +} + /* success if no crash or abort */ static void fuzz_registers(void) { @@ -661,10 +888,16 @@ int main(int argc, char **argv) int fd; int ret; =20 - /* Create a temporary raw image */ + /* Create temporary raw images */ fd =3D g_file_open_tmp("qtest.XXXXXX", &test_image, NULL); g_assert(fd >=3D 0); - ret =3D ftruncate(fd, TEST_IMAGE_SIZE); + ret =3D ftruncate(fd, TEST_IMAGE_1440KB); + g_assert(ret =3D=3D 0); + close(fd); + + fd =3D g_file_open_tmp("qtest720.XXXXXX", &test_image_720k, NULL); + g_assert(fd >=3D 0); + ret =3D ftruncate(fd, TEST_IMAGE_720KB); g_assert(ret =3D=3D 0); close(fd); =20 @@ -686,6 +919,7 @@ int main(int argc, char **argv) qtest_add_func("/fdc/read_no_dma_1", test_read_no_dma_1); qtest_add_func("/fdc/read_no_dma_18", test_read_no_dma_18); qtest_add_func("/fdc/read_no_dma_19", test_read_no_dma_19); + qtest_add_func("/fdc/last_sect_bounds", test_last_sect_bounds); qtest_add_func("/fdc/fuzz-registers", fuzz_registers); qtest_add_func("/fdc/fuzz/cve_2021_20196", test_cve_2021_20196); qtest_add_func("/fdc/fuzz/cve_2021_3507", test_cve_2021_3507); @@ -696,6 +930,8 @@ int main(int argc, char **argv) qtest_end(); unlink(test_image); g_free(test_image); + unlink(test_image_720k); + g_free(test_image_720k); =20 return ret; } --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585217; cv=none; d=zohomail.com; s=zohoarc; b=bdLS0RdRplpGxVT1GVldYgV856N0MFmTlDVHhAd79H7/Ex2BiqCUFd3mhtzN7WGCxmk5H0AXdLuHM8mE4OaVhDqouP1UjUEwTqnECSmo2aNr2Mu58z64ese0V0Sl/R4qROIZbt7Xg5H0k+SQTCJkGilTOemCEw8df135P/Nmy64= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585217; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=U45IFqB/B/WnMCg1IRuOHzVkoRjzCwe1cooFYxUHXWw=; b=LP3nFw6z8J7i5Xg6uflZ+8FF0QOiylUQlGBswx6WmZROzHnVHXMw1sqBltG17dSsl6L8hRFBKDfX+YArS/n0dncSuyEJM4JA+bKtUhUTcjidmnalHZCp4RvGEv2vexMYDLJtovjzTuIM1X/y5E2QtBMJujNro3wjEeB9HEv5oVM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 178758521714494.90205100244225; Mon, 24 Aug 2026 08:26:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWY2-0005ge-1t; Mon, 24 Aug 2026 11:25:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWXz-0005dz-MN for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:15 -0400 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXv-0007Dv-Sp for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:15 -0400 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-6a378f90555so5739529a12.3 for ; Mon, 24 Aug 2026 08:25:11 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a59e012f84sm13536443a12.8.2026.08.24.08.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:07 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6D39F5FC09; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585110; x=1788189910; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=U45IFqB/B/WnMCg1IRuOHzVkoRjzCwe1cooFYxUHXWw=; b=hdLTaR1emdnSrKO1wnnYf73DlJ0VXTGm7r5zqgeKvpJiQ/bLYFhdGdj6wy0cMLtCBg SDZI7TKXRez0dYihL/JmjHWiBmB6IjkZ0pFil5rFOxNaaqSndnjVSj3XnuMNaZo+7/uF ZwGchkcC0PSl9HlFU+jf2yyEryvZrPexf0WjPJgpZdaeEy+WbDypcED6qs7Sfs4mQ5R/ wN9eb9aoI5y9UmlBDUZhs47b1HB8YkcgnoUpn7r1hb/2S5n0BlSPeP1Fyize6xfgGEKk VI9e+CdP+AsdhWSUCnKsoW3RdOQOeEG9iGJQxgfbUvIAGQDkIejuJdxs3/GoO6tdiTOn oLlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585110; x=1788189910; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=U45IFqB/B/WnMCg1IRuOHzVkoRjzCwe1cooFYxUHXWw=; b=jj03pRGq6nbUBgQKkxzffPH9eqnvf+hUgld0Ajte/OGmu/iF9p7D/C0sXtE+w99208 jNdGn12TWJN0Wxeve9TtjOcZGBctJSoU8S/yyENRVgTcUEecw6irxL53MqjlaVVLt0kU +vQQRVUGPQqBD4Qczu1ZAPIUeKKAsaqNtjHePNl2rm6GrHXSFje//svBjCm1VgygJyBj cRybC9VnIM+uZ01dFBTHhFJhdLpNxClu/9C2kqMxEdiQ8vCDoqTnvMFsyYDbcF3yJZmX suAf+bpaFA0i9UnZcZuphfSmd7JqlEfcPyq9UudvkYDJctjzi9fj8ew0lFK6SW4OkZ73 L4hQ== X-Gm-Message-State: AFuF++llDrbwxzsR/Y7RecxopXx0fSqgx5cK0ptA7A/rdUe9MpegLkUq 1xMzCgg+fCF6UOryUNtrm+KsFx9XwHSBR1sAOHB9/ObF5rd1QcS1oriG/6978IIJpNo= X-Gm-Gg: AR+sD11efu9I2cFA9TH32oEuOTt7STpxzy3uz1wLEM59NBaSNGicQuynBRAbg1VVKJN OsKInftiPxwvnQB4dsBehQIzrR5ub9vW91ipxZ0ujg6cqzVa5/Ml0RnkEClBkVuIBlhIXFQOt+w eWSwYn0f2BsuigV3sm9OyVsC5dHxqGZngoKmjrcNXX2rm6dq3N15DI9Z4w80zx9nC5XHlTbT18I QDiIGZtd0FLCJqD/lWD1DBfrsCv7OaH/vC2VGwdXAF3H1FY1rreIe6aMjgQ91Y2lylrGtXZfHd0 MGhpVleT0DnnB9lDbeSJBS1dNL4iLogysKvbMO/id+3AViqDqX5s9uJaLLiT075V2C9uwIz0NPZ raiqCH3p8KpcyaM/06w3wUEeAwZr7j/xDgGBYblRbEcRKKia5bZ9R92OMNVIYTZXhbWf5iEbYwF mvq6+qulEWyUhHstPxPF4kAyjS52dKZ0nlKsLrA5E3kC4JSKMLKgaK8riVinRH X-Received: by 2002:a05:6402:1f07:b0:6a1:c908:1701 with SMTP id 4fb4d7f45d1cf-6a42f26dab3mr31841527a12.13.1787585110195; Mon, 24 Aug 2026 08:25:10 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:54 +0100 Subject: [PATCH v2 7/8] docs: deprecate virtio-crypto MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-7-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , Mohamed Mediouni , Thomas Huth X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1968; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=cMLkR++Pqz7yCt0s5pb0e/7fsHML1OtITb6mzDUOj2c=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJOraK+kojWIq01tyMbXtc0yAj6astNti5DP MkJ9/4MsP+JATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTgAKCRD70NsJWp4q RF+VB/9R/UJ6dGOCUOj//jdooY2wqVc6kBH/x04y5MN+vHX5qOfOdroZ1hhJxWTULR1FDPiKvjV YlOoG7mMlWuR/aWFq7oU7deiRER3vlSK6+gHYiJVv+f4zzcIpb1lpi/YWjnkd08P5Ug8vALifEb iSnUcIbtNqQ6G9D/qRuHiY1b/UeNGakeAEIkcxE4m8L2DaSL1jdOmDBFcChtRcsHnMl36W4PoZS a4Klv/esnpfgShOR2KOc6t86nq91uD+ktHJb3asFLs3PBd6gUxzAsggjqOoUKI4IUaqdu8XxLas aFLhO+MXfgVXJQS6j3orz7vb931eDG/4cNkmZeM+wmqAOy9F X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::529; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x529.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585219075158500 We have outstanding guest exploitable bugs in the code which is fairly complex and needs some serious love to clean it up. As off-CPU cryptography acceleration seems to be waning in popularity lets just the deprecate the sub-system with a view to removing it in a couple of cycles. We can also remove the backend code at that point as well. Link: https://gitlab.com/qemu-project/qemu/-/work_items/3625 Reviewed-by: Mohamed Mediouni Reviewed-by: Thomas Huth Signed-off-by: Alex Benn=C3=A9e --- v2 - mention the backend bits (only used by virtio-crypto) - use Gonglei's modified version of the text --- docs/about/deprecated.rst | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 0c656a968fc..05e4ce8cf16 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -276,6 +276,24 @@ future release. Where no 'dh-params.pem' file is provi= ded, the DH parameters will be automatically negotiated in accordance with RFC7919. =20 +Devices +------- + +``virtio-crypto`` and cryptodev backends (since 11.2) +''''''''''''''''''''''''''''''''''''''''''''''''''''' + +The ``virtio-crypto`` device emulation is quite complex code with a +number of known flaws. It has never been migratable, so it is +unlikely to be used in any serious virtualization setting. Modern +ISAs provide on-CPU cryptography instructions (e.g. AES-NI/VAES, +armv8 crypto extensions), and the Linux kernel deprecated AF_ALG +and dropped its off-CPU accelerator support in Linux 7.2, removing +the primary userspace path for off-CPU crypto acceleration. The +time for this sort of off-load has passed. + +As this is the only device that uses the cryptodev backends these will +be removed at the same time the ``virtio-crypto`` device is. + Device options -------------- =20 --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787585201; cv=none; d=zohomail.com; s=zohoarc; b=jrxTrQXQFfxbktyz3BDncisjD18kh4oL80BAf4WTTsrbrS8NlpfTxQ/18PsBAxsMATEraOESB+NHYFHxzTb6ojmbxabG7MguptvwI3MBMuTQoxN4U9U/uWCjF08unCNUQAAYzHVduT0wDu2R4rr98BTwOlBGdksvVqQe6pT9egQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787585201; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=G0Wd3sJhbhnAigDSbOw80EWCSyIFhk3lURnLFBsiUDE=; b=cskL87zNwYV6elhe54xKBUwaFOpBX5Dk3XprPsIZaxXL5RzMVoS0b0Krlc9NG1UyAiopKXjXuZVEDmSNp8H05rM+8zy+wARzfkda3qzW26IwlZaNt3JIm1j+NTI30Q/KIMHCwGfwOG7kPI68gEqOCA6mT4nXoyg8885tB3JU5Fk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787585201162474.9654453299663; Mon, 24 Aug 2026 08:26:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wyWXz-0005cm-8K; Mon, 24 Aug 2026 11:25:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wyWXx-0005b0-TN for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:13 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wyWXv-0007D8-7r for qemu-devel@nongnu.org; Mon, 24 Aug 2026 11:25:13 -0400 Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-c15e2dab83eso680522866b.1 for ; Mon, 24 Aug 2026 08:25:10 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c24966f8f08sm1282381266b.35.2026.08.24.08.25.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Aug 2026 08:25:07 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6F9625FC28; Mon, 24 Aug 2026 16:25:02 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787585109; x=1788189909; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=G0Wd3sJhbhnAigDSbOw80EWCSyIFhk3lURnLFBsiUDE=; b=S2SquJKLL320UGqf73K9Qlacfirb6HMSk6HdcrhFafDHDFynkQGximtAg1eCZynmJE baDd6ffpi8eG7/a9nQLOjtWNZXrRzimRf3Ps6KPqmAwWDZU2EKaPF3iOf0lxCFTODaFM Rdqd4ZhpUW/mvF4LhkUdSWVTLyjPTPQmDcD+aedjxgh+lOdF5oaUxwQfnkPPGAs95Q+M gXz3WNfTiG8/CiXeMnKt912yi//W5RUD9GsMNWcDZxcwPNq9owTmvNBpSDWAEdO9eoKC EtR6HCAB1N3jiaCPpLBek98jWqLJZ+6Z4vIQrdlqQa3vi+0GAD/7DVmhiA3ndOzT2Czp 07Pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787585109; x=1788189909; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=G0Wd3sJhbhnAigDSbOw80EWCSyIFhk3lURnLFBsiUDE=; b=Vgn9gJ+mtMpugJgOq2NYDNfIpwopQR3raOfGzVetpc9cU02eH6iVlnyVRqrito6Z/N wlgj55xGr04NQ/jzYIJRr1JW2L4FgKUPnFj095DAlvGWQTsT6RWmvGj4ZXmSa4Pb4Zak dax/dfkFuL4O8Fy3RHpQ42iY0GjEFOdM5g2uTeHSdnWu4u4akSjdny9Rxl/b0eK71sOe qa7tCKqxJxFW3NOOsvc2VUED4Q3H+vOX/jNHA/tb+nwIYMihsTgmEqsEDJ8JGzIcd87J p9Xb8o4GMnrpffJoIzch7leS5iyvfGiP0NJa4NMquVChOIO1qt0TlYSuMt/ylQ/oj3/L f/gA== X-Gm-Message-State: AFuF++m2aSMkk2ss49p/qNvZYEI/0GjI7oqrLNA9kWazcWdhRo9wsbBQ NG0/y7t/n1wJt1Q5n7OvP0hDCKLXf2IBsWWAGxuB6VprMJyaHuz5G6CM3O06zGNW9v7Le0ae24+ Q6npPjz0= X-Gm-Gg: AR+sD10BZRMd7MGzvvG6Ww1xeznNlan/xqN2DqsoHFmGz7QVSTQ0HOS7e7twExwfJBU YQyirNzp4n7eSFfuMDbtBBgSA0LhNsvHjxtHIE2XJWLObM5yudZNPZF2tAa+7mI8wGlgSXiMq1w kr9Q5yipkW1TJLATiMJXwoNKQB6ve8kxGtGeTQ5SNl9uRvSML3Ya5q/is3fEbS2eeMaDLDuyyZV vVm5qcbwd1Xah2FV9QShMDDqbslMFnodJqMM7XwXBgIs4CPqOs/PFArvWBwGJvA3H7gw4T4mTGc 6XCuPr6+OhKYAhWrAHHi+W3Ao7sM+8LQ0wBEXAzfBkYcxCdSp7GP/DfqW8uDP/sO3KgJynyiB9a Ra+HTVcXoBm0SzuQAJIFgqZkig4mLa9wE5G+zPop1WzgPOpoEsFpKkNbONwOt14+7FqacxX1POV kevgHvj4uDRgCr+4unHB4+aca/HwOON6OvYtGpqprhiz1qgGva+PTzcs/IJQv7 X-Received: by 2002:a17:907:9308:b0:c12:695b:8876 with SMTP id a640c23a62f3a-c246a39efb5mr3122286666b.5.1787585109460; Mon, 24 Aug 2026 08:25:09 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Mon, 24 Aug 2026 16:24:55 +0100 Subject: [PATCH v2 8/8] mailmap: map the last From-munged author back to a real identity MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260824-fixes-for-11-2-v2-8-352c6b890402@linaro.org> References: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> In-Reply-To: <20260824-fixes-for-11-2-v2-0-352c6b890402@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= , Fabiano Rosas , "Denis V. Lunev" , "Denis V. Lunev" , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1397; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=NdHao0lP1Djp3lKZKg7V1dUUByr13KB4ogSPisoA2Zw=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqjGJOm4MljmbHGBaQ+ZWY6OcUDfX3DPsXn6aLM ouGea0w/meJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoxiTgAKCRD70NsJWp4q RKI/B/4lI5UStKcb/v/9Eb8iHi2CMsgYvCZ5+PAc6ny49MWoGtFDwhbdQBX4AUcRhBZu6wHzvSo kVNwoClyOz14GHi7Z9wBiuGp0CUZevLKYWL5J9AHor3acqEaTndrvPKCGYnP1SM3oizvWDJiuap oAY4mTFF2B3wGzWdNgvK6nkLEJnu0Tmg6g3lHx4KPNXZ/1DtKhx5fNcZCkEJS25ouRm5gZZuYlx FmclU3HlRfi8fBO7/kTZONGAQRxdfRFvZoSLG94vqHqG4oAcStP4TmI76LqOsuA0dWK/F0wYpBK pW0AE1CIEZG4DA3iq6FrTSQhS0IibE0geVXpzWSEfuWmy6AF X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787585202840158500 From: "Denis V. Lunev" qemu-block@nongnu.org rewrote the From: header of commit b67e353863 ("block: drop force_dup parameter of raw_reconfigure_getfd()") for DMARC reasons, so it landed in git attributed to the list instead of to its author, whose real address is in the Signed-off-by trailer. Map it like the other munged identities collected in that section. This was the last one left unmapped, so 'git log --format=3D"%aN"' no longer reports any author 'via' a list. Signed-off-by: Denis V. Lunev Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20260812112456.970371-1-den@openvz.org> Signed-off-by: Alex Benn=C3=A9e --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index e5dc644623f..08f0fa9e118 100644 --- a/.mailmap +++ b/.mailmap @@ -68,6 +68,7 @@ Stefan Weil Stefan Weil via Stefan Weil Stefan Weil via Andrey Drobyshev Andrey Drobyshev via BALATON Zoltan BALATON Zoltan via +Denis V. Lunev Denis V. Lunev via =20 # Next, replace old addresses by a more recent one. Akihiko Odaki --=20 2.47.3