From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787131428; cv=none; d=zohomail.com; s=zohoarc; b=AyTYiWOODY8h9UUOovbsomKv3ClqXDAhUgtCTBnzb9bXMAk8nf+d2oYY4vRqAznXZ2Xu26x5Jm7JNbuevuVVa4Zn99G+B6/N0/1T2jYxb+NKgXdwwpcme0YPxvrW3kyfJOM7+B8eqUU5Abz9kFULDQaydTOSUx3obXzlb1XhXDc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787131428; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hI/4kRcuHe18/qYKP2hOGxNnKh8pw1N2QjNp4C1E0DY=; b=mPEmqu2w5F5ys08yAgdpQybOiSN2nD5Lgg9UtrDnDd1CcSfTVUMyipLHNlborangR0HA/xnzootmX6K1vNNa8IekdQVuHFKdvOBSb+BImw0443W6OvNWngHYsoXxdXGKH9EbAPOAn9WXTSv8NY6F5MbB0+5wQPtFtSDh342Q/+0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787131428681114.77810756304211; Wed, 19 Aug 2026 02:23:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwcV6-0007nt-QE; Wed, 19 Aug 2026 05:22:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwcV2-0007jN-Tp for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:20 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwcV0-0001vQ-LM for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:20 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-47de008b020so414691f8f.1 for ; Wed, 19 Aug 2026 02:22:18 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b145d31bsm4447265f8f.16.2026.08.19.02.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 02:22:15 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 61A7E5F82D; Wed, 19 Aug 2026 10:22:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787131337; x=1787736137; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=hI/4kRcuHe18/qYKP2hOGxNnKh8pw1N2QjNp4C1E0DY=; b=FQSgU+cDLAKAcGNPMHLGaFESsgjpW4+TcamG5+OvErnb3xZEeaTSZWQcMiktv8+X1L aiI5fgoyrSzUUytxnBF1Xjfrv8o54wxov69/L0tbl8YfDsmg/63Cn4wwHF0Ndfiq5dza bPultDunMMqGoxYHH6mNzDGKcPIRpRV7lOiWyIjHHO/EGOh8jFnlI7L7h/0gBvwhi9R3 1YVq7Nqj7HZhFxysQtly0EPlwi0gXWnmdlFxcxqLFhVGI4vDQQtorMg+RbmKbHjSEOMo bs8flewC0jHb7/Nr8okrTA2UrydwLJw3NWgX96RubAHx7LSATMFVaKFn05E7tR+H8ipi 9cyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787131337; x=1787736137; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=hI/4kRcuHe18/qYKP2hOGxNnKh8pw1N2QjNp4C1E0DY=; b=IAsktH2vHGEHE1IWGDCi4S4kOtInhlV4aXaeKNiOkNNGwDeKwHBhVBbANwB1VKMVwK XqKhy+mO5coXGbdDOVa9oeSqHA/k0LQt0wOALYa4H4KyMq4gETrkBnIi35nIJhPrsxkg tgGjtwmBvaNUE3IZo8aMhdcUv5l7mopm8StW01lYUNQDdwFvNUDVksgytbjvpVlGvzyS 063FAQAjYc6AUPYqR1Ei4r4U/nR/esQw2WmEIaW8Qm7NQMij6WTrbZlat4exHckyq0n3 uTTY+htL2jlTiJGcvr2xg0N8XKImBrZl8WexhDOOXLctDvbnXCXwVSml+u7LsrbsxqS6 Brzg== X-Gm-Message-State: AOJu0YzhCmIP2i4RQnITWjeBt8NwpvWQ3WXC1TtffLVr/scBmNKPml6Q OryKdNL7AvhB6JB0yBPb5e6ZYjcrmQmxyX/CjYy2Bi0hXwbRy2oHWYpIhK6zRjf8CUQ= X-Gm-Gg: AR+sD112vnu5d3KefFd0thH9pyqWoFsU/Fg2pQikkyGOh2wd4WYcNuZ+SVHKXeQE5nw Ge/sbqQKvzl5FwEAuGEYztgYBM+bGVvtBtxq61IGOf+kzM0/UbOTXrD4o9IrIf4KELX1CdNrG1b SeoyUTYiRRDfY+jpZQaWWdu4LA+R+XMnItuVbr5fiL4MvAa3I9Vn9aFTMCLY7mwSX7o/IW/2HSr JEudOA5oXQI0DWpAdR/1coiykXa46BBIh9LVgPec85ochNL5V8TynH/K5zDXAszOu3zhGby6lKV OOqCIUIAWtyoGH9pIkk4lgdPzVZcM78TA+D2d/X5L0X2Twji29CgT50p2S2cykAlYTsQStB+Se1 k/ZzsQOAlc5kJ7hmbKL2nM/LEI21W7wAPvHcCOJMS7kC/evh5UJvPY0TzqtAqoYY/kZtQWr3PbA Zb9nUX6yO9Mff0c7VNTIJi6qsrnbPGvJax6RCGKDBtzaSIvZUqxyf6hgCbR5it/DSUQ327XI7/ X-Received: by 2002:a05:6000:4285:b0:481:314b:b041 with SMTP id ffacd0b85a97d-482b1066a6fmr5516939f8f.7.1787131336957; Wed, 19 Aug 2026 02:22:16 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Wed, 19 Aug 2026 10:22:01 +0100 Subject: [PATCH 1/6] gitlab: use .base_meson_job_template for macOS jobs MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-fixes-for-11-2-v1-1-b7981c2cc371@linaro.org> References: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> In-Reply-To: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=700; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=oLQW1QjvvZodHpTsPvGLeM5B3yePRIAQ/JBnkvtdcNQ=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqhXXFqP6RI8y5GJAeGX56erSFzv9sCgzfILmz0 jmFwC2A+iWJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoV1xQAKCRD70NsJWp4q RD3YB/4rMr73ZG79e/v4epC1W29loewTMHg5hEvwFFt17neUi6k9Ul5yZXMsGKtOP8MLpd4kneA zA7zyxvdnIwtO7VE58tRhZxL9EmSv0/98az/980b2qJjbi/7cDDK6s4aE353G/4M/iOGGf7wO7h KBqE19f3cWZ9iM73xW3e7ZEFHIeNfrNuXFCA0WrgAQ5BSjYq2bN4sNtB1NoYF+BUOHDjARjmXa+ SbadvOXXb9CBHS4TmaTEYUW2W0W8k5JTqNjUPXvg6kcLj/mSSR5Hu0swDxpHWnGBbossZ9Oxs5i 0zcfR+NuiUAApd4XCmY/HsZ5TSrNYoLaC62dfMXFxyJyQ1mh X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=alex.bennee@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787131430692158500 This way we'll get more environmental information which will help with debugging. Reviewed-by: Pierrick Bouvier Message-ID: <20260723200904.224413-2-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/macos.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.d/macos.yml b/.gitlab-ci.d/macos.yml index 641a48b3832..bdb3eae18f0 100644 --- a/.gitlab-ci.d/macos.yml +++ b/.gitlab-ci.d/macos.yml @@ -1,5 +1,5 @@ .macos_job_template: - extends: .base_job_template + extends: .base_meson_job_template stage: build tags: - saas-macos-large-m2pro --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787131394; cv=none; d=zohomail.com; s=zohoarc; b=F1sFyW/4IJvBQUgrh06rLpXVyrQKH/+upZ9vwo4TLZewEy+6cPBA3o5qH2P/NWwGskDw8XRjf2Tm+jXxt0WkvbmDkFM0DWEx7HRdCdq93Av1NXL/os4EuMbqwp4NqOc/PplUS3xs5HB/OWBobnPC8N3DhqUwRdotzH10JU2VcIs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787131394; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pc/GOaaPlMM8Rx6IwwNSVab3AJ0ESXz+I20bcOy9tBo=; b=O4jhqRlYb6yPS2Y6cfCc/SbNdlZ7pVfh3zb7LO8D/NzK1ZDuINPE+H6UnlMlHIeBfhrqfnEylthCmC19Ahskv23lr0x78bgQ4loin55HFOfoIbTKnbqeOndwsZR7EOt/2cg7EkRBEvfvWkf1QElerUHhFrk1HadCrCqEOfijJ7I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17871313948521012.9989190557499; Wed, 19 Aug 2026 02:23:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwcV7-0007pR-DQ; Wed, 19 Aug 2026 05:22:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwcV5-0007mx-Fr for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:23 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwcV2-0001vx-C4 for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:23 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4955aa106b1so8126025e9.0 for ; Wed, 19 Aug 2026 02:22:19 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499a9dffa59sm66006495e9.3.2026.08.19.02.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 02:22:15 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 640865F878; Wed, 19 Aug 2026 10:22:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787131339; x=1787736139; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=pc/GOaaPlMM8Rx6IwwNSVab3AJ0ESXz+I20bcOy9tBo=; b=BnRxpsQEZGtN2beXW2mAk4CD+m/ofZbsbMb4kf0tYhZ4RMdsusc0Rn84+XgDyOLQ1I Y9cY9nK8Rlkf9KtkpD+y+J+og0ioxQbw50xrcjTohg+h6VX3/NqW3r/vDgj3yg7jXhUP W7TJPmq6arfUz71//R81A0xTanVMYCfCtY6Cm6ntefrT7hl0bEu3vNtxwdtaUt1sg/ei kcR/2VdflItt/3GFNx3ZAtVVEMAHpJt78+yEy7Ej3Bgy6F0ELtL0ZRHqF8pef8eAzFgb tDdUWZca8uPJyM1EdYD8u6JoANYSHbcfR8wnYXjAKNEUl4jZjFT44L+xDBnL7YgUXjT7 9oAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787131339; x=1787736139; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=pc/GOaaPlMM8Rx6IwwNSVab3AJ0ESXz+I20bcOy9tBo=; b=sco9rqYW0LXQO/d11Awn4438wQzL2QTCGER6nKEIg+gBQNdKmKSBKmqnV6wri6RHNK iKTOEsTA5He82LEYWz0JiOaxv+WJAIEXhDfD/SfRPfp1aLY0tDJw8jtuQtq+vvkavDfc PepSvvGlx+gW7jA2KVPVpHe7eRnEqsXeQGGYlDF6upP3DK7m/U4DQbzUbH8yZixVmoe0 h73zEB6Hp7iNie8rLfLSmkEXZ3jLMgjzLjN8UClJTW2Iwv7RQyHolCh2b/HfMv2YuOU8 rpZ5TbPxhCWKfA99MQKxzZiAYXOzchtneYLVwCGpoJLfcpP9o43mS0eBSRcpkRRLbsvU bxMw== X-Gm-Message-State: AOJu0YwvGYUCzTsTaPVCTbj7GF6MTwYtVYprt4NBsbBPXq9TFy7JDEWH We/JvnX4nmkN8Uz+q/sHc8P/Nghu3g8MJuAwUphpdkwCrEvdLWOXr35PjyR8iEFoA2g= X-Gm-Gg: AR+sD11MVQ3f2uFB3JSRmy4X7GFjBaXrsJbNLkvCO2m568pYjg4sinOtEPcZoh2H0eP dbu6Icyxaz2Vl2G8jlnWEktkyVbOnocExQtI5WoXgD39O/qoRjfVhk2qJDuGG2imAvP9raTbFTH WtpN4e80HAwM9cLMw+U6EZysfCgAhl2qTs/x7/8IbizDA6597UDkXCJtKB+k3VQYJdZALz1mwZ1 +VdKgQlZIhTmhszPyfON874/D9KnvvIlg1REK5E38UjRq/Itf3EpebiuzPKE9sTUW9utMpvRmRk kE19jXp3BRiti2J0zqGKm1YRe5VALMemevn6RH8pkm+EAERQmmXMH9c1hbDgKWMBGYOfP1HrCHR rRk8LWfuhhTop7Olx09CEuFxJu1wIzHIQ0oYI9OO+Q0hLpv7AU/7wj3SUW91SQWxAjihPfc945N 5FwI8VPbz7PZOOXp4QrKaydbf7EQnnv6+mQUK73YkBkcd3iD6S6SD2XhO21M62 X-Received: by 2002:a05:600d:8446:10b0:499:9eb8:a1d7 with SMTP id 5b1f17b1804b1-499aa1d0a9fmr40563525e9.9.1787131338788; Wed, 19 Aug 2026 02:22:18 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Wed, 19 Aug 2026 10:22:02 +0100 Subject: [PATCH 2/6] tests/arm: add explicit CFLAGS for system build MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-fixes-for-11-2-v1-2-b7981c2cc371@linaro.org> References: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> In-Reply-To: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1369; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=MJWvive3XIw267cYiTNdmu4ac2myJrVPkfmdAGEdR0E=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqhXXFQdbqk4aNMoF8Fqsqd+U0IJwWLn9FjAcLG nvn4891lYiJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoV1xQAKCRD70NsJWp4q RIMFB/4skduvdp2/XpuM6BCYc4XFHaKQCdl97vaqJUBVZgQs3hWJmU9r9u16zm93Zw0Wqyv+rZk fAPA2L9ZNDzrFaw0Wv2fAF4GcnHYPd3FOIb3a4IvdWrSbxFlO2Uio188ujTBhIWLmCiZDkboEBv X5SDsLWn4NjZsnSmGrv80jmOMuqMZAP2sYW/fDVwIKnN93XUtKXqFOY2SIaQJsRiyXbLlU2tNDX M2zlszD4TZpoLCtOrmXUaEUuLHrdZVNz96H9ufJhXTFMzq+kIcZamIlREzeyUIXhaidRyu9Vemp EEu6Z2sJPXfw+sAt8w9TlTd1yA/kyQ4ZoWbpp46idbigBmoa X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787131396852158500 The brew toolchain on macOS (arm-none-eabi-gcc) is a little different from the default on Debian (arm-linux-gnueabihf-gcc) as a result it defaults to an older architectural baseline (without isb's), assumes softfloat and will get confused by including stdint.h without being told it is compiling freestanding code. Make these all explicit so we can build arm-softmmu tests on macOS. The test-armv6m-undef is unaffected as it has it's very own build stanza. Reviewed-by: Pierrick Bouvier Message-ID: <20260723200904.224413-3-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- tests/tcg/arm/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/tcg/arm/Makefile.softmmu-target b/tests/tcg/arm/Makefile= .softmmu-target index b66074b0b43..3e8a9b4073e 100644 --- a/tests/tcg/arm/Makefile.softmmu-target +++ b/tests/tcg/arm/Makefile.softmmu-target @@ -29,7 +29,7 @@ ARM_TESTS+=3D$(patsubst $(ARM_SRC)/%.c, %, $(ARM_TEST_SRC= S)) CRT_PATH=3D$(ARM_SRC) LINK_SCRIPT=3D$(ARM_SRC)/kernel.ld LDFLAGS=3D-Wl,-T$(LINK_SCRIPT) -CFLAGS+=3D-nostdlib -ggdb -O0 $(MINILIB_INC) +CFLAGS+=3D-march=3Darmv7-a+fp -ffreestanding -nostdlib -ggdb -O0 $(MINILIB= _INC) LDFLAGS+=3D-static -nostdlib $(CRT_OBJS) $(MINILIB_OBJS) -lgcc =20 # building head blobs --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787131464; cv=none; d=zohomail.com; s=zohoarc; b=ZMb0+2GaLMo87rHr8wYoRIOhYObfAnNOvoanrgFIrkfTs0X0Gjvr6SBCO9ozKSUdovmfmSQthMkn+7cp37Ug9bkLkgCC2NcMt7u8d4ylQlhad6ArIBbt9M5VY5Mos6rhIYMhQCysitoddBBZl2zyhrUTlacp9SjmKlmL/6pS2SU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787131464; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zEBSWmDHcpbyAT5+oxLyqv+4C5kL0TnHpRS3uvgoVbI=; b=BWe8SryGqb1yfmaSofFloq1ieGUa9b0TlwGLmQ9uNh6CPa6fdBajrKv6Foy6f/k5gzuCQBSFSjaNPv060EDAD6KL2tSWidTWDTV+Cts61vl2acEiKcuu1cqcEKKPha1tHzu3aw68YW7ktYg1da4HzxP029VACqh04HiV5DlJ0+A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787131464302238.10732377062152; Wed, 19 Aug 2026 02:24:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwcVA-0007tU-5A; Wed, 19 Aug 2026 05:22:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwcV5-0007nC-Kk for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:23 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwcV3-0001wh-Jp for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:23 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-49558ce01afso6539405e9.1 for ; Wed, 19 Aug 2026 02:22:21 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-482b1450e61sm4408686f8f.13.2026.08.19.02.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 02:22:16 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 663D25F898; Wed, 19 Aug 2026 10:22:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787131340; x=1787736140; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=zEBSWmDHcpbyAT5+oxLyqv+4C5kL0TnHpRS3uvgoVbI=; b=XgWwhs70SAN8p+NmpeqpROpBSGqqskGycG0x1WYA9zkIdljZL0IaEJt5tCF9IfLgSe af5RAnRgsJB01+yznDf0hJirmLiGXZOcvtrB01VBS2XjqZFP3bOaNhW1YRDKaql4qQ/6 cNvKp69mtARml8AwmrHk0KWgxl+f8G40h66gg229vWoWSnvvwfRaV6D0Qn9YQNDfn+4I XMG8IIu/RDBWwdRVazJN4TyDSGVq4wyE7yKZ9RyFqEY6pEJGdLOxOBk1vfsGGPXmQe3w ft3uHQv5DrRVkdNe25SzCCRJp4v1Q1quI07PxzUqXlngRLdch6sFRPXJtDMBAcMoAxtu yS3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787131340; x=1787736140; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=zEBSWmDHcpbyAT5+oxLyqv+4C5kL0TnHpRS3uvgoVbI=; b=CPwbM7udHQRe2MAsqXFV9RHH6Cnk9voXgWFFi8/CZ/r2S80e+sNvdSuH1MgTnmjS8B E6vPqZ34Trd56urrDNseS923tUQdsbSuSE7Am8m4xFOEL2XmmN2LNKLgkaewKad2HZ+w LQEmLf8C0SAlW0Npi9sDbAo6o2UdfdlHIu0GHKUQyw2i7HXyUZ99Br2+85U67ReGmjn0 MlkV5H3id0O5SKgYMexUAEGp/H8bleth8GZa5cqBMW14QC3kk/kCHCj1fTXqZ23rZF15 JcRJg73uKeABzLAyfTPpab69rocrsOo5iI8i68nyRmhr3gQpRRrA4TtivrGKW/WdnvGR sLkA== X-Gm-Message-State: AOJu0Yyb8IvTe4ZVXF5TwfT82hSR2T4YmiC+GqD6jr/B+o9M2oig8+tN J/0opoEXGTIoLOFzZ2EWdaq1meSiO02xllCGxN44Jg39uj3RUR23w8c9maD59PGvtJ0= X-Gm-Gg: AR+sD13BooZ56vMpMDsGq1/DFtPSxTKRRc1mQ0mMOxM7AOJwaBDMSrQIo7I2Aa2xHn1 /AcKvNrweNJxev/L3U5ETA1vRFORXFGdfMaI92Bpuqrj1SRJLfkZ4iVgfVxHphYux+5YzMyvkWb s7srvx7n9+xGOicGlNUamy3AfWzY0PJns/qKrRrxEYYduJiJISCXW3f9wRFgBIMK75Y2Y8rtlA9 P8TFA96rg98jBPpxtf61yxCLorMUskkvemaF82zGIVl98A4A3XWgzz1n9iwN/pUC1bhMzCe7bIT nTD5AncWEuIc3fF2V4zT3i80renZlZGTNLUXp2KXAqdd6nRt/17G3Ewd2lGfmjbx/BZ1xupFwcT Uhl8yd4qRRP6wsejOQq4jCcylvfZ1HeqSGyyQJPJpr4GrTNxqRxRQ5vc9P3Xedljwc+p8mFLKmw z3AAUPmAgJKYlygBuhwr7+h1+k60vXPCmhumiIFpemTYLIRec0qp98TAyj1ueS X-Received: by 2002:a05:600c:190c:b0:499:5282:f8d1 with SMTP id 5b1f17b1804b1-499aa1ac47cmr54101095e9.12.1787131340217; Wed, 19 Aug 2026 02:22:20 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Wed, 19 Aug 2026 10:22:03 +0100 Subject: [PATCH 3/6] gitlab: add arm-softmmu tests to the macOS build MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-fixes-for-11-2-v1-3-b7981c2cc371@linaro.org> References: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> In-Reply-To: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1596; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=B9ZSx+meoWvdNqJq36oJBwbjPxCumeybg4Iya8CkY5Q=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqhXXGWquFVetm/TQPeCRaIqpMdvkNgXP2Pe5Gv MiUAU1Rn2OJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoV1xgAKCRD70NsJWp4q RNgJB/wIygNvGYLCcR6OOBZpVYQYPNJ9YUZ2FoQlAWuEHigXvwnQZXykBG9s0tTMvtOdfp3ecz6 H226V/XnMRF43ZAzsQMI80N5HOhF3ZBu/9j/ztxr31FSReMszHh3rj9Jb4xkj2bFEBpmZJMvF6T eY+c7ZIEMLKvlutTKUYzTDYjEY71AZ3/mwixyyARMS6c5+KgrUR3cvYd+d9beyeF0duFUO11dZN hK2vKKtuVWz3N4WvR8RJTTfdoPurDwxpZ4K1USsIVt330YxOMOz5f7bLKXVQsH7/u3bdTsBXmz1 Ml5NEOMS+g6T7s9CIa6cHrH+Jayjq6DxjdE1muhorCJu6Kbu X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787131464728158501 Now we have fixed the compiler issues lets have at it. Reviewed-by: Pierrick Bouvier Message-ID: <20260723200904.224413-4-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- .gitlab-ci.d/macos.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.d/macos.yml b/.gitlab-ci.d/macos.yml index bdb3eae18f0..40b9b637b3b 100644 --- a/.gitlab-ci.d/macos.yml +++ b/.gitlab-ci.d/macos.yml @@ -22,7 +22,7 @@ - export PKG_CONFIG_PATH=3D"$PKG_CONFIG_PATH" - brew update - brew install $PKGS - - brew install aarch64-elf-gcc i686-elf-gcc x86_64-elf-gcc + - brew install arm-none-eabi-gcc aarch64-elf-gcc i686-elf-gcc x86_64-e= lf-gcc - if test -n "$PYPI_PKGS" ; then PYLIB=3D$($PYTHON -c 'import sysconfi= g; print(sysconfig.get_path("stdlib"))'); rm -f $PYLIB/EXTERNALLY-MANAGED; = $PIP3 install --break-system-packages $PYPI_PKGS ; fi script: - mkdir build @@ -40,8 +40,9 @@ aarch64-macos-15-build: PATH_EXTRA: /opt/homebrew/gettext/bin PKG_CONFIG_PATH: /opt/homebrew/curl/lib/pkgconfig:/opt/homebrew/ncurse= s/lib/pkgconfig:/opt/homebrew/readline/lib/pkgconfig CONFIGURE_ARGS: - --target-list=3Daarch64-softmmu,i386-softmmu,x86_64-softmmu + --target-list=3Daarch64-softmmu,arm-softmmu,i386-softmmu,x86_64-so= ftmmu --cross-prefix-aarch64=3Daarch64-elf- + --cross-prefix-arm=3Darm-none-eabi- --cross-prefix-i386=3Di686-elf- --cross-prefix-x86_64=3Dx86_64-elf- --disable-plugins --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787131461; cv=none; d=zohomail.com; s=zohoarc; b=Y5DP6gpAf8vKIhpHHjCsW+/+qm9JhJI0Av0BiW8mZVy64hfy7OMBEHDjbPk7YCeNwf8wc49DH9VpuV8B9msZERsie0CkChi9zemo3nSm44YaGhC24lf7HiZSkQKKpRGqfiW4WjhMhQlfg4IRJHK3WEbCQ7t8pI7O/DWR94PNUgA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787131461; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WJwqaddlExuj8k565K3Q7CEWlxwfLdXIcKUzKJqIN0Y=; b=TJoj7ZUkCZ/rWvmZSh1p87PIZc4ZQJlNipOi+1OR1SXaraZrWMElQgQ8iHcQUgCAQPL5g18XUesGumgMQ2zPHdimfCfhI6spl5xNd/AzY6PWi7FtUgYGI6k9C9+tWjSLzJGOFkjNb1sreA60JOuqqk9zWJz0g3xq9HKAn618pYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787131461254722.1480395922055; Wed, 19 Aug 2026 02:24:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwcVA-0007tT-53; Wed, 19 Aug 2026 05:22:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwcV4-0007kz-El for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:22 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwcV1-0001vg-F9 for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:22 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-499ae1c6471so1280245e9.3 for ; Wed, 19 Aug 2026 02:22:19 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa1111b2sm63713805e9.5.2026.08.19.02.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 02:22:15 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 688D55F94A; Wed, 19 Aug 2026 10:22:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787131338; x=1787736138; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=WJwqaddlExuj8k565K3Q7CEWlxwfLdXIcKUzKJqIN0Y=; b=VnpmqvK6Rl5A0y3rzKCNGPhImM/jykJROmPZaUmMxDKM+Tpc1aMSjsbkCyNR8FA19C XvDaczi9mtbpM8CxJYFqBEyIll8wnvylvv3k0vBrQhdu4z4DPQddvKWpw6DdrxoHZ/px 18G0JiwLePdbbFqjpWAURMtjrxQ/avwISvB9HPsYFqKMrM1kms7kxksQt4AszS8CtEAW ollq9hqGNFvJ/v5LkLHtjs++ftGcMO/oG3mRqqNvCyHCGxtHV7un5aHwCmYLeZiS12UA WvTJqoGoQz+zNMyv2bEFoGrQAhA7HncH9WbfMIJhjc8va+ySt8rRYmVgJeQjFuSUBbj1 LYxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787131338; x=1787736138; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=WJwqaddlExuj8k565K3Q7CEWlxwfLdXIcKUzKJqIN0Y=; b=oXLRtkgHOUViNmEhk3uHEJQ9l4MgUO8oQCRXX5S4IyZM3EhEuL57IPxcFHzdd+Eg1q tmpgfhSIf9sqXnYscMSYtcY6yLzyKp8NTyYO9fd92pPPI0VFa4xy4Sdi5LyMsKEykMdf jhvy8GxoQCX26+rWTDCTHaHzHCOyGaU35KB7S4rhzj7i/xWSu3wJoCiA/gbvyv9dZNH2 IKramdYIgt8pGDaj2V3mehdthdL8dM+YtWTb90oRVplfnXJOrmzkdvhuqHjRjK5emJcV t55IfPXR8ZJnzlDizl02p8954u40+6EjYXy7ZLDKUkjyFb+6LDQsDXmUOViC7xTvvDcG lbSA== X-Gm-Message-State: AOJu0YyNkepeNaWd6dYIdL+MksYAJFKbtcIO0MuFvVm7TGl0E6yhQpw8 JTAA7DQ+Y13DDfmKEAFcAmXO0nd682OAKjgo55iPm81qavIe5qdKzFTW5SFYKAJwmnA= X-Gm-Gg: AR+sD12Lr5nWgIVPKK+oZYp/X/6dT58xFaGeZknBQHgYChy5Awfs9aEN1BUHLRYfFYt rgSwBnnC+4cRWIj0V4icdfUL1Kxw7pLPwedHhHmLLKaOIIJ2DuelUKKLdeVXtJ+r8EiLR90vA8Z 52SIkutSlEJFV+eUV63tJ0w5L7oIH4tzXTwNyNSy+p8r/nlt7SMB9gR1fBTHY1o808bLzifm6in MqoQA5AfpRtndbtPVMsKU6KjwrUD2uWk7t0RQ43RtHTX1HGfDB8AVqi3aY0rcDJLiopNwLilRBE M0uR2qPe7VMc/SdfhTnNPoOlnWk6iUYFZRzoNULwgtnEH6gfY+jXrF8illsYWB+6AFok5V3tVai jeaeQr6jdRuLrEp5mHgTbjOxFwGawta+a2j/Cgz07oXMljRqD8O59n7xeku5sUSw4q2ZfgFcDdT obDniA4fvLMXqCXkVh6VSx9lJ+MC9r1ACdAt0E3p+cdvd08F5dyAFU8FiaVCSrtR5mgV36LzM= X-Received: by 2002:a05:600c:3e0f:b0:499:a79a:694d with SMTP id 5b1f17b1804b1-499aa155e7dmr61077895e9.4.1787131337958; Wed, 19 Aug 2026 02:22:17 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Wed, 19 Aug 2026 10:22:04 +0100 Subject: [PATCH 4/6] char-fe: implement qemu_chr_fe_backend_name MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-fixes-for-11-2-v1-4-b7981c2cc371@linaro.org> References: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> In-Reply-To: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=4652; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=16o9aOALfN4xkFpmwmkWkdn+kTLD6/M+CAi326lKzSg=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqhXXGvUdFInmClYy9aj06x8dzM9oZUdQQYHyOe pWOViXcoSmJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoV1xgAKCRD70NsJWp4q RBkIB/9d0x7H9ilApVtTUBg2lCgecTkU/tdYtW5ma4ks4mrdMKsQetAmaO2VdVwT3Iull02ZaHJ rutM/W0cVyTZZioT43i33OM1ts1VlzFR526ZlqnPx4To5hHL5hVvrAm8YgDLbtS7g3qD9n94GGd YU6PVJD1iVA2XvxAPxXnkpDf28ezPhBq8ciHx1nuCJvPGdcwOC3LhU3mleEGCgHGmrgaNHqEpdm HfFEa2AUr2mpL+Pousp7qn8Uuvr02dN8lWd7IGtR1s6k7v8T8Y8w9c5HZ8itxgtYc79hoxzSysX Qj6VoLc5tjeqy2W0OB9zOZPqyy0//l2e+oxAmW9FxoIxq1eZ X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787131462976158500 A number of chardev users where calling qemu_chr_fe_get_driver() which is discouraged as it blocks backend hotswap. As the pattern is common and need for the string is transitory add a helper and keep qemu_chr_fe_get_driver() for those that really need the funkiness of poking around the backend setup. Suggested-by: Peter Maydell Reviewed-by: Marc-Andr=C3=A9 Lureau Message-ID: <20260810153503.2652324-1-alex.bennee@linaro.org> Signed-off-by: Alex Benn=C3=A9e --- v2 - checkpatch fixes - r-b --- include/chardev/char-fe.h | 13 ++++++++++++- backends/cryptodev-vhost-user.c | 8 +------- backends/rng-egd.c | 8 +------- backends/vhost-user.c | 8 +------- hw/char/imx_serial.c | 4 ++-- 5 files changed, 17 insertions(+), 24 deletions(-) diff --git a/include/chardev/char-fe.h b/include/chardev/char-fe.h index 5f8a6df17dc..a82894e1d51 100644 --- a/include/chardev/char-fe.h +++ b/include/chardev/char-fe.h @@ -52,7 +52,8 @@ void qemu_chr_fe_deinit(CharFrontend *c, bool del); * associated Chardev. * Note: avoid this function as the driver should never be accessed direct= ly, * especially by the frontends that support chardevice hotswap. - * Consider qemu_chr_fe_backend_connected() to check for driver exis= tence + * Consider qemu_chr_fe_backend_connected() to check for driver + * existence or qemu_chr_fe_backend_name() if you need the name. */ Chardev *qemu_chr_fe_get_driver(CharFrontend *c); =20 @@ -70,6 +71,16 @@ bool qemu_chr_fe_backend_connected(CharFrontend *c); */ bool qemu_chr_fe_backend_open(CharFrontend *c); =20 +/** + * qemu_chr_fe_backend_name: + * + * Returns: caller freeable string or NULL + */ +static inline char *qemu_chr_fe_backend_name(CharFrontend *c) +{ + return (c->chr && c->chr->label) ? g_strdup(c->chr->label) : NULL; +} + /** * qemu_chr_fe_set_handlers_full: * @c: a CharFrontend diff --git a/backends/cryptodev-vhost-user.c b/backends/cryptodev-vhost-use= r.c index cc478d9902d..3334e280a27 100644 --- a/backends/cryptodev-vhost-user.c +++ b/backends/cryptodev-vhost-user.c @@ -373,13 +373,7 @@ cryptodev_vhost_user_get_chardev(Object *obj, Error **= errp) { CryptoDevBackendVhostUser *s =3D CRYPTODEV_BACKEND_VHOST_USER(obj); - Chardev *chr =3D qemu_chr_fe_get_driver(&s->chr); - - if (chr && chr->label) { - return g_strdup(chr->label); - } - - return NULL; + return qemu_chr_fe_backend_name(&s->chr); } =20 static void cryptodev_vhost_user_finalize(Object *obj) diff --git a/backends/rng-egd.c b/backends/rng-egd.c index 1d92bd71cf7..c2207f40c5c 100644 --- a/backends/rng-egd.c +++ b/backends/rng-egd.c @@ -126,13 +126,7 @@ static void rng_egd_set_chardev(Object *obj, const cha= r *value, Error **errp) static char *rng_egd_get_chardev(Object *obj, Error **errp) { RngEgd *s =3D RNG_EGD(obj); - Chardev *chr =3D qemu_chr_fe_get_driver(&s->chr); - - if (chr && chr->label) { - return g_strdup(chr->label); - } - - return NULL; + return qemu_chr_fe_backend_name(&s->chr); } =20 static void rng_egd_finalize(Object *obj) diff --git a/backends/vhost-user.c b/backends/vhost-user.c index 380d8250233..46dadb74800 100644 --- a/backends/vhost-user.c +++ b/backends/vhost-user.c @@ -152,13 +152,7 @@ static void set_chardev(Object *obj, const char *value= , Error **errp) static char *get_chardev(Object *obj, Error **errp) { VhostUserBackend *b =3D VHOST_USER_BACKEND(obj); - Chardev *chr =3D qemu_chr_fe_get_driver(&b->chr); - - if (chr && chr->label) { - return g_strdup(chr->label); - } - - return NULL; + return qemu_chr_fe_backend_name(&b->chr); } =20 static void vhost_user_backend_class_init(ObjectClass *oc, const void *dat= a) diff --git a/hw/char/imx_serial.c b/hw/char/imx_serial.c index fb41ee2ac50..8ac4efbb5e9 100644 --- a/hw/char/imx_serial.c +++ b/hw/char/imx_serial.c @@ -278,10 +278,10 @@ static void imx_serial_write(void *opaque, hwaddr off= set, uint64_t value, unsigned size) { IMXSerialState *s =3D (IMXSerialState *)opaque; - Chardev *chr =3D qemu_chr_fe_get_driver(&s->chr); + g_autofree char *label =3D qemu_chr_fe_backend_name(&s->chr); unsigned char ch; =20 - trace_imx_serial_write(chr ? chr->label : "NODEV", offset, value); + trace_imx_serial_write(label ? label : "NODEV", offset, value); =20 switch (offset >> 2) { case 0x10: /* UTXD */ --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787131437; cv=none; d=zohomail.com; s=zohoarc; b=LijsQaGxtDGireRgNuksr3rLJxzuLnJ4DIQLK2C4HIALU0yF9vJfw9Rd7F68QmBa32SHt2d5OnOr7ojjBs8MZaoo/ECWyXoFIpgP28r1dkkdppDTX89vMGNzS997iOY8liPSb+OQtHJFB8Ujwu1i8hLZsSyQ9axwg+sZ1js8/Fw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787131437; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=4fCOt0OznbhBOvDSho9fI+DXpHx6dkj8m4gGLZPFe7g=; b=GKR1foUh0t4V84C68uB26jS+PQRFrEPklMmyP7UofY1TIPTmHEhIEPr9B+M6sWB1bK9rPfHFYrBlJCKPOzUeJwFdCsyYWUaGFNKlRRnTKqD+FIGAsyAtUISikf3mz1h6T5L7M6pCRuUFrqXqJvQTLRnZn0G5gPuQeW6SsNdY5Cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17871314377325.383972920101314; Wed, 19 Aug 2026 02:23:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwcV8-0007pr-D8; Wed, 19 Aug 2026 05:22:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwcV6-0007ns-HG for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:24 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwcV4-0001xJ-Ob for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:24 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-49554ebb87dso7810305e9.3 for ; Wed, 19 Aug 2026 02:22:22 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa1111a7sm48838695e9.6.2026.08.19.02.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 02:22:20 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6AC3F5F951; Wed, 19 Aug 2026 10:22:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787131341; x=1787736141; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4fCOt0OznbhBOvDSho9fI+DXpHx6dkj8m4gGLZPFe7g=; b=ar3Kc+vKHwcIJgmSs/pT/0rmrOfWyzaHrqsuQU6W+y6mecpBFcG1LakxneefacyV4W C50pF6eLJjUYu4/934zn0woZc8xgCsFEHbh5LbZKhnPX1h5/aRxM9hacinPdNL2u3uAf 08KlD8luj1PXGybYOogM7D3qgbEk84PFlG3sw4mqJu++TpEH+6yWv+gzbydIHqTjAWst nhVQleMVf4pfGxOPDiL4wvFuYqA6b1sFUnnCcdMcNvEPa19pyyVAFUZgU0B7JESJy5yj 1hp7x8u3rVuUvAzghGFBHgRzcrmFM3JcPlRJRKVOxW1cB2FNgcVH/SKJDv2qG2c9mfzd bLGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787131341; x=1787736141; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4fCOt0OznbhBOvDSho9fI+DXpHx6dkj8m4gGLZPFe7g=; b=fk0ueh3iu9b/8zLlsULJn0yN2SrDVqAyxSSQ3tIwSSp2tZ1IjjSuEYHuTL+RayLN73 AeLIBpzDd3a92gXDCcMrkk/8xlhIfdxcs3zT0OVkGcT1Kf69sAeBrgrF2KYvls9qxhdS fwIm1+6OAa1CwTxy0Q12at3EWBYV7A836j3RLuST8Yd5CtzF5u3JNg3xWdjBe8i3rWvW s4QJq11gB+hRfmuf/BfwJ2YK0vMukRDUN2b1O2h2KKDOBS9OpglzaP7FegH/O3HdU2BG UqO8WSEOUJjIHFyvtCVl7wMd2vHLcJhwpS3Z6WGCtYRJDvxCmzoYQnXZNmQswATO3k9U CMdw== X-Gm-Message-State: AOJu0Yzk0MWuqaUxeJNbnRM4rvuButju7XiAo8HojW9OJ41QCRU/WD9J YGXWoStnfoxxzuA2pED5tjw/dcY6+Gm4POaqdil0aaaUzt9XE+XaQWa7lbQWXqe8dc0= X-Gm-Gg: AR+sD12HEu7XMuA3ADpnn4dnkcenfUP3oHApTSnVIR8RFhwpk2BDoCaQWj+rtQcPRz0 3VYuPf1RbK45YfXL2Es6MoMo9sDAHNvZlHux+5FzyAZMHMv7MnAI4/jdKbiRD5oyvP9n2oWU1pE aXJ6kroFV27GdKcG0t5EbDJRN/t5aEkBvdFe6TxOeC0KYylZ08obD0aUegW5Z6Bkw2nBIUkVweN uSBFNtzr7p5T0fXqubR3lAbeLwYgxNLegCdYglUCRff3jved00xJbtMp0KJ78fTSsyyEJC26izl lMYn2h4H9Oelm6o2jBNU/I7MvnuWCyDqf/CVtwI1JMVygkCtDMRNSxW+eaeOy85R2OX7oP5H4U1 gjMBfBbFom7hrWPK0QsBaBF0P9QgJvUOLDg8zDmtzlSLWGDo/FwmSySh8FdQbgXkvFvysUJqW0C qQQE04km+WKuACOm+WOYkcZdnXSZBd5hVOxMZ1GxbKJpWgnyOgBxqqPnEw/Vm/ X-Received: by 2002:a05:600c:3f0b:b0:495:4491:b8c2 with SMTP id 5b1f17b1804b1-499aa14b191mr63229715e9.3.1787131341079; Wed, 19 Aug 2026 02:22:21 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Wed, 19 Aug 2026 10:22:05 +0100 Subject: [PATCH 5/6] hw/block: validate the fdc sector position fits within bounds MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-fixes-for-11-2-v1-5-b7981c2cc371@linaro.org> References: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> In-Reply-To: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=3740; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=OEX2z9GvvKbNe5gsvOGBjrtH21eDSoBa+jvNaK6zjWc=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqhXXGNAi9uavy3WXrBtrOwQIiWOo6yYdUrRrxr QU1tJkP13SJATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoV1xgAKCRD70NsJWp4q REzDB/4pLaXN3OGb2+yQgYXx7wM53dI6ydkRkDkAQEdFHU5Zv6CWLVjU/pBWTbwvW3GO84qrqnh +9tNUGxXqvUiYHEfU6Fb5e+OWFLsJlFZQuODLpKN6IlwrltUh1MMVnJ7LHwchbegwVae4kW5ycQ w1xm1vzivm3xLGZ28QjV7XfJJVzrQo7HFxNSBItbB7w+S1+1fFnICFBHwEiA2qKGT2j7nLcmgUf oVYuICmEwwSHCdMuMMx1TMyVIAXX1/bCVI6B/XYicmTHRbZyqWag/D3DYIwftpcWEzMEayRM0UD uIgZ4L0hPlBynxF+Xt+ITJ0yE/bxT9Kx2XQ5DAM0CwPlQjng X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787131438992158500 Previously the guest controlled the value of last_sec and wasn't particularly careful to check it didn't exceed the media size. We can't re-use drv->last_sec as that changes as we do operations so we set media_last_sect when the geometry is probed. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3800 Signed-off-by: Alex Benn=C3=A9e --- v2 - checkpatch --- hw/block/fdc-internal.h | 1 + hw/block/fdc.c | 28 ++++++++++++++++++++++------ 2 files changed, 23 insertions(+), 6 deletions(-) diff --git a/hw/block/fdc-internal.h b/hw/block/fdc-internal.h index e219623dc7a..3a39ac903c7 100644 --- a/hw/block/fdc-internal.h +++ b/hw/block/fdc-internal.h @@ -83,6 +83,7 @@ typedef struct FDrive { uint8_t max_track; /* Nb of tracks */ uint16_t bps; /* Bytes per sector */ uint8_t ro; /* Is read-only */ + uint8_t media_last_sect; /* Probed sector per track*/ uint8_t media_changed; /* Is media changed */ uint8_t media_rate; /* Data rate of medium */ =20 diff --git a/hw/block/fdc.c b/hw/block/fdc.c index 1178b959a64..18a61f5ce87 100644 --- a/hw/block/fdc.c +++ b/hw/block/fdc.c @@ -192,6 +192,7 @@ static void fd_init(FDrive *drv) drv->max_track =3D 0; drv->ro =3D true; drv->media_changed =3D 1; + drv->media_last_sect =3D 0; } =20 #define NUM_SIDES(drv) ((drv)->flags & FDISK_DBL_SIDES ? 2 : 1) @@ -373,6 +374,7 @@ static int pick_geometry(FDrive *drv) } drv->max_track =3D parse->max_track; drv->last_sect =3D parse->last_sect; + drv->media_last_sect =3D parse->last_sect; drv->disk =3D parse->drive; drv->media_rate =3D parse->rate; return 0; @@ -1905,6 +1907,17 @@ static void fdctrl_handle_partid(FDCtrl *fdctrl, int= direction) fdctrl_to_result_phase(fdctrl, 1); } =20 +static bool fd_validate_last_sect(FDrive *drv, uint8_t new_last_sect_val) +{ + if (drv->media_validated && new_last_sect_val > drv->media_last_sect) { + qemu_log_mask(LOG_GUEST_ERROR, + "FDC: Guest attempted to set last_sect to %u, exceed= ing valid media max of %u\n", + new_last_sect_val, drv->media_last_sect); + return false; + } + return true; +} + static void fdctrl_handle_restore(FDCtrl *fdctrl, int direction) { FDrive *cur_drv =3D get_cur_drv(fdctrl); @@ -1919,6 +1932,10 @@ static void fdctrl_handle_restore(FDCtrl *fdctrl, in= t direction) /* timers */ fdctrl->timer0 =3D fdctrl->fifo[7]; fdctrl->timer1 =3D fdctrl->fifo[8]; + if (!fd_validate_last_sect(cur_drv, fdctrl->fifo[9])) { + fdctrl_stop_transfer(fdctrl, FD_SR0_ABNTERM, FD_SR1_EC, 0x00); + return; + } cur_drv->last_sect =3D fdctrl->fifo[9]; fdctrl->lock =3D fdctrl->fifo[10] >> 7; cur_drv->perpendicular =3D (fdctrl->fifo[10] >> 2) & 0xF; @@ -1983,13 +2000,12 @@ static void fdctrl_handle_format_track(FDCtrl *fdct= rl, int direction) fdctrl->data_state &=3D ~FD_STATE_MULTI; cur_drv->bps =3D fdctrl->fifo[2] > 7 ? 16384 : 128 << fdctrl->fifo[2]; -#if 0 - cur_drv->last_sect =3D - cur_drv->flags & FDISK_DBL_SIDES ? fdctrl->fifo[3] : - fdctrl->fifo[3] / 2; -#else + + if (!fd_validate_last_sect(cur_drv, fdctrl->fifo[3])) { + fdctrl_stop_transfer(fdctrl, FD_SR0_ABNTERM, FD_SR1_EC, 0x00); + return; + } cur_drv->last_sect =3D fdctrl->fifo[3]; -#endif /* TODO: implement format using DMA expected by the Bochs BIOS * and Linux fdformat (read 3 bytes per sector via DMA and fill * the sector with the specified fill byte --=20 2.47.3 From nobody Tue Aug 25 02:51:37 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1787131453; cv=none; d=zohomail.com; s=zohoarc; b=O1rGnvmzfkb+4Bw7qLDRwZCcNFwLseS+u2NekQ0aYgR4MwS81AIvzL4ndyCImJbq8G1BDJscfazV2B74oLshEDSv5Y3QCQ/3McrSTzU6+AbLUvKWzsGzggP8dbNI5rvCP1qIB04VMkUgaxdxaguOx8DL6aBi9eUKNjXew2q6GEA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1787131453; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iaAT8nwz/f/r3I4xJQrnagwmY7s7BG9goh2VAnx+Bdo=; b=kPxzuJcoQp7lybMUyFyJZGM0VQnpwWsCC5b7rkgwG0UcRsCuFX3bZR0pptb3ziA5rk0qTScxbEFhPpk+hS9mQnVnvzDm8jxi/uHE4qvzPvlurmdzIEyOkMEzF8uXA260BPL/AxmcDi1FmwZXw1xHId21oOlzPVImq2MRTaKde1c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1787131453887708.8247612486437; Wed, 19 Aug 2026 02:24:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wwcV8-0007qB-Ka; Wed, 19 Aug 2026 05:22:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wwcV6-0007oR-UL for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:24 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1wwcV5-0001xg-6C for qemu-devel@nongnu.org; Wed, 19 Aug 2026 05:22:24 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-4957eefd361so5906825e9.1 for ; Wed, 19 Aug 2026 02:22:22 -0700 (PDT) Received: from draig.lan ([185.124.0.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-499aa0fd7a9sm61725355e9.2.2026.08.19.02.22.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Aug 2026 02:22:20 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 6D1C45F9CB; Wed, 19 Aug 2026 10:22:14 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1787131342; x=1787736142; darn=nongnu.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iaAT8nwz/f/r3I4xJQrnagwmY7s7BG9goh2VAnx+Bdo=; b=d4laKpEAO2BWNMlUJ3pdI6yKyFJkFIls3cypWF5LbbonWuYKLZtRMHeEYmjR4Asto9 zsZP01cyh0yQNA5ofMkvovxe9ejlZ4A5yOjHd7ZaZUiDBy0lmG5tQJq11aPRkEk22jkF kSw7RFZNWi92xfzVQiDJgsJG20H1A77PTf7FKuj7+EOUeG77mg+xqCii0gZLXO9JzL9U qr84hT3papF/uscgLlbPZ2uAqDlU9PY81gPD7GaQBuI+tkAYa+Ko4oXkrySPb3TZvcZe aTw/repSOYaxczE83/rbRJ/wziZ7rvX6I27lajZWeKFLJC0pASwK3gHsNd4Sx+MktoUU lWew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787131342; x=1787736142; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iaAT8nwz/f/r3I4xJQrnagwmY7s7BG9goh2VAnx+Bdo=; b=BDqQw6ssLYNK+A5B57Pl7Mk069bbp9+GokKk4/64DruNW1b02eSiIbFz9T+9h3X62O fhcFBGxfnnu/fBCAXMNWSrD7RPWhRpycehmzagHmuUy9z7DxEksqxUpErD8N9yLNBjHX 2wb7Qs1WY9CWc7v9xK71v+Lx22JMHGl3aJ8yVop/l12ammCMpacVJHK+QPkywMZPPc+T whEBXvxdERcscylytoPVYBSZiVtNWP1DtIpbvrveVcVi9+SLcpkn3pBGFiTh3L3wL6Gx G0eGQRlY/HkpagLXsTHFHQyKTcTGWIFeLNPMEHgZ5QxoWFmAZB7Duh0IIAVpnHtzAhXE 7pjg== X-Gm-Message-State: AOJu0YyA6xXF4J1ewxoOLbVXrAD/eQPsVzlLoPy3Dli3qSpHLHWVjNm6 5KMGCXn6VE227q/dHddtKQGA+9RYHZq0BP6C8CG58e8I8PScVihaegFcxOyRoQr2VqQ= X-Gm-Gg: AR+sD10Bz14VfOUpnTmPXPUCF+x/Mm+odTUy1zJzZ+ymvgcdOTSIxFarC1LSMptXDUS mONfZPtuh1O/6m/mzJEdUlX2PmcvalGSFnJQ+uDsIKqoRhUBkgaRNwcONvXN4QxgdobGQYG05Um XLEDbih1poyap58l/yEQEhG397+/os5EZaWBj9Wc5TF9MMuSnXR6p1HESqsNNfdia/t2t/iWEBR Rd37aKnbCgnVZ2p3amZv7K2vak9rWTO5NLHeJQnTzQydIv7XZO9VIgyHgLVjygjTfhUjPTbRBJs Pc+lACdhi25GGNz8cJwfpPoLP2x147FIaiFiNPK6Srly7pfiQ68+4KAzJmEUDy9qyFxfyuA0Vhf 4jHo9ohsyXCs+C/eo0VAtvr9dixJIqrVyC+q0r6m4gHngiy3U3xcGHBYkl9V4glsT4672Jj5Cze easZDWAKgwrV93U0NHEPbgOXS/I79K1zhJNidYtyuHzCGi3EwA+InxVNU0dv8+ X-Received: by 2002:a05:600c:3484:b0:499:7a5e:4c3f with SMTP id 5b1f17b1804b1-499aa14e6abmr69404585e9.1.1787131341756; Wed, 19 Aug 2026 02:22:21 -0700 (PDT) From: =?utf-8?q?Alex_Benn=C3=A9e?= Date: Wed, 19 Aug 2026 10:22:06 +0100 Subject: [PATCH 6/6] docs: deprecate virtio-crypto MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260819-fixes-for-11-2-v1-6-b7981c2cc371@linaro.org> References: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> In-Reply-To: <20260819-fixes-for-11-2-v1-0-b7981c2cc371@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Pierrick Bouvier , Peter Maydell , qemu-arm@nongnu.org, "Gonglei (Arei)" , zhenwei pi , "Michael S. Tsirkin" , Stefano Garzarella , Laurent Vivier , Amit Shah , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= , Paolo Bonzini , John Snow , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, devel@lists.libvirt.org, =?utf-8?q?Alex_Benn=C3=A9e?= X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1496; i=alex.bennee@linaro.org; h=from:subject:message-id; bh=LnZGeVc7wYy+BtyAMr/N70wRi+tYZ8yVbPE+MJ6dnI4=; b=owEBbQGS/pANAwAKAfvQ2wlanipEAcsmYgBqhXXGyf98LQqrkd9pc7pVXUICntv+8Iywp3UUS g0TmqcLkg2JATMEAAEKAB0WIQRmha6Z51FnvK/I3zX70NsJWp4qRAUCaoV1xgAKCRD70NsJWp4q RHiEB/0W+vnulxUs8yFacc39tyLzM9s/PsBBm6Kjr9XpgoNK4xDG28hOcguVfYZBwtsIBdamK1o VaLY1YOvLEKIIGjE2P6aAh9mYnLroFmOgbAP1ZbXkf6deFV5dFO96PoTX2nFbvtU4NmXsvqq7TQ FslhgdqNoIwsG8OSMCrbZIxA2ZucoQvGiLd/8UKA1XHEzw/kAoSElZHF+hQwficY1V/16QW0ZM4 zxrDyOvNRsADb4t3pJEQpUb0j5nrVYDHp46idFVvmCdkm2XC41Mk3WM97wWPv8MH313qSS09nQD MhiGT5YgfeaifTw3miIu1k5D/VJaY3ujGgvBPKC5LeYpx3Hc X-Developer-Key: i=alex.bennee@linaro.org; a=openpgp; fpr=6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists1p.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1787131454713158500 We have outstanding guest exploitable bugs in the code which is fairly complex and needs some serious love to clean it up. As off-CPU cryptography acceleration seems to be waning in popularity lets just deprecate the sub-system with a view to removing it in a couple of cycles. Link: https://gitlab.com/qemu-project/qemu/-/work_items/3625 Signed-off-by: Alex Benn=C3=A9e Cc: Gonglei Reviewed-by: Mohamed Mediouni Reviewed-by: Thomas Huth --- docs/about/deprecated.rst | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 0c656a968fc..3c22981fc8a 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -276,6 +276,20 @@ future release. Where no 'dh-params.pem' file is provi= ded, the DH parameters will be automatically negotiated in accordance with RFC7919. =20 +Devices +------- + +``virtio-crypto`` (since 11.2) +'''''''''''''''''''''''''''''' + +The ``virtio-crypto`` device emulation is quite complex code with a +number of known flaws. It has never been migratable so is unlikely to +be used in any serious virtualization setting. With most modern +systems supporting on-CPU cryptography acceleration via their +ISAs sets the need for off-CPU acceleration is also reduced. Add to +that the kernel has recently removed the ability to use off-CPU +acceleration suggests the time for this sort of off-load has passed. + Device options -------------- =20 --=20 2.47.3