From nobody Tue Aug 4 22:20:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1785864805; cv=none; d=zohomail.com; s=zohoarc; b=RDjjpHmW8WeDXBhrZNaDDoHY+A8Q7R0zBslr5UxlSnHrBJ+1m1JvuAyklHZmR77BzgN2o63gEJUT6ctGbAqrOYbfsLzT5Z93Ti5Nqo7eLXkqTWtyLdvgG/ZDAUzfO/c26OJ5Zslz6CUvN7JCodq9RunJFag6I/JKpcNd7tpbgqU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785864805; h=Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=jOSvITnwwyz7Rw3KFOgxBkpik4Jq9kgbuffG3txvDDE=; b=CmoLYdWs0xrLVgbfLwDi0l7W7Pr5liVnaYJQtlFdNtcYW/nQ+HGuA9G0khwnSEOKu6a1cWT30mBlf3gXW8AzFG7KpW5jQp1CFo/yrv51jpu8sBWX94jIJeAtoDwMyKp9toHUmwcPCWftPM0RcBKY8Q7hU+QYgZKpNW/W/dH/Qgw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1785864805642359.0006320787629; Tue, 4 Aug 2026 10:33:25 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F314C417E2; Tue, 4 Aug 2026 13:33:23 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 753C341A96; Tue, 4 Aug 2026 13:32:32 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id D0BC23F9B8; Tue, 4 Aug 2026 13:32:22 -0400 (EDT) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D6CEB3F9A4 for ; Tue, 4 Aug 2026 13:32:21 -0400 (EDT) Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-4980dc26022so614705e9.1 for ; Tue, 04 Aug 2026 10:32:21 -0700 (PDT) Received: from localhost ([69.51.117.136]) by smtp.gmail.com with UTF8SMTPSA id a92af1059eb24-13fca508a48sm4835174c88.1.2026.08.04.10.32.19 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2026 10:32:19 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1785864741; x=1786469541; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jOSvITnwwyz7Rw3KFOgxBkpik4Jq9kgbuffG3txvDDE=; b=Iiw2DSFIKjOz1IR36t8tkZstt1TQIfhnGnckrqiRqN7qdGIDhinzMoxIhL2/IMDC3O SgQSV/mjXtEeRot0MbBLe0uJkHO2YaoJ41JRvpEodPbqgzp095SnNPd69rKzwoKDk19B 8JD8wptYDqOZBUbX8ZFcPHhOupGrkeIW6AGcybcl9mqW/yQxPthvX8AxYyxSk/bdRqhV kWoi6mEvfP1YlAfYsEQlZE4uKb6wgD7hqvkOYgL2yagM4+l8/i6JpacWSEFhNbjW3Yny TH3z4FLuUm36YCutktH3yBuqspUX/MY5c2ghi4rAErkyNhwlPoaMYd4sHdXEjWr8Lklx s09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785864741; x=1786469541; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=jOSvITnwwyz7Rw3KFOgxBkpik4Jq9kgbuffG3txvDDE=; b=YITImywa4FgTM7BGSHjCyUG93y6Jue9kR4BAnBQprzqMbr9lpOVu/R0vw9xyFPZ7wd pWU0UMc1ZMyQhrIrAneZZvYmg2QDH8CHRTvWFCWHUdR21KH9pHjrwoxXY2f9u/XcDuk4 ZG963gkzk60KGEn5uKVpkYVIVuCbL4lzZ/NIWk/S89miixgVr8Z52TPjJHcw7Yx8yTty aC8TW8PqnEwhtJYZPhctkJ8HOKxBhLh0mESZ6t/dTh5ItYJf8QT7T8UtKn40QX77hmhy I/oUp0CMPytM5fgJHmLbJsIo9wZC+ltxz6L5lWi+JXIq1x7JeOIenmiMrbY00MdVXZdA vm2g== X-Gm-Message-State: AOJu0YzE/5iycGHb5mDcGVabTAoR9qAs672DdQ46d7IBD7Dh9vL6p4WC B1SUnjMe4uYFEQP8Oh0lzISfk8eo2MbJ6Nm2nmTia19YEE5OsJ1opAAucgqkktSIQRqY8z1tJyk kBhTZN3M= X-Gm-Gg: AR+sD13kw3dGaOF/wu6xyuw9SrBoYthA5oSPSUCQot6fwuFFmBHEoeSswqfOtxpe2g0 ZgZJjnRXKAa6lrYfTBOLuJX/JwfJOHm5s403zdN4zCTVg6iVDB83+srUeKogQKcPJdW3WKCpgQq irJk49RCeaT+Z5ZSXmHDOszwQ0wwJ+I92USSthc1N0bLNwM4N+St9EKfmPN8aMEiPvuaUtCbi2B lVDvHu8hOVbJChWVHQHFT0U2E73iFgsX+w5MMU30UZDo/YrENmK4idmbU6HY0hwNdo08R0d35Tg 6140FpxbSjRWP5ndgN1o7d9TPZ1DPn2c6C9IfQ4Tv6+yV3zUpBJHXCxs2vbcnTEm+KLs5M94fdx mLCbOh782yV6ZlSG7ANTOMAHi2ogAMzphYDtn07xBNcJxKX5kNAKFTMBCOYFymynWhx50JxSU2r Fk+ofWWuDCd1GBIo0qmqvp4tpKxYYTwu9L3gd+SSMfx/WZmtPjuko= X-Received: by 2002:a05:600c:4444:b0:493:f6f0:d66b with SMTP id 5b1f17b1804b1-4980c6458aamr344447935e9.1.1785864740527; Tue, 04 Aug 2026 10:32:20 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH] Commit 9899c91515 introduced the potential for a NULL pointer dereference crash when the 'ctl' parameter to vshPrintStderr() is NULL. Below is an example backtrace of the crash when attempting to detach a non-existent disk with 'virsh detach-disk test vdz' Date: Tue, 4 Aug 2026 11:32:06 -0600 Message-ID: <20260804173218.217139-1-jfehlig@suse.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 6T7NEDJXS6WFFJIS2DC4D6UOARQP27ZJ X-Message-ID-Hash: 6T7NEDJXS6WFFJIS2DC4D6UOARQP27ZJ X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1785864809005158500 Content-Type: text/plain; charset="utf-8" From: Jim Fehlig #0 vshPrintStderr (ctl=3D0x0, level=3D4, format=3D, ap=3D<= optimized out>) at ../tools/vsh.c:2148 #1 0x00005555555e6b2c in vshError (ctl=3Dctl@entry=3D0x0, format=3D) at ../tools/vsh.c:2170 #2 0x00005555555afec7 in virshFindDisk (doc=3Ddoc@entry=3D0x555555696ee0 "\n test\n 9b27a21e-dfa2-4c1e-9d11-2de275aefb03\n \n , argv=3D0x7fffffffd= eb8) at ../tools/virsh.c:908 Ensure 'ctl' is valid before dereferencing it. Fixes: 9899c91515d79595d19800ccc895df18eb7bb3f7 Signed-off-by: Jim Fehlig Reviewed-by: Daniel P. Berrang=C3=A9 --- tools/vsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/vsh.c b/tools/vsh.c index ccf2f21d64..667cc1a0d2 100644 --- a/tools/vsh.c +++ b/tools/vsh.c @@ -2145,7 +2145,7 @@ vshPrintStderr(vshControl *ctl, if (ctl) vshOutputLogFile(ctl, level, str); =20 - if (ctl->stderr_closed) + if (ctl && ctl->stderr_closed) return; =20 /* Most output is to stdout, but if someone ran virsh 2>&1, then --=20 2.51.0