From nobody Tue Sep 22 22:50:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1785520518; cv=none; d=zohomail.com; s=zohoarc; b=S+aoqSCB3ZgPMKmVhXWc9GD9xDSnkk2gf22EFJfvkc0e1pXYYRSsseX5tUfhCAQsM8XPS+eibU6IzsXjpFc2pXhyytixaTjg33cb8VrZDDo/rqDREmvyk7lZ0txGpbCsQFOe6+EHCMkwVV5IyVFYXzSuvXUe0z4S0D2cTz+yPqY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785520518; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=OAk80yQo9g9oubjQ2m2+fS5U7tjzaObDY8jcYwS+psI=; b=BQ+ftCSNDZAFMtJtZF192Z2vZ+1I39HIobaldv8IcYGCkOshseHKBcXZM8NNeS88LTTwY3jWQNVsRcJzzqJZZll91QCBREWf72K+rYDv3xxDWAq5gBi3cdofN9dmn1hFRUTVYbv8NCl8cK5Z5Cvzn88grHYT2IKm3ho7nZogPLo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1785520518120839.1582943399094; Fri, 31 Jul 2026 10:55:18 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C04AF41885; Fri, 31 Jul 2026 13:55:16 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id B9DC4417F7; Fri, 31 Jul 2026 13:53:17 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id EFADA3FA30; Fri, 31 Jul 2026 13:53:01 -0400 (EDT) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 780CE3FA58 for ; Fri, 31 Jul 2026 13:53:00 -0400 (EDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-c15d111ca99so141437866b.0 for ; Fri, 31 Jul 2026 10:53:00 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c9e3e6sm223961966b.22.2026.07.31.10.52.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 10:52:57 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785520378; x=1786125178; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=OAk80yQo9g9oubjQ2m2+fS5U7tjzaObDY8jcYwS+psI=; b=GHIo67pQyyzuTOPXJW/i/qpvy8KYVX6J7z50bm/rV3sYojmjkDPWNaKuF0B7bv6Ppy Ye/MRQ34U+Vf6UEAz968izX4yRzEW7LrC5l/Qxq2exRyMSKi+xhhI+Ymx6Eo4wV6yDL+ Zu+6U9dbUQs4Icshc9jQWOQpYYZuNdoG4b7lKvOoN3bxcZ3xx2Sgca2I0EFy0KYFd39E I/gBijilkp5xEx4DPsSZPVZpW8LZeLayYCpU1IsHaFdPONudTSGcG6VJQClxVJxSXi1i KuMVziJUXzNXTr9QH7grWkNwM6bEkLAGjtqBjnuo1uh17rhd5Dtf85zdNCkpL3yg8jkq Fn+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785520378; x=1786125178; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=OAk80yQo9g9oubjQ2m2+fS5U7tjzaObDY8jcYwS+psI=; b=QynpQ4cDVpLoBTd0Ui+PFONj0tJXXjoJR58J5jU1Nb3splpKRmL/k7BXkNpdEO/vEV AoNtJEYho7fTOabnuWZwuQ9WQH5WckJtsB1+71odz6xl6S62LflBlgbR3fq421LasDRc 8IxHJrSndWv3JTdNVr+jF2qy2X0SON3EIO1nilgN8flWrPsSheD+yI0MVrKpAo65yRYA emTSQrPFOZnEzfONFa31gyqOxy3g6xvHpDfUx7VbgQsA0nPAoIG4Jno1cXFJQZtuV3DH Ny4YnixsNq8Ls2jmQMA/ysTA9wNGOkVtwZYuIB5B5h2JACTwKkZJsOhCAd1Y24Pqpzi6 bbZQ== X-Gm-Message-State: AOJu0YxWcIsJ//H7QOWh/p2R9xjMhW3X7FVmvlURBIYTbtO2izRcp4f6 Bz9274gyAoNx2dJUcR2X9kO0kIzAxki1rEsHCJ7tQ0Jy7rimrmp2t+hkfFjt7v+/ X-Gm-Gg: AR+sD12h7SDbk9pwjdzTln2ezRo2aoRJ8rRh9aEmCWv4lKY9gO/7IOq9TJXx30pGf+J KGqE4kKdLl+sJK7qYsSrk/rJvBBsHUAT0ZqHw+VUZrJA2NkMumheyyPMF1uAN86g3N9Ob0q89J/ guNcIHjET5J8qSACmuWvpJAuc/B33dBrbm8VDfX6HCR5VXaamyOTeUWmW4m+7v90BD+PjEXSHEB a9VInVNDgPprGKzZzep8cnpYUso9YDaOIGtZPSJ8RU5TBuJLyxGEB911/r1pBUZtO+hE0F0QNMg HNh8HWMXKVAtN0FELKpNUcYds+COfrpbU3cVvMcVMWDHzqOTkPU53pSs+1Mb4tLs7Qd2gdwYKo6 oSQ2GHixCX1EGR0w/ODiRojrwEKRWdTdN8185CVCvs1dADSu2t7qHNUzikMELgZKPK8+zo8P14/ BQw91crrs/MyphpZ4SCn5jVyCfC6d/ax0SjYqoUj6vFSCtbrVhgAXRUEvW9OSJ4ErgRFhA6bAle qzaVCSc2vyGwQfrJgNlehWuLfrriox7AFWmIIJ2zg7RGPWZw1AV6xc5I0XD8R8mFXL/21xm1qM= X-Received: by 2002:a17:907:e1c5:10b0:c1f:1520:4de5 with SMTP id a640c23a62f3a-c1fe7fc5018mr28691966b.1.1785520377880; Fri, 31 Jul 2026 10:52:57 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/3] bhyve: support setting serial number for SATA disks Date: Fri, 31 Jul 2026 19:52:03 +0200 Message-ID: <20260731175205.14822-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260731175205.14822-1-bogorodskiy@gmail.com> References: <20260731175205.14822-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 7KO4ZJWRSZ7ITLUX5V7HJTTRW6XWHHXT X-Message-ID-Hash: 7KO4ZJWRSZ7ITLUX5V7HJTTRW6XWHHXT X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1785520518756158501 Content-Type: text/plain; charset="utf-8" bhyve supports passing disk serial number using the "ser=3D" option, so update bhyveBuildAHCIControllerArgStr() to set it from the "serial" element. Closes: https://gitlab.com/libvirt/libvirt/-/work_items/901 Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 3 +++ .../x86_64/bhyvexml2argv-sata-rotation-rate.args | 2 +- .../x86_64/bhyvexml2argv-sata-rotation-rate.xml | 3 +++ 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index a4f9c8823b..f0c3cf03c5 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -333,6 +333,9 @@ bhyveBuildAHCIControllerArgStr(const virDomainDef *def, if (disk->rotation_rate) virBufferAsprintf(&device, ",nmrr=3D%u", disk->rotation_rate); =20 + if (disk->serial) + virBufferAsprintf(&device, ",ser=3D%s", disk->serial); + virBufferAddBuffer(&buf, &device); } =20 diff --git a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rat= e.args b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rate.ar= gs index 2cf40953e8..3ae510e2ed 100644 --- a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rate.args +++ b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rate.args @@ -5,6 +5,6 @@ bhyve \ -H \ -P \ -s 0:0,hostbridge \ --s 2:0,ahci,hd:/tmp/freebsd1.img,nmrr=3D7200,hd:/tmp/freebsd2.img,nmrr=3D5= 400,hd:/tmp/freebsd3.img,nmrr=3D1 \ +-s 2:0,ahci,hd:/tmp/freebsd1.img,nmrr=3D7200,ser=3DBHYVE-SER01-0001,hd:/tm= p/freebsd2.img,nmrr=3D5400,ser=3DBHYVE-SER02-0004,hd:/tmp/freebsd3.img,nmrr= =3D1,ser=3DBHYVE-SER03-1234 \ -s 3:0,virtio-net,faketapdev,mac=3D52:54:00:b9:94:02 \ bhyve diff --git a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rat= e.xml b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rate.xml index a0d80cb908..ed6da8e317 100644 --- a/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rate.xml +++ b/tests/bhyvexml2argvdata/x86_64/bhyvexml2argv-sata-rotation-rate.xml @@ -8,16 +8,19 @@ + BHYVE-SER01-0001 + BHYVE-SER02-0004 + BHYVE-SER03-1234 --=20 2.52.0