From nobody Tue Aug 4 22:21:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1785513348; cv=none; d=zohomail.com; s=zohoarc; b=KJO9Y5x6rNn8FCoJXh2jJWSB90oNV9O2DHmRXAvPCdTcGfaa4rrvvos7XnKB/zzUWr5M1Z3ns5KV3T6TNjgf+4vt+S/Yt8VeUfkbiRrT6wlZLqXqTxqLi95//Rjp7MxArSeM64W3j948gj74GV3ZRFyFxvE7/gBxa7krzS15YU0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1785513348; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=6XBhC0l9jvdzEeEiQ2U1VbVZRb9WDivWk4aDH6jUMsw=; b=deMgE35epq6WJgVnk3w3kzD2HC+cfnbUNgsSDj8hxXUHkQCUkJIxyCy9KZ3JcoL0/sLDwKcA3RrzOspZcZbuc3WgA9sU8scoumprb7eU/FxYxh3gm9zDJyZw+B9W2YhBgVu+j3wV17V4ajSNGd8LUXVwsoBFMyBucBsW7X9U1lE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1785513348287137.53818991529647; Fri, 31 Jul 2026 08:55:48 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0B14D3FD29; Fri, 31 Jul 2026 11:55:46 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 4A5953FAD0; Fri, 31 Jul 2026 11:55:01 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1DAEA3F9AC; Fri, 31 Jul 2026 11:54:53 -0400 (EDT) Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 6B4913F2FB for ; Fri, 31 Jul 2026 11:54:52 -0400 (EDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-69c108fee7fso1829924a12.3 for ; Fri, 31 Jul 2026 08:54:52 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a09c657601sm2696224a12.24.2026.07.31.08.54.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 08:54:50 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785513291; x=1786118091; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=6XBhC0l9jvdzEeEiQ2U1VbVZRb9WDivWk4aDH6jUMsw=; b=Vl9iqj7hOvJPEd6gc86t7sp3qI6Rd9r7hlLUicaQYoM4Yt3lzQN07AWlfttMKiAyOR IMAVqX29dzC5XpqZKff+Z1JO5hDsgMFObVy+IiX65zTqzgK+Kw6H4w3dd+twm1gPtY88 2IgGpwKpSC1oUxg5OPUt4Fz95rr3OduPDL9JYHWvOmB8v7nHSPG5jVAzl9UMO76A7Wc+ pYmia311P5UxKlrnTo2ornPQYgiW4X3j3TqBdsHU88bM94QmTfxm562QGPaV1WFpeUxP KR94m0o2Q6nPtAaP3T0t/xRftHU9lztmOsJveGPLmDu1+q3qhg/TNwsxWE2M3TEZfP2v wEKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785513291; x=1786118091; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=6XBhC0l9jvdzEeEiQ2U1VbVZRb9WDivWk4aDH6jUMsw=; b=ReL6jf8fiO8jV/A8+7GaoSoSgFyn9BRG6gdplOK2uTxYSoPLgu5l2LhyYBbcEl8LNO nZQVKjNxPKbLzKxpCIMniY5CG0SlVoP/5zBfcKhNF4oO1iIUNH2o6carMdOwNyyY70mo +9uHZ73Yo5ebC5wi+fmxEearMEbZBHKSyclnPF9IOK3iqokx4evuHuZrX0OQHnumYatk TPaAXm+b35Q0c47oIQeDuznwq0ZVSh9mEZt7+LOJYo5yTd6gd6lWpRkQxHQqrWM75nNk gypgfgqQrEkT/qtDQWePb8TeWVVjlBPoo5ycrsxUBUjHhuJIGIypYLd1pxdp45ECrB92 52Bw== X-Gm-Message-State: AOJu0YxBHxsC1hppSQLk64mRzpGn1GUpTN6m+6STi8SvQcM2FFoIUSkp wXqz41nfpIXkrDTsQyLLDNMFzen2H9dgKIiO79sqaM0KPrViVMwPKZrwmOVjirxk X-Gm-Gg: AR+sD12kqGrdbPAv2t24k4VMol7SjRFgLb2OrwEB00Wn23Kv/QZTXXHvEuslIJEBNcs lUwvFL/Xvb5f9PsfKk99K1nWV8y1EutH8VcQ6WqrlX/9bXy0DU3zaSivPAPQrSn66HGNoYEgLzD WSNtYraEHq2RTex6tvPPZ1w6n8VEZJ4OsD8hBCAbpaBWjFI+ybCqXBBjUWI3WRVRKHYcDHeNa/6 iIE46/an9z5edlAOCTP9b3w08/A/qACHDw9PXoz/eTXDDM0m9JcrI0l7+faI+qj2sVQYV97m3Me M42r+c5zgb5ybip4N3T5O7MXT8W3y5bjoa+hu2Bj9olIBiKkW1FN28kerMGAdc4QAezYv0Xb5hL D6kONicn42vGpHR5bhhxpKsZk4tU20eTl+VFF2kPlpxNABVMx2x8FapcRV2mey/RoX2C6nST5D2 ckDHMdLAblZRdw6EBjBKro4CnaD2w4NFIJDcL0vpkBz9ouGOEg6O6uvEa2vPieOEEoYpKkgcjU/ d038Kg2E6IVhduw/9QYJQXeYVu7AAkBCxYqk4HOQbZU9cxLWl1vVhWpe8VGLai7wiGo4xnrWzk= X-Received: by 2002:a05:6402:a0c5:b0:69c:4051:69e5 with SMTP id 4fb4d7f45d1cf-6a0a7cf4215mr92615a12.28.1785513290558; Fri, 31 Jul 2026 08:54:50 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH] bhyve: capabilities: use full path for emulator Date: Fri, 31 Jul 2026 17:53:56 +0200 Message-ID: <20260731155356.58841-1-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TGHBUISS7XEU4T544CTLCWJJL7LDET7R X-Message-ID-Hash: TGHBUISS7XEU4T544CTLCWJJL7LDET7R X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1785513349569158500 Content-Type: text/plain; charset="utf-8" Currently, when the bhyve driver builds capabilities, it uses just "bhyve" as emulator path. That leads to issues, e.g. virt-manager uses this value to fill domain's emulator field, which has to be an absolute path. So that results in a domain XML that fails validation. Fix by trying to find "bhyve" in PATH and falling back to "/usr/sbin/bhyve". Closes: https://gitlab.com/libvirt/libvirt/-/work_items/899 Signed-off-by: Roman Bogorodskiy Reviewed-by: Daniel P. Berrang=C3=A9 --- src/bhyve/bhyve_capabilities.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_capabilities.c b/src/bhyve/bhyve_capabilities.c index 1fe0a3ad77..85988a2ce8 100644 --- a/src/bhyve/bhyve_capabilities.c +++ b/src/bhyve/bhyve_capabilities.c @@ -48,13 +48,14 @@ virBhyveCapsBuild(void) virCaps *caps; virCapsGuest *guest; virArch hostarch =3D virArchFromHost(); + g_autofree char *binary =3D virFindFileInPath("bhyve"); =20 if ((caps =3D virCapabilitiesNew(hostarch, false, false)) =3D=3D NULL) return NULL; =20 guest =3D virCapabilitiesAddGuest(caps, VIR_DOMAIN_OSTYPE_HVM, - hostarch, "bhyve", + hostarch, binary ? binary : "/usr/sbin= /bhyve", NULL, 0, NULL); =20 virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_BHYVE, --=20 2.52.0