From nobody Tue Aug 4 22:21:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1784969669; cv=none; d=zohomail.com; s=zohoarc; b=Wv0dHci0xthzG6cY9Zw7v8s9ao1Iy3+a27dJk6pTQTDSHvCnNJPbgwKO+OGnewD2KAoMq8uKusZTNpUN1AaPwXBO+hcIKaPpHH2h7DtaHwk3bDzZZPeE60kwow/zeyjQ4jqKHCya0i/BCJ3H/2TV8zbkSeUU1TsHceFC4GQ7/lg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784969669; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=LKv18gVpBt79i/CfM+4u3gXxjKDrxaH9kBFvuPVcl+Q=; b=NABIs3IORpmvyen25dSPdclYMnbGNekY4QOntRWJquv2DZFU/ZVG4Yg3WANHeUD3tgweCj10vwl6O/MWjSstudwShUo/BKwGxWetSKp4cwhf8lgTGmiDC0//Y3fhQ0K8w+GmY4/1HNW1+r/rXSBhfwj94KEgQ1HJzuQTFOE+I9c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784969669116889.9109296851996; Sat, 25 Jul 2026 01:54:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BDF204187F; Sat, 25 Jul 2026 04:54:27 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 1FE3B41D72; Sat, 25 Jul 2026 04:53:43 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 00AA53F9A4; Sat, 25 Jul 2026 04:53:35 -0400 (EDT) Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2885D4187A for ; Sat, 25 Jul 2026 04:53:35 -0400 (EDT) Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-69fab5a852cso1658613a12.0 for ; Sat, 25 Jul 2026 01:53:35 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32ebc828sm448921966b.43.2026.07.25.01.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 01:53:32 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784969613; x=1785574413; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=LKv18gVpBt79i/CfM+4u3gXxjKDrxaH9kBFvuPVcl+Q=; b=BA0S1SKIOOqvTHwBhL65j+ioyysUMHkgGoohKjhqAXrF/zmZMDgXwmv5jK0GKplErV ke8bDV43Cxknj/U/2qfqUdb0vhN+SYGjGxYt7gJIb4eXsZ4FsGLvV7XpDQvBaxP+kukz H9qvJFOIdd/HSQ62mWpdorNLBKgDxLQGzq4gqUf4/io1uZKTxQI3tsdjgatMBu6Y4oBf WEPYe+3wq799+lARK725UItyVun0WUewALxgctXjCDg1z2TtvmgRhycg+mgFJ/A9+1Se Uti89rMjs1gT14N0+pn4p0SaCZ1J7ZPV4O6wlE8wnDB/ElizDyTpHXWRUog4/EGSnEHw IJsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784969613; x=1785574413; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LKv18gVpBt79i/CfM+4u3gXxjKDrxaH9kBFvuPVcl+Q=; b=k7B3SMm7HCfGuSpBoqp9RrvBkP5CkoavczuJc1JPVf1fOoPhsFmqbMrwMbs1wF7ci3 ZG3eM4qX2M6FeRNtTiIl6Wuy08tW4lvTo4WJn2U4bbXVQkuM/oh+LZ8FYGrwF4JYnIzZ 3CJcKh56WisRrBL3QHVbmHV2rDUygYWVOAn5j/egfjRkPB98v8dxXVdaoK9gsj73skKu 9iNwPKkp44gpeEwXIA930sDws5TVFAL5g9UmA/ggR60ZLfTxrkvS1An04VebVxj666Q9 wnD79bDXauLGyvlwMc0XKEFiwVUhpPiDt3xEOK5KZKfJubwxioPmZLsdIppuOMnZNchx 0HVQ== X-Gm-Message-State: AOJu0Ywmwir9NRMLbnOhKPRi1FUkNBO6u/929UWF4X3ZYDVN3UFLGO8M mCZRYag0Wo1xAQJ0qP64cSAwwqPRY9pgqcWnxc0sJIvZgh4weu2VDrvNWDAle2LA X-Gm-Gg: AR+sD12JPMKsYt1Cm6piQubVCBotFdYxWPVrfQz5gy3CNUF4CZcvyxSfK4FbHcRYcv0 pghxTx5grNLiwuEunOMbWRV3AXdIy0cw/53SZKmj2ggwdI7MJEdgtunzR1F3CNgyrMs38sCF2mY 9+fRmKEkVQy6kjoO5Rq6LVAfiqzPvkf/HamMCt7yngkJKSbizTvlxmhaX6VyuGTvhP0jIRoz5ia 2RYP+oxMPp6EzMdqCsOSjLHSBCGOPkZMW7kFUM7wEDtDCD43QJZgZKeGa2A+51iJDrB7ayWD+Cu MpTEKe8pqRAJ2zIUeoYjDdnK7dVEJwuRjUcvEtY/ByK0lElNq0OgYt+WyTLpBJb5iW2n1/8B4++ WPzwX3s2ZU0kMF9jSGcqysNpu1apwlpnJOBBjJiW59lq/SsEhVcCABSWcNFmcD45kUkkJiTyvOC wtRBLEcs74ZIByehsesKOOFcJpFoyGwXZG4fHhHZ4YcBMnzR+IODd8ygk1zxbCXG3gn+Vh3TaQe q4z750FJhr/HnCfZkOjde7+VNs= X-Received: by 2002:a17:906:6a2a:b0:c16:886e:f0f with SMTP id a640c23a62f3a-c1f1f06b1c3mr56317966b.48.1784969613248; Sat, 25 Jul 2026 01:53:33 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH] bhyve: clean up event thread Date: Sat, 25 Jul 2026 10:52:51 +0200 Message-ID: <20260725085251.59201-1-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HPQCWA6S7AMUPQUAFXU7KT3USPIZEOWW X-Message-ID-Hash: HPQCWA6S7AMUPQUAFXU7KT3USPIZEOWW X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1784969670427154100 Content-Type: text/plain; charset="utf-8" Currently, eventThread cleanup is missing. Fix that by calling virBhyveDomainObjStopWorker() in virBhyveProcessStop() and un-referring the eventThread in bhyveDomainObjPrivateFree(). Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- I think it would be nice to get this in before 12.6.0. src/bhyve/bhyve_domain.c | 5 +++++ src/bhyve/bhyve_process.c | 2 ++ 2 files changed, 7 insertions(+) diff --git a/src/bhyve/bhyve_domain.c b/src/bhyve/bhyve_domain.c index d5bb22501c..b6344185b7 100644 --- a/src/bhyve/bhyve_domain.c +++ b/src/bhyve/bhyve_domain.c @@ -54,6 +54,11 @@ bhyveDomainObjPrivateFree(void *data) =20 virDomainPCIAddressSetFree(priv->pciaddrs); =20 + if (priv->eventThread) { + VIR_ERROR(_("Unexpected event thread still active during domain de= letion")); + g_object_unref(priv->eventThread); + } + g_free(priv); } =20 diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 636d74afcc..81f00954c2 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -675,6 +675,8 @@ virBhyveProcessStop(struct _bhyveConn *driver, if ((priv !=3D NULL) && (priv->mon !=3D NULL)) g_clear_pointer(&priv->mon, bhyveMonitorClose); =20 + virBhyveDomainObjStopWorker(vm); + cmd =3D virBhyveProcessBuildDestroyCmd(driver, vm->def); if (virCommandRun(cmd, NULL) < 0) { /* Only failure of the actual destroy command warrants unsuccessfu= l return code, --=20 2.52.0