From nobody Mon Sep 21 03:45:33 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1784916802; cv=none; d=zohomail.com; s=zohoarc; b=nSblKwc9sy5+hxcVqJfQ/WgM/VaV3YJuJyffKwnrHV2fOva9inigpzQVp4PZpWDRkb+Iy2sf2nnFsNCxVUuHIJKAwgke8Rk9HPethUHBd5HU8G2mHuJPsH/ZmNBOMUnfEieRbocK5mQq+gWaj4S5dyPL79BxAlJEc/cw0oXDo6g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784916802; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=4wyqu6rHoOphGkLJ/7WeY7j8MkHMeTeqx4KCdrqNGII=; b=T2g3VN2jQY5UMgPNbUtAlHxNFmXHoavaYBmKovbUvK2F3EQFvn6/bDADiy9pceI8ZqjYk/2i80DPDBXgl0lRM6C9k+0rrJ3P5bhQodj7grf8VnnP+YGw4hwNfnhCeviuagMQYGkJwG/fca32PF2aw6x6WIem1uIb5WMvYnf8y2k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784916802381263.09023754958184; Fri, 24 Jul 2026 11:13:22 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 55A384197C; Fri, 24 Jul 2026 14:13:21 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id CCBB841E98; Fri, 24 Jul 2026 14:09:55 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 18E303F956; Fri, 24 Jul 2026 14:09:29 -0400 (EDT) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5ECB541831 for ; Fri, 24 Jul 2026 14:09:27 -0400 (EDT) Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-698ae09e356so867017a12.2 for ; Fri, 24 Jul 2026 11:09:27 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69fb5746da2sm202974a12.21.2026.07.24.11.09.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 11:09:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784916566; x=1785521366; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=4wyqu6rHoOphGkLJ/7WeY7j8MkHMeTeqx4KCdrqNGII=; b=EkcL+PQdEcNfxyw53tm3/VBtf7wupgSRZcTXlukCSJSKSimxavgBhB07RBpYTz5cnA i6rFXcXkwCgTqD/QgR5aV1550zy74ygw+RwuL83tEAlIdbPyjghvi4TYy+laJzMP02ZL 6BoGp652JD8nKhceEwF9QTu7XH/DQSE46JVJvaD/HtD+D1cszgz2f88fZ6khL5qZCA3K P8CLJUrT/mDQ+JEhiJlSywTHc4drElfNXJgsyrRf5CWDKZehtmt+JXKqnZPoAZwpoKig bmBfT6iYLc1CVJsgHRw/5ehW3mCSg8R1v516UQ58zKs/ZzhObjWWxUdQ3JzpCe/e9Ai1 eLYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784916566; x=1785521366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=4wyqu6rHoOphGkLJ/7WeY7j8MkHMeTeqx4KCdrqNGII=; b=lBlCZT6a7xxesGAgcvin2t27erBPWB9LogRHACo1DwXYeVhOyNbWuYYXJwD9d8krT3 f1BpFsSfdlLs8cBlvRjPaH0wniIU/8xlEXJASKp3xYLtw5UA4vdajWiFCvFRpEz8PY4y fTDuIWiOh0ZnqrlIUNRmEvLe9Bv/AQfn0lhFlacGaz7l+wh6eX2dC2WZpGnn0AnDsfAW OtW/5NnExN30StHflzq30hbv5NbX7H4z3wZ1Qf1tazB8aBYhz488j9jeBaycJmLsyXdV HFR36XfFxTeW/UrC4PQ/EdOSO39ayO5Hz9b8O38Pq0GCkS6ZCDFjzYNbpFpGb0p9S8O9 Omnw== X-Gm-Message-State: AOJu0YwIZzootH3Fsh69TApk20/H+X/lVGWhHJyXGh60vO6IlHMmAyV9 aaUikBvTb2nVuLwrU1PkU4hPJV4k0C5vVxKf+x9zu4xEYFQqHihX7MwioarJiexF X-Gm-Gg: AR+sD136IFFXwBhZCeGB72E1awnjkzIzgNNR53e/OldtyNTVIeXvNMKvkBr5CQzcPIi FvuU56PBYCE30XlURX8X5p+c9h8FxyKtKN36PndvsBkZ+SZHD6UaKly2HIYlBNSTFMa/MCGcTia MLPxb9lC1kMZO3UGD/WXF0OMOsA2CNJil9EYDG4onYt6VTNraonmOyNGOO+y5BI5Ys4ZL7LRMC8 MKCcEcGspD8I4pi0n0DqGPKBPCkrGRbbvnZeXVDzLlkFEduy307qFfJwQgr4RGFIox6rljafPGf ddf/GmTREotQQR4sjrW5r26Oh3kV4KYxtiGE2fPx1KHEnG/IKifu7mx37JjS/zBeObHIjCdfw/u o6dHaEbmcnurGqINxpyDj5KzhCo7mev81G83vHzPq9e2YfmgIPWvJAyblJaZWzb+5MaupJdOpys kmDKTKhVGdIjv0weG5CBO96JTpbuIk7M65grOO0rJT/vrY4tDHYzBneMgrmb4IFax7THeF08oLS OwHnG1/vmqk8Vo9Xt4XDYIOK6k= X-Received: by 2002:a05:6402:24c1:b0:698:778e:736a with SMTP id 4fb4d7f45d1cf-69f6a2394aamr2848582a12.18.1784916565824; Fri, 24 Jul 2026 11:09:25 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 2/3] network: pf: fix memory leaks Date: Fri, 24 Jul 2026 20:08:45 +0200 Message-ID: <20260724180846.54713-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260724180846.54713-1-bogorodskiy@gmail.com> References: <20260724180846.54713-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2MNF7USYFJDKO7SU65OAN7PRXE2SWVF3 X-Message-ID-Hash: 2MNF7USYFJDKO7SU65OAN7PRXE2SWVF3 X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1784916804132158500 Content-Type: text/plain; charset="utf-8" Properly free result of virSocketAddrFormat() and virBufferContentAndReset(). Signed-off-by: Roman Bogorodskiy --- src/network/network_pf.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/network/network_pf.c b/src/network/network_pf.c index 724b82c054..95f63ac37f 100644 --- a/src/network/network_pf.c +++ b/src/network/network_pf.c @@ -171,6 +171,8 @@ pfAddNatFirewallRules(virNetworkDef *def, g_autoptr(virCommand) flush_cmd =3D virCommandNew(PFCTL); virPortRange *portRange =3D &def->forward.port; g_autofree char *portRangeStr =3D NULL; + g_autofree char *addr =3D NULL; + g_autofree char *pf_rules =3D NULL; =20 if (prefix < 0) { virReportError(VIR_ERR_INTERNAL_ERROR, @@ -205,36 +207,39 @@ pfAddNatFirewallRules(virNetworkDef *def, } } =20 + if (!(addr =3D virSocketAddrFormat(&ipdef->address))) + return -1; + virBufferAsprintf(&pf_rules_buf, "table persist { 0.0.0.0/0, ! %s/%d, ! %s, = ! %s }\n", - virSocketAddrFormat(&ipdef->address), + addr, prefix, networkLocalMulticastIPv4, networkLocalBroadcast); virBufferAsprintf(&pf_rules_buf, "nat pass on %s from %s/%d to -> (%s) port = %s\n", forwardIf, - virSocketAddrFormat(&ipdef->address), + addr, prefix, forwardIf, portRangeStr); virBufferAsprintf(&pf_rules_buf, "pass quick on %s from %s/%d to %s/%d\n", def->bridge, - virSocketAddrFormat(&ipdef->address), + addr, prefix, - virSocketAddrFormat(&ipdef->address), + addr, prefix); virBufferAsprintf(&pf_rules_buf, "pass quick on %s from %s/%d to %s\n", def->bridge, - virSocketAddrFormat(&ipdef->address), + addr, prefix, networkLocalMulticastIPv4); virBufferAsprintf(&pf_rules_buf, "pass quick on %s from %s/%d to %s\n", def->bridge, - virSocketAddrFormat(&ipdef->address), + addr, prefix, networkLocalBroadcast); virBufferAsprintf(&pf_rules_buf, @@ -246,7 +251,8 @@ pfAddNatFirewallRules(virNetworkDef *def, virCommandAddArgFormat(cmd, "libvirt/%s", def->name); virCommandAddArgList(cmd, "-f", "-", NULL); =20 - virCommandSetInputBuffer(cmd, virBufferContentAndReset(&pf_rules_buf)); + pf_rules =3D virBufferContentAndReset(&pf_rules_buf); + virCommandSetInputBuffer(cmd, pf_rules); =20 /* pfctl -a libvirt/default -F all */ /* Flush rules as a separate command, so when it fails, e.g. because t= he --=20 2.52.0