From nobody Mon Sep 21 02:42:26 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1784916701; cv=none; d=zohomail.com; s=zohoarc; b=cRjofbEpTGS3YB6jkweuMRS5IV+bz4JS5/aoEtfvdkiuUbLItHAhVQiE6mpawBDrBvBMWlmVPatH44jG5i0Y4pPU2CyelZx5Q78frYZ5GdQQwq/8wi5zG2JeIjs7/0g7ARMAZePfLjYfnowKBThnkAJjEs61wzTj17WahDQ1DmA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1784916701; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=xnOZvRWszCrYVaJy3ZRwWY25aMHcOKDHEJ5pq+2+nD4=; b=Bcd/X5gKc/ydbjsFLIzUkF8oVJwBOspmoXEO92BElFjxe7nbZ+T3si4VoS7KdOjycm60216MWcZhDEMW/vIbgbm70bHbE7qAmMUFufJDUc+lhTgWLmrU0pisxtYrjnKo5HzsaZEGMQX9fOMJV29840lwqsaaBZS0C9tcDmrUopU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1784916701957445.6005525039286; Fri, 24 Jul 2026 11:11:41 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id A94E841AFC; Fri, 24 Jul 2026 14:11:40 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id F083341DE8; Fri, 24 Jul 2026 14:09:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4204B417D7; Fri, 24 Jul 2026 14:09:28 -0400 (EDT) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C9536417E6 for ; Fri, 24 Jul 2026 14:09:26 -0400 (EDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-69e5f8a193bso823287a12.2 for ; Fri, 24 Jul 2026 11:09:26 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69fb5746da2sm202974a12.21.2026.07.24.11.09.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 11:09:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784916565; x=1785521365; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xnOZvRWszCrYVaJy3ZRwWY25aMHcOKDHEJ5pq+2+nD4=; b=kOiw8JYplaCr9uuwo/lZ0krOBvcNJhakcx8IDT/mYtwH7r8u9yVwhaoxtCew4UPfo/ FDgYLS0FxdoM48VwYoSQkXIRpEyPpM3t8nEelQDqBlZu7SAZAb0I6iErxb3b4O43JBkU mhnCm0+6qOmWoWCgjqX7W6XT7a3nJTLqMFDpmHM2VFEU3jTw5b+cTzH74tTKHp+zmQU3 B3vTHPnf+MxKS8JtDkJ4rETk4MZbbHC3RGLgSxJ49lZaFOQi8BsZ+TVA3Cw5AEBv1jbF dCs4nap/owtxDIYhzEsRWTUELHTNvtPLsJ9ovkM0qMsFzUzolXDZENq8RcTzIcf/UAj8 o5tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784916565; x=1785521365; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xnOZvRWszCrYVaJy3ZRwWY25aMHcOKDHEJ5pq+2+nD4=; b=CgWINziMUgaO4wXA44Mhh4KmojXzDqqwQ1lRbVZJyHceLiZ5bD2hVcc4dX8ALcLNjP sWOlkNmhEv7ZlYAozgc3wwfDv2/ECFrTUoRgVj2gEef1KxSl977UfzDGh5SIad2PmwNc FE6MEgdaiidepAizlNCoIwN0Iz1mIeYSJBr2X4hMtqujn2BjlCz8HrHQzSrTLWhxXXpo HyJZ16U/wyZM/5N8h1IqbrIs7Ea24SmejcB6OVjibh6+UyCaPDTia/gro2t92eOfkg8S pEr81IJ/MqF2FHR1RGUonwtEnpD9w2yjGOqEorOi26M837olH0tyyQEjbKHaYVS+BcqN lEbw== X-Gm-Message-State: AOJu0Yz2/ET/XbCwvLFnZFU5k/riVqJdL7s+4dCsa81MteUy0Axn+4Ce ovB6Bbxec8bRzm0s3nAUPHuZJ/+MlZDqABC81k1TIBVUv6ym2uZOV0AGyFiMNXqv X-Gm-Gg: AR+sD130ebrCGNUwrZ0m+WUUQ/spw2lTygMFhjtGp5bJPlCfOXZ/2mg4dWSGXYmo92o /kMlMWhFu9OWet7cWnzLmTgwJy2XL1iG/HgFBFRlcll58OE0u5oegPg03jip/9T8jFF47dujbQW zmrMB2QlRiHT7qef1G6i4e2by02J2h38A1Wn5qGNCZA/SbZCMRIh82PwUygtnZH90T90OZhfoE8 zTCwWRv5QDPvdV82lpxbhDmoL3sbRY6f4HRykfXOnqpCHA31hpppGC+o+J4bmPvt+oLHHh2Z++X sUejqKVaH6Pjc3PPOfvRxRJ11rHXRrsWl8aMbRpJmQfeRfyhu0nFhplPtmrD3A97vDK1VhMQu2N hvPSOqUW/pqQ9lh/NvAJO+4R4L2MC+ibGg9PG1M3gJhK0v6Mw6+R1JxOUiSf39cpr3VbKmyEQFM 2uufo38Yb8MkjCH49uIShvaXHl/jwQuiB8IEJDilBSAtrF7eYakbNUpIrkcrQ4Sgl7ltDU0RTL7 64j7/Xqfjep6vZN X-Received: by 2002:a17:906:f5a2:b0:c05:8586:da12 with SMTP id a640c23a62f3a-c1c50d8485emr397083866b.50.1784916565316; Fri, 24 Jul 2026 11:09:25 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/3] bhyve: fix memory leak in bhyveBuildVirtioSerialControllerArgStr() Date: Fri, 24 Jul 2026 20:08:44 +0200 Message-ID: <20260724180846.54713-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260724180846.54713-1-bogorodskiy@gmail.com> References: <20260724180846.54713-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 5NYX4YCYAUZO5SDWYFKFTP5SEXXVU6ZT X-Message-ID-Hash: 5NYX4YCYAUZO5SDWYFKFTP5SEXXVU6ZT X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1784916703712158500 Content-Type: text/plain; charset="utf-8" We cannot use virBufferContentAndReset() right in virCommandAddArgFormat() as we need to free the result. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_command.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index 941b48eb66..a4f9c8823b 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -518,10 +518,12 @@ bhyveBuildVirtioSerialControllerArgStr(const virDomai= nDef *def, } =20 if (virBufferUse(&opt) > 0) { + g_autofree char *console_opt =3D virBufferContentAndReset(&opt); + virCommandAddArg(cmd, "-s"); virCommandAddArgFormat(cmd, "%d:0,virtio-console%s", controller->info.addr.pci.slot, - virBufferContentAndReset(&opt)); + console_opt); } =20 return 0; --=20 2.52.0