[PATCH 2/6] qemu: capabilities: add capability for iothread poll-weight

Jaehoon Kim posted 6 patches 1 month, 3 weeks ago
There is a newer version of this series
[PATCH 2/6] qemu: capabilities: add capability for iothread poll-weight
Posted by Jaehoon Kim 1 month, 3 weeks ago
Add a capability flag for the iothread poll-weight property.

Detect support for the property from the QMP schema so that libvirt
can conditionally expose and use poll-weight only with QEMU binaries
that support it.

Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>
---
 src/qemu/qemu_capabilities.c                       | 2 ++
 src/qemu/qemu_capabilities.h                       | 1 +
 tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml | 1 +
 tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml  | 1 +
 4 files changed, 5 insertions(+)

diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
index ebea050453..971663badc 100644
--- a/src/qemu/qemu_capabilities.c
+++ b/src/qemu/qemu_capabilities.c
@@ -768,6 +768,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
               /* 495 */
               "blockdev-mirror.target-is-zero", /* QEMU_CAPS_BLOCKDEV_MIRROR_TARGET_IS_ZERO */
               "object-monitor-qmp", /* QEMU_CAPS_OBJECT_MONITOR_QMP */
+              "iothread.poll-weight", /* QEMU_CAPS_IOTHREAD_POLL_WEIGHT */
     );
 
 
@@ -1671,6 +1672,7 @@ static struct virQEMUCapsStringFlags virQEMUCapsQMPSchemaQueries[] = {
     { "netdev_add/arg-type/+stream/reconnect-ms", QEMU_CAPS_NETDEV_STREAM_RECONNECT_MILISECONDS },
     { "object-add/arg-type/+sev-guest/kernel-hashes", QEMU_CAPS_SEV_GUEST_KERNEL_HASHES },
     { "object-add/arg-type/+iothread/thread-pool-max", QEMU_CAPS_IOTHREAD_THREAD_POOL_MAX },
+    { "object-add/arg-type/+iothread/poll-weight", QEMU_CAPS_IOTHREAD_POLL_WEIGHT },
     { "query-block/arg-type/flat", QEMU_CAPS_QUERY_BLOCK_FLAT },
     { "query-display-options/ret-type/+egl-headless/rendernode", QEMU_CAPS_EGL_HEADLESS_RENDERNODE },
     { "query-display-options/ret-type/+sdl", QEMU_CAPS_SDL },
diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h
index daec874a59..8f83eb8acd 100644
--- a/src/qemu/qemu_capabilities.h
+++ b/src/qemu/qemu_capabilities.h
@@ -742,6 +742,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for syntax-check */
     /* 495 */
     QEMU_CAPS_BLOCKDEV_MIRROR_TARGET_IS_ZERO, /* 'blockdev-mirror' supports 'target-is-zero' */
     QEMU_CAPS_OBJECT_MONITOR_QMP, /* 'monitor-qmp' -object */
+    QEMU_CAPS_IOTHREAD_POLL_WEIGHT, /* -object iothread.poll-weight */
 
     QEMU_CAPS_LAST /* this must always be the last item */
 } virQEMUCapsFlags;
diff --git a/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml b/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml
index b45dd83889..6c5c1770ad 100644
--- a/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml
+++ b/tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml
@@ -189,6 +189,7 @@
   <flag name='query-block-flat'/>
   <flag name='blockdev-mirror.target-is-zero'/>
   <flag name='object-monitor-qmp'/>
+  <flag name='iothread.poll-weight'/>
   <version>11000090</version>
   <microcodeVersion>61700287</microcodeVersion>
   <package>v11.1.0-rc0</package>
diff --git a/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml b/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml
index 7a4396c82b..98a6a7e083 100644
--- a/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml
+++ b/tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml
@@ -223,6 +223,7 @@
   <flag name='amd-iommu.xtsup'/>
   <flag name='blockdev-mirror.target-is-zero'/>
   <flag name='object-monitor-qmp'/>
+  <flag name='iothread.poll-weight'/>
   <version>11000090</version>
   <microcodeVersion>43100287</microcodeVersion>
   <package>v11.1.0-rc0</package>
-- 
2.54.0
Re: [PATCH 2/6] qemu: capabilities: add capability for iothread poll-weight
Posted by Peter Krempa via Devel 1 month, 2 weeks ago
On Wed, Jul 22, 2026 at 13:52:11 -0500, Jaehoon Kim wrote:
> Add a capability flag for the iothread poll-weight property.
> 
> Detect support for the property from the QMP schema so that libvirt
> can conditionally expose and use poll-weight only with QEMU binaries
> that support it.
> 
> Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>
> ---
>  src/qemu/qemu_capabilities.c                       | 2 ++
>  src/qemu/qemu_capabilities.h                       | 1 +
>  tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml | 1 +
>  tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml  | 1 +
>  4 files changed, 5 insertions(+)

Reviewed-by: Peter Krempa <pkrempa@redhat.com>
Re: [PATCH 2/6] qemu: capabilities: add capability for iothread poll-weight
Posted by JAEHOON KIM 1 month, 2 weeks ago
On 7/29/2026 8:53 AM, Peter Krempa wrote:
> On Wed, Jul 22, 2026 at 13:52:11 -0500, Jaehoon Kim wrote:
>> Add a capability flag for the iothread poll-weight property.
>>
>> Detect support for the property from the QMP schema so that libvirt
>> can conditionally expose and use poll-weight only with QEMU binaries
>> that support it.
>>
>> Signed-off-by: Jaehoon Kim <jhkim@linux.ibm.com>
>> ---
>>   src/qemu/qemu_capabilities.c                       | 2 ++
>>   src/qemu/qemu_capabilities.h                       | 1 +
>>   tests/qemucapabilitiesdata/caps_11.1.0_aarch64.xml | 1 +
>>   tests/qemucapabilitiesdata/caps_11.1.0_x86_64.xml  | 1 +
>>   4 files changed, 5 insertions(+)
> Reviewed-by: Peter Krempa <pkrempa@redhat.com>

Thank you for reviewing the patch. I'll add your
Reviewed-by tag in v2.

Thanks,
Jaehoon