From nobody Sun Sep 20 12:48:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1783842080; cv=none; d=zohomail.com; s=zohoarc; b=awfLzv726OpGRtsv7AcjnVP6owtER+BS2TmxRmD6mVlhHeLeDaqzoxjDqNJL7zu2MejdyDnAv1/PsU0M7zfoKRoAXy4ajsCnmcuCJsp0wzMGZ+ClKnqf22gjXpf4U/BXHZ3UhjdUoix/kaeR72+3/22cEP1CLQ/elJHQzzC4+rc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783842080; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=CCIReg53Dgv+5mB1/wAAqvDatxMZWr6mnsORVEMFRaQ=; b=EEUwplW1R88lZuSiiNKwbQs6l+3lfiwtQuKvv7ZTpxKUa3isa6ukTxRqKwlkuLqjMB9Zi+Zgo1ONphIVFN1F1H6cX8uyqGPI8AM1UK/kZKkhzC1rs1zNh3K0j2QVb/Rau5Cses58NEDEqEN1MexwclhED15Ws01muXzhAfiUfuI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 17838420805943.700524100492771; Sun, 12 Jul 2026 00:41:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4079B3F966; Sun, 12 Jul 2026 03:41:19 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id B13C241CC6; Sun, 12 Jul 2026 03:38:33 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 269704184C; Sun, 12 Jul 2026 03:37:59 -0400 (EDT) Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9E4A841D77 for ; Sun, 12 Jul 2026 03:36:29 -0400 (EDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-697bd21fdc2so3666730a12.1 for ; Sun, 12 Jul 2026 00:36:29 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c15cfac0f76sm646490466b.33.2026.07.12.00.36.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 00:36:27 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783841788; x=1784446588; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CCIReg53Dgv+5mB1/wAAqvDatxMZWr6mnsORVEMFRaQ=; b=gyAW4NfJn3ojCiBkfgZ6TxKnSxov35hUGJcIzEpKT5edm3M26bC8vVFqvZ3kJZ9gI+ tbaMh63s16ERnJErJziWsyIocxLt/TVmu2MqqagvwKGWlJ1s92TPVQoIiGkbMIU0Hkrz Dmaet4uefESCo9M9dqKLZDSTq+gdb5IhFRgk8Hfuw0LwWWwqAMXFs94noQpIem4fi3oR RSCBkwa8xvcooOA/2OZbYFOMdKX+EfeHWQA+T0O0uHnWk3o1AR5tVkzOS3X295Zd3tiW S/FapAES0Hbda9wSq0EXEkhdbFxEUVwa5zd8K1L8WYcerQ8OBl7ZL83ElCPLmel+FSbw BtKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783841788; x=1784446588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CCIReg53Dgv+5mB1/wAAqvDatxMZWr6mnsORVEMFRaQ=; b=RN+YKAlqiXVcz5C8wuYIwLNirK311ke23EpA9wBVfL5P46i4LXi4xPA2FfVvtit4Pv QXn0F7Lj7N2SXY6h/FLPnBlmkyrNKWvJDpovGNDSLMcOiKmGwy0Ji6zY0l66n24CTp/V fuP0nB+0Fd1YCzaPxl8bQu7U1O03JRjLv8KWLhrY39K/f7/dsZc6a3hLuvrs1BdA8bPy LCeR4+fS9l7dn5pxIFlyb+pkZJgr8/sMNDxcqG4dLEHwaVh1u80Jl87G9aJWt2B4M1ka qGRdc9DJXtYWNnsJNBIHGV3rMcF/DXs8gyZLQPwzRiAAsLVKb86MjR3DwoimYrzPrjmM v9yQ== X-Gm-Message-State: AOJu0YwTVwx+3HEPk/UYCPDv901580XT4iUbndSPKoIwO/9+4N9voGr+ joYPD0GV4XsYx2pVA7itgxpJpf5UmPaUMIA/o8+gkiZIeNos1rmHCJlC//UBjZCQ X-Gm-Gg: AfdE7cm9NQTpvywLWFbsDSE5nzxNQenjc0u0G2fmw//bYAygia82vIbAy/EMVQw+WE6 D78vkOQVTwQI3/DqsnR64q4hPkJVZIpx5V4fTVQp/V8dpLv4A1eyBUtQzuTv6LefAaVMCl8xDmz Fir3gxWNnK7eYtm81QG6mfqskRmt16ER57Y5IF0699eSbOSniK/gAbUabmBFfTH18YlAogfrl4X Aeu+qq6Or7ypXQ7AL17x9DkMmGhRSqfkjxuFnQiKYbR6EugEdjdoEteWPUjaKRNR/N9Q7T3CPVz dmg+BD8tFTuEUunZHb+7lSsUyu6KGudbbIRWZF4rOxd+5yKaCHnY2d1n557Ysst+soRsVoR84Eq SYKnhLYnKrlO0t/IegCKSJBMcPoRNBpm+asf7O7EfFeiO+Zs+YbQc2IQxPj3Ygv4d2CUyxpXmQ1 v7XwQ/Uf0DG/FF5OEzw8bN4zUy+x5i+qS0a8eNqB1qT7F9Cf5olhDc8wUFMoYP8iATChNcceCVl eN/A6IICqBgUkCXrmhuY8SofYI= X-Received: by 2002:a17:907:1c83:b0:c12:a588:4113 with SMTP id a640c23a62f3a-c161e9db968mr207059666b.29.1783841788226; Sun, 12 Jul 2026 00:36:28 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 3/3] bhyve: implement virDomainSetLifecycleAction() API Date: Sun, 12 Jul 2026 09:36:08 +0200 Message-ID: <20260712073608.6547-4-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260712073608.6547-1-bogorodskiy@gmail.com> References: <20260712073608.6547-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AD3JJB2BDDDQZS57OLU4H6FM3DSJDC5K X-Message-ID-Hash: AD3JJB2BDDDQZS57OLU4H6FM3DSJDC5K X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1783842081351158500 Content-Type: text/plain; charset="utf-8" Implement virDomainSetLifecycleAction() API for the bhyve driver. Support both config and live configuration update. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 110 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 110 insertions(+) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 668e46ad37..feeb140ba4 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -2807,6 +2807,115 @@ bhyveDomainRename(virDomainPtr domain, return ret; } =20 +static int +bhyveDomainSetLifecycleActionValidate(virDomainDef *def, + virDomainLifecycle type, + virDomainLifecycleAction action) +{ + virDomainLifecycleAction onPoweroff =3D def->onPoweroff; + virDomainLifecycleAction onReboot =3D def->onReboot; + virDomainLifecycleAction onCrash =3D def->onCrash; + + switch (type) { + case VIR_DOMAIN_LIFECYCLE_POWEROFF: + onPoweroff =3D action; + break; + case VIR_DOMAIN_LIFECYCLE_REBOOT: + onReboot =3D action; + break; + case VIR_DOMAIN_LIFECYCLE_CRASH: + onCrash =3D action; + break; + case VIR_DOMAIN_LIFECYCLE_LAST: + break; + } + + if (bhyveValidateLifecycleAction(onPoweroff, onReboot, onCrash) < 0) + return -1; + + return 0; +} + +static void +bhyveDomainModifyLifecycleAction(virDomainDef *def, + virDomainLifecycle type, + virDomainLifecycleAction action) +{ + switch (type) { + case VIR_DOMAIN_LIFECYCLE_POWEROFF: + def->onPoweroff =3D action; + break; + case VIR_DOMAIN_LIFECYCLE_REBOOT: + def->onReboot =3D action; + break; + case VIR_DOMAIN_LIFECYCLE_CRASH: + def->onCrash =3D action; + break; + case VIR_DOMAIN_LIFECYCLE_LAST: + break; + } +} + +static int +bhyveDomainSetLifecycleAction(virDomainPtr domain, + unsigned int type, + unsigned int action, + unsigned int flags) +{ + struct _bhyveConn *privconn =3D domain->conn->privateData; + virDomainObj *vm =3D NULL; + virDomainDef *def =3D NULL; + virDomainDef *persistentDef =3D NULL; + int ret =3D -1; + + virCheckFlags(VIR_DOMAIN_AFFECT_LIVE | + VIR_DOMAIN_AFFECT_CONFIG, -1); + + if (!virDomainDefLifecycleActionAllowed(type, action)) + goto cleanup; + + if (!(vm =3D bhyveDomObjFromDomain(domain))) + return -1; + + if (virDomainSetLifecycleActionEnsureACL(domain->conn, vm->def) < 0) + goto cleanup; + + if (virDomainObjBeginJob(vm, VIR_JOB_MODIFY) < 0) + goto cleanup; + + if (virDomainObjGetDefs(vm, flags, &def, &persistentDef) < 0) + goto endjob; + + if ((def && bhyveDomainSetLifecycleActionValidate(def, type, action) <= 0) || + (persistentDef && bhyveDomainSetLifecycleActionValidate(persisten= tDef, type, action) < 0)) + goto endjob; + + if (def) { + bhyveDomainModifyLifecycleAction(def, type, action); + + if (virDomainObjSave(vm, privconn->xmlopt, + BHYVE_STATE_DIR) < 0) + goto endjob; + } + + if (persistentDef) { + bhyveDomainModifyLifecycleAction(persistentDef, type, action); + + if (virDomainDefSave(persistentDef, privconn->xmlopt, + BHYVE_CONFIG_DIR) < 0) + goto endjob; + } + + ret =3D 0; + + endjob: + virDomainObjEndJob(vm); + + cleanup: + virDomainObjEndAPI(&vm); + return ret; +} + static virHypervisorDriver bhyveHypervisorDriver =3D { .name =3D "bhyve", .connectURIProbe =3D bhyveConnectURIProbe, @@ -2885,6 +2994,7 @@ static virHypervisorDriver bhyveHypervisorDriver =3D { .domainAuthorizedSSHKeysGet =3D bhyveDomainAuthorizedSSHKeysGet, /* 12= .6.0 */ .domainAuthorizedSSHKeysSet =3D bhyveDomainAuthorizedSSHKeysSet, /* 12= .6.0 */ .domainRename =3D bhyveDomainRename, /* 12.6.0 */ + .domainSetLifecycleAction =3D bhyveDomainSetLifecycleAction, /* 12.7.0= */ }; =20 =20 --=20 2.52.0