From nobody Tue Sep 22 03:46:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1783841700; cv=none; d=zohomail.com; s=zohoarc; b=H7dYu+NSIbvrcXIY8JjQYK7zFfkoY+plgx0Cyy7pmNxIW0nACDGNLVQUH8Dzv7Wf9IXDeppFlnlrvHgju5azDYCQfmoE1s0nQQZz5/mC4aeXCbt7MoUTtA0g58V6wkStkH2vnO18eYLpUjGBYW3ZYA5ZeiFbVhxAH25U+YqE1oQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783841700; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=+fz3arQHXD4IFqelZJcJ/RaOXULK1lB5t+53Iz+3PpE=; b=MJalkWCCcFpmkqd9tf/x5tIKHISywdT05dLF3Zd9GDsXVip4Rbq4Ycu4+KivYzi+Yf8Ycot4+fUuZsdgA57r2BpzR+WXoa0qipemm2WQZizimBiuKRpFPaIcgFckz4QmsOs0mM8FOpWJ3xtUFyK4TBt8LB4zaobifRxT6xDyhtQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783841700571167.65495552222205; Sun, 12 Jul 2026 00:35:00 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4483A41D94; Sun, 12 Jul 2026 03:34:59 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 95BF141D27; Sun, 12 Jul 2026 03:33:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 7197E3F959; Sun, 12 Jul 2026 03:32:51 -0400 (EDT) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 68CBB3F2F3 for ; Sun, 12 Jul 2026 03:32:45 -0400 (EDT) Received: by mail-ed1-x536.google.com with SMTP id 4fb4d7f45d1cf-69c7697d523so989092a12.2 for ; Sun, 12 Jul 2026 00:32:45 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69a19cd8904sm13245978a12.2.2026.07.12.00.32.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 00:32:43 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783841564; x=1784446364; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=+fz3arQHXD4IFqelZJcJ/RaOXULK1lB5t+53Iz+3PpE=; b=rQKvSgadvx8QZtbTxKwJQqVMIEOFldw1q9d1OQSUrI7uBJ7OwwU650fqL7E9vOOJeg JwmcacVr0klIeuPP6NglC4R2nAQiBeDP24bSK+mkJJuiYeeIsz41busXrD2rz+mgUyBc 7x7afArSvH1fEgOavPJ9REuscFtb2JnXCktNWfnC9iIpP2spUYthaAfyPl0vCcRr++bS cm25b868GMLB9taoq+kMDjCLmuRUI9wM78jU05LBWRX6TKQWAIKay/6wzTcNgckHCaiz 30GQiV6SPIFqVMC1KnDkZBURo+P0K2A8dbEpqC2h9I2m+JTb6+I/dQrHxkhTvLyiQgKT 1Vaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783841564; x=1784446364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=+fz3arQHXD4IFqelZJcJ/RaOXULK1lB5t+53Iz+3PpE=; b=l5tKtK0KrXxleUki+2VKoy0fjJZYfEd/d8J7DYywGM7FZaWf55hqNx6FNfNRosFb+F /9cSrnPzw+2M4BCkMT1pKpxmzQSe/4V/C01bj6F8R0/sMF0ynu+AEy/V/BoGIlm7X/nU 22HwI/21zDXrhzJ+oIMFRgckdd2ORhdtddSxDjwOD8hun2YbgiZVA0Xx9bEdsVjNUR8z 4XTvinRSJ3AcPHIheKn4R+6dqCPpE01oNpmNgsak+nmpa8+DCUmtFy3sj0LzcOuiC3T0 dOx5x4+HFf1a2e4yI3UQYbnySMOdjebRJxlHA/3Glmp1AZTqQxKt/GfpEQ/rXGyxJRZH fXHg== X-Gm-Message-State: AOJu0YxYSf4s1CQzQUBfjbb3mCdXv08+JNmlRszknvtGgqTmD+P9Z/Lh gEMWGFZv0iMe/bouFPhI4kExvSCvAr1Hw79Uy/keW+z4MUb11QYi+WgI2ab+Q4PV X-Gm-Gg: AfdE7cndk+3BYjvmLUzxsIa1HXck9GAymq6BbDP8hqfjEP385046hD70mj9UQ3oAs0h e3pEgZEkc2jfq8z2EQeJZcDtNd5wK8BMUJ4+imh5Xl+ykWdUiojAJCjOxGFcs01KYiSJ4AhZhnG 5rHqzu3JUqevp1FIMk7PcXm2dqAQ1hhV55b0WdADDvZhxxG/Xd4tjTMd1NeDE3S+8zwOt6Tqkmk 4rqb6fyNOY2lF5twNl9EnFpJ3tsgX/p5qtXfZxiXtQ6EI7b0xUjpv/1hEf+8lA9TJeS4J6GKmI1 c3/olOuGS+Vhg8wd+n3asNVyPlF6zRYFoqFPQLLeMRBEdwpAwV3jPZMgff6dmWVnNKxAFEwMxG3 M+Vp4Vcz+VKWSQrr6I11uRPrDx47BNQHgpS2GphQmvsBaS/PyuTQATzBzcY2fGVeJiHFOooWUoE jAmkeMqngCnYe1Iip/mVenZW90oPdkUvwZ/F3FA0rT9FwoTQ57hxIRLuS9DqLos64zh87CIaE6W jKe+Rt38Q2c1FdUaTC/yr4hjg8= X-Received: by 2002:a17:907:3c85:b0:c12:40c2:9d09 with SMTP id a640c23a62f3a-c161e909efdmr233457066b.12.1783841564120; Sun, 12 Jul 2026 00:32:44 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/3] bhyve: error handling for monitor opening Date: Sun, 12 Jul 2026 09:32:29 +0200 Message-ID: <20260712073231.6404-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260712073231.6404-1-bogorodskiy@gmail.com> References: <20260712073231.6404-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XHJ7YU764U2BID4C4LDYYZHXKTQS44CV X-Message-ID-Hash: XHJ7YU764U2BID4C4LDYYZHXKTQS44CV X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1783841701855158500 Content-Type: text/plain; charset="utf-8" The virBhyveProcessStartImpl() function which implements domain start does not check if bhyve monitor open is successful. Check that and jump to the cleanup routines if it was not. Signed-off-by: Roman Bogorodskiy Reviewed-by: Peter Krempa --- src/bhyve/bhyve_process.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 2221d8700a..4d93ba8fac 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -411,7 +411,8 @@ virBhyveProcessStartImpl(struct _bhyveConn *driver, =20 vm->def->id =3D vm->pid; virDomainObjSetState(vm, VIR_DOMAIN_RUNNING, reason); - priv->mon =3D bhyveMonitorOpen(vm, driver); + if ((priv->mon =3D bhyveMonitorOpen(vm, driver)) =3D=3D NULL) + goto cleanup; =20 if (virBhyveDomainObjStartWorker(vm) < 0) goto cleanup; --=20 2.52.0