From nobody Sun Sep 20 18:54:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783604517; cv=none; d=zohomail.com; s=zohoarc; b=h193/pe04fxa6QF7IFIwotX48BGysVQ6FmxUMCvfrjnpFtB4K0/ZvCjtWDAzS/+599nVtgRqmxlkBvjGh5N6IZBPBTTuOURcXPSOOTZ8NLUmcP2f4W/DOl7JvTPMprMCnFA11K2WXxhyGASDZcN+e1SuTAnxY8mkrN6xFnYe9+A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783604517; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=A2bTF2IM7vB5qIABaRlPySUZSwhTnXVDiG9l/jKSbrY=; b=dEQJHie0dzLAFyrxHq0tBJetv7XGJe/oLWo1+lt71f7LkgMoututiVpGuybWcIcPweThP9vxG3YTTdflQeZoLlGXiKHUoxZeIXT2G9V8zNFVfVP5As0Y/B/g3lP+Vg0RlvexcOyYljc1kqPZZgSNTW7xhmmYiRjIWUfiXD/PqMM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783604517839924.5810858997473; Thu, 9 Jul 2026 06:41:57 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 77DE241CF0; Thu, 9 Jul 2026 09:41:56 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id AC6C141BAC; Thu, 9 Jul 2026 09:40:54 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 8E37F41ACF; Thu, 9 Jul 2026 09:38:22 -0400 (EDT) Received: from relay.virtuozzo.com (relay.virtuozzo.com [130.117.225.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3541441983 for ; Thu, 9 Jul 2026 09:38:19 -0400 (EDT) Received: from ch-vpn.virtuozzo.com ([130.117.225.6] helo=mami) by relay.virtuozzo.com with esmtp (Exim 4.96) (envelope-from ) id 1whoh2-006MF9-0A for devel@lists.libvirt.org; Thu, 09 Jul 2026 15:22:35 +0200 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 X-Greylist: delayed 951 seconds by postgrey-1.37 at lists.libvirt.org; Thu, 09 Jul 2026 09:38:20 EDT DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=MIME-Version:Message-ID:Date:Subject:From: Content-Type; bh=A2bTF2IM7vB5qIABaRlPySUZSwhTnXVDiG9l/jKSbrY=; b=rJa8iQuObmJb UWUCYdLZ9I8inGs39uDLMXJCYmVJ+rHk/IG6e+LauxLVmyBP8N9VpMsU3g9TOreOa+c+5+1JVr/DX TN8celaJFWtzOmDi6/3gMEhYPmU/0RpbsU0YyW8GmPLV97/oIYeWDz0z52l2OtDIp5TwIuxvb9Mz/ 4DUu7JOByaAFenCDjKtz/PtiB1BShhofq3ninuVU5hKtsdDF+dnyvmdPJnSG5QtBRJAigsiTY/9AZ 8BWFiOVFUFgAjSdJO13vANa9lLcYJ7alwtY+Mx1P8oWSy9FLTh9OPqd4ThhMRQsHPxOTVd697+ZyC 0K0tmCkPKtEamVkIjQ2cPQ==; To: devel@lists.libvirt.org Subject: [PATCH 3/6] qemu: Add qemuDomainVsockHasGuestCid helper Date: Thu, 9 Jul 2026 15:15:16 +0200 Message-ID: <20260709132213.2392145-4-polina.vishneva@virtuozzo.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260709132213.2392145-1-polina.vishneva@virtuozzo.com> References: <20260709132213.2392145-1-polina.vishneva@virtuozzo.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MailFrom: polina.vishneva@virtuozzo.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: T65K7HSLZCR2WQ7TM4HK3ZK74EPN6R3F X-Message-ID-Hash: T65K7HSLZCR2WQ7TM4HK3ZK74EPN6R3F X-Mailman-Approved-At: Thu, 09 Jul 2026 13:40:42 +0000 X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Polina Vishneva via Devel Reply-To: Polina Vishneva X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783604518556158500 Content-Type: text/plain; charset="utf-8" Fold the "vsock present with a usable guest CID" check into one function for the upcoming AF_VSOCK agent transport. Move VIR_VSOCK_GUEST_CID_MIN to the header to make it available to callers outside of the module. Signed-off-by: Polina Vishneva --- src/qemu/qemu_domain.c | 9 +++++++++ src/qemu/qemu_domain.h | 2 ++ src/util/virvsock.c | 2 -- src/util/virvsock.h | 1 + 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index e1b805d906..8539bb72fa 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -59,6 +59,7 @@ #include "virrandom.h" #include "virsystemd.h" #include "virsecret.h" +#include "virvsock.h" #include "logging/log_manager.h" #include "locking/domain_lock.h" #include "virdomainsnapshotobjlist.h" @@ -7387,6 +7388,14 @@ qemuDomainCheckABIStability(virQEMUDriver *driver, #undef COPY_FLAGS =20 =20 +bool +qemuDomainVsockHasGuestCid(const virDomainDef *def) +{ + return def->vsock && + def->vsock->guest_cid >=3D VIR_VSOCK_GUEST_CID_MIN; +} + + bool qemuDomainAgentAvailable(virDomainObj *vm, bool reportError) diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h index 50ab492023..e994776996 100644 --- a/src/qemu/qemu_domain.h +++ b/src/qemu/qemu_domain.h @@ -805,6 +805,8 @@ bool qemuDomainCheckABIStability(virQEMUDriver *driver, virDomainObj *vm, virDomainDef *dst); =20 +bool qemuDomainVsockHasGuestCid(const virDomainDef *def); + bool qemuDomainAgentAvailable(virDomainObj *vm, bool reportError); =20 diff --git a/src/util/virvsock.c b/src/util/virvsock.c index 10ca1d44eb..3c088c8648 100644 --- a/src/util/virvsock.c +++ b/src/util/virvsock.c @@ -81,8 +81,6 @@ virVsockSetGuestCid(int fd, return 0; } =20 -#define VIR_VSOCK_GUEST_CID_MIN 3 - /** * virVsockAcquireGuestCid: * @fd: file descriptor of a vsock interface diff --git a/src/util/virvsock.h b/src/util/virvsock.h index 06c251b594..8bf08f9228 100644 --- a/src/util/virvsock.h +++ b/src/util/virvsock.h @@ -18,6 +18,7 @@ =20 #pragma once =20 +#define VIR_VSOCK_GUEST_CID_MIN 3 #define VIR_VSOCK_CONNECT_TIMEOUT_MS 200 =20 int --=20 2.54.0