From nobody Tue Jul 14 21:21:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1783585382; cv=none; d=zohomail.com; s=zohoarc; b=oHr17VWQX0NhM2o5lzZibXliBpBirrC84vX6wQ7ILFDSYPADcf7QGnaFx3/J0LH4G+wdBMR08Gs3ljPE1rYpxSl9ceaxQyJM/aPrv9Eiob7ySGY5jaF7pASaY+z2rHrXMvxntToSugpPQsIrdqlErik2UqtW0LdDsN2KtWLhDHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783585382; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=o9HoZHbbdoyQnI+K3q2OcLbd2wiU25fU9xNf06KxQZI=; b=TGzD0ymDyPEIPOVjuJUoTQHEL6PMPrGXiiyL85pVJRJzhKEt5DzhIGdiSP6+Jyuh9bC/gtEq4NyTqdBdN9zV/F78g5B6SA+Jh4Pftc+1qdNZ/sCx5QYhRRRW++lnsjkRw4XtiMHPkZmZWrEWLaFTL4dl+EyoX6gxwJ+KHrk/4Ro= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783585382104236.15255383701765; Thu, 9 Jul 2026 01:23:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 78A883F87A; Thu, 9 Jul 2026 04:23:00 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 2FEB441D55; Thu, 9 Jul 2026 04:21:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3E20041AE4; Thu, 9 Jul 2026 04:21:43 -0400 (EDT) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 9BDA741ADF for ; Thu, 9 Jul 2026 04:21:42 -0400 (EDT) Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-39c7225e60bso14469301fa.2 for ; Thu, 09 Jul 2026 01:21:42 -0700 (PDT) Received: from rbta-spb-lt-115149.astralinux.ru ([95.32.207.183]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-39c84b84954sm2113931fa.23.2026.07.09.01.21.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 01:21:30 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783585291; x=1784190091; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=o9HoZHbbdoyQnI+K3q2OcLbd2wiU25fU9xNf06KxQZI=; b=MWgnNiWroovD6tl5A1huPnjHORqAf8R/6z9fncFIpZXn6XjNXvvJ90vhwUo3+9Em/p rlEaIsxkPiqpOl20rhK7xYCL7/hu+f5IoXkTge9tfgbpPubasMDII3Czl7n5BwW35IOP 5lt86qa57f/6QWsqoDRfTV7s3cM8f0UKe5GTL7L5pLXhIdioUAqTLVtP+zh9kHo9mMLs RhX4eg7nXufXKE+4eX36g4AN8kS5FpfuiLb8os2mBVK0yeAleqOFtsDwt4SWepWGO8Ba 7WVvk+n/od08ZVYHdWhM81zgQF46v9xQIESJQkf5UdpOXvgHh/7QoBwq5Ce9D+goezT5 vsSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783585291; x=1784190091; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o9HoZHbbdoyQnI+K3q2OcLbd2wiU25fU9xNf06KxQZI=; b=ElE6vAdnTUYiRfHnmelmqiOQPHqzNMDNWfU5fENbsU9hZryWvdB8GLETKgrSaxmQaZ iHZ7TAqX985J13g9Fk3mG3Ub+TEjb146k4Smca00y5WWB2klzqVtMQ0FkjimwzKrJPdc yLD4JxO+h1i5RNbzj3/DoOhP0nfse9pY+eq03RtbLOmdY1ZjHnK4Fp8KZmD1I3JA8C4p XbQC3gLEw/Vy4pFtSoh3YabEZmp2fx1VmFGUcG+nMJyfDKdFA0YEqReyxQ8PjMbRaAq2 dMr/pTM8ABQLE4HgOSGgmxEAIeraS0mPB29moCHeRuyEUbAreq7qipQtQh8AxtY0UaQn CRvg== X-Gm-Message-State: AOJu0YxQIlqjQp5/hzubm8Z9vU55q3Ji99AjEHSkciHPUwcAp3mqmrA3 cVx1362VeWIz4ADBuIvUHdZ7rdcPQLMKrL4bo4cIUDiiPDMiLpjgACkDk+fgWA== X-Gm-Gg: AfdE7clkzz2Sh89JJXNC1W0gc37LRE4cVqvxmpukgIrjoluKU5c5pIj1Ojl2fVyv2VK wiKiPmxQ6TS/Q7tcRi+2pakWkrC4ui0gqnlmGU9DyYFON+5Fg58QrcrwoQyevSyfLrJyiM9w1oZ YatbkpqhqlBY6bRC2i/96tgUt9j8DoRPsp6TzDmKcD+4MaRcygln2AT40Rwd8YR6xHI+5sykKxg 7irVy69Xuzb8Qz9FirV9d7AyT+nyqQFipxWG5iteF9VurkJPKFX7dM+olPNteYk9D688NhEs55T 2EWU9VC01fWyAHLTKeBWqVHWIeLL5jdCAqJy9of/NM5aruZxl2dRVkQIoa1XV4O/T/6HlBCkdVL qtpx5J7dFesXmN/3VRd9I4vHpSS/OHLznLjQELipkdQXASqKt0sPH74P6WMO9VDfC0F0eWWoJID n15wdC+YDXRZofUw1d9vX1JoLyjDAkCTPBzEiJ6hDcu4awQRBOKJoE7Zo= X-Received: by 2002:a05:651c:b08:b0:39b:164a:2208 with SMTP id 38308e7fff4ca-39c79a403acmr11518371fa.40.1783585290456; Thu, 09 Jul 2026 01:21:30 -0700 (PDT) To: devel@lists.libvirt.org Subject: [PATCH v2] vbox: fix memory leak in vboxStartMachine() Date: Thu, 9 Jul 2026 11:21:06 +0300 Message-Id: <20260709082106.49896-1-teryoshkina.ea@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: VMPI3S73EKENC2W3VSRDDCZMBEKW6FAV X-Message-ID-Hash: VMPI3S73EKENC2W3VSRDDCZMBEKW6FAV X-MailFrom: teryoshkina.ea@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elizaveta Tereshkina X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Elizaveta Tereshkina via Devel Reply-To: Elizaveta Tereshkina X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1783585385871158500 Content-Type: text/plain; charset="utf-8" vboxStartMachine() allocates sdlDisplay via g_strdup() and doesn't free it. Replace VIR_FREE calls in the function with g_autofree macro. Fixes: 3f4f0ef47d (vbox: Fix starting domains) Signed-off-by: Elizaveta Tereshkina --- src/vbox/vbox_common.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 65ae9cc651..63401613d5 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -2162,8 +2162,8 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMac= hine *machine) int vrdpPresent =3D 0; int sdlPresent =3D 0; int guiPresent =3D 0; - char *guiDisplay =3D NULL; - char *sdlDisplay =3D NULL; + g_autofree char *guiDisplay =3D NULL; + g_autofree char *sdlDisplay =3D NULL; PRUnichar *keyTypeUtf16 =3D NULL; PRUnichar *valueTypeUtf16 =3D NULL; char *valueTypeUtf8 =3D NULL; @@ -2233,7 +2233,7 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMac= hine *machine) if (guiPresent || sdlPresent) { const char *display =3D NULL; const char *sessType =3D NULL; - char *displayutf8; + g_autofree char *displayutf8 =3D NULL; =20 if (guiPresent) { sessType =3D "gui"; @@ -2250,8 +2250,6 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMac= hine *machine) =20 displayutf8 =3D g_strdup_printf("DISPLAY=3D%s", display); VBOX_UTF8_TO_UTF16(displayutf8, &env); - VIR_FREE(displayutf8); - VIR_FREE(guiDisplay); =20 VBOX_UTF8_TO_UTF16(sessType, &sessionType); } else if (vrdpPresent) { --=20 2.39.2