From nobody Tue Jul 14 21:18:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1783523993; cv=none; d=zohomail.com; s=zohoarc; b=Hzh3LQiyr54yy2tUQeOL+iE3pbSm8jf9rUYGGrQM7AJdVbHcbvXILOZi1vrf8EqUZX6DjpC2CcUsz1iWkoQ6u7AzScA75S9joMLOfuP+H17QwCOULhZwK81S5erUqJq6X1qtdqVHiSXFI4vYeENFQo45cWX1zOEAnuhio6tbOQE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783523993; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=fwjnjvsWxY2j21ShKHgN3OxbfygsbzO1eigJxLMDagg=; b=ioxi+lVEeoK1Ga8o59zd/0Dftp6GrcQDNc7rkWha8GgeJm6EBTG7bs21W8CUjTzx54QDGxtOmWkoGNT2cIxv5+5EE2VkZ5Uohtf/rsJCJMEaQDMY0arYFuhxnn2U6004drVV/ISPLKXXR5ScxZeYCcjHeKgTJCyvX6i1exmvcyQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783523993601637.5627391198453; Wed, 8 Jul 2026 08:19:53 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2FCDB41BA0; Wed, 8 Jul 2026 11:19:52 -0400 (EDT) Received: from [172.19.199.10] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 9390A41D48; Wed, 8 Jul 2026 11:19:11 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E7B4A41B41; Wed, 8 Jul 2026 11:19:04 -0400 (EDT) Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 50518419A9 for ; Wed, 8 Jul 2026 11:19:04 -0400 (EDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-5b0117dda13so673907e87.0 for ; Wed, 08 Jul 2026 08:19:04 -0700 (PDT) Received: from rbta-spb-lt-115149.astralinux.ru ([95.32.207.183]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5b00cdd72cesm964307e87.78.2026.07.08.08.19.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 08:19:01 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783523942; x=1784128742; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=fwjnjvsWxY2j21ShKHgN3OxbfygsbzO1eigJxLMDagg=; b=i5Qhs2yJzFhFekf6WKXav8nRBQGzkuB42JCCatOaOmQV/tCSgBn70erhotOmT2xJwC vIhiOUQ3JP4zq2m7o2YWQU0lp+0hfirSG6hg+m1kohOYMEzXnyacOAGk0zjyF5kPAU6B AunAMYiT2Dsp42bndVpN1wm1uQeVBfdyqRW7OnPyyLBCkZk0SOb2mc2f7/dk0aXJIavI R9gEdIEFlVHX0JURaUpDpj48ssLHtNvLQdaSlY0KIRc1BdygOl3/fxWF1YHR1wIsTG9e ovFtn2F6nCPXR7KZ79Io0SCL+SLmm9vbyzxj2Y5+q29iJSMj1zr6lfA3brPzqTrE2bOV WS8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783523942; x=1784128742; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fwjnjvsWxY2j21ShKHgN3OxbfygsbzO1eigJxLMDagg=; b=UhF+CzKuJicXcquytgvgaY07sI9Xq5ZNK6a9hEU1s5N0WJ+wvB6qs9Ls7nX+MWY3Ff 0+dJ1WLPIG+0CfZrO/X4iLfDybnQerVM46LK9sD5j9JZLzJWn0t+BBObepOmzvmamQcb Ze+8L44NO27T0wEkC4o6hTS+78ofvh+d5j8UMNXFSYFX9dwO82JPxes4NkF75/yP3v1K vev75QwyE2AXz2JYvoqnpY/b7Jfjtn0ZhXpMYejusBSxX5o6i5An0Zw+XAYdOsuwxCpM J0XKNB46NVvTqnBChxwEx9xtMvJU/Z6jh8hOeu7ZR2+HmkUIff4FIjNCvGa5e2L4l3h4 Acuw== X-Gm-Message-State: AOJu0YwdRAeZ92zrisRD+XuNG8eZczo44kmq9pLq3ujomZpv6GreyUZV 04f0MU2wkDSwvpzrvnktuwvz20hhlMtwaluJLDTCJZxEikOG4vTD3KNfb4ZdNg== X-Gm-Gg: AfdE7cn/qKSX6Grj2iCRWhyJDQ9YFE2/4JM0V/CKHTsv0nQtJoKEKufIpvKQoLKHawT uGxiLFnIX0nkxPkPyTZ2hD3vmFZo3SpjIAkFxuTcjl3RRnxffpYMhxbaAr8YG4Laxg638h4YjkT 30xMWqu1HYIrzxX/3tYPIl67aU66Ika+JaX0P5BIXvAJPkERKyUI8jkIhlSFM+jkSdzvucuAf6v 6FWGInzcpk2QoJmu+gi6zK1BpMQ3HClMrMlOPObAO3g39NfzrORHe7GlAV1iix2VUntxIRFbT47 OZ5rjvJVPZuaarvgepxZyS3obVBfovokQzXusQL3xDWMZ9KkkUgtRbtPOuBAMh/r8jgKNjHuw5M ZxExehm2NAEBXW4V7yXKpSrv5rrxKiKHRlXWkOgOL2E3QKrk+jaEcYEaKfqLlGYT9I1BoSbhxtl n+DZA65gdjRwgw2zUq2SL1DNf0AGXcJXtApWXUapL9EVM= X-Received: by 2002:ac2:491b:0:b0:5ae:b78c:da1 with SMTP id 2adb3069b0e04-5b011478bb2mr521877e87.28.1783523942136; Wed, 08 Jul 2026 08:19:02 -0700 (PDT) From: Elizaveta Tereshkina To: devel@lists.libvirt.org Subject: [PATCH] vbox: fix memory leak in vboxStartMachine() Date: Wed, 8 Jul 2026 18:18:16 +0300 Message-Id: <20260708151816.552225-1-teryoshkina.ea@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TIAN4UTDGCMFA2FGIDREN5WOH5OT77E7 X-Message-ID-Hash: TIAN4UTDGCMFA2FGIDREN5WOH5OT77E7 X-MailFrom: teryoshkina.ea@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elizaveta Tereshkina X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1783523995694158500 Content-Type: text/plain; charset="utf-8" vboxStartMachine() allocates sdlDisplay via g_strdup() and doesn't free it. Add VIR_FREE. Fixes: 3f4f0ef47d (vbox: Fix starting domains) Signed-off-by: Elizaveta Tereshkina Reviewed-by: J=C3=A1n Tomko --- src/vbox/vbox_common.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c index 65ae9cc651..a47183927d 100644 --- a/src/vbox/vbox_common.c +++ b/src/vbox/vbox_common.c @@ -2252,6 +2252,7 @@ vboxStartMachine(virDomainPtr dom, int maxDomID, IMac= hine *machine) VBOX_UTF8_TO_UTF16(displayutf8, &env); VIR_FREE(displayutf8); VIR_FREE(guiDisplay); + VIR_FREE(sdlDisplay); =20 VBOX_UTF8_TO_UTF16(sessType, &sessionType); } else if (vrdpPresent) { --=20 2.39.2