[PATCH v7 20/35] monitor: use dynamic cast in monitor_is_hmp_non_interactive

Daniel P. Berrangé via Devel posted 35 patches 1 month, 1 week ago
There is a newer version of this series
[PATCH v7 20/35] monitor: use dynamic cast in monitor_is_hmp_non_interactive
Posted by Daniel P. Berrangé 1 month, 1 week ago
Rather than checking !monitor_is_qmp(), use a dynamic cast to
check for HMP.

Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Tested-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 monitor/monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/monitor.c b/monitor/monitor.c
index a818659392..6fdd0255f4 100644
--- a/monitor/monitor.c
+++ b/monitor/monitor.c
@@ -170,7 +170,7 @@ static inline bool monitor_uses_readline(const MonitorHMP *mon)
 
 static inline bool monitor_is_hmp_non_interactive(const Monitor *mon)
 {
-    if (monitor_is_qmp(mon)) {
+    if (!object_dynamic_cast(OBJECT(mon), TYPE_MONITOR_HMP)) {
         return false;
     }
 
-- 
2.55.0