From nobody Tue Jul 14 21:18:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1783197330; cv=none; d=zohomail.com; s=zohoarc; b=IxaJnr6caSUc5lDnF0rbm5bntVvsNi4jaaNFT57oidLTdiTab9sSvz+4VyufIL4JmArzt9oikwpM25jC0AnAs9MTLhUfEpv6Jx0X0cgj5/Qdf1ImqSVZWvW7JxLRJiM9UcWKR3OR0GXIjAu+ATXyTzCtiPZAy8av25YTsCcWHIQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783197330; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=2uMaETBxqSznqin2CMH7crpUAyvpykiwIK8wXxAD9Og=; b=A1ORfy90oUMPYYw7nmwZNk0rVAdLmYW6NDPGAPvZhniNO3luf4nCscBsBiH/oT+XdBXJc7rfBRcPLcz02O75NkqpszTXe6vVAD8+y9QkB8j0t7ZdeNgQpolTaDv4FGPn+Dk7le7liaeh25AzVVLDosSsehfKOl9BxqtPheUQcu4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783197330587895.4030190614146; Sat, 4 Jul 2026 13:35:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0781D41CD9; Sat, 4 Jul 2026 16:35:29 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 7B7C541CF9; Sat, 4 Jul 2026 16:33:41 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 28D4241BAA; Sat, 4 Jul 2026 16:33:28 -0400 (EDT) Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 20DAE41BAA for ; Sat, 4 Jul 2026 16:33:27 -0400 (EDT) Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-2c7ab2b9dceso3660885ad.2 for ; Sat, 04 Jul 2026 13:33:27 -0700 (PDT) Received: from localhost.localdomain ([2604:3d08:6a7f:fe54:b801:a376:eb28:37e0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38127cc5909sm2821497a91.14.2026.07.04.13.33.25 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 13:33:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783197206; x=1783802006; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=2uMaETBxqSznqin2CMH7crpUAyvpykiwIK8wXxAD9Og=; b=YdAeZ4QAgBvYnawcFC8Qp+4XQnQEqV0MhZeOmGlXme+aAg+NKL0ljSxjB1VCf7zYDQ tetyyKIGLj6KRjiUnem1VIJznhsM7yBAY+VWuXaK5O/YPcqHp9wkitmB4I1L4zuhlRwP pvlrv1ZDatBSC0S3/RjFZyXbOEth29K2C7gGmAOa7LxYaTtIGKp6a0gHNjtWSdXa8a+v 3WtPPoqyvPvDIVY1Vty6qzN2YscJMVdN7dIElcYERt+/rU5MlL9yAHomhOD3kkkk4z9b U7AaNYZIEzLtg59pRSqOap0N/qx3xaAlOvcQpa6Jn77xBQr5MVL//J3/XBbS8Vv2Ng3U 6TbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783197206; x=1783802006; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=2uMaETBxqSznqin2CMH7crpUAyvpykiwIK8wXxAD9Og=; b=G8gnrSR/wbFO61+C6nQh7BWo71tuWfyoGU/QQV5BkoLQlVJoO/GTKhU3jtSV7LkguB KU76pQJt98C2E30UCq7DDX7IHZLSHJFaNENBcusGWmzgWu1qyCN+AcjVb9eQ3ewDggu4 j+KewMhZNDUL/JLszRJyp2WYBKLO3YvQE/qlg4Qj6zQStM+o32JzXjO9D+tw1MDrNyqK 5m7rObT/FJOCdzv/4Gw+/ikkin1pxkUlG4DoJP32GwoHGFzyr7QlqIFJ1ysjckW9X1N+ OnMoCq4idbiThTwh11Z75M017E6WKFPilX6IC8pHBFH0cY8vegZjDjbOgAzxelPqkm6d h/6g== X-Gm-Message-State: AOJu0Yxh8f1l8Xg8lwPEZaxFw1J059GKEO7dKw8cp0eFN85Dk4+JDKCv XFFkoaS5OhguLOXeyLLmmjJ4Qgyjnpx8IUmjxJTrsJkGSv1iYJAmGi1sRsa5RaZz X-Gm-Gg: AfdE7ckvrejXu0DqX6gXnMHu3J4HWQ7fGCuMe3xbnTRLii8ne6uzQDVRt3YlMfDxaFD F+HXJFhW5bHT+CfS10Oy7latp6EjID+rcXM1Y8PS38MDOr1ZSXbI3uambBO/U0O/AiKzoKueATj oi6QRHCqftDm6wBvVjKkveZgfR0OYzzYG+03EdMUagyYEutFU4aU70iDZYigh66faNNbZgnpwsK kkmny9vTAelA0dIfUZgOy2AtuyrILGbdZd2jog/cAwtNpjOdPvTydMVU0pHy08aFPuhoIaHwtK1 j1eXS+MqUlDJHv5Ya6qAlY5+CFQY7yOhWWUX8A1+iPogK7cTdCRjVRyiOdXGCGX6cYUOqbbL+a5 tZFeaWQkm0/dBFFQiuGvA829AamMK8xCQQGnGI/YQ20FxzfYs+ka/U+VUnWK+vKdFleroBPdCSd jDqiI7hN+jSZ91VbLnuYt7fsvjpYc5DiNnUVa2oKSH7MABlFH70g== X-Received: by 2002:a17:90b:1801:b0:381:bcfb:e710 with SMTP id 98e67ed59e1d1-3829cb9af51mr2634995a91.3.1783197205792; Sat, 04 Jul 2026 13:33:25 -0700 (PDT) From: Nimish Jain To: devel@lists.libvirt.org Subject: [PATCH 1/2] virHostValidateBhyve: replace if_tap check with if_tuntap check Date: Sat, 4 Jul 2026 13:33:10 -0700 Message-Id: <20260704203311.10203-2-unauthorizen@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260704203311.10203-1-unauthorizen@gmail.com> References: <20260704203311.10203-1-unauthorizen@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: M7AOIM2BDQ2AZOP7WFKLNJMUA6JJKV2Q X-Message-ID-Hash: M7AOIM2BDQ2AZOP7WFKLNJMUA6JJKV2Q X-MailFrom: unauthorizen@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Nimish Jain X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1783197331021158500 Content-Type: text/plain; charset="utf-8" if_tap is now bundled with if_tuntap, so we replace that check. Signed-off-by: Nimish Jain Reviewed-by: Roman Bogorodskiy --- tools/virt-host-validate-bhyve.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bh= yve.c index d7a409db9d..9bc958445e 100644 --- a/tools/virt-host-validate-bhyve.c +++ b/tools/virt-host-validate-bhyve.c @@ -22,6 +22,7 @@ #include =20 #include +#include #include =20 #include "virt-host-validate-bhyve.h" @@ -62,14 +63,15 @@ int virHostValidateBhyve(void) =20 if (STREQ(stat->name, "vmm.ko")) vmm_loaded =3D true; - else if (STREQ(stat->name, "if_tap.ko")) - if_tap_loaded =3D true; else if (STREQ(stat->name, "if_bridge.ko")) if_bridge_loaded =3D true; else if (STREQ(stat->name, "nmdm.ko")) nmdm_loaded =3D true; } =20 + if (modfind("if_tuntap") > 0) + if_tap_loaded =3D true; + MODULE_STATUS_FAIL(vmm, "will not be able to start VMs"); MODULE_STATUS_WARN(if_tap, "networking will not work"); MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); --=20 2.39.5 (Apple Git-154) From nobody Tue Jul 14 21:18:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1783197395; cv=none; d=zohomail.com; s=zohoarc; b=Vu1pkJc6Yq1rVB5R1uSfPlFmaKiksMXPtwSBGUHsAZuXyWvOFa9EwdZTTmVchkgKWTvulGf5wQzAlamfMDz68PCtbj4bXow/B48jHFqxze4Mu0EnZsSMtOky14lwrDgQuXlBXDcLTYb7yqiy3pWJFhXm49AqEPVirwcSxb9v6tU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1783197395; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=xxYIPgWl8oKWPGds2zeR08b2LMQNbjAB9fjMJgQflbI=; b=GpLLdx55fSXTq5SSfKFH7rQ6dIKY87ubS8QObbSG79LtZRIZ5QiuxvvUXMHG8lZuMWGFMpgrn3o7BKlF4FBgZMb4lJLTN1B/wQQ0RP17diz6E7XCWtw3fch5H4bfoeqP5hp4fAfEsPlqin5CSYQcLLTAXFVuerLNE4k3QFYZvDA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1783197395632324.3640598423234; Sat, 4 Jul 2026 13:36:35 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 164D241CD1; Sat, 4 Jul 2026 16:36:34 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id E54D341E2A; Sat, 4 Jul 2026 16:33:48 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4797441DBD; Sat, 4 Jul 2026 16:33:40 -0400 (EDT) Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B454A41CF2 for ; Sat, 4 Jul 2026 16:33:29 -0400 (EDT) Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-37e1657510bso82714a91.2 for ; Sat, 04 Jul 2026 13:33:29 -0700 (PDT) Received: from localhost.localdomain ([2604:3d08:6a7f:fe54:b801:a376:eb28:37e0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-38127cc5909sm2821497a91.14.2026.07.04.13.33.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 04 Jul 2026 13:33:28 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783197208; x=1783802008; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=xxYIPgWl8oKWPGds2zeR08b2LMQNbjAB9fjMJgQflbI=; b=bdX7MfqVzxcL4hLh+D5pRFzH6beTSgXlbmB7PKZn2rKVqMNcCQGjp1GUJR0bG8F6wG /5bj68PCJ0S6yl2UeYRmISRuJw6KynJjLyHCIShmjnboKsO3m1JSTX5uqaGg3WZ7ynoY EbiAHo6fXQN0+VGqY8sArXuo5nvvPBOdDXIKGfOeg6VrFPjQ/Yo6eAEX0D4m7b8UH9uY f0IbKj4mX4CCFMFS0d/Sehb0926SxI3v0r5khFvDpNpDr3GJWxEsUIPw2bn9nPJIO96h Hk97gcuIbdlI5ludDNjYPW4UZDpY/CW96JYF1/ZlE5RYnTRInlvTNGxLAU/7yFD/67v5 MP8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783197208; x=1783802008; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=xxYIPgWl8oKWPGds2zeR08b2LMQNbjAB9fjMJgQflbI=; b=m+UL/VYVza+DPq/WYaSG4PRnL6wegeqCKhZj6S4wrJ6r+otrab4L22QzxcoIHfNH6D Pio5iV13lB/RhCsK9TuixS4SyF08hXk0UmnTwyhLlwCgIHuLtQOd7YfynVLAh/4t1/aQ 725Y1zey+qlgMKs8Jx6KlpkHR+Oo/LXEcNEeCH5Buc9ty1WgPYS3QFdDQEl9fs6bAZYD mn/v6Cl46RedsEHfIm8G7B4u5hZBwdR5822ui7MZwrpl5PpZSGpn+SPGL3vNru5YeXY6 +6pqeVTe9WawDVC8rmvkrzLsJbb4UrdcjaSg0p/uaWhuZ5GBcyoE/ONpyTQyl4GtnkdT J+zw== X-Gm-Message-State: AOJu0YxYQZxdEU043JdrRTRrQtsfEtMfpB7Df47vkGyBqaH/eDD1xqJ5 WF0dD/InAI+oqlnMyybpYYW/OTZ99mVdQ4bL6PFdYIvYIjKs49pgOL+B2uphQW1C X-Gm-Gg: AfdE7cllUHSBlYgHEpsea4fnV8FlJr/vvEUv0FYENFU6KgP29TvBgl4VpRXrwlW+Ihh FBMdNW5EAAiJWCuC22MsYeGadSES1I3iyltFWATHEYK+Wm6ek8cjd1DUrHS/6PFUVHAgAY0b2KG oQvfMzmSpESkK1BR0l218kPHtdZcWP98gH70+7/kG2d/iOvPcPKWunJ4WgaDaZEghZCNQmURavn aXzUBDQNok/AAbp+e2q+BzG+aRBMoTFTomCkZ8XSpdN8CEuv5KB51XNQUonp4o8VYu73W4EZry1 gxcbFwMoHLtZH2ehbAAwd856XEn861UX4WZc0XDfU8L8yPnWZ7xaH6F+Lxn7n8justjp9qAsR6W Hqlp1kiKi7BeeAb6agyjyELqM7hMZi/zI56FzQeABLI4wtIEA4qqC9pQh/ClslwUc5feQMbREIs sdlxcK+BSIZUGNp/U0ck8E25D6zEF3WP3zHAw3Mlvp/N+g26oO/g== X-Received: by 2002:a17:90b:5544:b0:380:9cd1:d985 with SMTP id 98e67ed59e1d1-3829fcdabb8mr2843468a91.6.1783197208474; Sat, 04 Jul 2026 13:33:28 -0700 (PDT) From: Nimish Jain To: devel@lists.libvirt.org Subject: [PATCH 2/2] virHostValidateBhyve: add pf check Date: Sat, 4 Jul 2026 13:33:11 -0700 Message-Id: <20260704203311.10203-3-unauthorizen@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20260704203311.10203-1-unauthorizen@gmail.com> References: <20260704203311.10203-1-unauthorizen@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: FY6SGHXVNU3O2UMXJMH3TGY3G5ONYEQT X-Message-ID-Hash: FY6SGHXVNU3O2UMXJMH3TGY3G5ONYEQT X-MailFrom: unauthorizen@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Nimish Jain X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1783197397258158500 Content-Type: text/plain; charset="utf-8" pf is needed for network driver to pass packets to the VM Signed-off-by: Nimish Jain Reviewed-by: Roman Bogorodskiy --- tools/virt-host-validate-bhyve.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bh= yve.c index 9bc958445e..bbb4a691b6 100644 --- a/tools/virt-host-validate-bhyve.c +++ b/tools/virt-host-validate-bhyve.c @@ -55,6 +55,7 @@ int virHostValidateBhyve(void) bool if_tap_loaded =3D false; bool if_bridge_loaded =3D false; bool nmdm_loaded =3D false; + bool pf_loaded =3D false; =20 for (fileid =3D kldnext(0); fileid > 0; fileid =3D kldnext(fileid)) { stat->version =3D sizeof(struct kld_file_stat); @@ -67,6 +68,8 @@ int virHostValidateBhyve(void) if_bridge_loaded =3D true; else if (STREQ(stat->name, "nmdm.ko")) nmdm_loaded =3D true; + else if (STREQ(stat->name, "pf.ko")) + pf_loaded =3D true; } =20 if (modfind("if_tuntap") > 0) @@ -74,6 +77,7 @@ int virHostValidateBhyve(void) =20 MODULE_STATUS_FAIL(vmm, "will not be able to start VMs"); MODULE_STATUS_WARN(if_tap, "networking will not work"); + MODULE_STATUS_WARN(pf, "pf firewall backend will not work"); MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); MODULE_STATUS_WARN(nmdm, "nmdm console will not work"); =20 --=20 2.39.5 (Apple Git-154)