From nobody Tue Jul 14 21:18:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1782731730; cv=none; d=zohomail.com; s=zohoarc; b=cZZSXzrCHXXj4yT1iQ8J3xuhFSQUyT1j4+YPd54ylTsLYnCXMctmGd5Ga/vmky/fmrPaPa4ZSdCMwfbten9sY7u1oO2k270+tXQ0HjBFXJ/86gWQ6lPHWuAtU9lvLiobybM9A0YLdhPdOrlKDhTxHgZvAPBGoTxKzF/qLJB2Yy0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1782731730; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=dTEsRmhyYZHH04Sd9S3sdMjNdx449b6dGOyee9bfVGA=; b=jJEIdL1l0OLXXgL4LLmLMyz1SI5/LAy7sMpS7NMqDedh8/S0s1hYYafh4fr8d3dCggdg37BViIRUV+HLElhWby4W6PQHFxm11/Zwc+nyQrSfOKhUdkQHECZBJy/lTvgdf/O9vxMFACrC1Syxl1yCgQs/tEvKdJdvZ1nBUXI5efs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1782731730628839.0684721118287; Mon, 29 Jun 2026 04:15:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5F61541AF4; Mon, 29 Jun 2026 07:15:29 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 456EA41E58; Mon, 29 Jun 2026 07:08:37 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 5623A4197B; Sat, 27 Jun 2026 02:39:45 -0400 (EDT) Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4A8C141BAD for ; Sat, 27 Jun 2026 02:39:44 -0400 (EDT) Received: by mail-pl1-x62a.google.com with SMTP id d9443c01a7336-2c8081023a5so531485ad.2 for ; Fri, 26 Jun 2026 23:39:44 -0700 (PDT) Received: from localhost.localdomain ([2604:3d08:6a7f:fe54:3813:c984:1a0:8ffe]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2c9878acad1sm14377795ad.42.2026.06.26.23.39.41 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 26 Jun 2026 23:39:42 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1782542383; x=1783147183; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=dTEsRmhyYZHH04Sd9S3sdMjNdx449b6dGOyee9bfVGA=; b=WpIGI+YxwyyhnPIYvifCnJlxvm0XtvWq+Ct7T7KVHpufM8ZChZYQjsveOng5+aydMk Jfmli5qTWyhSmYtPDt7gTzoUGqUSnC5q7ME5BrnqsbJv8Ornfu/HD3UlFNVd4oHqiqT/ HNyDHuLloG8KzeytP4WNVPvvo/B022QtdvtvDGGVDPdFlUc/JkcQ0vJ6gZ4Sn6aeWcrm 0VDK6DNNHdIvVMKVwQaFYZu5r7WauwbSAyStP8h3DQZwLbQhXCWcoDJyEHhuGzpHn2rO nWWxyzOTEKS3k1m5uJ3P5SDs43L+ZHXbHJXpOPq8+ZCeW2E0Eauj8s4ecRJPUqK84zMx Py2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782542383; x=1783147183; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dTEsRmhyYZHH04Sd9S3sdMjNdx449b6dGOyee9bfVGA=; b=qpWQg2e8BGMgJ3I18dc4YGCjDaqe6nLzbuLZZv/soCv6RMCyz+QiIa/TfVAh6VwmAB cUH3FCvDtidSs7bgQkoGWPLcayuB+xGudxuPuKsU2+VS06KO8G9k5kh64zmNED+ahNyo 4H9fnDFwe7TwzkMjnsBevfeWRBrKkJr5c8P6sR1oevVOw4h+2dTxQ6EjHIDuroY1XTeO 5liMtPOPbPjQ1hkyjYvC6rUk4v3xqYBuSLi1wpr0kMFZN6KjbwHjKgqopHbPFSpsz8/R fr02f/9V6jxRGwq7lzhOTF1M8wycgrMj0cVe095NGbEycGcKMV92rYT5JRu7o2KCjL2i rUCw== X-Gm-Message-State: AOJu0YzrigzeHAaJODatNuBjJn1IMRcu0BLzOJQGC2UWO+1Pi5chIQUU y+SjaVxiovIIyv9MUXmASNm/iCHT4g8uMBODmtSHMshh9i9b4I046Ze3L6b6ylODpLa33Q== X-Gm-Gg: AfdE7ckQf5FvP1mdeIKzKpx9+/bYG0ZqA4jrbSu+aK/qYuroZg/U5rgrd0sSYKUvw83 jYXXaQEfMnBltjfO8cwH/KGumCEmovPvOMqwXVSt22l846PLs1DhM63i8AdW7VzHqfGTYywZLOT 5P0kS5cW029kv5SjZzrKey0XjJZTSmZOQ0Y6A0b24LSiTyGY82V9XCU8n5QDzIcU+llpA/JhPsB P+AwMxrrxY7vShWLGUcVQJ4EDsXqfVAd13vUz7iBjCE38x3HTS9LMcZE3IO8r5QTo3YKtY8SVVP QjXyQ/LJOAr2LX0aWt38NIgnZqABgUbOqHRqkzDzkLJCwWZl83m99gu2ZEXZkeo7NfhSRnQ0B/1 w959DFTe+jQtoQLNCYgZT4trNy5aZZHqjRPo7IRLRPvPsABI+wEZYPVQEDwxcay1OS/mfF/Yj0t L81w+2y05F/IJY3qFHQ1yGujNEjLGmpdob5A== X-Received: by 2002:a17:902:e851:b0:2c6:da17:f1e5 with SMTP id d9443c01a7336-2c7fc750f37mr47273295ad.5.1782542382993; Fri, 26 Jun 2026 23:39:42 -0700 (PDT) From: Nimish Jain To: devel@lists.libvirt.org Subject: [PATCH] Replace if_tap check with pf check Date: Fri, 26 Jun 2026 23:39:38 -0700 Message-Id: <20260627063938.43041-1-unauthorizen@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MailFrom: unauthorizen@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: T3FMT6PWV2ZEKCXZHPNODLF22RZIFOI3 X-Message-ID-Hash: T3FMT6PWV2ZEKCXZHPNODLF22RZIFOI3 X-Mailman-Approved-At: Mon, 29 Jun 2026 11:07:45 +0000 CC: Nimish Jain X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1782731731663158500 Content-Type: text/plain; charset="utf-8" if_tap is bundled with if_tuntap and usually included in the kernel. Instead, check whether a firewall is present, otherwise network driver will= not work. Signed-off-by: Nimish Jain --- tools/virt-host-validate-bhyve.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/virt-host-validate-bhyve.c b/tools/virt-host-validate-bh= yve.c index d7a409db9d..539c6f85f3 100644 --- a/tools/virt-host-validate-bhyve.c +++ b/tools/virt-host-validate-bhyve.c @@ -51,7 +51,7 @@ int virHostValidateBhyve(void) int fileid =3D 0; g_autofree struct kld_file_stat *stat =3D g_new0(struct kld_file_stat,= 1); bool vmm_loaded =3D false; - bool if_tap_loaded =3D false; + bool pf_loaded =3D false; bool if_bridge_loaded =3D false; bool nmdm_loaded =3D false; =20 @@ -62,8 +62,8 @@ int virHostValidateBhyve(void) =20 if (STREQ(stat->name, "vmm.ko")) vmm_loaded =3D true; - else if (STREQ(stat->name, "if_tap.ko")) - if_tap_loaded =3D true; + else if (STREQ(stat->name, "pf.ko")) + pf_loaded =3D true; else if (STREQ(stat->name, "if_bridge.ko")) if_bridge_loaded =3D true; else if (STREQ(stat->name, "nmdm.ko")) @@ -71,7 +71,7 @@ int virHostValidateBhyve(void) } =20 MODULE_STATUS_FAIL(vmm, "will not be able to start VMs"); - MODULE_STATUS_WARN(if_tap, "networking will not work"); + MODULE_STATUS_WARN(pf, "network driver will not work"); MODULE_STATUS_WARN(if_bridge, "bridged networking will not work"); MODULE_STATUS_WARN(nmdm, "nmdm console will not work"); =20 --=20 2.39.5 (Apple Git-154)