From nobody Tue Jul 14 21:23:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1782731440331624.4404615456045; Mon, 29 Jun 2026 04:10:40 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C995743F4E; Mon, 29 Jun 2026 07:10:38 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id B397941D7B; Mon, 29 Jun 2026 07:08:12 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B97C241CF1; Thu, 25 Jun 2026 09:36:03 -0400 (EDT) Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 5924741CF0 for ; Thu, 25 Jun 2026 09:35:56 -0400 (EDT) Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65PDWQ3v4113625 for ; Thu, 25 Jun 2026 06:35:50 -0700 Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021094.outbound.protection.outlook.com [40.107.208.94]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4f01dkvsmj-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Thu, 25 Jun 2026 06:35:49 -0700 (PDT) Received: from PH0PR02MB7223.namprd02.prod.outlook.com (2603:10b6:510:18::20) by CH3PR02MB9090.namprd02.prod.outlook.com (2603:10b6:610:143::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Thu, 25 Jun 2026 13:35:48 +0000 Received: from PH0PR02MB7223.namprd02.prod.outlook.com ([fe80::7914:e632:3672:30be]) by PH0PR02MB7223.namprd02.prod.outlook.com ([fe80::7914:e632:3672:30be%6]) with mapi id 15.21.0159.015; Thu, 25 Jun 2026 13:35:48 +0000 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Y33u7p8DCh6lPIO/elcB1dYWl5Z1IwcKMBHqnKTUx Ko=; b=HtHGxClGo82xEeTAepoPqFFBCgoX8a4U3vsKiDD1QUynrdlNe2AozK2+d qrZjvxxCoAW+uNenWPrZRoRNCXqFIrvMYAkWVGMqoLf8BcRcimYENUQEaFiQX9g4 F2gsr5Hw2paQzeED0XzZ6vLuUGklf/RPQlgb4W3aR4viCE7nmPLpRG8wgJquJ9Ub mimqk8pPmIRfkDzm6whovfRR5yZ0U7VZQM3S9YV21MQfMBvGyvITMmO6ayqIl998 MJLCZyhB6zEGEGB2eMm900wC0yYXnUfy0eBkr7uYLAQUwdpODxMBHFNNhpvGsFTj w3ajqSpuMjweOtNfBAuEcAQHBl61A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=sXU3lYzL8xPKM5v3a5D0S8ynQOw2vQJzMdEh4YwroOltUSuNpoyxQv22SLQqChGVBf655OoxYsgIYpyMEDf9XKmhxw14BiJgnvVGTbrGz5czS6p61gUANrIf2uPHjHZT06k1QdNAy4/8Aj52zQeFp//wLjrBzaHL8uuwQ9xCyKqcaBohscr5D/c6OBJV1s3yVSZXFWJNXGOEsuC2Udh0QBXR4yylpijnS853Bq0WTgMTJKD6WGd1oR8aUzSswddN3LJl7/j3EouoCry7YoZ2LsO4Y4BhORhg24b2xiaDuxF+GIiG9vI0uZHz0P1JZL/r1T5a5qrJ36ijNIfJB4gVUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y33u7p8DCh6lPIO/elcB1dYWl5Z1IwcKMBHqnKTUxKo=; b=wInmJ4Ub/svrLgNrSwBa6ae7e/sjbXRMgBiCb0Y+vtpE9rVFRoALBIas1qlCv81bHwmSBPmZWLO0vOGMYKiOtC7FzpVs/f3hndJ/i2YjR0HxdJuBfftX1W0sxF5zGB0cVRIG1kcgJpHBXjQejMj2quOve+fIAg0QXV6GldufxMOTa8bzE31UdXJf4LtNM7Ug/Xub1uANuMutNWxGBAm8Sb75p+jRUQhejiNDDySax8uUKULhDqOzzq4Np1GhxNM6gSMEDVduGHoaiCrJlsW9f54HivfgZKRhUy/6MkbnzTIJe6xYqAbnF3SEScXOy5jp85gytvtiP2ke4ON4bCok1A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Y33u7p8DCh6lPIO/elcB1dYWl5Z1IwcKMBHqnKTUxKo=; b=kfhKfqtDMoSS6pDl1GVXfdjeTLjV+3jFbS/XwWOcrIi4Re3Ll8Cz5Vh0J94VrgMhjEHYrfOX5X5kZG+pk51FZDG3wbVo47DnP/fjDdc4L18MHtjjcQaa/grcwMe2lfD3c1dMJZ98ieXGDoRwvL21rSMRrDpFAp0V/CY6M25EGdzztudm95XiFH1o6UkF2CKKwuqbHLAy5zAUFjDx4xke4qcCGT2GKWpVOcAdkDPdvbPGinrhkyXjmKqiOHe/rZPhxK/n/0mFcrFM4j6DdENZFxgZnjOF0DHjYlCKFOo4wcL//odq3XnnRNA1YB1ML5uLLD6iaxzrng9kPlNKrlhTYA== To: devel@lists.libvirt.org Subject: [PATCH 1/2] qemu: Emit explicit kvm-poll-control=off when disabled Date: Thu, 25 Jun 2026 14:12:22 +0100 Message-ID: <20260625133523.585764-2-chris.riches@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260625133523.585764-1-chris.riches@nutanix.com> References: <20260625133523.585764-1-chris.riches@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CY5PR15CA0063.namprd15.prod.outlook.com (2603:10b6:930:18::9) To PH0PR02MB7223.namprd02.prod.outlook.com (2603:10b6:510:18::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7223:EE_|CH3PR02MB9090:EE_ X-MS-Office365-Filtering-Correlation-Id: 9663a543-7b23-4c96-d1c4-08ded2bea792 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|18002099003|22082099003|3023799007|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: Zgmyze2rn4+EF0C/0IeWpBcPiwjHE78MXqyIDsHYgiOjfrpuc5kVA5E5sPLGYxtxkoeYKVGdfomCTGHkjqF79ZDv+tj6iKwAnDNPnGi93M8BGdTVDkTs1GW+vEtdEr354zG9ruj3sHPzt9rPp7BhjDeAa5n15NlJXE/tAC1hl89uf8TAG+/VbmkXq9UTKDTw7jqwC144ypaOQdYNW5vZsJDnAMgPQBknFBLXOrfhgVyacQeiCq05061bP/MiPz2v03sCT1DxiOLUCyIhQJLHmhMr1BZ5l0kgQ9RkFJ0DJjlBhuHIdWEzgnyJR1+20O2V601KtWKN/5kXPkpfeWCcpL5kM9HpVK8g2SHfTXyWLTgQfZLHj9PC74xE6/na+z2pRW/UtID3rhXcCtlRXzXsRJUUAUY2IqPBeRuGpl8d2AnsxNlprrgYTCs5hQlZwBDQ6oRlFvm3kNOA7Ifvylt4U6VezK9Iq/+rc2Mnz7nLBtbpd3g48/z7wS7CT8iGxjXD3326t2tf88OL3sQ3U5H/0bGsssfdkiFlT9uq6xVhwwJ8HVbl8/92urDmbKiLSP5Tkmns0uLUlT+9T+ipBs/djsBhfVmGamu4VxbEwN0Kcj3OgCv/gvh7ibu6Y1Tc4JZAg4vp8k8Fz1ZqUqZ1SianYZJHys0yi9KTQv6EHwpnCco= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7223.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(18002099003)(22082099003)(3023799007)(56012099006)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AJrgNIAieIVM0qAVSk1ruhBVJX22cFDjyVz5fkdXmzYlhlutqkfKiqUMGO8j?= =?us-ascii?Q?3kzyM0o4rAadtT6gyfCHYZbJBMbOF5jB02DqLML1v9XtXib32aetHJWir139?= =?us-ascii?Q?ZeLFncOllKQJiLd8heyRFOuBj3AXSBLA+pHvCXZ+quqFLY6mMiMv8Uw1Zwk+?= =?us-ascii?Q?0BChjBYgkQY4fuoB0NvA363ylm82rgZs9XojyXYLxU7LsmdS5DOWdWjieJdl?= =?us-ascii?Q?1Zw0EyBeHMaSKbPU1XkBQxETLjU8Z6hRTf86i7mAOK00Vc/t+4ehLQFDD/aW?= =?us-ascii?Q?Ka4NqeoEqOqpDwsPKF+v0LW+c5FKYNFn6i/VPfbrpiLBqui8BQAtPTLzW+9a?= =?us-ascii?Q?lyxeX5zM3Lxijd4wtJ+U+hlkjYlyp7ZtkDjnxAUol49gFy5tDImERYHoPHgT?= =?us-ascii?Q?YyhlAHnVM8V9La7LbT84jILvy7n5bAYrXBIrZSDxJye2wAuio/a7KVxNhk/f?= =?us-ascii?Q?8SImfc81htuScJhcMbTaOX39+2FMqSBp0hJr4ZFs9113ZbWDk+g2BsuvKEFX?= =?us-ascii?Q?Cx6yEwxGhzbhaT2x9xXRpZVRECrv9K37kb+iOykhq9aSl6CHWv16wZHR7yXX?= =?us-ascii?Q?nYNOTF6xu4CpXNMHl04T0i3C519EGOBUiC5OsE9S82OK0vQ5ChxIh0onVTNa?= =?us-ascii?Q?CYeMMwaiTDmTOI/CezKZgaRjVcEGENC0cKJTbnVyrFyrUZA8dYMhH+XKDseC?= =?us-ascii?Q?Vd2s7zCYCP+XBNm56p74FfNbbsBB/wtXDV7JF7BEsPGiRD0O3Tyy+P/sHDZm?= =?us-ascii?Q?FAsiBX7yWeeqJFruPrFUI7Gt+8Pa4RiJuxQFp1m1W87eb08WIeIqTakNuY7N?= =?us-ascii?Q?gmWOMRhB2iJQmx89D0su/ifycT1zfXeSKwvw647vyFsryQZksWAszl3B2acU?= =?us-ascii?Q?FyziMdj6SW6i5D/5rnnpNnUOQBi+aEM/5D6OxdZK4oIUHvC2yIklZ2Xx8yI2?= =?us-ascii?Q?tUEmGWG7M3el1LMj3Rfa1qUaqpfWfCYlTBOk4G7Pd3bsvzZh/tPb0f+n5x2j?= =?us-ascii?Q?sTpy/KxURl3DyzbgttzTbd2OiAWXtjXg2mIGm29SsSFEQgQWAl3np4juWXqO?= =?us-ascii?Q?wU+QqxrbLJcHi+GkXW6G5SgO+DSmVwaRqUdyxQ6ePA/+7qUhWQpy+pTmhD+i?= =?us-ascii?Q?nY1Sn3rBv6hBVzdeTcRq+mFfbOOeKuf+1AVtWSWaARN2TmvFAWU5+mqxUDmS?= =?us-ascii?Q?sbJ0ApeRe13TGxo2nk4GZygJZI/B4KwxeC3Sr7LO9QzjsgJuLJzkao+w4mrV?= =?us-ascii?Q?o4NTYKQoiC5Mt6uti7ZHmoI92tAyWsCeS5BbedlLT4Ag4a45uF9FAYrrwiQo?= =?us-ascii?Q?4lXmuQQ8c1fAtdW6EjPYzuL+2LqglFIZqlCcBdx86fACcdI2/yuvJRKOi//D?= =?us-ascii?Q?pp4hZcEOpSJt3vRRzhzVURXbB8lhBntkH0UDzIlvyRmyW37ytNuBlrcEtxeS?= =?us-ascii?Q?PLIrMPBoNjnk58wQZq1udw+ZZgHR/LTAclIyVbq4hP5msSgbQLUTUDYovoWt?= =?us-ascii?Q?7cxx8A0uRM1/Ju74F67WxUEs8KRprQ79p2cgSCVLbOwruyPZb4aM3YTl4op4?= =?us-ascii?Q?UcEofWXZ2/OYVL4QfYrOHjFs+oMQs8mC4wTStR+kgng7UnMAJAvg2pgJw+Oc?= =?us-ascii?Q?9h2Wc6XDZQw93oQ0hmXz7pQSIVv/QEH3j1c5iigMyR/VnwPZq26QYkxd+BOP?= =?us-ascii?Q?FXYe3IL6zG6qBVzg3pAKTuJIVHAJ2jMb+6fTWcRAf3fwnw9iMVuVOn76nLC1?= =?us-ascii?Q?rO8FR1WgyQ=3D=3D?= X-Exchange-RoutingPolicyChecked: OVIWSG41Hs17B8faFKlTGc1jBd8DYl63/Sbh18KzK2ESFD2A/yjpICvJzZXl53AtGQpLvBImYez40mP7R1NZLCMuTdfg3eiaMb0H7LAoHP3tz28YvPqochELdHUMrybHASRlBTLwUjYzECIWYuLLmslWzqtNkqABzFp9EqcmyYjM5bNttiYfS2Tk7BQhO6FRYg3keeRHvQ1zp2D3Ip9XLRU7oTjCfIHmGY9jhjSFskmhYSkIiU+lWOf/dTCbnx0JmTMeOrziVfmTpkfHybCka8ofwsmYk5s+Ygx1430PkLSv6kVBYIEO2wXgE8bc7BCaqN2u3ov89/oiik16/vGcfg== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9663a543-7b23-4c96-d1c4-08ded2bea792 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7223.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2026 13:35:47.9907 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3SuBtOcr8Ab2Qqquie7Pjeg9vljzOYBKzkChPutGv1VpAbor9tE15ek3D7o387sv33ii4X4gr1pl76/2N/UWGzlJJqLEkrX3Nir0kiGuk3s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR02MB9090 X-Proofpoint-GUID: WXdaO3_HINHFkPPfNliHwqTCDtkDrGkU X-Authority-Analysis: v=2.4 cv=LYkMLDfi c=1 sm=1 tr=0 ts=6a3d2eb5 cx=c_pps a=Dy1/g0x6RHl9kMZQX3cATQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=_-M8LpHI31CeLmyZm6wg:22 a=64Cc0HZtAAAA:8 a=vefY6h8FAldMTwJ7Zs0A:9 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDExNiBTYWx0ZWRfX0KzhCD12veFR uOwxuE3I77bI7watIKic+ho1AnYLW50MdvRlCaOxERFUarTMyLBdzuEBUnl42LlU6dkcQpbu01u PMaAqLG7jrwtka+tBcdu5C5ogQZmV+DFIpClcCTeb/I7LNwBsctspbG11NB+ioXOjoofA7BXOb2 gBkgbs9PcUU7JYjSspDuRVsdFnm/eb+/K6PdQ6II8yujDtkbwHo/rZbaeh/ZQ18O6geg/3m38Nv Pc7+NNCKdPQdnAW4v5IyN58OBVXVglXZa4OKXIATyKBD011KtilpiGTkij0dnKZGGNF4J9bzxkD zhS4ZVbawcjHKMqX0AgUihM18vtPaKua23TtG2yJf9nqqBiv4sWsQEBPv8cJvLkyO9OH4jvl0wL 5DplqgeQi+/xUlCsaqbgHXEO9fpVdGcEDsR2PI6Y1ySScLBvfPKk9/yuF6ZDCrfBPdFvIkkqDTk a2gsGuTJIH32uORUaLA== X-Proofpoint-ORIG-GUID: WXdaO3_HINHFkPPfNliHwqTCDtkDrGkU X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDExNiBTYWx0ZWRfXzBVNsTzTpJpS E9r3jyKRMzdflAM4/fy30Cq5PvaBg1JqiGBPAdMQ6eIA6k7XfQzmVI7QySY3gs5cXMQuWp8bomg cl7GVTjjh40MoZ+PIDLPvRFx45t9zJU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-MailFrom: chris.riches@nutanix.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: VN254LQT4VTXUXXNQ4QRRV6DV3UXG7TV X-Message-ID-Hash: VN254LQT4VTXUXXNQ4QRRV6DV3UXG7TV X-Mailman-Approved-At: Mon, 29 Jun 2026 11:07:45 +0000 CC: Chris Riches X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Chris Riches via Devel Reply-To: Chris Riches X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1782731441426158500 Content-Type: text/plain; charset="utf-8" From: Chris Riches Ever since commit 3fc4412c6f (qemu: support kvm-poll-control performance hint) introduced support for kvm-poll-control, libvirt has only emitted the arg when it is explicitly enabled. However, leaving the arg missing from the output is not equivalent to disabling it, since QEMU may default it to `on` in certain paths (for example, with `-cpu host`). Therefore, if the XML specifies state=3D'off', we should explicitly set that to ensure it is disabled in qemu. Signed-off-by: Chris Riches --- src/qemu/qemu_command.c | 7 +++++-- tests/qemuxmlconfdata/kvm-features-off.x86_64-latest.args | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index e726dc661c..dbc4b5ac94 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6745,8 +6745,11 @@ qemuBuildCpuCommandLine(virCommand *cmd, break; =20 case VIR_DOMAIN_KVM_POLLCONTROL: - if (def->kvm_features->features[i] =3D=3D VIR_TRISTATE_SWI= TCH_ON) - virBufferAddLit(&buf, ",kvm-poll-control=3Don"); + if (def->kvm_features->features[i]) { + virBufferAsprintf(&buf, ",kvm-poll-control=3D%s", + def->kvm_features->features[i] =3D= =3D + VIR_TRISTATE_SWITCH_ON ? "on" : "off= "); + } break; =20 case VIR_DOMAIN_KVM_PVIPI: diff --git a/tests/qemuxmlconfdata/kvm-features-off.x86_64-latest.args b/te= sts/qemuxmlconfdata/kvm-features-off.x86_64-latest.args index 70b1fb83e1..8c1e238e2e 100644 --- a/tests/qemuxmlconfdata/kvm-features-off.x86_64-latest.args +++ b/tests/qemuxmlconfdata/kvm-features-off.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Don \ -accel kvm \ --cpu host,migratable=3Doff,kvm-pv-ipi=3Doff \ +-cpu host,migratable=3Doff,kvm-poll-control=3Doff,kvm-pv-ipi=3Doff \ -m size=3D219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ -overcommit mem-lock=3Doff \ --=20 2.43.0 From nobody Tue Jul 14 21:23:39 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1782731358281120.14250386276535; Mon, 29 Jun 2026 04:09:18 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 209D941CDF; Mon, 29 Jun 2026 07:09:17 -0400 (EDT) Received: from [172.19.199.7] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5FD7141D43; Mon, 29 Jun 2026 07:07:58 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9E73741CF9; Thu, 25 Jun 2026 09:36:01 -0400 (EDT) Received: from mx0a-002c1b01.pphosted.com (mx0a-002c1b01.pphosted.com [148.163.151.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 82A3D4194F for ; Thu, 25 Jun 2026 09:35:55 -0400 (EDT) Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P3ca8m4140274 for ; Thu, 25 Jun 2026 06:35:54 -0700 Received: from ph0pr06cu001.outbound.protection.outlook.com (mail-westus3azon11021134.outbound.protection.outlook.com [40.107.208.134]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 4f00eymwb6-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT) for ; Thu, 25 Jun 2026 06:35:54 -0700 (PDT) Received: from PH0PR02MB7223.namprd02.prod.outlook.com (2603:10b6:510:18::20) by CH3PR02MB9090.namprd02.prod.outlook.com (2603:10b6:610:143::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.139.20; Thu, 25 Jun 2026 13:35:52 +0000 Received: from PH0PR02MB7223.namprd02.prod.outlook.com ([fe80::7914:e632:3672:30be]) by PH0PR02MB7223.namprd02.prod.outlook.com ([fe80::7914:e632:3672:30be%6]) with mapi id 15.21.0159.015; Thu, 25 Jun 2026 13:35:51 +0000 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=NZjqSeMK+yL6nP2QBkSuQeOX5oosCVHLGbFGxpHKj HM=; b=wGU8lpKIIAiCe0W5vW3XvU9VMeESTfjTPT5GHAgZIIgm0XbknkZXsJrIV RRB45ZJBI+rcKvkwhDwxz5xtJCzQlDeZWS0tLM/AAOcQrDACwX5kLtfBD0QySrIv U82LbOZY2kbgFDPJu2zGTgbSuNx75SknvBkimotgEwkzFa7U5Pt3d3TFYZmp0RTg Y5ODlTN8qrZMC1dAhaZ+Ga0A4RSV95KPa02uewkvWJgOd7d9FdeCvbvxMIOp3036 +03RNcouOXKoWOZSMhYpke4w1gVwCexSPAVOiiMLlsPXFoYoLDvfiqOBvxlrQWXn p5J+ubWokSTBNH+YU++oC6SEi9hyw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IANYQkZQW0EmdCkGH7+HyrHGvfKc3GVHclblJxP3vSs6TowIE20HYWzhCfuH0UH4tu1PGtCJMk88XbvXDD0laJf7ynsX0mHX7A5uetC+38/e1oEAN+Kqfm3GRjJH9SZznpg2476kchrASfi5bMrrKnGi7R+hQwc4DObXcSIkngqHy7V8hcJKgTEPF8isJ4M6iXVnA5RC242/Kb2/gax+wr4p3gxwXVfAvlUsQEUQK6waRKYmc1HEO+CTlXrWv0iOtzo3eQ/potBn6kS0HS1uDnBvpTc9FnaKw6SP5Y1/AnohxB8VK5pHug/HQbPVDyDsn0mJX+ojpc2nFkc4z0MPtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NZjqSeMK+yL6nP2QBkSuQeOX5oosCVHLGbFGxpHKjHM=; b=uJ+wkJCKfLFlw0M0DPvzk+kuf+n0rvsOTrWfKUpnY34dVRzhIorOU7xSSxKvi29uXGguN63b2Kf4AlwpTWlzvA8lr2k5Ljp/K+UejbxP55YBuazG4eqvY4uUHFXDxEYx+ver/zMcPIz65g2QxQp3Ee0wFBndN299zEI8jGoOZihXuaDTR72dWstcZ9LnVpZ4zLPDhpo/oW8rNVa/5AzhJCRiEfjfcNWb/gsAkc9pvU13FaAa0LJbK/0WsOvSW7DPx8Jyd5WH2eH1q3hooGi917uY5CpHefJNhJ2KqKfddzoBKsZzPCQD6m4bRC34/omifQwtX+7Fw7mx5NyP5Ha88Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NZjqSeMK+yL6nP2QBkSuQeOX5oosCVHLGbFGxpHKjHM=; b=DI6fgZL45RczYAct5F0xZ9LH3IhYTnrLC0OIY89het1z90KDXcIQkLfT5fdT1HQYA4ILrf/eFneE4w8cCwE4OdQzEqpxsJ5mi3pomn3lqybfEsUIB8gF+ODcX0M7gWOppPMZ+Q7s2T6rctJqpjtU+kzv1zZ9VJgWoyKtt0bj/rmlMVWRyifLKVnoO1pyjwqa59408q3/EufxWFjLwVvSKZ7YkJuZx3YreBjYGvpPMXnufeLU07ZVIggtP2jVGepjmfSWlmeltk01NEhdPkWchxyppjU/AgFelkzjYljBN1c1m4Ua0JeNEjgEmFsmC+yhuCC/U2+7p2yNDNd9H/66LQ== To: devel@lists.libvirt.org Subject: [PATCH 2/2] qemu: Emit explicit kvm-pv-ipi=on when enabled Date: Thu, 25 Jun 2026 14:12:23 +0100 Message-ID: <20260625133523.585764-3-chris.riches@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260625133523.585764-1-chris.riches@nutanix.com> References: <20260625133523.585764-1-chris.riches@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: CYXPR02CA0068.namprd02.prod.outlook.com (2603:10b6:930:cd::28) To PH0PR02MB7223.namprd02.prod.outlook.com (2603:10b6:510:18::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7223:EE_|CH3PR02MB9090:EE_ X-MS-Office365-Filtering-Correlation-Id: c4d0e5fc-c8bc-41bd-cb91-08ded2beac36 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|23010399003|1800799024|18002099003|22082099003|3023799007|56012099006|6133799003; X-Microsoft-Antispam-Message-Info: FOWr0GrFXeVHU/mYo4hrQUbvQNhBhylnO/CAxmNMp5KfHfC/GBHzM1q1vOyrdFxhj1mzBqHw5Z1mOx0fNBbaWnmL/iaF27OQ9KHMJCQvOW6YsL+O3PqMAYqzMnVrbUKbWJRHQ2S23RmSFYqY5GsA4rS3OwFDB1ZlNktZTjn59qkzUvJFB3MdbFMYWFIWSqSu3rn5rjmy4H0Cd5yLMKpJ9ExRNmj1eP4qNNnibKJWaP780RKbmqs3Eu1bTlylHKijuGCnKxtsMVlLU/cyq0HKR4osMAUqtSVGb0I19b0simCTOii5W5gFqfbbgoCJh2et61pPNrWUd6OPLck1dZMSbVZK7Fzx1+u96RA24tEeptYZijmmmmi6OeOMnuZuUvpUZGJ9Td3RlooVYRfJEDhZJtm7+K8UppLWgxvC0+sNnWTG22UQKEszriRDaQx5lHCv2PskYHT+mEUS6wpOvLlqsOtEWwqT9u9J05la5kXnCqhcMNwstkyaYnU6Tj1Fx49BgwOvfxQs2mlu0qzVPbyYZxXAdbIVAZw+mx+4vSyYBu0gpZJC+MY9Iase7ozDcmQDZS6YgudzcwYeZaqnhq7nBPXe1GYGC/Z3GhuLDJydXpW/Q4gdp0G/tFm3EFo7dJnueWT3dGQaR/pfGblcAAuf7sZBkFfT57ZUeQQ7zlDTS3c= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR02MB7223.namprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(23010399003)(1800799024)(18002099003)(22082099003)(3023799007)(56012099006)(6133799003);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0TTGWAmR3bGkmndr36FIAkG4g3dfAhJytHRnnKFQe5w8pjRswCXiBVY9ijWN?= =?us-ascii?Q?Fa1v5EO0NietZ4Veu6VCr2FRqa92nMI4SEpEOU4nO8dp8IRKGDowwsdUsn7x?= =?us-ascii?Q?3Gsz1QJGUeGgl3LhOM9BW1emq7r9lqKpJWE4mW5xnZXsTrn02Eg7R+zaToCA?= =?us-ascii?Q?cvD1uWzsEJas2pPATkiq2WygKy7GXhFcBtZayGmmBGsJBMMuEQDlolGTSmKL?= =?us-ascii?Q?IGHXDDSyTl1yR+bcDcTfTC050ANPWizvzGIVONEuT5j6m22ahBgZzgDM7XSD?= =?us-ascii?Q?jvtgQ3iHLJNls1jbRUnI+JjCbttJpH6aDxwmSB4Zc/q3wJrJ+d0CaYvgQSW/?= =?us-ascii?Q?UyrdUfHHqqZocIBfiIBzscuXkQcyYdMey4/VrVxdz8PPQVFNpxCPpN6E2X+/?= =?us-ascii?Q?KeRIGigFoVAQb6zW0GxlC97q7xNnjGhEaWkcJRVi0WSB2nqgov+aEYNZs9dW?= =?us-ascii?Q?e0F8MNLZRuuUv6S36DZEVNL4jaBhYq2AeZegx+pN+AkiOB3404dJpE2a3Omg?= =?us-ascii?Q?zUalK9VMQS7K7Uo3/u+8UXyAypVd1Jp1jzrXCucJBaZx2ME7KHFlv1hakUY/?= =?us-ascii?Q?+NXEPIfpzwjn82ToTMw8BFK5pdJi02+JCHQp8wQSWAnI9AXtI74LVtv+AzDr?= =?us-ascii?Q?UYhc8JfFq6Ot3jzzWLKnB5/IA4NUvIlMssI3kPbce/Gd0CYYd24CH5UjB5L0?= =?us-ascii?Q?XNLWwRmN8YxFepN4dBTsV6Uca9Eo3m35wi09CG7YLYBnJ53nsCjbLuOWuL9i?= =?us-ascii?Q?SbxMoJRHFfQuozwT6G/YZLUF4aqECX+/v5IodHgVEcruTE/Ujgz0UF185ry/?= =?us-ascii?Q?0uxRJ5XUnKXGlK8+ur5if1gYHASsSueLSgvHqRoYOBQ/qyo+0yBN6JmxVN6p?= =?us-ascii?Q?OAeAHuHDGdWSBVFx+BF1c1sjOkNM7NKzI+6Tr6t7NmZ/vADLt3eMaKoUSpXn?= =?us-ascii?Q?7OHzFJh+pLS0hKlJ0GM+F9Ap5kpHVts6AjPeCeM1Ozchxk3lSQvlvW/2kDPb?= =?us-ascii?Q?9wrcdnD4cbcrh/IgFzTOCqZKbAB12HLGpzMBlpb6oAv92gLJ60L8MRXI5M+W?= =?us-ascii?Q?wi4IpSjsrJ7Dpof9i/l4PQxQVLBcxVKKjwUtiS3wqf0s3ScaHW8o4zLVy//U?= =?us-ascii?Q?c1qCgeUPVlrNJXXL7q1MFUBZxAmuJvODcJrmwgTRfP8WB8bXUqI3h33AU89r?= =?us-ascii?Q?p8Qtm390GICifPxXC5CVy1RUROYgK76yzBZEGHsILdwy6lVNrIpfJK9CYhP0?= =?us-ascii?Q?PR6Kjg+Co9mF3Vo4XOElk81PMdJbh64llKT0b3IxKlCcAB5EREOUVy8xSHB2?= =?us-ascii?Q?/ggwxkAMrkBPIVS+Vf4krGkoUHKsJlhFpwARnpbbWHR5ve24smXJGy6MlN64?= =?us-ascii?Q?2qzlGq2LFaGig6Szczp7vVD6Rrfbx/u6vFLyHZdBnqaDe4Eq7DUgtUhpyiGR?= =?us-ascii?Q?sKX6F4870YieoMYZGROBxY4U8gX61zWdcdhozy4wTwjt5fF2qn0hliEDqJmK?= =?us-ascii?Q?UDvtCAVt9WlNF28FYD4/DrEzYilOGPG4LAvKotueHClFp4EGlF9ImWAWH0uJ?= =?us-ascii?Q?6Sd5t/ycZ7l0YKEPipmfnS+i3wuUh5yIoR4N/1RwsENI55AMlSdfDyBQZAdA?= =?us-ascii?Q?ilFEc4dn+vYmJMZPKVkXAbGF5x8GBM3Qj1e6rsPCuCFdQup92EqaJKdRxxar?= =?us-ascii?Q?4+0cSsO6ewzYOpnACijnSmFMYGJJWp2Bn+phWWjR7As5zguHxYy3Br+TmaLp?= =?us-ascii?Q?/8NTuUWGBg=3D=3D?= X-Exchange-RoutingPolicyChecked: kflSgLce2Hc9M4tXZD/NqW2Jv5sw37Rmji9QZo/xiChz1/dyXCM8ONX8F2OrR4A6XAYKQgq69Hz7el8ubbHNpwrQ2yK7yzmD68Rot1ojddM/ZaivJCQ9uvF7ukbDUSNk1CXj3VlMJv2jEdIZnXFiCzQrMSGxKkrvFPUwUpxZmlEzWhiE4SIuW72iNIa51BCVZdjJ1FdVDnzzxAFAwNqN0nSp138Yn+NfBQlPfqfHiK+Ud6LkHY0lTUOvEZJlj/KkOYxju3nBNGgfIN9qv9XRi430VLeCq3ENywoMBxnkVw6hhW5XkaXPEtWsFT1UGe4PGoWIxbc74JX6rwXIv0OQGA== X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4d0e5fc-c8bc-41bd-cb91-08ded2beac36 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7223.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jun 2026 13:35:51.9058 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZcZZ7WSFwl3avAG+YRcKaBAMrgF8K6zyA3/6tqv5BSFbKGQgcqf8jLQWl4QmOj0IS1QA72zmzD+3YdXvIZ0LLr5B9WzPSDtjATiKcSZr1RY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR02MB9090 X-Proofpoint-ORIG-GUID: 61HUxz32OfHr52YNOP1usxTYk-ltKZoh X-Authority-Analysis: v=2.4 cv=Ivsutr/g c=1 sm=1 tr=0 ts=6a3d2eba cx=c_pps a=FeeVHR8rqpo+Pf7fuAv9nw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=FelO9ux0wxsA:10 a=0kUYKlekyDsA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VofLwUrZ8Iiv6rRUPXIb:22 a=y4UcunY2MAxhM4LwGdWI:22 a=64Cc0HZtAAAA:8 a=YLrWDD_h0TXL4whhMQgA:9 X-Proofpoint-GUID: 61HUxz32OfHr52YNOP1usxTYk-ltKZoh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDExNiBTYWx0ZWRfXyoGFKlm56Vvs vx/Bv8UTW3WffLdlxAKci48589JJYsKA0T2lgtTYSV9dVZniS5hw3k+OK4JUQFMvFiHODJ8qfS5 va0JQ1ZfDW+sAACHbG0Z1YlmUjFyrjpzRuurPijc5byyn+ze3t/ACk+7dvdG37vyvygRa/vwmnZ xWAdJ1XtzJO/4eY3h7paSkDahQzveDfcJ1dNixyVA9A1IjfouSnFm163GbFGT1cgxIzqOt4wDzb A4l4eRUBr4fR8Tro8pTMIa2IyTTF567tRXmAKLTbxnpPF7DkaIdhAmIJCkblN9qDKnq/WCQVnEG ZBlJ3y22mN+mk10mZ/y9fwhow86Geo68xGXFzF7l66pTKoA07A3/s3uAAEbTlToLurFY8+rkJZt IFhajK39lvvzolCMj0LgNIrdc0u/W0W/nnKHGWsIYrwa7Hy+RuNJ8OJHvsge484jy2R6jVToQH9 pyXqmAsknhbK4HHfF3A== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDExNiBTYWx0ZWRfX/vxDaZHteaN+ nv3C2ePL+g6l9BIPO7Mt5rT12AVMTaOHNmZFFe+OmQwmpJC5kKDSeT3sEHgqC/Xfu9tk1FTpFnX KCTdwMjz+rZXrbD7GkYpu+9YFmJU/gU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Reason: safe X-MailFrom: chris.riches@nutanix.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: AKXTZJBY2WI27K6RICDKTA6KPKJ45IDY X-Message-ID-Hash: AKXTZJBY2WI27K6RICDKTA6KPKJ45IDY X-Mailman-Approved-At: Mon, 29 Jun 2026 11:07:45 +0000 CC: Chris Riches X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Chris Riches via Devel Reply-To: Chris Riches X-ZohoMail-DKIM: fail (found 2 invalid signatures) X-ZM-MESSAGEID: 1782731358920158500 Content-Type: text/plain; charset="utf-8" From: Chris Riches Ever since commit b2757b697e (qemu: support kvm-pv-ipi off) introduced support for kvm-pv-ipi, libvirt has only emitted the arg when it is explicitly disabled. However, leaving the arg missing from the output is not equivalent to enabling it, since QEMU may default it to `off` in certain paths (for example, without `-cpu host`). Therefore, if the XML specifies state=3D'on', we should explicitly set that to ensure it is enabled in qemu. Signed-off-by: Chris Riches --- src/qemu/qemu_command.c | 7 +++++-- tests/qemuxmlconfdata/kvm-features.x86_64-latest.args | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index dbc4b5ac94..d1e4e39c45 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -6753,8 +6753,11 @@ qemuBuildCpuCommandLine(virCommand *cmd, break; =20 case VIR_DOMAIN_KVM_PVIPI: - if (def->kvm_features->features[i] =3D=3D VIR_TRISTATE_SWI= TCH_OFF) - virBufferAddLit(&buf, ",kvm-pv-ipi=3Doff"); + if (def->kvm_features->features[i]) { + virBufferAsprintf(&buf, ",kvm-pv-ipi=3D%s", + def->kvm_features->features[i] =3D= =3D + VIR_TRISTATE_SWITCH_ON ? "on" : "off= "); + } break; =20 case VIR_DOMAIN_KVM_DIRTY_RING: diff --git a/tests/qemuxmlconfdata/kvm-features.x86_64-latest.args b/tests/= qemuxmlconfdata/kvm-features.x86_64-latest.args index 8221fdb16f..90d3ffba55 100644 --- a/tests/qemuxmlconfdata/kvm-features.x86_64-latest.args +++ b/tests/qemuxmlconfdata/kvm-features.x86_64-latest.args @@ -12,7 +12,7 @@ XDG_CONFIG_HOME=3D/var/lib/libvirt/qemu/domain--1-QEMUGue= st1/.config \ -object '{"qom-type":"secret","id":"masterKey0","format":"raw","file":"/va= r/lib/libvirt/qemu/domain--1-QEMUGuest1/master-key.aes"}' \ -machine pc,usb=3Doff,dump-guest-core=3Doff,memory-backend=3Dpc.ram,acpi= =3Don \ -accel kvm,dirty-ring-size=3D4096 \ --cpu host,migratable=3Doff,kvm=3Doff,kvm-hint-dedicated=3Don,kvm-poll-cont= rol=3Don \ +-cpu host,migratable=3Doff,kvm=3Doff,kvm-hint-dedicated=3Don,kvm-poll-cont= rol=3Don,kvm-pv-ipi=3Don \ -m size=3D219136k \ -object '{"qom-type":"memory-backend-ram","id":"pc.ram","size":224395264}'= \ -overcommit mem-lock=3Doff \ --=20 2.43.0