From nobody Wed Jun 24 21:44:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1781326992; cv=none; d=zohomail.com; s=zohoarc; b=n/T7Iu+jJgkGCRw9UiC3Pn8tHRLqfH8u9c1SlYzx5xhiGK/Gb8UMijKgz2EAZay5fK0dizveiFO2Tpdo3QU1xidcq51BuWhj8uFBwPHkX/VD50AQn5Ki+xhlGG/II00mDdhfvkqUN8YV/dFNV5/FefSscpnfv/q3YApaPzz1uPU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1781326992; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=ZXPjBdMD5sgAnIeQJV8WV/HAWMOLRvbbbm+ZY55nnp8=; b=eIj3Pxy8Hn9nPBULMNJ8MPK2j6ZX8kfAj31IxUR20RbmUlUniuwedvgn2N3osXHBwfS0grZu7c7DHY1orF/iccOdVLhZv6gvlHYHd2epW7xA68UM9qJu0Hwvsd1L61hNiqStZePlLDRi66XvswNsXhgSXC/O7RGa1p8R658D3sM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1781326992572584.0477330478524; Fri, 12 Jun 2026 22:03:12 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 143AE41AC9; Sat, 13 Jun 2026 01:03:11 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5715B41C7C; Sat, 13 Jun 2026 01:02:24 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 40EBE3F899; Sat, 13 Jun 2026 01:02:16 -0400 (EDT) Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4C0AE3F28B for ; Sat, 13 Jun 2026 01:02:15 -0400 (EDT) Received: by mail-ej1-x634.google.com with SMTP id a640c23a62f3a-beb44f97561so222447666b.0 for ; Fri, 12 Jun 2026 22:02:15 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb8b23f84sm185558966b.51.2026.06.12.22.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2026 22:02:13 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781326934; x=1781931734; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZXPjBdMD5sgAnIeQJV8WV/HAWMOLRvbbbm+ZY55nnp8=; b=MgX7XMxx+etsDRoO+JXYuSA5uB/lDDZ1fHhL0QLNH+mxK+SVDpJrJdJElCp2I1yETd lnzfELaTvf0zZAdaxvRXXG7gt3gk1W5CfhwF1zuty6lw/dayJZSY4Xup+cc+17v+Ryyw MGxWC3ecGvLUXAg0z9seIKnNJtTRe+WzhpkE0FeGKoknlSilOO93V3V/L7ECIoZosQ2d peBv8xVa7CkiTq+aMoB4beEs4PYxO3WZTn6hLKj8vfq06RG5BqvFfSFmbFCts/vlDwZx hBAtn3C8DiQn/lWa7f6fbAGX/1F/+3RpXWhXRxcy3DDMtsaq3yUnHXQFEVEbq+hHdjrx aXpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781326934; x=1781931734; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZXPjBdMD5sgAnIeQJV8WV/HAWMOLRvbbbm+ZY55nnp8=; b=gkXSIF8i7lhQBAs3gkiQA7XY8cflT78eXQObMaJ39PXIuGEACkfg4dpUfGubBChqu8 QZK2P3+R1x0hJ/m8I3oL4j9en9/K08PundW/3LPVDQGdH2xSNlssGe3bkszwYKxUGlGs xV5bqKRpgPs0CiUatpuN6VF9AfQ5Ne0EYaiLvtBuKRkNuSfSiffs3JqWDRDcgS8WULEs mMlBWyuUFCDBw4zOU0kl3lHRfcBKHNm/q5rbgzwZvJ0UA3gudRac30jQnc4End3+0wtt 0HGfNdIiW1J83xGxqXwuYR2LVg5mLyPkmstnQjOTItZJeudGVHJw9LNXM4zB0+HZb90c Tqvw== X-Gm-Message-State: AOJu0YzV6bYXKI/io7ZNOUnkAdkIzxamobXYIzeMRJyc6Ap2WAeAqG8+ zCXLZ8X5itW0QpwBozR130djuWF0/fKlsye6BM3dwb4kozwoAdnppQb1EN+UAc0i X-Gm-Gg: Acq92OGJElZ0lXWeTy61MJDz9BnrscUEY9vXCpSWClyGRYsf89SsqF7sEzgsuf7hCpy a+X8jyAHfbcmUI0vGW4ZAGfAYActOPuWNa8pvSHrUFIALHnW0XM7Iyrlatl/u58qHRperQXRDjb qF/7YUYKhTznBKyLkYy4qyqKIa0HYTRkgE0TKBnP50kAe5rNqhz9FntWD1yDUZjPy/aGh1e1eVC /4rdX8cGdbxBf38KoMhJKuzeuvxNBYme0ruRV/ij8rYKLdIZ3KCXS9uuYkrU/CThG1dOMQA6r1B wIXzSCtSEe1mty3C+/4xz9KMIkmMLZsYn2WzAxYSJ+kDOBhDalHMAZo/aEUtTggJcZ1QL9gxlpK xZ+kIq5o4TMdTUzB6bdWnVYH9iTvxBX5L36aVb4sjKBmuMg7JnpLRQrBcdZ/S5FuH/BVgKca0vL ZOpg9qlnlVzcIs4Go5PnW/mPKjFr1hYGROaEjw/o1FPKXWpBpLq46TW0lOFhGPVEho4V/us9mC+ lohiBz1qB6vNFyark+l+/WbQ1OWcpLCOV/t5w== X-Received: by 2002:a17:907:266e:b0:bfa:f563:9294 with SMTP id a640c23a62f3a-bfe2890ba61mr170404866b.18.1781326933531; Fri, 12 Jun 2026 22:02:13 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH] qemu: use proper job type for qemuDomainAuthorizedSSHKeysSet() Date: Sat, 13 Jun 2026 07:01:20 +0200 Message-ID: <20260613050120.61453-1-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: APYR2CNZ2U7BERZLPWU6H2CBRUTWMCSC X-Message-ID-Hash: APYR2CNZ2U7BERZLPWU6H2CBRUTWMCSC X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1781326993051158501 Content-Type: text/plain; charset="utf-8" As the qemuDomainAuthorizedSSHKeysSet() call modifies the domain, use the VIR_AGENT_JOB_MODIFY job type, not VIR_AGENT_JOB_QUERY. Signed-off-by: Roman Bogorodskiy Reviewed-by: Peter Krempa --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 544955ecf9..c3eb209f70 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -20375,7 +20375,7 @@ qemuDomainAuthorizedSSHKeysSet(virDomainPtr dom, if (virDomainAuthorizedSshKeysSetEnsureACL(dom->conn, vm->def) < 0) goto cleanup; =20 - if (virDomainObjBeginAgentJob(vm, VIR_AGENT_JOB_QUERY) < 0) + if (virDomainObjBeginAgentJob(vm, VIR_AGENT_JOB_MODIFY) < 0) goto cleanup; =20 if (!qemuDomainAgentAvailable(vm, true)) --=20 2.52.0