From nobody Mon Jun 8 06:38:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1780729530; cv=none; d=zohomail.com; s=zohoarc; b=ataWCgqTNNO7p4uaJynZ2Pap+CNNra+YZv85D3WM6OLhu8LNJ8tif63zOPaPgsVg4typvpE5xPGtE7uq+PG/kn8t32QIGk+0Z7fc+GeDrJ0NNn5XD+Z7s6Kc44rKFTz1KMb1IrNaTfK292w57CSLgr8muRS1lrGvkwAAWy4y6cg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780729530; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=L3EiF7poCoAE6mWacLoirT0lhOshEUsOZHoEEDTOhSs=; b=I5R4M4apfFZ3F5wpAzBVHA7z40CpNy2ZoQneSODudGhi87hgKcNjx5+eKD5YFQirBQb3LkR8IUgazXaNlztmRNOKH8vop5xXP84T+iamChTY7GgTZha5TjTtDLj5J589QNIuSpp4LPAiOuWlrWAMiKZL3ll83fQk12iJwlNRed4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1780729530760683.6900338006691; Sat, 6 Jun 2026 00:05:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F22FB41B41; Sat, 6 Jun 2026 03:05:29 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id E041541D55; Sat, 6 Jun 2026 03:03:40 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1A48941A0E; Sat, 6 Jun 2026 03:03:27 -0400 (EDT) Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8B5A941A96 for ; Sat, 6 Jun 2026 03:03:26 -0400 (EDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-68d23430690so5486305a12.3 for ; Sat, 06 Jun 2026 00:03:26 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64e29c0esm4693333a12.7.2026.06.06.00.03.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 00:03:24 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780729405; x=1781334205; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=L3EiF7poCoAE6mWacLoirT0lhOshEUsOZHoEEDTOhSs=; b=L45VPqdD/Jcs3bdLMkhBmSlKi0yUqYTnYhnWavvTIWGRvqmDcAz48L8i63wxNrW50j 9/YYSEJ08kLy2TaNmMXiHpKtNUu1uHXO9IwB3BwuyrC68X6lTexSoiHQ0Bev7AnUPQIs egj0hasVilLCuyOW7gxB2GU5QhGzWvS7PO4r6hIKXyKkJFjvjKWT2vhwrgWWvLvu5Dly 2iHeqUFuWYRKUl21zYq5h6cPmdBMVtTk1twUIDgzXN+r4c8xMUQ/oow1K2KqjHst2cUI vi7McnNjlxd/eURTTsjYKvSTJ2R7d+MtDDGY3eNENQrFBfZkIfVqWYRC2m8x1CEys0nz RnFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780729405; x=1781334205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=L3EiF7poCoAE6mWacLoirT0lhOshEUsOZHoEEDTOhSs=; b=WqUwFDB1K0iX2jhWdh6F9FOo5v2x4jLC2iEz6kqfhyRJCan97Vqbl8ZHnaTDkHBuan kpONzzThhZfGzVySuNuM1jnpddeYGcP6BlccaAH5cj3t+WjrrkRvDmECOGwf0rbrYmlF geGT4G8woeEyioc0wlddHit4HvS3VWoqOkj8nbJrwDgThmUahx7Jr8euTO3Cje+dDdiD wzhqtzgBNsYiz47ygp2tXp+pKRpbEe560CwfRUJ6Rx8atqbSVVZELfiKBRPZStGYotGb mhsM0/Z/XAJ9euyYtjy9EyPNh3PJ2YTGxz7vfzqZhngr7KMMqn0T75AOGgcwqUoj1Fzh AAlg== X-Gm-Message-State: AOJu0YznK11Yoslj8Ag9+BlxmPuWeAdPOTsJs/Gw5GXcGqSMGYcJny3o CzZjuyy3u/2tbcIg27PQoHRmFYkekxTZC+vdRxejEAWm5LHZGuvDiDhbpvdYU1YT X-Gm-Gg: Acq92OGq1SsoM7XQZBpGR91vnKtYASmm8lr5NuY8ujb6xkbdc2NbyexQWigNDNwDm3C yD+hcv429uxQvo2cu9aKlSCVaIsvyYU4g4cAXIGHheg8Z1mOu7rIe/lu7pMv4tyKCfOheWxR3qn yF6n7GphCyqF0O7SuyxLaS09s0ICwr69nGhAcw8rIRNTuAKNTjeqHM9OKVzMCoC4ff9xbdhrlRL cNGc2jQc8IGfBR2X7eO1odM2bOpHOrJmxDL7cOyzBG70AVbXieC28LFCnhH9JlAQKeK26h1B5DP bYJv1MTtMgbIlIt/kyLHmRnG36Je7wA2vHh+sDBq6gPIc/I7enaOXBycQVUjpm7Xs5aZW1+WLNc 9JNEGX6GXw9OOgpyaaNotFIYGs9/MQLlHDcOE5fDIUltsbDaunqRojp3flXU5/d2faP7NEX5gCR ZpPmNZrIYBbae+9wAGKgxvSUl+bGvNPV8PgSzEqxson6eXVwWhaR2ZY5kGP4oEmD4QeXBwqrmaw S8UjhEAj6WwrLzp5wFKyE3mS04Rcn2MuyFFTffLx2RXOu/b X-Received: by 2002:a05:6402:518c:b0:68c:627d:fc2b with SMTP id 4fb4d7f45d1cf-68fa5039e51mr3535609a12.16.1780729405161; Sat, 06 Jun 2026 00:03:25 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 1/2] bhyve: process: properly handle misconfigured agent Date: Sat, 6 Jun 2026 09:02:57 +0200 Message-ID: <20260606070258.89961-2-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260606070258.89961-1-bogorodskiy@gmail.com> References: <20260606070258.89961-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XV7E5E6IKDIWJN2QU6QOKVHGKFALIBSG X-Message-ID-Hash: XV7E5E6IKDIWJN2QU6QOKVHGKFALIBSG X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1780729532936154100 Content-Type: text/plain; charset="utf-8" Currently, bhyveDomainEnsureAgent() returns successfully (with 0 return value) even in cases when the agent is not configured. That happens because the bhyveConnectAgent() function does not fail if it cannot find the agent configuration. This might result in accessing the agent point at NULL. Fix by making bhyveConnectAgent() failing if the agent is not configured. Additionally, only call bhyveFindAgentConfig() when the agent is not configured to avoid unnecessary checks every time the agent is needed. Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_process.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/src/bhyve/bhyve_process.c b/src/bhyve/bhyve_process.c index 92665419d4..e92bdeb416 100644 --- a/src/bhyve/bhyve_process.c +++ b/src/bhyve/bhyve_process.c @@ -243,14 +243,17 @@ bhyveConnectAgent(struct _bhyveConn *driver G_GNUC_UN= USED, virDomainObj *vm) { bhyveDomainObjPrivate *priv =3D vm->privateData; qemuAgent *agent =3D NULL; - virDomainChrDef *config =3D bhyveFindAgentConfig(vm->def); - - if (!config) - return 0; + virDomainChrDef *config =3D NULL; =20 if (priv->agent) return 0; =20 + if (!(config =3D bhyveFindAgentConfig(vm->def))) { + virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", + _("QEMU guest agent is not configured")); + return -1; + } + agent =3D qemuAgentOpen(vm, config->source, virEventThreadGetContext(priv->eventThread), --=20 2.52.0 From nobody Mon Jun 8 06:38:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1780729580; cv=none; d=zohomail.com; s=zohoarc; b=lyfJhx/ElyX2Kce5+X684CLfujUHeRm8ngaRFokr2HfxDowad15i6knwICOBBx1IG2/Ke69yih4Eu+ceNmB0Vv4h2hGGuqlKbQ6FW2q8ZEEf5HPFImcrv+OQMYPA8hjvUmmm+eub2qrVxALb6w0idjm1HnSS8CITe86LltosgVc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780729580; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=EgrHYqdHqVDRYDg8k7lR1MnPtMakNK/8yXJufv9okGk=; b=Sc1BxIgAFpvSlyO5kGKsM3zRlqdSoBD8xN0qvGfg7oGEiHBaQXJgzYik5Ql+vLGpeG2Au1sld/+SoyQiVejpqCAqbYgLWCjfwR50H+cJBpHCtxSrCZts1+Si39K2HR4zSLlZygo2n7TGrgwyhhoQtYCo1o69stdAOgt2HjQXzZE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1780729580088329.964553866248; Sat, 6 Jun 2026 00:06:20 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 62D5241ADA; Sat, 6 Jun 2026 03:06:19 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id CE75C41BCF; Sat, 6 Jun 2026 03:03:45 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id F20C54184C; Sat, 6 Jun 2026 03:03:27 -0400 (EDT) Received: from mail-ed1-x530.google.com (mail-ed1-x530.google.com [IPv6:2a00:1450:4864:20::530]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 3B0EF41A0E for ; Sat, 6 Jun 2026 03:03:27 -0400 (EDT) Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-68c76fb8009so3330291a12.0 for ; Sat, 06 Jun 2026 00:03:27 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-68e64e29c0esm4693333a12.7.2026.06.06.00.03.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jun 2026 00:03:25 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780729406; x=1781334206; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=EgrHYqdHqVDRYDg8k7lR1MnPtMakNK/8yXJufv9okGk=; b=ArbKT04wmzfmMc9rTGgxcYK3HCrUGMU0S/8g4d2yIX/8lKoKxQ4/DUWzT9SbLejwbZ AtdNFftc9vb3llCSnXYBvFit5+OO0ah2VVjyVBePqkFuR7vIUxG1Yt8LpqGFcnRm3eyU gOb3l/3gsZ4ULOSTCTj9MwOfhm8w7wGXy5H46pPJ43FbDUFvGKuIv6bRrkZyiowQFaKz jA5DfQX+Z5yCQUpvUAuCWxmLYncqemp47OF7wkIENT7bXkAcewhn/Gw5uOmoG3YaCn23 uAJnNkiwnvVstyAq5UXz+uNvbY6Qm5oTWqj/k4ugKv17nPOY5+XUGqBiM6Xua0bxx/1w 34Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780729406; x=1781334206; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=EgrHYqdHqVDRYDg8k7lR1MnPtMakNK/8yXJufv9okGk=; b=GaEKBdkCAIwThWLu8TmTj82VCpXa7nc13EGBKXmdAaG0Mbk+x45utbNYAIvstvYCfL zXNjFngoF07OylbHW2aAir82vqHGJltfY1Ah6NkaaU+ybJue5R4pLQ3gGwVbdVpWJeNh DFOPiND4vhT6sxsY6MFu5VtkxmWDxWfih7cGzvlw3+eNpArGuyIVRDZiNTiH6WFHhM5d ZLQKQdGdpM3jBNOOJUlEL8wDx3g8NGk3hWaNdr/p2/LZHr0FQgtdcWCSadyB/8uyow1V AXAX6nl7c1MHMMPoFBToxY8cLACKM2hEQ2AObCv5mIl8W0dhU3w52VReEhzLB4026XlD zArw== X-Gm-Message-State: AOJu0YyuUhjO+/FfQ6i6/HZn9xq1frPPwH3412o2cnHqSjSYUGmCG9Rk J9LxSunbFEANlbheRfjUlnLcotPy0nZXLmksBU+CShvmZZ+UVIyf3MqeO78cdV/R X-Gm-Gg: Acq92OHqoyAJN8ju64r3MFlgf4KmK5Z9RklDVmTDNDH/9+GILwcez9dTI088jO9CHU+ rW4N+aXwRnv16tKsqPpONY3wAINSWZZvH5ONs7N3flbxnLCNm411bu1RaDHqHNxL74KsBRNyG5u jcVxJj32e9FYtNHTQ/ampw4YhG/D7TyIWdnq5qduEO/76pWFTSdsJYrlhqxsUeiEmtbXALit+qc 0tVDoNkF1EQm89E1TkZoszNXoP4sS7UP/LovAEKzwm72H8sCjt0zoFp3Tv1XKc+/vEZwBekCb1w fmhlcizP4cCUhtt4XguHCzkymxrTQRxZcHSGErLu8tZFEGp92TRLeC+ABZM/B56WfET7HwQOfUp MmjuTrhL7bmgVhcYDaqktc7z54yXr35vtP5LqI1rQ+2PiYYBGpmK/BJDP/KZ6QxmlSke4wcKtSv dkt+uRiqYoeeuI2x+ZOH8cTTgHgmschXPNLE6GurkkbSk/W3DAdMB3Xe/aNgJdHapA1/tKpGild EAsd/YzehZ9ILZaA6yhbS9n1qw/d+WT9EhTx+BgCEJeWRyl X-Received: by 2002:a05:6402:3987:b0:691:55d9:fff5 with SMTP id 4fb4d7f45d1cf-69155da0443mr572015a12.10.1780729405810; Sat, 06 Jun 2026 00:03:25 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH 2/2] bhyve: fix domainQemuAgentCommand Date: Sat, 6 Jun 2026 09:02:58 +0200 Message-ID: <20260606070258.89961-3-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260606070258.89961-1-bogorodskiy@gmail.com> References: <20260606070258.89961-1-bogorodskiy@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MEB5VTOCPLLBO7FCADSHJANSJUVLNBKU X-Message-ID-Hash: MEB5VTOCPLLBO7FCADSHJANSJUVLNBKU X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1780729581701154100 Content-Type: text/plain; charset="utf-8" Currently, bhyveDomainQemuAgentCommand() uses bhyveDomainAgentAvailable() which works only if the agent was already initialized. It should use bhyveDomainEnsureAgent() instead. Also, remove the bhyveDomainAgentAvailable() function, there are no cases when it should be used instead of bhyveDomainEnsureAgent(). Signed-off-by: Roman Bogorodskiy --- src/bhyve/bhyve_driver.c | 35 +---------------------------------- 1 file changed, 1 insertion(+), 34 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 2e7a534396..7bd0cbadb0 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -123,39 +123,6 @@ bhyveDomainObjExitAgent(virDomainObj *obj, qemuAgent *= agent) } =20 =20 -static bool -bhyveDomainAgentAvailable(virDomainObj *vm, - bool reportError) -{ - bhyveDomainObjPrivate *priv =3D vm->privateData; - - if (virDomainObjGetState(vm, NULL) !=3D VIR_DOMAIN_RUNNING) { - if (reportError) { - virReportError(VIR_ERR_OPERATION_INVALID, "%s", - _("domain is not running")); - } - return false; - } - - if (!priv->agent) { - if (bhyveFindAgentConfig(vm->def)) { - if (reportError) { - virReportError(VIR_ERR_AGENT_UNRESPONSIVE, "%s", - _("QEMU guest agent is not connected")); - } - return false; - } else { - if (reportError) { - virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, "%s", - _("QEMU guest agent is not configured")); - } - return false; - } - } - return true; -} - - static int bhyveDomainEnsureAgent(virDomainObj *vm, bool reportError) @@ -2060,7 +2027,7 @@ bhyveDomainQemuAgentCommand(virDomainPtr domain, if (virDomainObjCheckActive(vm) < 0) goto endjob; =20 - if (!bhyveDomainAgentAvailable(vm, true)) + if (bhyveDomainEnsureAgent(vm, true) < 0) goto endjob; =20 agent =3D bhyveDomainObjEnterAgent(vm); --=20 2.52.0