From nobody Mon Jun 8 07:26:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1780608019; cv=none; d=zohomail.com; s=zohoarc; b=d7Qc9MjGDoQSp7tFRreGKZXPddH3rBu2mTzaeMdgBte5Hu7Wj46KbrNywF697FHztq6vN4BumtKyJhLYIeoLhWtrgRgng/sDwQ6PsAtFPe+5ErIyZopj15mINRUb5NbL/50PkFZh2CPmxMPL2Jc2PSip0Id5WqsPCVANjebfZj8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1780608019; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=zc54XIANOardcotz5PbnM89F0kVjRG21cniZNzDMvlY=; b=dahTphaTs/70DPCacKTc9W1pOGJEeSNkgF+yEb0pnNMYR7K/cTV5Wy0CHjDrFSL93wEaL05kjZD9cHuSHOSmeB/A1Ez6gUk/XvHzt9FSnb4or+QRSfVWWKcErK/pp1ReBWTqLrqgnsrZ5i6gcQFBbaQqCV6JTwfcww5h26o4/dg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1780608019389780.3103319616482; Thu, 4 Jun 2026 14:20:19 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1344A41AF8; Thu, 4 Jun 2026 17:20:18 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 2E45141CD7; Thu, 4 Jun 2026 17:19:26 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1D88841A7A; Thu, 4 Jun 2026 17:19:18 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 290353F931 for ; Thu, 4 Jun 2026 17:19:15 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-0jpkGv4zNH-uvrUPh2r39A-1; Thu, 04 Jun 2026 17:19:13 -0400 Received: from mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D647A1800350 for ; Thu, 4 Jun 2026 21:19:12 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.80.68]) by mx-prod-int-10.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3789F414; Thu, 4 Jun 2026 21:19:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780607955; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zc54XIANOardcotz5PbnM89F0kVjRG21cniZNzDMvlY=; b=XF9OVzuHclglRTtoX4K+fUKS/Cn/Pd4NVFHdCyE4zlnNXnCakuSWO8+aKBqOThlGf4o8LN KT4qd3WhMVtiyUv6FccMO/hRAX5NiIgwru+mjOUBobsEK0/ArEYo93ZDsduRWDrL1EvWJQ YauTdBNCMcZbZbFMCCXrhKj3RbWI+Ik= X-MC-Unique: 0jpkGv4zNH-uvrUPh2r39A-1 X-Mimecast-MFC-AGG-ID: 0jpkGv4zNH-uvrUPh2r39A_1780607953 To: devel@lists.libvirt.org Subject: [PATCH] test: unit test for qemuMonitorJSONAnnounceSelf() Date: Thu, 4 Jun 2026 17:17:01 -0400 Message-ID: <20260604211911.1942137-1-laine@redhat.com> In-Reply-To: References: MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.6 on 10.30.177.95 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: GU9QFdaAm9H9D_z2fW3BdUWQ57DwQwqeNNWfMtoHVjk_1780607953 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 44UBATLJDKLQSAPRQVGGTJBWCUELY4JJ X-Message-ID-Hash: 44UBATLJDKLQSAPRQVGGTJBWCUELY4JJ X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Peter Krempa X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Laine Stump via Devel Reply-To: Laine Stump X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1780608023450158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Laine Stump Does this do what's needed for testing? (I haven't added any cases to qemumonitorjsontest before, so it was a bit of an adventure to (I hope) figure it out). If this is correct, I'll squash it into Patch 1. Signed-off-by: Laine Stump Reviewed-by: Peter Krempa --- tests/qemumonitorjsontest.c | 79 +++++++++++++++++++++++++++++++++++++ 1 file changed, 79 insertions(+) diff --git a/tests/qemumonitorjsontest.c b/tests/qemumonitorjsontest.c index e34dbad7cd..f59b97c1c3 100644 --- a/tests/qemumonitorjsontest.c +++ b/tests/qemumonitorjsontest.c @@ -2776,6 +2776,84 @@ testQemuMonitorJSONGetSEVInfo(const void *opaque) } =20 =20 +static int +testQemuMonitorJSONAnnounceInterface(const void *opaque) +{ + const testGenericData *data =3D opaque; + g_autoptr(qemuMonitorTest) test =3D NULL; + + if (!(test =3D qemuMonitorTestNewSchema(data->xmlopt, data->schema))) + return -1; + + /* Test 1 - all parameters are default */ + if (qemuMonitorTestAddItemVerbatim(test, + "{" + " \"execute\": \"announce-self\"," + " \"arguments\": {" + " \"initial\": 50," + " \"max\": 550," + " \"rounds\": 5," + " \"step\": 50" + " }," + " \"id\":\"libvirt-1\"" + "}", + NULL, + "{\"return\":{}}") < 0) { + return -1; + } + + + if (qemuMonitorJSONAnnounceSelf(qemuMonitorTestGetMonitor(test), NULL,= 0, 0, 0, 0) < 0) + return -1; + + /* Test 2 - interface device set, everything else default */ + if (qemuMonitorTestAddItemVerbatim(test, + "{" + " \"execute\": \"announce-self\"," + " \"arguments\": {" + " \"interfaces\":[\"net0\"]," + " \"initial\": 50," + " \"max\": 550," + " \"rounds\": 5," + " \"step\": 50" + " }," + " \"id\":\"libvirt-2\"" + "}", + NULL, + "{\"return\":{}}") < 0) { + return -1; + } + + + if (qemuMonitorJSONAnnounceSelf(qemuMonitorTestGetMonitor(test), "net0= ", 0, 0, 0, 0) < 0) + return -1; + + /* Test 3 - all parameters explicitly set */ + if (qemuMonitorTestAddItemVerbatim(test, + "{" + " \"execute\": \"announce-self\"," + " \"arguments\": {" + " \"interfaces\":[\"skid00\"]," + " \"initial\": 23," + " \"max\": 54," + " \"rounds\": 867," + " \"step\": 5309" + " }," + " \"id\":\"libvirt-3\"" + "}", + NULL, + "{\"return\":{}}") < 0) { + return -1; + } + + + if (qemuMonitorJSONAnnounceSelf(qemuMonitorTestGetMonitor(test), "skid= 00", 23, 54, 867, 5309) < 0) + return -1; + + return 0; +} + + struct testQemuMonitorJSONGetGuestCPUData { const char *name; bool qomListGet; @@ -2940,6 +3018,7 @@ mymain(void) DO_TEST(Transaction); DO_TEST(BlockExportAdd); DO_TEST(BlockdevReopen); + DO_TEST(AnnounceInterface); DO_TEST_SIMPLE("qmp_capabilities", qemuMonitorJSONSetCapabilities); DO_TEST_SIMPLE("system_powerdown", qemuMonitorJSONSystemPowerdown); DO_TEST_SIMPLE("system_reset", qemuMonitorJSONSystemReset); --=20 2.54.0