From nobody Sat May 30 15:29:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779522436; cv=none; d=zohomail.com; s=zohoarc; b=iKjrB9dyPpo1Ij+JxfuHBcza+ZCkUUh9L23kAIvyI/ozF4yYB+scjvFQd8SfaXLmqlwyd3uhdZ9zzpEm/Fv/nz/3QezTDQfUCd9LL5H/DEBTU5RCU1KspjKhy/oDGpFGsOSbVpDZ6Kydp1C1alvyBy9W+Gqp850mrSlrBhKmQnw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779522436; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=GrcpdopYuj2UFVye9oP4bgEM0YmAnyS/4eXTcEnjc0k=; b=j9HEkc45pmT7O/peOeAJoj8EBdirx62WxutkfilOOEocKbvzBJ6J+fOtUE0lYgiiWuzouIhcwIAe8MErVgorKwTreb97TazSW2Fs286FeiHTfUTYc16MX4wAFeCibE5igEgrxE9NWcW25eWynXgJdPcRuB51zFLs9AF7EnVK/Z4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1779522436795219.05175614006032; Sat, 23 May 2026 00:47:16 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9281941ADF; Sat, 23 May 2026 03:47:15 -0400 (EDT) Received: from [172.19.199.4] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 315F341BB8; Sat, 23 May 2026 03:46:31 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 73BD741AAD; Sat, 23 May 2026 03:46:23 -0400 (EDT) Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AAD5B41967 for ; Sat, 23 May 2026 03:46:21 -0400 (EDT) Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-6746d0b2b4aso13958587a12.3 for ; Sat, 23 May 2026 00:46:21 -0700 (PDT) Received: from tulp.my.domain (2001-1c02-1a15-3000-ee82-4536-a8f2-9e22.cable.dynamic.v6.ziggo.nl. [2001:1c02:1a15:3000:ee82:4536:a8f2:9e22]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-688baf1eb98sm1596884a12.16.2026.05.23.00.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 00:46:18 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779522380; x=1780127180; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=GrcpdopYuj2UFVye9oP4bgEM0YmAnyS/4eXTcEnjc0k=; b=FLrNuCkG2HcREU5z342rE2UYQ4ddhWBbNAQvOmzA+MRie5Y/wAruG1gZsJMh1Mzp2M zU/bYr1ryuIQomH+pg0aim9as2yLTbVMHcBgLHWYdqS2fMkHxGvm5ui9ZsCJHFMJCe1D gimNlgWDzi8dWSp3nYGP83205DJ2i6oak3stKPtvfhEUhzzeYnOQZ+NvsaLUAi0ILJd7 Y5VU6vYBDqFdklmO8Q/+sB1HIn8uyeDZCYP2yDJ36UOQhOWcFnu+cwPSUFpfiZxKgF8H +h34KNxbVU2GYzNoRg2q9Si+hV4SS0IFRiAUmFknml3FRJPwkL9oHu8x8+Y3cogpyl3T frAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779522380; x=1780127180; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GrcpdopYuj2UFVye9oP4bgEM0YmAnyS/4eXTcEnjc0k=; b=cCmDPOXTUeORTDEWozXSZTEt3aAbUmS41ExPmTxwsiCWvPqgo7vj6RbWqqiISLAmsh 8638qrL2jsbsEvA0nTFqXtWLZvYYsAYB2iwDVs2V/IWj/n41ECmqXvghUpeWkuKYaBKs fe6AJHNp90nKh9i2gPj8xAJ5wBvPuH2ZJJo0DdJD7GFDOqZ0m4T0xeuALT7U5CK7IYlr h+8/qZ8XQLBnSldO3MH0cUEJCA0vOymVsgtZzA3loCVZeH0jnBGW76zbmMlSqNNUIu4S ISGSuIXNeoKNNEjPI969i0v91farzpVIBbeo7ot2x6hYMaf1LXTZJehSUUKkIDuDgsW7 aR5Q== X-Gm-Message-State: AOJu0Yw21nMdRXEtF7h1IcO2YAZNtDtHOokYT031T9N5qcE6nD5YZf8v BPuyTNRRETZ+CmmVSSXY0sAg9tMO0yqj+5Yfa0akIGRhS3x0gIlBp2dFt107/iux X-Gm-Gg: Acq92OEJBmdTjCzSWu8ak7GqfZQZRTYR88L1rmfqPFPI6YCEvpXqiJiTd1NUMn7aBhG lZQx27nRsDUSwWXlREzFfUIDwnEmOBqJx9rTV/e3SzGxn5uYttgjrjjHi8uF/tTOWhsgwbHRjpm mqXzYY/FX5HiG/Ya2deJpODdblhQsxS+tczCDGsMdNucTAxqkXmRLQCg1SQLVum54kcF6HjWiU/ /oxiuWHq5PDMSt1FnsswLSdFPwW83HXYCGEWeWB+S3D6CQ3+TvY2Uk8uQjZ+q5LSdA0dIkMHC0j M3Q8l5RVHMzxZY8+HcBg7gakgayGKeO1V4qka3YIEThXSCoJHDrPat9Q1wSS96bPYJ8YtYN5TEv pm6jNlBhy6DWFJYOg6yUu54h5IfL9BSNJ6PM37F1Tft2NdVz+dqPlk031cggam7CinpUmYkpkjf WBBcwYgcncJmSyn4ZpU5+UMURQYcoaLlVu6C2E0XPnc2/rOK4RaocRiZJNuncyNjhhsXX7AKZ7+ j9ukNBHB3rPf0jokOpVAG3oys8j60oQrVooRQ== X-Received: by 2002:a05:6402:a284:20b0:687:2181:90ab with SMTP id 4fb4d7f45d1cf-6889c470332mr2468378a12.14.1779522380331; Sat, 23 May 2026 00:46:20 -0700 (PDT) From: Roman Bogorodskiy To: devel@lists.libvirt.org Subject: [PATCH] virsh: fix entering interactive session Date: Sat, 23 May 2026 09:42:35 +0200 Message-ID: <20260523074235.47341-1-bogorodskiy@gmail.com> X-Mailer: git-send-email 2.52.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ILWRRR6XSS4A26IF5CHGGGW7ED4HGQJN X-Message-ID-Hash: ILWRRR6XSS4A26IF5CHGGGW7ED4HGQJN X-MailFrom: bogorodskiy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Roman Bogorodskiy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779522439082154100 Content-Type: text/plain; charset="utf-8" When entering an interactive session, that is, without a command specified: virsh --connect $URI virsh currently segfaults because it tries to access ctl->cmd->def->handler and the ctl->cmd is NULL. Fix by checking if ctl->cmd is not NULL before doing further checks. Fixes: b489eb8d6b52d4183754a5d1da55006148a331e4 Signed-off-by: Roman Bogorodskiy Reviewed-by: Peter Krempa --- tools/virsh.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh.c b/tools/virsh.c index 72d233f98d..401d4f9787 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -126,7 +126,7 @@ virshConnect(vshControl *ctl, const char *uri, bool rea= donly) virErrorPtr err; virConnectAuthPtr auth =3D virConnectAuthPtrDefault; =20 - if (ctl->cmd->def->handler =3D=3D cmdComplete) { + if (ctl->cmd && ctl->cmd->def->handler =3D=3D cmdComplete) { /* When running from a bash completer we need to avoid any kin= d of * keyboard input (e.g. ssh asking for a password). To achieve * this, provide no authentication callbacks. */ --=20 2.52.0