From nobody Sat May 30 15:28:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1779175830; cv=none; d=zohomail.com; s=zohoarc; b=dV16pha7S/q63JN3lLCgbXyzz8ZbwiILHBXq2Z5910CGk2tOEnTEirHBDsj+0jxys2Q1R2+yYE7lo/nwzv0B2gCRgGazXN3ULSWhdRbg5gFXT47/uVy31NEhWT99cQ9bTJEdq6YbMRFci+iwR4SdNRssVZjvCrjac61aFSedfAQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779175830; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=11eFfpYUA01b702luX2IyIToucXVJXzW8g9pHIHBhOs=; b=XB8KMrdxgxNchGlsw64Y3jyH5ORPLpRKFU4wiA3PTnda+HVEtHyRReCQa8mDJaRVx9OqcTUDcx8w0FvkSNM3DmfN2ZozEyESSnfberh2hhYuCdW5m/qtDmj8S4venTYgFXQUMTzriQltLW9W+sIjIDRwzNQLiJKr5KoZ2lb/iC0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1779175830380138.63005234663876; Tue, 19 May 2026 00:30:30 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4440E41905; Tue, 19 May 2026 03:30:27 -0400 (EDT) Received: from [172.19.199.5] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 5230E41943; Tue, 19 May 2026 03:29:23 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 600E53FA92; Fri, 15 May 2026 15:14:15 -0400 (EDT) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8E72B3F30D for ; Fri, 15 May 2026 15:14:13 -0400 (EDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-38e7c3a2deaso2172891fa.2 for ; Fri, 15 May 2026 12:14:13 -0700 (PDT) Received: from lenovo-legion5 (pppoe-77.220.51.71.ttel.ru. [77.220.51.71]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a91c33ddb0sm1511842e87.78.2026.05.15.12.14.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 12:14:10 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778872451; x=1779477251; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=11eFfpYUA01b702luX2IyIToucXVJXzW8g9pHIHBhOs=; b=o3w5SYwlG4pUTwDSzDuoKN9WsW93XCJkyYQsHmp2A6P7kgZFpkVscSmNhNhwe7M1qC zm69QGgHJaFLuggoNbG/Thla5vc7Llf+L0YFJH4yLZVTHCnjGY5bV8ToxzHw/5V1s2Nt mDlkz4LiOyc/0JWgV2XSaxuS7LpbM7FJIoO2w77yob/yIIPyPQaBolJ0/azUi6SKLnhI mLWYM15+AOyi6QzE9r8tnxE/Sq6bc1huBEb8N7p+sCPnwnm7K1lDuUgj8NgGPzMqJen2 h5QVPTXZaqa+HVYMAN0D24w8IuEFfjh4W9onZI1g8pwO7KdQ0DmPj/eFma9TXvKKR8md 0ckg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778872451; x=1779477251; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=11eFfpYUA01b702luX2IyIToucXVJXzW8g9pHIHBhOs=; b=dv8wLVEte+Lc3AYWh2hwgrsCXqmRUstDk4aBwEVub/wzQXT3efpSa6V5uvfqjRLSL/ kuTM7EHmmA4KLbVuZKQA7RRjkOsBaA19jw0ZyrzI1VQqOvJMm+IuqhAqei0BqTsRab62 dlBk7XZeZ18qo13n76NNGaOicdLdH3ezDSpdP/LsSjucOf9VP5JgqUbNQoHEz1zZY69e g/OOxEpe1K23MaoPmxpXihA0UwOvkQbkCWW85QbDxWQygMQcTozwCdUrtOhaYWuxeKo7 CiGLIMsguoQmqIr82iwb1wJyChpXez7es9O0/hWBz6iAPCzfkB1PF8UTeFidvSprj98S KCFw== X-Gm-Message-State: AOJu0YxgeiMPJpiYfnty1lrZP93GvxLekp3bWbna4WjSw/mtfn2oQe5J gHSBKr4Cy4M+6fpZzIJfb2aQAP6NaqcdjyzhPhavmO35qbGYoN4svwbV1DUBaA== X-Gm-Gg: Acq92OEUaCej0x08l+S+x4MPFzQnP3isc+gnvxP/QMZ4o/kW8p5dO67onP82IorSNYm tMwFJasXuFJjKlNBUEhNBAV8p/kayiYXGtRqGZ7hun9azNByJ5jsAcyds0riOvWxViOEd4BQjQN XxlP2o7qVEZ9SpgGfOzNxfLTWlkxmV9Bkcwev5asz3GMXMXjAb7XUMoUe0KP4nB338NhH24AuUM UKOSWhAikA8Kd4NbLbLUBvSq1Jsc0YUBuXsh7puHigRUykApwdXPwN3ul5+CUyrgnkhffi0FQAL C4ImXa4Kdu/JHWY9q5yWnO0zxf2ZMo4FF8L/VGKdLBfrARcFeqdP9GqefdyEnudMQNdAPvus85L AVBQimjrZqSt/dU/+w8E3Im+u8Jo8PdJMrKFHp3LxVCUtCqldtfie3O0s9VUlRgheZnQ2Jy0n/k qejOQ2+UNpqLf2SFiaCS0RPZz8QSDGBv5Y2iW+9dops2WC3dXK+R9ndA== X-Received: by 2002:a05:6512:6c8:b0:5a8:72e2:dba8 with SMTP id 2adb3069b0e04-5aa0e6191e4mr1596210e87.3.1778872451450; Fri, 15 May 2026 12:14:11 -0700 (PDT) From: Yaroslav Borbat To: devel@lists.libvirt.org Subject: [PATCH] util: typedparam: Fix sentinel handling in template validator Date: Fri, 15 May 2026 22:13:32 +0300 Message-ID: <20260515191359.2462604-1-yaroslav.752@gmail.com> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-MailFrom: yaroslav.752@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: AHVZS7ECPWVHVX4EG34IVGHBJTEIAARL X-Message-ID-Hash: AHVZS7ECPWVHVX4EG34IVGHBJTEIAARL X-Mailman-Approved-At: Tue, 19 May 2026 07:29:13 +0000 CC: Yaroslav Borbat X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1779175831551158500 Content-Type: text/plain; charset="utf-8" From: Yaroslav Borbat virTypedParamsValidateTemplate() iterated templates with an inverted sentinel condition and counted entries incorrectly. This caused valid params to be rejected as unsupported, e.g. migration parameter 'disks_uri'. Fixes: a650af5002a7477cab649c44fff58bbbc909b8a8 Signed-off-by: Yaroslav Borbat --- src/util/virtypedparam.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virtypedparam.c b/src/util/virtypedparam.c index 92f25cea39..530136978b 100644 --- a/src/util/virtypedparam.c +++ b/src/util/virtypedparam.c @@ -213,7 +213,7 @@ virTypedParamsValidateTemplate(virTypedParameterPtr par= ams, /* we need to copy the list of templates because * 'virTypedParamsValidateInternal' will need to sort it */ - while (*templates[ntemplates++].name =3D=3D '\0') + while (*templates[ntemplates++].name !=3D '\0') ; templ_copy =3D g_new0(virTypedParamValidationTemplate, ntemplates); -- 2.54.0