From nobody Fri May 15 10:50:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1777013196; cv=none; d=zohomail.com; s=zohoarc; b=XfJ05vPaTxX/gUBvviB4t+Mp6borJZ4laoWy6/ihjE+uPgPia2ZikHtItm0pwsjg1KfwO0VhBWfVqX794zWfeoo9avZX79JIAHx50PCOlLzlw5/mqNzadP+b8695sMWY1m1KiLiWPBnKFF0nlgx3Z9SsXJ9RSxsGfN8MUjmGFss= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777013196; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=fArUNQ9X95QyMDkIJmw1BFjK97VQ0NgvptKffVW9xrc=; b=ePoJtpb2ZdJ046Re4Xzn5kz2pSOL7AyTbPHqYFtZh27nMw12nbV9u5+FIFGeM0BpbM4PI1JiNkNzh7lPvyZgw9dNgjQeDXRtXp1CjC0y6wzwk0TQRuKaEeQb0tqbZ00Ow4OkQlJhnB6FAk0mmAb9nFf7mi80eiaS+M3y4TrBd+Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1777013196366441.1619022958872; Thu, 23 Apr 2026 23:46:36 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 653D941948; Fri, 24 Apr 2026 02:46:35 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 6198E41AEB; Fri, 24 Apr 2026 02:45:46 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 281244192A; Fri, 24 Apr 2026 02:45:38 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E52D141901 for ; Fri, 24 Apr 2026 02:45:35 -0400 (EDT) Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2026 23:45:35 -0700 Received: from ubuntu.bj.intel.com ([10.238.152.35]) by orviesa008.jf.intel.com with ESMTP; 23 Apr 2026 23:45:34 -0700 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777013136; x=1808549136; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=KPGqJL9Q8mPmF1chtdS5BWe4DLOsgNfRbk0qwP7hhaU=; b=L22EhqFrE8CiEfsSNAVo8keEzCo/RuovlxAM0iPfajUXXg+rmi5L0Idh PylXzN2o0L6wisnoeje/Zr+50TiFISpFLqsgRkOUsjYevRN2tPXbD18Em 1d6GHX/CpYhCBOwLanI0Qt+hqjhP4tK6CSgIWJzmYcB+mjaempnP7kRjl biUbi/lrbAlFT/hDc2p1KCdQBlPYgZHsQp/pz1ufHAWAXzK9LUIpmoSu7 +CwdepxFBZXBFqa1xsfawZBZQmjRY/Ms4tRQvNiV/nG8MrtlQrdKqnAl+ iSgsXdGzdhjTo4Q7WbwQAEs8X+B4Jko2vGBCY42/ot3N83iZfAUebb3hA w==; X-CSE-ConnectionGUID: IkKxNveHTAKFwj4gkTCCZQ== X-CSE-MsgGUID: y78dp0BzT2aUOXJpWonc3A== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="89454173" X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="89454173" X-CSE-ConnectionGUID: hutlCA0AR0eBL2W0IRGVDw== X-CSE-MsgGUID: PfbQdyMdSTqigjysjcoW2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="232782929" From: Jun Miao To: devel@lists.libvirt.org Subject: [PATCH] qemu: block core dump for TDX guests Date: Fri, 24 Apr 2026 14:44:38 +0800 Message-Id: <20260424064438.92371-1-jun.miao@intel.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WYM4MUMKDEAXLUEPTAY7J4FFVYKRMU4F X-Message-ID-Hash: WYM4MUMKDEAXLUEPTAY7J4FFVYKRMU4F X-MailFrom: jun.miao@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: jun.miao@intel.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1777013198232154100 Content-Type: text/plain; charset="utf-8" TDX guests use encrypted memory that cannot be meaningfully dumped by the hypervisor. Attempting a core dump on a TDX guest would produce unusable output since the memory contents are encrypted. And dump will make TDVM crash. Block the core dump operation for TDX guests early with a clear error message instead of letting it proceed and abort the Qemu. Signed-off-by: Jun Miao --- src/qemu/qemu_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b3e60471a8..555a6b6fb3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3249,6 +3249,13 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto endjob; =20 + if (vm->def->sec && + vm->def->sec->sectype =3D=3D VIR_DOMAIN_LAUNCH_SECURITY_TDX) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("core dump is not supported for TDX guests")); + goto endjob; + } + priv =3D vm->privateData; qemuDomainJobSetStatsType(vm->job->current, QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP); --=20 2.47.1