From nobody Tue Jun 9 21:14:29 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1777012844; cv=none; d=zohomail.com; s=zohoarc; b=kwXVRzh8l1TT9ir3QCtaQ8Aa5Jo827OlwO8nW1bRaSR6k9Jx8BSKA6oXwsWOC38nScx5S9dA2SzEL+E1+LkDSEHyJinJ482w/yCbbKhF/KVtRGqYNMKjmiXc8k6HzlXAYGYAbW2RBt5UPiPm+SnGCbz0mqXMUrnrtR7qSx47EaQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1777012844; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=eYt8/ScOhM5egdbDJC5L5ZJ7d/ReGT8JdVZhSVSjdII=; b=CnlPsQFsqxYwWDo7oh7bDfIe2QZX93lULhG5aCwJX5Njnhx8OHl2opeFJdsaIbHEo4XPCFgMOEdXafMRT7csb/8JnMHVLGk7p0+jQOjdFDko4M3DWW1pc4+7fpyF39xtkHrPTM4Rp/45TYWIEy8NQ0b9ZqVZzFMwKoy69urDxBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1777012844183213.86221155364444; Thu, 23 Apr 2026 23:40:44 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id BEED041944; Fri, 24 Apr 2026 02:40:42 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id BE98241AEC; Fri, 24 Apr 2026 02:39:59 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 2DE7C41901; Fri, 24 Apr 2026 02:39:51 -0400 (EDT) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 469DA4193B for ; Fri, 24 Apr 2026 02:39:49 -0400 (EDT) Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Apr 2026 23:39:48 -0700 Received: from ubuntu.bj.intel.com ([10.238.152.35]) by orviesa003.jf.intel.com with ESMTP; 23 Apr 2026 23:39:47 -0700 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1777012790; x=1808548790; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=UaIupuwh1Btv9K/87GRyjrkzbZYXwp51LEpLszyFsQw=; b=Blp/q0MK0hU2DxlAapfZgnfV2IMAO+7VczV3sEY4MDIf0DO7M63in81t B8p2DklknPx/ZaZGykbjef7gsVbK7SVAGSgvB1jGwhZqi+5T46JtXPPES LjKpyHLoqZJ/ul7C2RwqaJmcXioDlfWzOz9GU0rebwndfbdWaKrdGg683 HtD/3C/G2Lm60Udn4x5ZRsE8xhuZOYOQ4qgR2qj8gUT32PbVMwckSVa3M CPWiIVnOm2Fc9H4RgBWe0tyzHLiTEqa36EwQU189KUK+Or/RC92Dzxhhw rltQ4hAQX+3FfXcDrI1FxNrS4UMYovXPUDcd2YLsirtO8fZJw2KzOleaQ Q==; X-CSE-ConnectionGUID: G6orVKgpQPOG9b9FWhHIxg== X-CSE-MsgGUID: 90DBvgtVTUWxb84J/FcZaQ== X-IronPort-AV: E=McAfee;i="6800,10657,11765"; a="81847628" X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="81847628" X-CSE-ConnectionGUID: PqgV9nVkRGSM1IUBhIxpag== X-CSE-MsgGUID: PWwhNcEYQwC81fyTiNuSeg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,196,1770624000"; d="scan'208";a="236853454" From: Jun Miao To: devel@lists.libvirt.org Subject: [PATCH] qemu: block core dump for TDX guests Date: Fri, 24 Apr 2026 14:38:51 +0800 Message-Id: <20260424063851.92003-1-jun.miao@intel.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: RJOFYTCTT6OG6SPCW6CCHRXCKHZN2FE6 X-Message-ID-Hash: RJOFYTCTT6OG6SPCW6CCHRXCKHZN2FE6 X-MailFrom: jun.miao@intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: jun.miao@intel.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1777012847724158500 Content-Type: text/plain; charset="utf-8" From: root TDX guests use encrypted memory that cannot be meaningfully dumped by the hypervisor. Attempting a core dump on a TDX guest would produce unusable output since the memory contents are encrypted. And dump will make TDVM crash. Block the core dump operation for TDX guests early with a clear error message instead of letting it proceed and abort the Qemu. Signed-off-by: Jun Miao --- src/qemu/qemu_driver.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index b3e60471a8..555a6b6fb3 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -3249,6 +3249,13 @@ qemuDomainCoreDumpWithFormat(virDomainPtr dom, if (virDomainObjCheckActive(vm) < 0) goto endjob; =20 + if (vm->def->sec && + vm->def->sec->sectype =3D=3D VIR_DOMAIN_LAUNCH_SECURITY_TDX) { + virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s", + _("core dump is not supported for TDX guests")); + goto endjob; + } + priv =3D vm->privateData; qemuDomainJobSetStatsType(vm->job->current, QEMU_DOMAIN_JOB_STATS_TYPE_SAVEDUMP); --=20 2.47.1