From nobody Tue Jun 9 20:58:22 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1776948885; cv=none; d=zohomail.com; s=zohoarc; b=kKYUhXMLSIDoEAyJFBOqpU02HKJDcIpoDVukAAMoiCBy/J/Sf09/xP0NCY/jRwzEdyzddSOLHGq6DbkTItw257UkF6uOwLBGGCDNyXMS5yq8et/Ma6we/LJd0Z03hmPA/n+VFdXVSDX08aUZ9sG/drBPNI2WT1LslRRCRjYjXZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776948885; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=+XeIrPIBA6rSC5tS8ecsclxpBFAwfFNMnzeqd9BKotA=; b=JVfIdeNdz6RsAwT0O6Z75JxV8PqAxrwWfbKCFcD0KvP2zQmab+M9HBvyDO2Vvoi2bbcebhNZA8eRRgTk1HZeiidQp8F8UuMf6OqxsNCCxO+MTLw5moWy9hXFmuwp315f9OI6MCLiskB1aIuyp86asM87w9G6wy3z9RUZ0ZiLgLA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1776948885653958.8940950114281; Thu, 23 Apr 2026 05:54:45 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 0E51E419D7; Thu, 23 Apr 2026 08:54:44 -0400 (EDT) Received: from [172.19.199.9] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 7AC4C41C36; Thu, 23 Apr 2026 08:43:14 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id B78BA3F33C; Thu, 23 Apr 2026 08:23:01 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id B315D4192A for ; Thu, 23 Apr 2026 08:19:06 -0400 (EDT) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-180-qZfvzcVuMHWcnec5--jJyw-1; Thu, 23 Apr 2026 08:19:05 -0400 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4DF931800345 for ; Thu, 23 Apr 2026 12:19:04 +0000 (UTC) Received: from sparimi-thinkpadt14gen5.bengluru.csb (unknown [10.67.32.8]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 32D3B3000709; Thu, 23 Apr 2026 12:19:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL,SPF_HELO_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776946746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+XeIrPIBA6rSC5tS8ecsclxpBFAwfFNMnzeqd9BKotA=; b=c3fvf8Q2zZqwTAEyn9SIYnhCnqE7ai3fYq+Z5f688Pt6MJtEyXIxDHBdqRs9hLqIXH+JAP sJ9DKlEMqPius+Ra3559rW0UTVtqwcVM0syxkLr0bJvGXG8ok54j7HPW8N+Efh8WwQmMJE yAV+Vy7CXqNQRYQ5U8VUvf/7it4bsSM= X-MC-Unique: qZfvzcVuMHWcnec5--jJyw-1 X-Mimecast-MFC-AGG-ID: qZfvzcVuMHWcnec5--jJyw_1776946744 To: devel@lists.libvirt.org Subject: [PATCH v6] vmx: configure TPM device in the XML Date: Thu, 23 Apr 2026 17:48:17 +0530 Message-ID: <20260423121849.180955-1-sparimi@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OeDYModqoVq2VCdOiYHFDy19IQinhQeFjaQG6vc7HQE_1776946744 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-MailFrom: sparimi@redhat.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: A7P5OLJNOXCHN7D265SRJ6TNRNR4EQO4 X-Message-ID-Hash: A7P5OLJNOXCHN7D265SRJ6TNRNR4EQO4 X-Mailman-Approved-At: Thu, 23 Apr 2026 12:43:06 +0000 CC: Srihari Parimi X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Srihari Parimi via Devel Reply-To: Srihari Parimi X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1776948887600154100 Content-Type: text/plain; charset="utf-8"; x-default="true" Parses vtpm.present from VMX files and converts to libvirt TPM device with CRB model and emulator backend. VMware vTPM uses TPM 2.0 as specified in the document below https://techdocs.broadcom.com/us/en/vmware-cis/vsphere/vsphere/8-0/vsphere-= security/securing-virtual-machines-with-virtual-trusted-platform-module/vtp= m-overview.html implement support for formatting TPM devices in virVMXFormatConfig Signed-off-by: Srihari Parimi Reviewed-by: Peter Krempa --- src/vmx/vmx.c | 74 ++++++++++++++++++++++++++++++++++++++ tests/vmx2xmldata/vtpm.vmx | 22 ++++++++++++ tests/vmx2xmldata/vtpm.xml | 32 +++++++++++++++++ tests/vmx2xmltest.c | 2 ++ 4 files changed, 130 insertions(+) create mode 100644 tests/vmx2xmldata/vtpm.vmx create mode 100644 tests/vmx2xmldata/vtpm.xml diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 57dfd57cfc..977fd3b346 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -599,6 +599,7 @@ static int virVMXParseSerial(virVMXContext *ctx, virCon= f *conf, int port, static int virVMXParseParallel(virVMXContext *ctx, virConf *conf, int port, virDomainChrDef **def); static int virVMXParseSVGA(virConf *conf, virDomainVideoDef **def); +static int virVMXParseTPM(virConf *conf, virDomainTPMDef **def); =20 static int virVMXFormatVNC(virDomainGraphicsDef *def, virBuffer *buffer); static int virVMXFormatDisk(virVMXContext *ctx, virDomainDiskDef *def, @@ -609,6 +610,7 @@ static int virVMXFormatFileSystem(virDomainFSDef *def, = int number, virBuffer *buffer); static int virVMXFormatEthernet(virDomainNetDef *def, int controller, virBuffer *buffer, int virtualHW_version); +static int virVMXFormatTPM(virDomainTPMDef *def, virBuffer *buffer); static int virVMXFormatSerial(virVMXContext *ctx, virDomainChrDef *def, virBuffer *buffer); static int virVMXFormatParallel(virVMXContext *ctx, virDomainChrDef *def, @@ -1938,6 +1940,15 @@ virVMXParseConfig(virVMXContext *ctx, =20 def->nvideos =3D 1; =20 + /* def:tpms */ + { + virDomainTPMDef *tpm =3D NULL; + if (virVMXParseTPM(conf, &tpm) < 0) + goto cleanup; + if (tpm) + VIR_APPEND_ELEMENT(def->tpms, def->ntpms, tpm); + } + /* def:sounds */ /* FIXME */ =20 @@ -3367,6 +3378,27 @@ virVMXParseSVGA(virConf *conf, virDomainVideoDef **d= ef) return result; } =20 +static int +virVMXParseTPM(virConf *conf, virDomainTPMDef **def) +{ + bool vtpm_present =3D false; + + /* vmx:vtpm.present */ + if (virVMXGetConfigBoolean(conf, "vtpm.present", &vtpm_present, + false, true) < 0) { + return -1; + } + + if (!vtpm_present) + return 0; + + *def =3D g_new0(virDomainTPMDef, 1); + (*def)->type =3D VIR_DOMAIN_TPM_TYPE_EMULATOR; + (*def)->model =3D VIR_DOMAIN_TPM_MODEL_CRB; + (*def)->data.emulator.version =3D VIR_DOMAIN_TPM_VERSION_2_0; + + return 0; +} =20 =20 /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *= * * @@ -3701,6 +3733,31 @@ virVMXFormatConfig(virVMXContext *ctx, virDomainXMLO= ption *xmlopt, virDomainDef goto cleanup; } =20 + /* def:vTPM */ + if (def->ntpms > 0) { + /* Validate TPM requirements */ + if (def->ntpms > 1) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("VMware only supports a single TPM device")); + goto cleanup; + } + + if (virtualHW_version < 14) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("vTPM requires virtual hardware version 14 or higher")); + goto cleanup; + } + + if (def->os.firmware !=3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("vTPM requires EFI firmware")); + goto cleanup; + } + + if (virVMXFormatTPM(def->tpms[0], &buffer) < 0) + goto cleanup; + } + /* def:inputs */ /* FIXME */ =20 @@ -4231,6 +4288,23 @@ virVMXFormatEthernet(virDomainNetDef *def, int contr= oller, } =20 =20 +static int virVMXFormatTPM(virDomainTPMDef *def, virBuffer *buffer) +{ + /* VMware vTPM specifically requires TPM 2.0 */ + if (def->model !=3D VIR_DOMAIN_TPM_MODEL_CRB || + def->type !=3D VIR_DOMAIN_TPM_TYPE_EMULATOR || + def->data.emulator.version !=3D VIR_DOMAIN_TPM_VERSION_2_0) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("VMware driver only supports TPM 2.0 with the CRB= model")); + return -1; + } + + /* VMX parameters for vTPM */ + virBufferAddLit(buffer, "vtpm.present =3D \"TRUE\"\n"); + + return 0; +} + =20 static int virVMXFormatSerial(virVMXContext *ctx, virDomainChrDef *def, diff --git a/tests/vmx2xmldata/vtpm.vmx b/tests/vmx2xmldata/vtpm.vmx new file mode 100644 index 0000000000..6e2fd725b7 --- /dev/null +++ b/tests/vmx2xmldata/vtpm.vmx @@ -0,0 +1,22 @@ +config.version =3D "8" +virtualHW.version =3D "19" +displayName =3D "test-vtpm" +memsize =3D "4096" +numvcpus =3D "2" +guestOS =3D "windows9-64" + +# Disk Configuration +scsi0.present =3D "TRUE" +scsi0.virtualDev =3D "lsisas1068" +scsi0:0.present =3D "TRUE" +scsi0:0.deviceType =3D "scsi-hardDisk" +scsi0:0.fileName =3D "test_disk.vmdk" + +# vTPM configuration +vtpm.present =3D "TRUE" + +# Network Configuration +ethernet0.present =3D "TRUE" +ethernet0.connectionType =3D "nat" +ethernet0.virtualDev =3D "e1000e" +ethernet0.addressType =3D "generated" diff --git a/tests/vmx2xmldata/vtpm.xml b/tests/vmx2xmldata/vtpm.xml new file mode 100644 index 0000000000..cbb23ce673 --- /dev/null +++ b/tests/vmx2xmldata/vtpm.xml @@ -0,0 +1,32 @@ + + test-vtpm + 00000000-0000-0000-0000-000000000000 + 4194304 + 4194304 + 2 + + hvm + + + destroy + restart + destroy + + + + +
+ + + + + + + + + + + + diff --git a/tests/vmx2xmltest.c b/tests/vmx2xmltest.c index fcca765bed..3ffc04fda4 100644 --- a/tests/vmx2xmltest.c +++ b/tests/vmx2xmltest.c @@ -243,6 +243,8 @@ mymain(void) =20 DO_TEST("firmware-efi"); =20 + DO_TEST("vtpm"); + ctx.datacenterPath =3D "folder1/folder2/datacenter1"; =20 DO_TEST("datacenterpath"); --=20 2.53.0