From nobody Wed Apr 15 07:04:08 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) client-ip=38.145.34.151; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1776085732; cv=none; d=zohomail.com; s=zohoarc; b=KPZISouXbvPYt1IleUeMjuO9VxhtpHEOkL0mXju+O3KLZiXIpaJ6W6RWx1xMVdqYHv+ifNeY4Wv8wAv4sA96RkgIB9VH+8cqdA+pGSef3bRLGIZ9+ZkAYrlOn6UcVXCwX9oaT9bXzfojNCTRas201omymB6FPAUhXB6WYijecM8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1776085732; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=T+polFJXIRW8YuYLuBeq5TCrPMFMgIHh/5hqcgt2EOQ=; b=OWvcR4h0Rxw2Jx8kF7IQUiJ5s7Esi+GXA/kywchu0Wu+vZNRTP24vQrTM5jeNpvgFIBMwMA3cyo9pZRjYZCd8FssLnk8qWtQXGx6BKaeEugu7S0BZwgKwAc84xdEmf+LI+9ErbG57Y+gnaPENiJ4myQzMNjd7uQ0k71W58AiQ88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 38.145.34.151 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [38.145.34.151]) by mx.zohomail.com with SMTPS id 1776085732927983.0967613746027; Mon, 13 Apr 2026 06:08:52 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id AD5D8417DE; Mon, 13 Apr 2026 09:08:51 -0400 (EDT) Received: from [172.19.199.3] (unknown [10.16.107.18]) by lists.libvirt.org (Postfix) with ESMTP id 204F2418D2; Mon, 13 Apr 2026 09:08:02 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 9374C3F281; Mon, 13 Apr 2026 09:07:53 -0400 (EDT) Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EFBB23F2F9 for ; Mon, 13 Apr 2026 09:07:51 -0400 (EDT) Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-482f454be5bso46881745e9.0 for ; Mon, 13 Apr 2026 06:07:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d63de2e4csm34608412f8f.2.2026.04.13.06.07.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 13 Apr 2026 06:07:49 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776085670; x=1776690470; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T+polFJXIRW8YuYLuBeq5TCrPMFMgIHh/5hqcgt2EOQ=; b=nQACK9f3KEWJ6Du9upQLaZpcNg7b9xjhZ9r6S7lfvsB/TlX7rEj0IOoGq4xWzXtcFY FON+8fAKh0DQ0VLIBFUYwIzKLlLJgHxep8pYsPqvT/9CBTmRZLwKcbUy4MMrZMNCO1xr tpf4Sos0feakXVGRLzQeEKP3SB2FBMRjGUNGrW3IPMchI72L5ZTHu6SCx02HInjCrsBm slNMkEtcx0vs1A2aBhiPTo5IUu+WPnAm2fvF29dLxVe3HhXmD29h1WmW1rY7ePtnYchG s5e6KVf/kD7m5IVqIyiRySVoqdV+rnmEcmPSMXmIlSrXwr1vjn1XuGf76MwhIXcs/TP/ vLGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776085670; x=1776690470; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T+polFJXIRW8YuYLuBeq5TCrPMFMgIHh/5hqcgt2EOQ=; b=IrTkYD4R+hI3Vxa/pwf513xuQSj1ohax9QyKU+v+WNGbKyqA23wxSvkor6wglrrwRh lzE39VZ1T25lKtijejRxMZ81weqTPwLYFZboZ64+cfCtIa7YSMATetKaVAoOr+2hieJZ 6lSwHX5BvwXSWXLKcxuDkTEY5Acsnvaoh3DcZw9WpDdLcvDJrwmKPVCT7sr06CQk4paH GJ03N87q1ZsNH7pmXSsC7hNtbuizhOKJbplcwxwuiRaC4bmdWDKx7r+TMbzXOrZUdfNG KboYDmezjIKcrMkP/enrJ2dMJ/e8JhsKnihxcn8NawvqpvO3QEoU00b6CXffYUFPWVKL WMFw== X-Gm-Message-State: AOJu0YxGrOQhHh1wy3k7PJUHJq7Ty9Guje6pkMeEcnNp3ExOdMlF+oPy A/LeE30fYBFG5yVaKfCmwIiZoS8PbQrnv2vgNltpdGGkM0jYusM1iyCkw2oIQ2RA0uc= X-Gm-Gg: AeBDievNg03DIKf4owrJLWlDtRoytC+PWJlfwjfGnF05rRUDdEmZwCmg2zeIMnnUmjs o2+tWnExxNW6mucX9SMm2KNWsbjGrM5alKG414oYXI4dD04tDse1MhJ9JsMPwT5qkK/YsqzlMZs G7m2lZpSbYmCRMdGB9PvHj/f5hhKMY84GYU2iBkBdIQrKlyiOWJgND212nxQB7iIO0NM/sK9bVE 6b8UiQvUjPPQvP1Qs1ubd0YeDLei5LIVYRCCInD0Q680+Pp65abvGAbiJAwGeWynzjZHvawGlJG XEdwHTc9tpRcO57yTcI/QHVQOHtoW2zcS0MUO3tPlWx7UAWv09v583Dml2MdRZNz2qgT+UsHsKF AGPta3OpHMg6TjSppHLLDpYY3kxa5E3nFoN4GD5aJTz85162OHo9riVS2pcUSjwuLoqK5SLoKLo LcYFIAvB//IorHK32AypX4NCS04tCtriithpiVOaeMk8fEPn3u7xA77oAWSq5nP8P+BjtnTswV X-Received: by 2002:a5d:5d03:0:b0:437:7719:ca82 with SMTP id ffacd0b85a97d-43d6491fef7mr18361158f8f.3.1776085670379; Mon, 13 Apr 2026 06:07:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-11.0?] target/i386: Mandate monitor 'info lapic' take a vCPU ID argument Date: Mon, 13 Apr 2026 15:07:48 +0200 Message-ID: <20260413130748.6631-1-philmd@linaro.org> X-Mailer: git-send-email 2.53.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QYQ4W2XNOIKYC7N6CKVZLTND7VZKHY3J X-Message-ID-Hash: QYQ4W2XNOIKYC7N6CKVZLTND7VZKHY3J X-MailFrom: philmd@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: devel@lists.libvirt.org, Pierrick Bouvier , Zhao Liu , "Dr. David Alan Gilbert" , Markus Armbruster , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1776085734276154100 With SMP configurations, using the 'current vCPU' under the monitor isn't recommended, as it changes during runtime. Better to specify which vCPU we want to monitor by its index. Deprecate the default of 'info lapic', mentioning an argument is expected, so we can remove this unpredictable behavior one day. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- The other command with this unpredictable behavior is 'info tlb' which we'll deal with differently, after the v11.0 release. --- docs/about/deprecated.rst | 6 ++++++ target/i386/cpu-apic.c | 2 ++ hmp-commands-info.hx | 3 +-- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index a6d6a713265..a62da93259a 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -169,6 +169,12 @@ The ``stopcapture`` command is deprecated and will be = removed in a future releas =20 The ``info capture`` command is deprecated and will be removed in a future= release. =20 +``info lapic`` without ``apic-id`` argument (since 11.0) +'''''''''''''''''''''''''''''''''''''''''''''''''''''''' + +When no APIC ID is provided, ``info lapic`` defaults to the current vCPU. +This behavior is now deprecated, the ID will be mandatory in a future rele= ase. + Host Architectures ------------------ =20 diff --git a/target/i386/cpu-apic.c b/target/i386/cpu-apic.c index eaa10ad2a3d..9ca569f62b8 100644 --- a/target/i386/cpu-apic.c +++ b/target/i386/cpu-apic.c @@ -97,6 +97,8 @@ void hmp_info_local_apic(Monitor *mon, const QDict *qdict) cpu_synchronize_state(cs); } } else { + monitor_printf(mon, "Not specifying the local apic id is deprecate= d" + " (using the current CPU one)\n"); cs =3D mon_get_cpu(mon); } =20 diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 74c741f80e2..e4206d329fc 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -118,8 +118,7 @@ ERST .name =3D "lapic", .args_type =3D "apic-id:i?", .params =3D "[apic-id]", - .help =3D "show local apic state (apic-id: local apic to rea= d, default is which of current CPU)", - + .help =3D "show local apic state (apic-id: local apic to rea= d)", .cmd =3D hmp_info_local_apic, }, #endif --=20 2.53.0