From nobody Mon Mar 23 23:45:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774102958; cv=none; d=zohomail.com; s=zohoarc; b=K0hAZASYbTVAsN2dfeZp0Js9m5seMARKBz4m1BTJ+dfeWJwWFn8Bb90GOUtbI16k67Md5ywPeCVpTV83MIuM6Yqqeo9X723ryqgOezHr9AkW/eiuVfrBQymmk/lfezyMepKfZR5xMbEtJOacPMviEmksGqTp6eKAnYFkjOg1n9U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774102958; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=L52Z4w2+XLkwBTJMDnWgOreEW9etcPWfHngDTejpPl8=; b=Pe2gXBfv+Spy0eHqpBKlA0XdefxPd0Wjp3eac/DhYSvIzhuYrqgdqBfjw2wgJfK78KacVN/d+x2FQZbGgl0Ra0YJjfbwPNlNrzZjcSZkawitQb4XF4o6qTLeaG6BxuKBwLIwqP33IxenYEV4gzkR4AxjFjH0imY/I3K5yPMDSGk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774102958353744.8566040049052; Sat, 21 Mar 2026 07:22:38 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 86E39418AC; Sat, 21 Mar 2026 10:22:37 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 401C741C3D; Sat, 21 Mar 2026 10:19:57 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id C979A41BBA; Sat, 21 Mar 2026 10:19:52 -0400 (EDT) Received: from mx1.osci.io (unknown [8.43.85.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C2241418AD for ; Sat, 21 Mar 2026 10:19:42 -0400 (EDT) Received: by mx1.osci.io (Postfix, from userid 995) id 7D5E820651; Sat, 21 Mar 2026 10:19:42 -0400 (EDT) Received: from smtp-42ac.mail.infomaniak.ch (smtp-42ac.mail.infomaniak.ch [IPv6:2001:1600:4:17::42ac]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mx1.osci.io (Postfix) with ESMTPS id 442AF2041A for ; Sat, 21 Mar 2026 10:19:41 -0400 (EDT) Received: from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fdLt60tf4zFky; Sat, 21 Mar 2026 15:10:06 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4fdLt54s8yz30D; Sat, 21 Mar 2026 15:10:05 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Greylist: delayed 572 seconds by postgrey-1.37 at polly.osci.io; Sat, 21 Mar 2026 10:19:41 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gugod.fr; s=20250112; t=1774102206; bh=L52Z4w2+XLkwBTJMDnWgOreEW9etcPWfHngDTejpPl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QU6bnCO2Gzs5o3dThHZ5zYeTNRpCg7BSKp1DE3niTUPYSz8BrO9DmZJZQLGaIPAvp 2DGCpZmG3DZeXFI8OdnInINkB2XFHff3wXbmPTT7Xm6FYE3e9PNU3JH6dHvTCwPm5B VOXRO05lr/0qCLSG8KT9dLPss1t3fx1qMqOI+3AHbfy1O94HixAo4Mcfm+x1JFTTrk hupbv5g3kYQVTL3mX6A48Y8IN0MIJHT0nBDdELv+dRalvpv1cL96RaGXrEkByuGYxk 2cxwXLow1S9HGp6aHzJe9ctLi1DlwJK7jzOYxS+eUDnJ47XMsB/hznvBZWTJgTRQA4 GrXbpUfJS/rag== To: devel@lists.libvirt.org Subject: [PATCHv2 1/4] docs: hooks: Clarify that the migrate operation is on the destination host Date: Sat, 21 Mar 2026 15:09:01 +0100 Message-ID: <20260321140923.23807-2-guy.godfroy@gugod.fr> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260321140923.23807-1-guy.godfroy@gugod.fr> References: <20260321140923.23807-1-guy.godfroy@gugod.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Infomaniak-Routing: alpha Message-ID-Hash: OK6N5IBZWZFSBQUVDUWVYLNHSCDQXNS3 X-Message-ID-Hash: OK6N5IBZWZFSBQUVDUWVYLNHSCDQXNS3 X-MailFrom: guy.godfroy@gugod.fr X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pkrempa@redhat.com, Guy Godfroy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Guy Godfroy via Devel Reply-To: Guy Godfroy X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774102959413158500 Content-Type: text/plain; charset="utf-8" The documentation for the "migrate" hook operation described it as being called at the beginning of incoming migration, but didn't explicitly mention that this happens on the destination host. Add "on the **destination** host" to make this clear. Signed-off-by: Guy Godfroy --- docs/hooks.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/hooks.rst b/docs/hooks.rst index e1745b8cc7..0310e0d82c 100644 --- a/docs/hooks.rst +++ b/docs/hooks.rst @@ -244,7 +244,7 @@ operation. There is no specific operation to indicate a= "restart" is occurring. =20 =20 - :since:`Since 0.9.11`, the qemu hook script is also called at the begin= ning - of incoming migration. It is called as: + of incoming migration on the **destination** host. It is called as: =20 :: =20 @@ -417,7 +417,7 @@ operation. There is no specific operation to indicate a= "restart" is occurring. /etc/libvirt/hooks/libxl guest_name release end - =20 - :since:`Since 2.1.0`, the libxl hook script is also called at the begin= ning - of incoming migration. It is called as: + of incoming migration on the **destination** host. It is called as: =20 :: =20 --=20 2.53.0 From nobody Mon Mar 23 23:45:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774102922; cv=none; d=zohomail.com; s=zohoarc; b=TNn8agOGnoRWuELSv8TBRqLBfhAekT0m4cfVrGmmiPfAft6ar/FXBDSVQX+svzn/1k3VekckC4XXgQx2c4HfYx8pSTTJpvHzodxpW6v3zH0wlp32X9NFgNN9yfMdMGELlikKRm3MaBU11JcJpQ5RdUMkrVGyr79XbWUP4BWo0ts= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774102922; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=9zSG8Z0p87xbRDqPTU3a/8LqbF2zHDRlwOM/7WlEVHs=; b=D74I0gPBj4eLmxKWZUyrabJ6FdJ0wHkPQ60Mql5e0EIJqKs3au+SjopB4sGEdte3NPcsy9Ro2QqoWpOPdVmUEI3m9MG0YVoGDrxAjZHbLimOe5fk87ToLyJ4sipgv0NzbAnmZD7xJq4d0RGWdRLeB/Fy3VjHNzG7zPTYWv2ppiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774102922144696.5749471573741; Sat, 21 Mar 2026 07:22:02 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id ACB4041980; Sat, 21 Mar 2026 10:22:01 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 5C2E941BB5; Sat, 21 Mar 2026 10:19:47 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 556B73F36A; Sat, 21 Mar 2026 10:19:40 -0400 (EDT) Received: from smtp-bc0a.mail.infomaniak.ch (smtp-bc0a.mail.infomaniak.ch [45.157.188.10]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 55B063FA60 for ; Sat, 21 Mar 2026 10:19:39 -0400 (EDT) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [IPv6:2001:1600:4:17::246b]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fdLt64DRszFhC; Sat, 21 Mar 2026 15:10:06 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4fdLt60jNKz2hV; Sat, 21 Mar 2026 15:10:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gugod.fr; s=20250112; t=1774102206; bh=9zSG8Z0p87xbRDqPTU3a/8LqbF2zHDRlwOM/7WlEVHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cEzexcJGyD1mfRAWkYoxVsL8wlapNmdqVNkb+VzYcvUccbQXAhqxYpDmE0YS1+a+V RdEHATZSdiL37vxBu/jehDuk2jLeNJ793beN4pXA4xxk7hAfW3eHijHcejQBw74MRd NvZTBUHrt07IBWghOAfcRBshlHF8zB2lmVCbmLOhaqyTfOYmKfMXrL9lkGkK3ZeRuy 9sDxXsxT4X4ej+KQy6yIjKevPe0tdtdVcmWR+pvZr7/7jo0w0NftTQCXZznsZBXyjE Inxuarzy2n1KM9+L/yFw0eAHsvK+7V/5k4Lnu1JzXyBoubWtNX302k+8+IZYL7U2Zg 2EtA4KK4M+dMQ== To: devel@lists.libvirt.org Subject: [PATCHv2 2/4] util: hook: Add migrate-outgoing operation for qemu and libxl drivers Date: Sat, 21 Mar 2026 15:09:02 +0100 Message-ID: <20260321140923.23807-3-guy.godfroy@gugod.fr> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260321140923.23807-1-guy.godfroy@gugod.fr> References: <20260321140923.23807-1-guy.godfroy@gugod.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Infomaniak-Routing: alpha Message-ID-Hash: C6JP73JWR5B4LF5ZRWFWZOGV7MG4L6TO X-Message-ID-Hash: C6JP73JWR5B4LF5ZRWFWZOGV7MG4L6TO X-MailFrom: guy.godfroy@gugod.fr X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pkrempa@redhat.com, Guy Godfroy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Guy Godfroy via Devel Reply-To: Guy Godfroy X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774102924318154100 Content-Type: text/plain; charset="utf-8" Add VIR_HOOK_QEMU_OP_MIGRATE_OUTGOING and VIR_HOOK_LIBXL_OP_MIGRATE_OUTGOING enum values with corresponding "migrate-outgoing" string mappings. This new operation will be used for hooks called on the source host during outgoing migration, distinct from the existing "migrate" operation which is used for destination host hooks. Signed-off-by: Guy Godfroy --- src/util/virhook.c | 2 ++ src/util/virhook.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/src/util/virhook.c b/src/util/virhook.c index d012bb1825..7f7e253a67 100644 --- a/src/util/virhook.c +++ b/src/util/virhook.c @@ -84,6 +84,7 @@ VIR_ENUM_IMPL(virHookQemuOp, "reconnect", "attach", "restore", + "migrate-outgoing", ); =20 VIR_ENUM_IMPL(virHookLxcOp, @@ -115,6 +116,7 @@ VIR_ENUM_IMPL(virHookLibxlOp, "migrate", "started", "reconnect", + "migrate-outgoing", ); =20 VIR_ENUM_IMPL(virHookBhyveOp, diff --git a/src/util/virhook.h b/src/util/virhook.h index d8237c837e..a7536fb01e 100644 --- a/src/util/virhook.h +++ b/src/util/virhook.h @@ -60,6 +60,7 @@ typedef enum { VIR_HOOK_QEMU_OP_RECONNECT, /* domain is being reconnected by l= ibvirt */ VIR_HOOK_QEMU_OP_ATTACH, /* domain is being attached to be l= ibvirt */ VIR_HOOK_QEMU_OP_RESTORE, /* domain is being restored */ + VIR_HOOK_QEMU_OP_MIGRATE_OUTGOING, /* domain is being migrated out */ =20 VIR_HOOK_QEMU_OP_LAST, } virHookQemuOpType; @@ -94,6 +95,7 @@ typedef enum { VIR_HOOK_LIBXL_OP_MIGRATE, /* domain is being migrated */ VIR_HOOK_LIBXL_OP_STARTED, /* domain has started */ VIR_HOOK_LIBXL_OP_RECONNECT, /* domain is being reconnected by = libvirt */ + VIR_HOOK_LIBXL_OP_MIGRATE_OUTGOING, /* domain is being migrated out */ =20 VIR_HOOK_LIBXL_OP_LAST, } virHookLibxlOpType; --=20 2.53.0 From nobody Mon Mar 23 23:45:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774102877; cv=none; d=zohomail.com; s=zohoarc; b=AVEMwC9AhWKfWuCizhyOLARDXEanztJgmkHbgn5jDgQri583DbxnNEOVmCZXFOuomF5cUQyusn5mMIldrbr5MMZMK6YoxQ+q/wWwoZmPZW2/wb15E1uRWML1jAKbAwVFp/ACfs8Dj08NhDKl/UwD8BfoYHLmS6xhUOIrsHQuuTA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774102877; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=+6ebdc7pvIrWdxGvg5zH2AnKWg8PzlQFS5sc58DlATE=; b=hrOvkLHPrxBJaoHbdhPZIZrwNpJbFC/+jTwodZfcvbYbzHL5/o7P0hKgyc7N5VgbvniS4duW4c+KlARXZcI5i3E5bHb/qkToHCvvOHq8mnatW98f7Z5gPk3AoU/V3/ZPvfyLLFVn0v00tEofAlpJyHsUTG2eHbvQ00cC/nP2oqQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774102877093425.9595128388585; Sat, 21 Mar 2026 07:21:17 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 1497C41ABA; Sat, 21 Mar 2026 10:21:16 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0517441B54; Sat, 21 Mar 2026 10:19:46 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 23E103F362; Sat, 21 Mar 2026 10:19:40 -0400 (EDT) Received: from smtp-bc0c.mail.infomaniak.ch (smtp-bc0c.mail.infomaniak.ch [45.157.188.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2F9153F94A for ; Sat, 21 Mar 2026 10:19:39 -0400 (EDT) Received: from smtp-3-0000.mail.infomaniak.ch (unknown [IPv6:2001:1600:4:17::246b]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fdLt704KMzFnm; Sat, 21 Mar 2026 15:10:07 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4fdLt648Mfz2fG; Sat, 21 Mar 2026 15:10:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 X-Greylist: delayed 571 seconds by postgrey-1.37 at lists.libvirt.org; Sat, 21 Mar 2026 10:19:39 EDT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gugod.fr; s=20250112; t=1774102206; bh=+6ebdc7pvIrWdxGvg5zH2AnKWg8PzlQFS5sc58DlATE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SvK7zEI7rNQ+j7E2/n2209pEh8HU1uPDxX8dSpHyYUytkuvfOVjsIBliGRKo8ii9S ZQMFqe5oc2X+ergBflx6dm32uY19COobbIMRsLBbJUQ+lNxbIA5z0ceVmB1suygIxx ObPiOObVL9Co29n9YlnTeGRlRQUzLW5tun4mkHtkGoJw02yn84lJwlbQDs1JlLASKf B+L+9BTmFpePQL6EJGBcAtrq07HrjePh+EyL8YejweuItm3zVATJTRzi0zZ3fTwool HaoLHecHHSKrenPd6lyYNITcXdafHqow/tZ0bDL2dGgkTi9WAoYe+lQj41iaQvMQNG TAkst2lBIWqPg== To: devel@lists.libvirt.org Subject: [PATCHv2 3/4] qemu, libxl: migration: Call hook script on source host at migration start Date: Sat, 21 Mar 2026 15:09:03 +0100 Message-ID: <20260321140923.23807-4-guy.godfroy@gugod.fr> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260321140923.23807-1-guy.godfroy@gugod.fr> References: <20260321140923.23807-1-guy.godfroy@gugod.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Infomaniak-Routing: alpha Message-ID-Hash: XZRQWJG3SBWYTVGSN7TS53XOSX7KIRHQ X-Message-ID-Hash: XZRQWJG3SBWYTVGSN7TS53XOSX7KIRHQ X-MailFrom: guy.godfroy@gugod.fr X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pkrempa@redhat.com, Guy Godfroy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Guy Godfroy via Devel Reply-To: Guy Godfroy X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774102879464158500 Content-Type: text/plain; charset="utf-8" Currently, the hook script with the "migrate" operation is only called on the destination host at the beginning of incoming migration. This makes it impossible for the source host to prepare for migration, for example to change storage locks from exclusive to shared mode when using shared LVM storage with lvmlockd. Add a hook call on the source host at the beginning of outgoing migration using the new "migrate-outgoing" operation. The hook is called with "source" as the extra argument and "begin" as the sub-operation. The script is not used as a filter; its output is ignored. If the script returns failure, the migration is canceled. The same change is also applied to the libxl driver for consistency. Signed-off-by: Guy Godfroy --- docs/hooks.rst | 32 ++++++++++++++++++++++++++++++-- src/libxl/libxl_migration.c | 17 +++++++++++++++++ src/qemu/qemu_migration.c | 17 +++++++++++++++++ 3 files changed, 64 insertions(+), 2 deletions(-) diff --git a/docs/hooks.rst b/docs/hooks.rst index 0310e0d82c..cff1711536 100644 --- a/docs/hooks.rst +++ b/docs/hooks.rst @@ -257,6 +257,18 @@ operation. There is no specific operation to indicate = a "restart" is occurring. is not valid, incoming migration will be canceled. This hook may be use= d, e.g., to change location of disk images for incoming domains. =20 +- :since:`Since 12.3.0`, the qemu hook script is also called at the begin= ning + of outgoing migration on the **source** host. It is called as: + + :: + + /etc/libvirt/hooks/qemu guest_name migrate-outgoing begin source + + with domain XML sent to standard input of the script. Unlike the destin= ation + hook, this script does not act as a filter and any output is ignored. I= f the + script returns failure, the migration will be canceled. This hook may b= e used, + e.g., to change storage lock mode from exclusive to shared before migra= tion. + - :since:`Since 1.2.9`, the qemu hook script is also called when restorin= g a saved image either via the API or automatically when restoring a manage= d save machine. It is called as: @@ -430,6 +442,18 @@ operation. There is no specific operation to indicate = a "restart" is occurring. is not valid, incoming migration will be canceled. This hook may be use= d, e.g., to change location of disk images for incoming domains. =20 +- :since:`Since 12.3.0`, the libxl hook script is also called at the begi= nning + of outgoing migration on the **source** host. It is called as: + + :: + + /etc/libvirt/hooks/libxl guest_name migrate-outgoing begin source + + with domain XML sent to standard input of the script. Unlike the destin= ation + hook, this script does not act as a filter and any output is ignored. I= f the + script returns failure, the migration will be canceled. This hook may b= e used, + e.g., to change storage lock mode from exclusive to shared before migra= tion. + - :since:`Since 6.5.0`, you can also place several hook scripts in the directory ``/etc/libvirt/hooks/libxl.d/``. They are executed in alphabe= tical order after main script. In this case each script also acts as filter a= nd can @@ -566,10 +590,14 @@ Migration of a QEMU guest involves running hook scrip= ts on both the source and destination hosts: =20 #. At the beginning of the migration, the *qemu* hook script on the - **destination** host is executed with the "migrate" operation. + **source** host is executed with the "migrate-outgoing" operation and + "source" as the extra argument (:since:`since 12.3.0`). This allows the + source host to prepare for migration, e.g., changing storage locks. +#. Then, the *qemu* hook script on the **destination** host is executed + with the "migrate" operation. #. Before QEMU process is spawned, the two operations ("prepare" and "star= t") called for domain start are executed on **destination** host. -#. If both of these hook script executions exit successfully (exit status = 0), +#. If all of these hook script executions exit successfully (exit status 0= ), the migration continues. Any other exit code indicates failure, and the migration is aborted. #. The QEMU guest is then migrated to the destination host. diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index f5dee7627b..be51cfd316 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -411,6 +411,23 @@ libxlDomainMigrationSrcBegin(virConnectPtr conn, if (!libxlDomainMigrationIsAllowed(def)) goto endjob; =20 + /* Call hook to allow source host to prepare for migration */ + if (virHookPresent(VIR_HOOK_DRIVER_LIBXL)) { + g_autofree char *hookxml =3D NULL; + int hookret; + + if (!(hookxml =3D virDomainDefFormat(def, driver->xmlopt, + VIR_DOMAIN_DEF_FORMAT_SECURE))) + goto endjob; + + hookret =3D virHookCall(VIR_HOOK_DRIVER_LIBXL, def->name, + VIR_HOOK_LIBXL_OP_MIGRATE_OUTGOING, VIR_HOOK= _SUBOP_BEGIN, + "source", hookxml, NULL); + + if (hookret < 0) + goto endjob; + } + xml =3D virDomainDefFormat(def, driver->xmlopt, VIR_DOMAIN_DEF_FORMAT_= SECURE); /* Valid xml means success! EndJob in the confirm phase */ if (xml) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index fec808ccfb..e9ce2d8b8b 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2870,6 +2870,23 @@ qemuMigrationSrcBeginPhase(virQEMUDriver *driver, vm->newDef && !qemuDomainVcpuHotplugIsInOrder(vm->newDef))) cookieFlags |=3D QEMU_MIGRATION_COOKIE_CPU_HOTPLUG; =20 + /* Call hook to allow source host to prepare for migration */ + if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { + g_autofree char *xml =3D NULL; + int hookret; + + if (!(xml =3D qemuDomainDefFormatLive(driver, priv->qemuCaps, vm->= def, + priv->origCPU, false, true))) + return NULL; + + hookret =3D virHookCall(VIR_HOOK_DRIVER_QEMU, vm->def->name, + VIR_HOOK_QEMU_OP_MIGRATE_OUTGOING, VIR_HOOK_= SUBOP_BEGIN, + "source", xml, NULL); + + if (hookret < 0) + return NULL; + } + if (qemuBlockNodesEnsureActive(vm, vm->job->asyncJob) < 0) return NULL; =20 --=20 2.53.0 From nobody Mon Mar 23 23:45:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1774103429; cv=none; d=zohomail.com; s=zohoarc; b=IK+SDQAT0D+3DeUD3JVsUPJ3N+fg3rJNRWS+oPS2kx/A9QXF4HaXNUgnWSK55ZTLEjA+9PSr9/nLBfARg41aL/pFX46Uoq3pNWpQMl8L8lpPcIqrVqzfuY9Q9Fbjh1+Oc7h5lSXjLf9F0kSYI1lIW1IUaototMG8i2oUS6nDWEw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1774103429; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id; bh=IqhZXr7/M22XCssEs4Dcr+Q8CFg3GZ3h+nsIXcBO4Fc=; b=eHIY1OcyR9ATlrzckTdVNb3/muNYj1IiMJMjxMvmX18w4NW1hZxzkWbtMtWed3IPaM1bLyEuNrFo8zR3WRHlqgE4mNS3Ze73zDekJpFQSk7AvMYNlvLFya4eIlDXsSLDvVBRakAV13Cz08vGAhHtPRDdJvUd4V8g50R/eAq7tgQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1774103429384896.101480459795; Sat, 21 Mar 2026 07:30:29 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 8D0D94194A; Sat, 21 Mar 2026 10:30:27 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 4F36841AFB; Sat, 21 Mar 2026 10:29:44 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 3E4F2417D6; Sat, 21 Mar 2026 10:29:40 -0400 (EDT) Received: from smtp-8fa8.mail.infomaniak.ch (smtp-8fa8.mail.infomaniak.ch [83.166.143.168]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 56B4A41831 for ; Sat, 21 Mar 2026 10:29:39 -0400 (EDT) Received: from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch [10.4.36.107]) by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4fdLt73PRVzGZ2; Sat, 21 Mar 2026 15:10:07 +0100 (CET) Received: from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4fdLt703Swz1LT; Sat, 21 Mar 2026 15:10:06 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gugod.fr; s=20250112; t=1774102207; bh=IqhZXr7/M22XCssEs4Dcr+Q8CFg3GZ3h+nsIXcBO4Fc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sUhb4qGHs7spdp2wUVk9PQSpKbWPLwFAXS+UO8HOXPmg22puDQN2jnptFdXOVVYkq m9mnnBPkVMGCOHd2B+Wi4WdKOeMg8Tm4EgDl66AFhWPSyWZb3d6PXVY54Pnv//QyrG x9f1ms8oD4SR6T+0dgSlSAn1kOhUjbxkRJgNkRJwiRXZFAEqRbw7A8++PfaNsdxbGa +DyzGHNoXeye23nU4Jv3BrHabt0nLk5EXtUepCy59rify1HTB1aOR7zj5KgAzmsY2a DgnhalvI+zIv36YvigU+t8Q2pY6IwZSZpCyYy/anN9Zf8CgIHRryQnowWOCc4iYoga i91OTOgu18V9Q== To: devel@lists.libvirt.org Subject: [PATCHv2 4/4] qemu, libxl: migration: Call hook script on source host when migration fails Date: Sat, 21 Mar 2026 15:09:04 +0100 Message-ID: <20260321140923.23807-5-guy.godfroy@gugod.fr> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260321140923.23807-1-guy.godfroy@gugod.fr> References: <20260321140923.23807-1-guy.godfroy@gugod.fr> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Infomaniak-Routing: alpha Message-ID-Hash: WDLHI4ANLFN2I2UFNK2N6XGDIA36JI7P X-Message-ID-Hash: WDLHI4ANLFN2I2UFNK2N6XGDIA36JI7P X-MailFrom: guy.godfroy@gugod.fr X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pkrempa@redhat.com, Guy Godfroy X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Guy Godfroy via Devel Reply-To: Guy Godfroy X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1774103431943154100 Content-Type: text/plain; charset="utf-8" When outgoing migration fails after the "migrate-outgoing begin source" hook was executed, the source host has no way to be notified and cannot undo changes made in the begin hook (e.g., restoring exclusive storage locks after switching to shared mode). Add a hook call on the source host when migration fails, using the "migrate-outgoing" operation with "end" as the sub-operation and "failed" as the extra argument. The hook output and return code are ignored since migration has already failed. For qemu, the fail hook is called in the confirm phase when retcode !=3D 0. For libxl, the fail hook is called in both the perform phase (when perform fails, since confirm is not called) and the confirm phase when cancelled is true. Resolves: https://gitlab.com/libvirt/libvirt/-/issues/37 Signed-off-by: Guy Godfroy --- docs/hooks.rst | 27 ++++++++++++++++++++++++++- src/libxl/libxl_migration.c | 22 ++++++++++++++++++++++ src/qemu/qemu_migration.c | 12 ++++++++++++ 3 files changed, 60 insertions(+), 1 deletion(-) diff --git a/docs/hooks.rst b/docs/hooks.rst index cff1711536..4fe02b7c28 100644 --- a/docs/hooks.rst +++ b/docs/hooks.rst @@ -269,6 +269,17 @@ operation. There is no specific operation to indicate = a "restart" is occurring. script returns failure, the migration will be canceled. This hook may b= e used, e.g., to change storage lock mode from exclusive to shared before migra= tion. =20 +- :since:`Since 12.3.0`, when migration fails on the source host, the qemu + hook script is called to allow the source host to undo any changes made= in + the begin hook. It is called as: + + :: + + /etc/libvirt/hooks/qemu guest_name migrate-outgoing end failed + + with domain XML sent to standard input of the script. Any output and the + return code of the script are ignored. + - :since:`Since 1.2.9`, the qemu hook script is also called when restorin= g a saved image either via the API or automatically when restoring a manage= d save machine. It is called as: @@ -454,6 +465,17 @@ operation. There is no specific operation to indicate = a "restart" is occurring. script returns failure, the migration will be canceled. This hook may b= e used, e.g., to change storage lock mode from exclusive to shared before migra= tion. =20 +- :since:`Since 12.3.0`, when migration fails on the source host, the lib= xl + hook script is called to allow the source host to undo any changes made= in + the begin hook. It is called as: + + :: + + /etc/libvirt/hooks/libxl guest_name migrate-outgoing end failed + + with domain XML sent to standard input of the script. Any output and the + return code of the script are ignored. + - :since:`Since 6.5.0`, you can also place several hook scripts in the directory ``/etc/libvirt/hooks/libxl.d/``. They are executed in alphabe= tical order after main script. In this case each script also acts as filter a= nd can @@ -599,7 +621,10 @@ destination hosts: called for domain start are executed on **destination** host. #. If all of these hook script executions exit successfully (exit status 0= ), the migration continues. Any other exit code indicates failure, and the - migration is aborted. + migration is aborted. If migration is aborted, the *qemu* hook script on + the **source** host is executed with the "migrate-outgoing" operation, + "end" sub-operation, and "failed" as the extra argument + (:since:`since 12.3.0`). The return code is ignored. #. The QEMU guest is then migrated to the destination host. #. Unless an error occurs during the migration process, the *qemu* hook sc= ript on the **source** host is then executed with the "stopped" and "release" diff --git a/src/libxl/libxl_migration.c b/src/libxl/libxl_migration.c index be51cfd316..4e7e2bdbe9 100644 --- a/src/libxl/libxl_migration.c +++ b/src/libxl/libxl_migration.c @@ -1237,6 +1237,17 @@ libxlDomainMigrationSrcPerform(libxlDriverPrivate *d= river, VIR_WARN("Unable to release lease on %s", vm->def->name); } } else { + /* Call hook to notify source host that migration failed */ + if (virHookPresent(VIR_HOOK_DRIVER_LIBXL)) { + g_autofree char *hookxml =3D NULL; + + if ((hookxml =3D virDomainDefFormat(vm->def, driver->xmlopt, + VIR_DOMAIN_DEF_FORMAT_SECURE= ))) + virHookCall(VIR_HOOK_DRIVER_LIBXL, vm->def->name, + VIR_HOOK_LIBXL_OP_MIGRATE_OUTGOING, VIR_HOOK_S= UBOP_END, + "failed", hookxml, NULL); + } + /* * Confirm phase will not be executed if perform fails. End the * job started in begin phase. @@ -1358,6 +1369,17 @@ libxlDomainMigrationSrcConfirm(libxlDriverPrivate *d= river, virObjectEvent *event =3D NULL; =20 if (cancelled) { + /* Call hook to notify source host that migration failed */ + if (virHookPresent(VIR_HOOK_DRIVER_LIBXL)) { + g_autofree char *hookxml =3D NULL; + + if ((hookxml =3D virDomainDefFormat(vm->def, driver->xmlopt, + VIR_DOMAIN_DEF_FORMAT_SECURE= ))) + virHookCall(VIR_HOOK_DRIVER_LIBXL, vm->def->name, + VIR_HOOK_LIBXL_OP_MIGRATE_OUTGOING, VIR_HOOK_S= UBOP_END, + "failed", hookxml, NULL); + } + /* Resume lock process that was paused in MigrationSrcPerform */ virDomainLockProcessResume(driver->lockManager, "xen:///system", diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index e9ce2d8b8b..afb5161ea3 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -4218,6 +4218,18 @@ qemuMigrationSrcConfirmPhase(virQEMUDriver *driver, qemuDomainSetMaxMemLock(vm, 0, &priv->preMigrationMemlock); } =20 + /* Call hook to notify source host that migration failed */ + if (virHookPresent(VIR_HOOK_DRIVER_QEMU)) { + g_autofree char *xml =3D NULL; + + if ((xml =3D qemuDomainDefFormatLive(driver, priv->qemuCaps, + vm->def, priv->origCPU, + false, true))) + virHookCall(VIR_HOOK_DRIVER_QEMU, vm->def->name, + VIR_HOOK_QEMU_OP_MIGRATE_OUTGOING, VIR_HOOK_SU= BOP_END, + "failed", xml, NULL); + } + qemuDomainSaveStatus(vm); virErrorRestore(&orig_err); } --=20 2.53.0