From nobody Tue Mar 24 00:58:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1773945718; cv=none; d=zohomail.com; s=zohoarc; b=GWS5xQMRzo0kupwo5rJqVdlF7dmc7IZQFH5ZPfsZQQ+ggtl6CYdUnwn7U9bK470rpk3IA0QCI1WH0dpqpFZbErLyZbqYJ1bwlAc2/jC1uZOJR+OEiB0ahb7z+ZozfTKlN2TQuflNV6BohzkyixcHdYoRN0MJQmPBqrh3foZsOMM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1773945718; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=vwZUaPqkc8K00cP1Z1z3s7o+gPFnJuQ/q0JOinHNaso=; b=F0FyW+t8/t1gja8PUvAYL16Ss6j7xUE95wvpWlK8bRjR/1Pn8/1KUv1FuxoLLfo5SmZAXGFDgcanBDRkj4Nu1FVZ8SYTpoaAjC/M15Iu36lVckalOeEM2pklJGZZke1EJ/v4KHMcEw298TNmY+Jyif1tqGeI5qeFjIwVHddBI/M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1773945718116586.1440242440738; Thu, 19 Mar 2026 11:41:58 -0700 (PDT) Received: by lists.libvirt.org (Postfix, from userid 993) id 4D9BB418AA; Thu, 19 Mar 2026 14:41:57 -0400 (EDT) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 1EABA41B79; Thu, 19 Mar 2026 14:40:04 -0400 (EDT) Received: by lists.libvirt.org (Postfix, from userid 993) id E12D73F86D; Thu, 19 Mar 2026 14:39:56 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id A7CE13F2BF for ; Thu, 19 Mar 2026 14:39:56 -0400 (EDT) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342--yNJOUgmOk69b_J1aiMyHw-1; Thu, 19 Mar 2026 14:39:54 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id F37EE1800283 for ; Thu, 19 Mar 2026 18:39:53 +0000 (UTC) Received: from himantopus.redhat.com (unknown [10.22.66.78]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7CCD81955F21 for ; Thu, 19 Mar 2026 18:39:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1773945596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vwZUaPqkc8K00cP1Z1z3s7o+gPFnJuQ/q0JOinHNaso=; b=FEY76RkR8/fUZHjIZfAJ0bHeY963lN8vk6isM9ADPm+lQjIB2BfPt6qHPbjPhFHK6W1PKs EJzad+4FNQannda7uRWaJGSMRhLMLo/kJ3dGqXccVk66tLG4go599MjAqSGTmSaEqlKIOa Ml86TliQgLvmhRtZ3lEqDH3052H4Eio= X-MC-Unique: -yNJOUgmOk69b_J1aiMyHw-1 X-Mimecast-MFC-AGG-ID: -yNJOUgmOk69b_J1aiMyHw_1773945594 To: devel@lists.libvirt.org Subject: [PATCH 2/3] hyperv: Implement domainSnapshotDelete() Date: Thu, 19 Mar 2026 13:39:49 -0500 Message-ID: <20260319183950.2100933-3-jjongsma@redhat.com> In-Reply-To: <20260319183950.2100933-1-jjongsma@redhat.com> References: <20260319183950.2100933-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -PsMeTttxKnRZuOvs9XBQkQRH78m9aVK8T5rsGjWkR8_1773945594 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: ELODVKIM6FMVCICO6Y7MXZLYYNFWCOC2 X-Message-ID-Hash: ELODVKIM6FMVCICO6Y7MXZLYYNFWCOC2 X-MailFrom: jjongsma@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jonathon Jongsma via Devel Reply-To: Jonathon Jongsma X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1773945719669158500 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Jonathon Jongsma --- src/hyperv/hyperv_driver.c | 41 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 18e06f0e2a..841d9ccaa5 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -4163,6 +4163,46 @@ hypervDomainSnapshotLookupByName(virDomainPtr domain, } =20 =20 +static int +hypervDomainSnapshotDelete(virDomainSnapshotPtr snapshot, + unsigned int flags) +{ + hypervPrivate *priv =3D snapshot->domain->conn->privateData; + g_autoptr(hypervInvokeParamsList) params =3D NULL; + g_auto(virBuffer) eprQuery =3D VIR_BUFFER_INITIALIZER; + g_autoptr(Msvm_VirtualSystemSettingData) snapshotVSSD =3D NULL; + + virCheckFlags(0, -1); + + snapshotVSSD =3D hypervDomainLookupSnapshotSD(snapshot->domain, snapsh= ot->name); + if (!snapshotVSSD) + return -1; + + /* Build EPR for the snapshot to destroy */ + virBufferEscapeSQL(&eprQuery, + MSVM_VIRTUALSYSTEMSETTINGDATA_WQL_SELECT "WHERE Inst= anceID =3D '%s'", + snapshotVSSD->data->InstanceID); + + /* Destroy snapshot via DestroySnapshot method */ + params =3D hypervCreateInvokeParamsList("DestroySnapshot", + MSVM_VIRTUALSYSTEMSNAPSHOTSERVIC= E_SELECTOR, + Msvm_VirtualSystemSnapshotServic= e_WmiInfo); + + if (!params) + return -1; + + if (hypervAddEprParam(params, "AffectedSnapshot", &eprQuery, + Msvm_VirtualSystemSettingData_WmiInfo) < 0) + return -1; + + /* Invoke the method */ + if (hypervInvokeMethod(priv, ¶ms, NULL) < 0) + return -1; + + return 0; +} + + static int hypervDomainListAllSnapshots(virDomainPtr domain, virDomainSnapshotPtr **snaps, @@ -4452,6 +4492,7 @@ static virHypervisorDriver hypervHypervisorDriver =3D= { .domainHasCurrentSnapshot =3D hypervDomainHasCurrentSnapshot, /* 12.2.= 0 */ .domainSnapshotCurrent =3D hypervDomainSnapshotCurrent, /* 12.2.0 */ .domainSnapshotGetParent =3D hypervDomainSnapshotGetParent, /* 12.2.0 = */ + .domainSnapshotDelete =3D hypervDomainSnapshotDelete, /* 12.2.0 */ }; =20 =20 --=20 2.53.0