From nobody Tue Mar 24 01:12:53 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1772835407; cv=none; d=zohomail.com; s=zohoarc; b=Il3HFB3MSjRjQOCGkXMAHH7CYU8+6N8mRM4GlXDjap88opDtCatNmWOXwoEf0ZwghyLvZsV5agnMC5HdQXt063Kc5VTTb9hz/ZK2VbKJbd1PMeg0Y3mo0I8AGIiU0hqwSc2M6Vb9NbtlIhjlSojo8uDjdXUf9TEeAqzuiHHAKwY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772835407; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=rJWljYIWKp1su7+DjaEQpDn8u9DyL518YkUkiFoZ1Gk=; b=OLislPnrqDzW7EL8hR32GgXHwOcAUTMQl2TWTNl/20XNI97MzrPIOtPs3dFu35Ep2i7NAmkQNtF25+UquoXO1AhogS+UirFhW1kOwicuoXk5DfI9TxlEkKoo46TxF29gu+Nku+hRUM1zegHiZvJK24Pe+qkGZ3eFrO/S3Y03jnc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772835406981717.4378795323433; Fri, 6 Mar 2026 14:16:46 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 14A93418DF; Fri, 6 Mar 2026 17:16:46 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id BCF6441CF0; Fri, 6 Mar 2026 17:13:12 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 095FE3F8A5; Fri, 6 Mar 2026 17:12:59 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 8C8CF418DE for ; Fri, 6 Mar 2026 17:12:58 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-124-vB22fsz4N1uNQ8idg4ukNQ-1; Fri, 06 Mar 2026 17:12:57 -0500 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 478961956052 for ; Fri, 6 Mar 2026 22:12:56 +0000 (UTC) Received: from himantopus.redhat.com (unknown [10.22.81.168]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DA2C71958DD2 for ; Fri, 6 Mar 2026 22:12:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772835178; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rJWljYIWKp1su7+DjaEQpDn8u9DyL518YkUkiFoZ1Gk=; b=HFOWPmRexzEVL090PaRGIH4DIE6R2fd7lyKy8UosSNZjKTx21skHuOMsVOKyr1A1/3beOf qeO9A1M7S3Y3cb7irMb4FEZKQnxT7+3OjKi5rOpHayHMaIHgNZ6iV3iZN7wuBmE9w+FcKS DGhoPySX03ygZGA9jx+dLo9Ma+2FMFg= X-MC-Unique: vB22fsz4N1uNQ8idg4ukNQ-1 X-Mimecast-MFC-AGG-ID: vB22fsz4N1uNQ8idg4ukNQ_1772835176 To: devel@lists.libvirt.org Subject: [PATCH 4/5] hyperv: Implement virDomainSnapshotCurrent()/virDomainHasCurrentSnapshot() Date: Fri, 6 Mar 2026 16:12:50 -0600 Message-ID: <20260306221251.929040-5-jjongsma@redhat.com> In-Reply-To: <20260306221251.929040-1-jjongsma@redhat.com> References: <20260306221251.929040-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ayED7JknpwBeeAC4szYXrbi1d1yhu5VGI9XncGrtKCI_1772835176 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MC2SYLU3XX6S6KG3EOP7BCLAL6M2Y7RY X-Message-ID-Hash: MC2SYLU3XX6S6KG3EOP7BCLAL6M2Y7RY X-MailFrom: jjongsma@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jonathon Jongsma via Devel Reply-To: Jonathon Jongsma X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772835409587158500 Content-Type: text/plain; charset="utf-8"; x-default="true" Signed-off-by: Jonathon Jongsma --- src/hyperv/hyperv_driver.c | 48 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index 4a4db0e76b..dd1248ced1 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -4235,6 +4235,52 @@ hypervParseInstanceIdFromParentPath(const char *obj_= path) } =20 =20 +static int +hypervDomainHasCurrentSnapshot(virDomainPtr domain, + unsigned int flags) +{ + g_autoptr(Msvm_VirtualSystemSettingData) vssd =3D NULL; + hypervPrivate *priv =3D domain->conn->privateData; + char uuid_string[VIR_UUID_STRING_BUFLEN]; + + virCheckFlags(0, -1); + + virUUIDFormat(domain->uuid, uuid_string); + + if (hypervGetMsvmVirtualSystemSettingDataFromUUID(priv, uuid_string, &= vssd) < 0) + return -1; + + return (vssd->data->Parent !=3D NULL); +} + + +static virDomainSnapshotPtr +hypervDomainSnapshotCurrent(virDomainPtr domain, + unsigned int flags) +{ + hypervPrivate *priv =3D domain->conn->privateData; + char uuid_string[VIR_UUID_STRING_BUFLEN]; + g_autoptr(Msvm_VirtualSystemSettingData) vssd =3D NULL; + g_autofree char* current_snapshot =3D NULL; + + virCheckFlags(0, NULL); + + virUUIDFormat(domain->uuid, uuid_string); + + if (hypervGetMsvmVirtualSystemSettingDataFromUUID(priv, uuid_string, &= vssd) < 0) + return NULL; + + current_snapshot =3D hypervParseInstanceIdFromParentPath(vssd->data->P= arent); + if (!current_snapshot) { + virReportError(VIR_ERR_NO_DOMAIN_SNAPSHOT, "%s", + _("the domain does not have a current snapshot")); + return NULL; + } + + return virGetDomainSnapshot(domain, current_snapshot); +} + + static char * hypervDomainSnapshotGetXMLDesc(virDomainSnapshotPtr snapshot, unsigned int flags) @@ -4345,6 +4391,8 @@ static virHypervisorDriver hypervHypervisorDriver =3D= { .domainListAllSnapshots =3D hypervDomainListAllSnapshots, /* 12.2.0 */ .domainSnapshotNum =3D hypervDomainSnapshotNum, /* 12.2.0 */ .domainSnapshotGetXMLDesc =3D hypervDomainSnapshotGetXMLDesc, /* 12.2.= 0 */ + .domainHasCurrentSnapshot =3D hypervDomainHasCurrentSnapshot, /* 12.2.= 0 */ + .domainSnapshotCurrent =3D hypervDomainSnapshotCurrent, /* 12.2.0 */ }; =20 =20 --=20 2.53.0