From nobody Mon Mar 23 23:24:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1772816266; cv=none; d=zohomail.com; s=zohoarc; b=SlhpC/KVkSAnwPsFrTrb3K7w8eDUc9uzYTUVUSW+TL+uGx2won5UvINZK+tDRVLx87gEBbZ1Uf/UuOKuCCD4lbZziADQb/I9xy8F0jXK3sNf9duucZ7aH3ivl1x7kcJDOe98cIYStKWznv20Cg+uIzcWhB+exOP0SsZy9bf1fl8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772816266; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id; bh=WnwcEAZ4raEBtKCZp0EfQHhsLU8MZXqIUWo8qeO8S7I=; b=M5/h+44v4t8zTPqZwfLd7RgmP2RZdN+xEK5LDkL+fMhxpVOrcfHga+8aqeKiU9QpD+Tiu3YbdjfdI1scqKjNqut6F76S4L0/Aqg6ehlxvy/miTFbDebjHfotD60ehbAV0RpFPPLY6Qp8BfYgj/qUiade0hiNqJiWVT5edvoMOFE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772816266774287.15970537864143; Fri, 6 Mar 2026 08:57:46 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9D54C41937; Fri, 6 Mar 2026 11:57:45 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8508341A04; Fri, 6 Mar 2026 11:57:10 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id C9D9A3F943; Fri, 6 Mar 2026 11:57:06 -0500 (EST) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D706141893 for ; Fri, 6 Mar 2026 11:57:05 -0500 (EST) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-482f454be5bso97041845e9.0 for ; Fri, 06 Mar 2026 08:57:05 -0800 (PST) Received: from localhost (205-201-32-8.scinternet.net. [205.201.32.8]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2be56d73a20sm727058eec.8.2026.03.06.08.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 08:57:03 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772816224; x=1773421024; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=WnwcEAZ4raEBtKCZp0EfQHhsLU8MZXqIUWo8qeO8S7I=; b=NV/L/1VGdiECMAd6HDPzCW038ggx7L4C2KiqiJ5kGe/NyXd3jpNopijys287wvgw3e VSyGWtg6p3bxQZU2A3ba7WOtsQkgkAkdPWtZvSRT2AVuTQZ74P1xE0vSqo001kxNvKb/ 2DgtioDdlqusKu/D416rtJRoQgFvL0F0ZGJm0BOjs0x5z6Twtu/peP6G/mi6ZyM1sGF8 J3KewB88bZ0IbkTwMD6C/MYgZLNMpOUTMC49XvoDRUizzFzIq1JgmlyM9yUiYm7IH76f qx05fbmaVjgojLU0vKvcE5iaGo83KsJKisXPPc7l4yUBohUnfnQbisTDkNZOyNVAiZu6 o94Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772816224; x=1773421024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WnwcEAZ4raEBtKCZp0EfQHhsLU8MZXqIUWo8qeO8S7I=; b=TefUTAKnL/+JYM6qiJ/afe2f8uuNHDsRt8gFZ5TbVW2bPW9d+BHYtpenMTWh5IgndC MKH1klBB7jNt6jobU2s3xY2HkdpWcyxBYjBg0NsGGhRiGWr+l66BG9gyHVuBN1yk0/mU PSBjnfiRuup8349a3n5Mq7YARhT5nQhwCmQYJabCD6oy+jz6nhxOPSfI91vDjqkvnaN3 OF5vD49TtuUH0ss8kuoRDLyf7LH9EVBmCKcPLNNPyWgHC52tMA8nA0UaAOJcthY+KkMA LbPy7Z//doaq/BQLqQo6lV85L5/HZgUlpZonCUUK4WOf/sUMRTvt1UDP1na5JwkNp0ne eZPA== X-Gm-Message-State: AOJu0YzgdCBCAW5P0JFnY1N80cDMxopIn/mOKyU14Xopp+912EIbFUp5 Ynq/uIO0zpVvXrigj5oGj3swYvJe+/OCQEcZdEw2H/1jPtPohrjz8Kbe3cYx3Tf8nRwPFidsLg8 G5gCW/gI= X-Gm-Gg: ATEYQzyi12QGPy33i0OPOUSGLlSY1SYCYjCiuMbkhBxMO1UxycxK46nujHJWsaBfctD bUP2m8iFbRH8ck/U+dgjaMQ/bKecFAMb8JmUqnNL9OQu23Wat/UkL6lHPJbbi/4w+AP8AVIeV0d rE6lXwfBjcdJQwlR6rJAMeAN2VEbiIxJat5Yq2ixSFpDDvFi0unnGSYklhVUSx2xhSX1FM+5CdD +4zwZiydJBAh1dEJWar9LY32iCoyMofAlFeSaoHgrSQprJRQkxOo+kjmNhvAG9MfeTbsaXCL+sK r6qcLuuFcvJzTsVhA5HgmhI12ppGB0PCYZBCiKF1uybKRYvcVCSLS8CAXooXBksfMSW7k0RsK1F m3bzjgKGQLxFC4/xz5PdpEwdRFh4U+mqDGgN1RBiWuInIYlQuXakV8tMpvkzNgrCXmUIASh3pRe T+W3WyByVVq5jY1GFO0vYsAuZvIGWmuzvu2lvJkn9J X-Received: by 2002:a05:600c:8586:b0:47e:e0b3:2437 with SMTP id 5b1f17b1804b1-4851ee73b5dmr113336865e9.5.1772816224520; Fri, 06 Mar 2026 08:57:04 -0800 (PST) To: devel@lists.libvirt.org Subject: [PATCH] test: Default to ROM type for loader Date: Fri, 6 Mar 2026 09:56:16 -0700 Message-ID: <20260306165702.31960-1-jfehlig@suse.com> X-Mailer: git-send-email 2.51.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JTWQHLPPUP3MCMFY7UL2WJVGYXPS6RDZ X-Message-ID-Hash: JTWQHLPPUP3MCMFY7UL2WJVGYXPS6RDZ X-MailFrom: jfehlig@suse.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: abologna@redhat.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jim Fehlig via Devel Reply-To: Jim Fehlig X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772816271164154100 Content-Type: text/plain; charset="utf-8" From: Jim Fehlig Commit 1504b7f687 moved the corresponding logic from the generic postparse code to drivers but failed to update the test driver, which causes failures in virt-manager's test suite. Fixes: 1504b7f687bdfc679377e605d076776b18533468 Signed-off-by: Jim Fehlig --- As an alternative to this patch, we can consider reverting 1504b7f687 (and the subsequent bhyve fix) to avoid duplicating the logic. src/test/test_driver.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 1165689de7..536e291861 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -421,6 +421,22 @@ testDomainDevicesDefPostParse(virDomainDeviceDef *dev = G_GNUC_UNUSED, } =20 =20 +static int +testDomainDefPostParse(virDomainDef *def, + unsigned int parseFlags G_GNUC_UNUSED, + void *opaque G_GNUC_UNUSED, + void *parseOpaque G_GNUC_UNUSED) +{ + if (def->os.loader && + def->os.loader->path && + !def->os.loader->type) { + def->os.loader->type =3D VIR_DOMAIN_LOADER_TYPE_ROM; + } + + return 0; +} + + static void testDomainObjPrivateFree(void *data) { @@ -448,6 +464,7 @@ testDriverNew(void) VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT | VIR_DOMAIN_DEF_FEATURE_NET_MODEL_STRING, .devicesPostParseCallback =3D testDomainDevicesDefPostParse, + .domainPostParseCallback =3D testDomainDefPostParse, .defArch =3D VIR_ARCH_I686, }; virDomainXMLPrivateDataCallbacks privatecb =3D { --=20 2.51.0