From nobody Mon Mar 23 23:25:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772794024; cv=none; d=zohomail.com; s=zohoarc; b=QJx4PkUJHnkpPlkl5nJZIdRx1Odltbhmyo1rvC9M450acwe5hk/dWNBUikQA5vcJM3jPc6i2VM/YmLTPxg6aOxMbxJ9/kVT3dwD1KW6+m1lOPYpZTKUDprDsiN3C0EQib15ZGCyGq5bgAQsCOIoFVdhLwHqoJtb6TXlqpY5P/0w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772794024; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=YebBPzB1eaVQdxZtV20OgIi1+Y1TEX1rBAdH2X2MzbQ=; b=SFDrbpfHcQY/ABViLBR2d7zxv+w1hPsgdGrPAy0EHlRTXADXEgwrz1RnOukW7gfaLa3LeIL/m7SufvkN3cak+9RsJ+3kbdRQsVMsuVnNhw78pgG3nDA44vB5PfWulZC+69R1QoZAkvkXDi35aM5WWc6Zux7cgzWUAznzcNmuLGM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177279402424118.14263138866272; Fri, 6 Mar 2026 02:47:04 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 5F08C418B9; Fri, 6 Mar 2026 05:47:03 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 848F3419C3; Fri, 6 Mar 2026 05:46:32 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3C9AB3F96E; Fri, 6 Mar 2026 05:46:28 -0500 (EST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id EB95F418B9 for ; Fri, 6 Mar 2026 05:46:27 -0500 (EST) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-439cd6b09f8so1553344f8f.3 for ; Fri, 06 Mar 2026 02:46:27 -0800 (PST) Received: from rbta-spb-lt-115149.astralinux.ru.astra-academy.ru (187.12.32.95.dsl-dynamic.vsi.ru. [95.32.12.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dad97da3sm3150971f8f.12.2026.03.06.02.46.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 02:46:26 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,HELO_MISC_IP,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772793986; x=1773398786; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YebBPzB1eaVQdxZtV20OgIi1+Y1TEX1rBAdH2X2MzbQ=; b=bk7kA2ELLLAH1PA3YVYvH00aGLoTWpYowjs1ripQiM80oXoO4XTgmaNdYysU6jD57L 98pOyTXdwn6/nDqHEUQGjkQ5zvDbSZabh5ygLAhz2k145MPbjG2NG0JOi5jER0xvEr6f 6ZU3N2dSnIbUAIOoD+6eTOcY75T3ei0kl1wWnEtIQuhYLYGOaS42kVMvFl9/U5Dg0+mj jQzXMIwVAgkXT3jAF7t4JZ71iJDoQiSyC8qLF1YX4e/r8AHo/oMIa81YipCGKhs7v1nM TX1glddjxbu6+PfrIfCJ6qb9UzZlHwy/HXlmkvMkXmv2NqvChzw9CpmUJLzvsqeern9T 9Bfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772793986; x=1773398786; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YebBPzB1eaVQdxZtV20OgIi1+Y1TEX1rBAdH2X2MzbQ=; b=xADCrX1EKIKtVT4sBcGjQx81NVlb6ALhxE9Z61ZW4m1wlkxqsjv6qXXkDUwcZrZgXD eOHXunDZ5kynOcgP/TC110PjaM0/gxo5CRiXeVwWQowAD54SkqjO1AYfwBfDsSnMQb5x wky2J2YFVyBgSY+JaPnjgg865sMXYfR/aYWox4t7aBwXlLLXJU3hfZbwe6IW4FAeC4Ni yAN15vogUUWNqcUto80jAABWlmlGs/VYmojIBmpYcNl8XEE6wfVv4fwFKrf6FOkP7E6A BYmNUOeAe5lJJa4pYha2r41BcTvu3Qo4CDXVL/RkJcCzwYLiCYrk4fMG3bvTdXp3rbPm 5ptg== X-Gm-Message-State: AOJu0YxJq3GJ4rCv8RneH6YrR+DG6WrOikW3xtlrkasi1ugmlmx5cmNq ggznU5w2JVVblX3EtyuRWrngvQj+WKwWLH2C2bPOhHFNgQvoGwufOXdFJVJDcXwGFxs= X-Gm-Gg: ATEYQzx7G/Kq87vteHjIGmvVbzGPMiJfwEPDfNVYtPxzVGzUwRSGWzD7A9r4GqLO0tu TTKgLxg+GeWqTaMUTCPa6Obiw58LmXwOIMEQO3ci9xH+Dwbwsog2QBQiy52RtXjdXlAtSTO2sEJ 9pv2KAPo4ISUwLz54SilCMMg36O1dP5FCa8fTTFsqcuAgPhkaQTvZltqA3J3UqYIVFaVs9AuNki /fQyKOOKf1R5jzrLznPSjQxDLgH56ROE4RK2+QuKysO3RWtuj5/szabT0IHiAnvQ4swY9hGUWE5 KBQOghWDxZCu0+xquVCg36FfEh0+HN84jeL63BYBMnt8AGyCLcY+jCn4GCX41g5vaLrMdCwhWIj MKY53oSXyd8xwTu1zZwdbDkUw1yinmBXhpm7zHy8FQQX2nyfvroTO5C0zYQZX8mJ7OzF4qYPIq8 yK6jJjmvPzcTx6ZyEsv/rskCnHTPAzRrtLNqBtdyxlXTX9sS2AnU78nNSxrnXmTgHWAb1xNGfZA LWjXVY3lrC+XurzW+lWU2nkDhLZ8Rjzc4r2gZqmrmVXNllk X-Received: by 2002:a05:6000:186b:b0:439:c040:cc8a with SMTP id ffacd0b85a97d-439da35f6acmr2903616f8f.32.1772793986366; Fri, 06 Mar 2026 02:46:26 -0800 (PST) From: Elizaveta Tereshkina To: devel@lists.libvirt.org Subject: [PATCH] util: json: fix memory leak in virJSONValueFromJsonC() Date: Fri, 6 Mar 2026 13:46:20 +0300 Message-Id: <20260306104620.155169-1-teryoshkina.ea@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: KIK7SDSVOJTNSZHX7BIOMOU7K7ZCB4LI X-Message-ID-Hash: KIK7SDSVOJTNSZHX7BIOMOU7K7ZCB4LI X-MailFrom: teryoshkina.ea@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elizaveta Tereshkina X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772794025029158500 Content-Type: text/plain; charset="utf-8" In the 'json_type_array' case, the error path uses 'g_free()', which doesn't release other nested memory allocations. Replace it with 'virJSONValueFree()' to properly free the entire 'virJSONValue' structure. Fixes: da66bf53b0 (util: json: check return value of virJSONValueFromJsonC) Signed-off-by: Elizaveta Tereshkina Reviewed-by: Michal Privoznik --- src/util/virjson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 454bd657be..72bd78453a 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1438,7 +1438,7 @@ virJSONValueFromJsonC(json_object *jobj) cur =3D virJSONValueFromJsonC(val); =20 if (!cur) { - g_free(ret); + virJSONValueFree(ret); return NULL; } =20 --=20 2.39.2