From nobody Mon Mar 23 23:18:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1772793468; cv=none; d=zohomail.com; s=zohoarc; b=mKvrCGKt0hWttRQdfL2Ryn6qddvzU95O27H1EqgpUwC5QDVimaF3F0V6Wz/m0X7u99P/bkAVyUZYwPiSrk/QQZFIgif/xxkUbz0XBULLG7IBzZLAkdtL4GnB0G/oOhj6hjVWkDT+jBRXH1sq8K78hz03DUrP3i3yAs6pByGd6AY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772793468; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=kyeu83FiF/Kof51iYEDpvcZ1Aube2cCY5FPUZiowyXk=; b=IDwEvBu3xP7okkHrawScPiA7CmolfgdG2DAKqxGr1D1AxlzLX7E4Ee/MBRRgsBGvkLI/CdUlW0g5jKI3xS7DRbWI7IkJuG6wEgSQ+2rxutqYinrlxGV4mYTYjATD8BSJxnZR+D2NRs13XgQil8kqBe2RoNV7iw33wxgQS+yv+64= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772793468805324.3258061047035; Fri, 6 Mar 2026 02:37:48 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6753041898; Fri, 6 Mar 2026 05:37:47 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id C3F2241A36; Fri, 6 Mar 2026 05:37:17 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 7BF3D41880; Fri, 6 Mar 2026 05:37:12 -0500 (EST) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C2D123F96E for ; Fri, 6 Mar 2026 05:37:11 -0500 (EST) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-439af00d33cso5885489f8f.1 for ; Fri, 06 Mar 2026 02:37:11 -0800 (PST) Received: from rbta-spb-lt-115149.astralinux.ru (187.12.32.95.dsl-dynamic.vsi.ru. [95.32.12.187]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae2ba5bsm2578940f8f.22.2026.03.06.02.37.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Mar 2026 02:37:09 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FORGED_GMAIL_RCVD,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,HELO_MISC_IP, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772793430; x=1773398230; darn=lists.libvirt.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=kyeu83FiF/Kof51iYEDpvcZ1Aube2cCY5FPUZiowyXk=; b=Ouyrq7SlxXLTuU6bPJ8gnXvyCXhzOqpdTUVGo6YbsDHzmtqA7t8swRLbfAMDTzGo3j HTy/YmgIa1SCHxyDaevDIMdioZht8dRbGRE9Nnuhne/vQvjpa8hkFqiBmAnakmnEMiO8 UN/yvkynlY/ihtLBT18XLTwYvNSN6KHY7AUEifmeqHjgC5nOrzGekE94BvhwMvMMcQv1 HrX3CWGXkgDaLyG9A3Gj+czeDTBDvriI/xz8HXWPshzpwam8OE+/5S7gAWjD1LitlGK3 O4YCI/puRaIJs+0Q0TegRQG+iAIStwlxzMn2o62OOHreViOJJF/L2E8YwmV6YXp1Bm5/ AyAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772793430; x=1773398230; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kyeu83FiF/Kof51iYEDpvcZ1Aube2cCY5FPUZiowyXk=; b=Sk7KYbMlzfSJKVntThDqIhEWS1QECrExoRfYW9iRO92wg9D26ILgrE89q4l2O1XLsx JUDI2x7c3O81jevGmyIFoW6Rc449nihCUEF1fvE+8Pixzev+2Y979Z8kl948wtW8UCBM nXB7yemv1zcm1BQWd+qoTrHAseyraC8Vg1KQepJ40ldbhtqN4evf3wuyEDgNNCbMxdH+ qSrhGin/sGchQX1O0xY9dcEAlXOausQUOolK1sPnLX2rJ/lBcoMkUg4AotIo5XdyO2jM DJdZvIasTU2ptSGgh+evOh4zhw2jOU/CBvhhm7ecIN8YD2aWPqmupUejAhQh7T34UdRm fjkQ== X-Gm-Message-State: AOJu0Yyw19AmBdcmvv17UaqP0UQV6sFWKR/ij/x9JAwozWKnk1uxYe42 beahIuIOEQqMkJaZirmRo+a4gy978slB+EXWc23eNFzZvuADu07OhHfgQ6CdVgExheM= X-Gm-Gg: ATEYQzy6Lw8uw4CeVbtCAV3bBfL9jrjNFZ9smZHUeMNzIvjx4Pxaaqyr3xZ7bI6dbjp wtZf66nAt3x9oJYM6PJ56sLuBuRHEbG6tS1SfFqSa7gWgnVstJlBajpZ9d2eOKQVsf9libL7AvF nyRyN1UeN/ZjjrV4SNqgbN+sps9s6Z/S7WhlImcsg5JiocF7XIN3kPjoBtNF7pBvEdi/M/2+czz UFH8cTbHquBxxpv+uiB2IIXLEArTn37CHZEVyLJ8f614XRSBS+bdY9L/EtotKhTfOCA01dW6aUf R3k0+tkd2pELiecyUQh8lKaWdg/XFoZcmJ937Bm8HPc4McuZ+NCVyb6VflJ97WvLWLL4+Og5KB3 r/Noa+z/j8yvwzIIBrZOww7kvV/1UT/wv6veJfvva7pV3mZMHgX5lJDyw9kKsnWvtlwvkMKyl82 C0JrvYuWAcZQk96q4DJYgIGsZEKihx6lUmJAcW3wLIYiWhOnRnZKsew74bu74KUxzfey5XyebqT lUrGBFAFTwqt+Q= X-Received: by 2002:a5d:64c4:0:b0:439:b55d:b0e5 with SMTP id ffacd0b85a97d-439da880b19mr2636339f8f.28.1772793430129; Fri, 06 Mar 2026 02:37:10 -0800 (PST) From: Elizaveta Tereshkina To: devel@lists.libvirt.org Subject: [PATCH] util: json: fix memory leak in virJSONValueFromJsonC() Date: Fri, 6 Mar 2026 13:36:59 +0300 Message-Id: <20260306103659.90975-1-teryoshkina.ea@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Message-ID-Hash: WZH2KPBML5RDRNECTW45X46U6667DPJT X-Message-ID-Hash: WZH2KPBML5RDRNECTW45X46U6667DPJT X-MailFrom: teryoshkina.ea@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elizaveta Tereshkina X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1772793470933158500 Content-Type: text/plain; charset="utf-8" In the 'json_type_array' case, the error path uses 'g_free()', which doesn't release other nested memory allocations. Replace it with 'virJSONValueFree()' to properly free the entire 'virJSONValue' structure. Fixes: da66bf53b0 (util: json: check return value of virJSONValueFromJsonC) Signed-off-by: Elizaveta Tereshkina --- src/util/virjson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virjson.c b/src/util/virjson.c index 454bd657be..5780dbb094 100644 --- a/src/util/virjson.c +++ b/src/util/virjson.c @@ -1438,7 +1438,7 @@ virJSONValueFromJsonC(json_object *jobj) cur =3D virJSONValueFromJsonC(val); =20 if (!cur) { - g_free(ret); + virJSONValue(ret); return NULL; } =20 --=20 2.39.2