From nobody Tue Mar 3 03:24:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=pass (i=1 dmarc=pass fromdomain=cyberus-technology.de); dmarc=pass(p=none dis=none) header.from=cyberus-technology.de ARC-Seal: i=2; a=rsa-sha256; t=1772196046; cv=pass; d=zohomail.com; s=zohoarc; b=Ixaz0+8EdqtJgbmcvA/7QChMK6on+U3U6jdcVBFWFUPUuaMTXsH5ik6/2Y/ubPuA5aDeqX1fCyislIFb9RssVWxNOET7YZ2H1bk6m+dsHRd19rK1kuMYiW7OOalWbxDdEA5tlyeHYta+zD08q0/juxU2Ij9M8JRLxiZmmb8q95c= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1772196046; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=0XhYpJxNjH1Yz0StjqCa6pig2oCkoZfadMRn6wlPOG8=; b=P2ZPsVJM9SkBSPkx9dodupcW0RPKPh+ugi5RCMZG5V2l/J5k+5FceOJiuQcv/trbWm03QDcS7psIXi9JXpIPz93Rz1AusXW5KcfHnPFjQALVizJvx92bXXGjLcJtsyEq4VZDYDcdeEOV7ZQY+MTmaRALFbm95LJ7iPcrrIQ1B8w= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=pass (i=1 dmarc=pass fromdomain=cyberus-technology.de); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772196045291931.2352144172861; Fri, 27 Feb 2026 04:40:45 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 5F2DB41E28; Fri, 27 Feb 2026 07:40:44 -0500 (EST) Received: from [172.19.199.12] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id C2D6641E03; Fri, 27 Feb 2026 07:40:03 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id AB15041D47; Fri, 27 Feb 2026 07:39:58 -0500 (EST) Received: from FR6P281CU001.outbound.protection.outlook.com (mail-germanywestcentralazon11020094.outbound.protection.outlook.com [52.101.171.94]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id D72EB41D43 for ; Fri, 27 Feb 2026 07:39:57 -0500 (EST) Received: from BEZP281MB2758.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:47::10) by FRVP281MB5719.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1c6::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.13; Fri, 27 Feb 2026 12:39:54 +0000 Received: from BEZP281MB2758.DEUP281.PROD.OUTLOOK.COM ([fe80::65af:d2de:99f6:734c]) by BEZP281MB2758.DEUP281.PROD.OUTLOOK.COM ([fe80::65af:d2de:99f6:734c%5]) with mapi id 15.20.9654.015; Fri, 27 Feb 2026 12:39:54 +0000 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DmToiHB78K2EKBC6Vs9NNvppdQAJ29pBUwsBUn9fQFH3uRltl8Q/ktgdoxppuNejrnC9SvczfNWyaPeqptcpuTc6l7CRJvXURTBocZ6Y74grBEE6W7Nia+8rpizOcHtGSV9nTtHItGZTBhd2ddTfcra8wvS8gKC4BjYmJwHi1QHHg/C4PoulXz0MVhHnItz1fkmbLty1PJaB4v6ir8TsERWbD6VJhdu/ym7/1aleHXIfEYOVy0tLO3FOa2WhFCaBE/dZedxbsOgP6BkwOFQ6zM9PPwkGV+2wmruM1EcqMqJDOPSmWuMvPESrVzkn1wO/jNhRrhHjaquOw4sGdPQgAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0XhYpJxNjH1Yz0StjqCa6pig2oCkoZfadMRn6wlPOG8=; b=O/nIlmfz5UIjSKXrEYcw9/hlbQ0NCrPByL2rKHuoJTTUdrrizUVAjggHyMKm2MsVqaSenh0BRYv68EAd78vHKhNYMSxGhmQzgkaQOgaFq4eQdDr6Mo28F7ff9s8RGIP7LYBaXAJV7I3jRSi1FKj81H4JdBX4JBnjBOd9AgPCZDPkdfliheXKOpM45/ugh+nDSSkrsbz1FRRouO/LLb2hE5U79yihK/FX2ZvB9OxjZ8G854ejdCV4SsICJCnfVMgnRNnFMhWPriQs+ByN7/828GpgY3h9Ky5ktzJ7OOXCDesDCd0V9V/Exms+Emq+hGF0rdflg+uS0j9awdD8VCmfGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cyberus-technology.de; dmarc=pass action=none header.from=cyberus-technology.de; dkim=pass header.d=cyberus-technology.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cyberus-technology.de; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0XhYpJxNjH1Yz0StjqCa6pig2oCkoZfadMRn6wlPOG8=; b=fY9ausSblaJ538vqCj1Pb6+H4MXhCtrS+0t9WH0GIlC6yhqEC9EkDp+M/bxXCKenApr3uK4AJ8BuqkNiatAZKskCVePrG6yFi5p4PHNoYwalxmVRc79It2fSFUT8TUgCsdkMQcZIapkh7B3eus/J3WhXWYhpqhHxorORo7MlellF6peofsNVt6j6H2yQGO0kT0rUmvk8LuJc56noz8slkZy7nl3VzcaMsKHfeCQtvCaG2VPBnkuX4ndZodBCaOddPg/taD0F6ofLC1wT8sGWsw4VrQM58RIX1vuMaUbT7YG5zz79qN97sRi1gjTzFs4NbevnRBlpGwjTYWhHPMRWXQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cyberus-technology.de; From: Leander Kohler To: devel@lists.libvirt.org Subject: [PATCH v1 1/1] rpc: free saved close error in virNetClientDispose Date: Fri, 27 Feb 2026 13:39:19 +0100 Message-ID: <20260227123919.395015-2-leander.kohler@cyberus-technology.de> X-Mailer: git-send-email 2.51.2 In-Reply-To: <20260227123919.395015-1-leander.kohler@cyberus-technology.de> References: <20260227123919.395015-1-leander.kohler@cyberus-technology.de> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: FR4P281CA0152.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ba::19) To BEZP281MB2758.DEUP281.PROD.OUTLOOK.COM (2603:10a6:b10:47::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BEZP281MB2758:EE_|FRVP281MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: a45f0321-2ea6-440f-223f-08de75fd4ed8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: HzpS3ChTqU9bluBx29SFiztP6WpMf+/6GWBNWWzjDhhrU3Le68kKWAw+TJDLapBkR1v2+wtXZYOqszH5hr7Xmmvp8PTa1aPtrqWF/wRZl5B57ialLhSflKSDXubz8A230ImScpt+C2zKKjF15LBxf+XmcVcj2l5m35OgQ5p7WDQ9bhSGNlq5t9WHIBf0qMX2k7VrRm5Mf1KoEIfsiklkiFMn6wEOSLH/6w1BcZR/b4UFCKOwBpHG2mmBVsIXnUPX9AJIytfg1CsPbbuXQKy8fP5bY8MsQy2n6SK6tQ9zmaYB6dggj0aCcg3b0nBLaDdIYPtyvBHr0hrEvxjeIUp233X1HqC+dYpomjDgy03LoZYUczW/IoXlk2C/xjFnS9Y2Bsr4vuqqWnYw/XNFLhZSpYCbcaDOaP7dth3xqaRRgFyExygsrC34JagRyfi6Oqg40Wku6l1kLdkYl9azIHQokDX20q2dVUOMK1ldZJhsSxmdkemK+WVR68z1RMOmlvNFHdatbsbf3P/SG/ibKdl5g+M6zXTAXpNtI/IPLNIHhfBk3bIe5l0IIEq9GwKiZIPpBSqcPhj7iT7yVZ9skmHflMS+roPZGp+5h97cEdJp3ki0UUSfUczAdQ13XL86NKoPL+/UT114jM18NMALAEBvRn3gGXcJXjW5cFm89rIxmPhK2rjPKiPujM8EztMsBGJTvT5zgK8P+HkAc3mJO7pt0KoDsk4SMIf1RSQgVoti2LY= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BEZP281MB2758.DEUP281.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(376014)(1800799024);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 2 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SGpwxhtx9MYrNbxZv37uN4Pzu+epRhZCZCloiUy7mrsCLQDnP9R/qncHpI25?= =?us-ascii?Q?QawQe39WNBFLEQcykMdgrcnJxAz8gY8BUsvOQtKRC0Xho2hWYQdaaOZ21nc/?= =?us-ascii?Q?V5eWpE3Zn0hmz4BtqzCdaIM4HBalRa6F654RRFcFhd4g0r92CPQJa/fCP8We?= =?us-ascii?Q?7eJBJhgiOd2Y3VBlvqoggC7n8qAf4/MDszlnxYUJiZJeRXdTpzM8JJ8N3IM9?= =?us-ascii?Q?ZZ2NofagrXeEoSXWkGUri96u04GhWqtlO25mo3b81LbuvX5GM3SWckRUOy58?= =?us-ascii?Q?+yAEoMDRhV4rcq2dcDkf5/VgjWMZ4phvBROG621vITK7ZOSA7dX7+A3qApXe?= =?us-ascii?Q?jMY1AY9LTSwpSPaduYdtF7MdTR5UtFw9AptHRfvugCOYME9vXB5LJvS7tw4K?= =?us-ascii?Q?fl1Mzx6Luxx2htQ+IA+EETf117PVoLhUNEwjCGhGhTbikIFMUQ9fKAb0Q5KR?= =?us-ascii?Q?maZ4hFa0vJR/7zvnFbu/KJisYoREAUb25Ba2eAknTA8pNgC56hwXX5/THrfv?= =?us-ascii?Q?EzfFZS1uqyHcZAxfZsk5USknLTU1SwyXTYeBv9wkfnyeq1lTEKMSn0nkDQbW?= =?us-ascii?Q?2Rf64nczC67ST6aCFq6GyZrVKbTC6oCmDeZHbb8wFj2Q89EKHeLcboxfA1Pu?= =?us-ascii?Q?JYsTSmT8leFIeEDy/qrcoyu0cTJVqpFA735Mh99bTNnYqhbh4wgHJ66JXHKO?= =?us-ascii?Q?gsg6lNBhRu1EYigLpv5vsPNYTl2wlPc2zVgmKQM4SSTM6d9LwBll+seSlOZx?= =?us-ascii?Q?jLaUsYRcOOKHQSOEng2f5BuY9cOtl9mdytamEGyNJ1mU0NTfONemQK4876P6?= =?us-ascii?Q?Zvt9wVrnp67FENQGv4v+6e99hY5Y/D+i6PBA74toWjc+Nt8ZEMQVtWdoAIcf?= =?us-ascii?Q?HLC65AVWC+3oN4NVq1GaWRbO6eKjHWk3zNqCAiqddqYY4Oq9rX6VgYK+2Z0Y?= =?us-ascii?Q?KSzirwEzMIWV0jKMznGkf1CiidIUjWx+GAYjNj/t5saBZ/xUgQ9WZeMaKFd7?= =?us-ascii?Q?7X7TxIiNs9wqDZGVt8tfMGt41Qn90Cfz6NoL1O/jqBH1BoKqk8isYasf9zHI?= =?us-ascii?Q?eO1+GF2FUl1Z1GI5eIzZGshUIyHU0RayTDs4ERvBtOxOPtzhwuPMDntPVSpn?= =?us-ascii?Q?L8BofRC283nvaPA8uRJ+7CMpx7WO5FMm6D6QXS3xwUnIShdVCnuxvcxcFhPK?= =?us-ascii?Q?cxZ10GAjrJHvkClH82v7JwaGMGytIxsLCT5eAGCFHtxQPoz57yKNK6YGDPbF?= =?us-ascii?Q?BhV94JD/abKgKvcuP+I4nmgraq8otQ/alAJNwFoSZ39YeH991eqvx6TWLyeH?= =?us-ascii?Q?dGfecco6tbGyEzIENtl7h96qAqF51mRDnfV4HLIETGgSX7wjIoRkWlegyMF3?= =?us-ascii?Q?ck5Mogd6DhWgCPzKhuITGVDxitLTLCKYFHI0wBRYeJNxXWy1Lrh4VO2SuHfH?= =?us-ascii?Q?PPIKHCLcE4+jSBkKAhLVwqKHZkpYytDfiDFEmKxRn8vlnMnJpVHYov5lUa6+?= =?us-ascii?Q?Jbk3HMPrRfZRtfRAq1RkMO2tU5TZL1O12HmkAVlKhBL3VOiIColO/UkG1em+?= =?us-ascii?Q?mlHym9LUDt1byL+oejhKR6miHejGtf4xjEn1XV1XOoSnKGh0A6El2QA3xjRZ?= =?us-ascii?Q?YXN1FmJekuzlCs44lkR9kns6ApaEl/PQv0QGUiv4pIgO8AfP8NedVgI922HM?= =?us-ascii?Q?EjgQU0iIxUyhGQpU/s/L6GTVQ5Apy27ikc0YmcTZoVNIL8EHRY7byRquhibP?= =?us-ascii?Q?ZCfM1WjvxfEpAx3t4ydbAxhaHZBbfG7qloGSnQOuELXvcfG+o2WbtDokEk/P?= X-MS-Exchange-AntiSpam-MessageData-1: NPkZaj7o8e/auVCrsRfsdbx3AewMZ96Job6Jci2qzGYj56XlHKiwYhrH X-OriginatorOrg: cyberus-technology.de X-MS-Exchange-CrossTenant-Network-Message-Id: a45f0321-2ea6-440f-223f-08de75fd4ed8 X-MS-Exchange-CrossTenant-AuthSource: BEZP281MB2758.DEUP281.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2026 12:39:54.4483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f4e0f4e0-9d68-4bd6-a95b-0cba36dbac2e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: XYXFhO4alrMqHcP8oIu/7LceY+5uehfmE2xvjMBLXxV4tb2RAr6rhNGmDUItK6oBI8BxtrCf1J2MOq12bPOrlpfxW5l4c27T+20heZe/wi0qXf3m0nYXi/q2Zi+kajAv X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRVP281MB5719 Message-ID-Hash: RAOXZW24AED4P2QHNGTZMXHO7GMNFE7N X-Message-ID-Hash: RAOXZW24AED4P2QHNGTZMXHO7GMNFE7N X-MailFrom: leander.kohler@cyberus-technology.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Leander Kohler X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-ZohoMail-DKIM: pass (identity @cyberus-technology.de) X-ZM-MESSAGEID: 1772196049080158500 Content-Type: text/plain; charset="utf-8" virNetClientMarkClose() may cache the current error in client->error via virSaveLastError() when a client is marked for close. That error is normally released in virNetClientCloseLocked(), but some teardown paths can dispose the client object without reaching that cleanup. In that case, client->error remains allocated and ASan reports a leak. Free client->error in virNetClientDispose() as a final cleanup fallback. This was observed during virtchd shutdown in test_disk_is_locked, with the leak originating from: virDomainInterfaceDeleteDevice() -> remoteConnectClose() -> virNetClientMarkClose() -> virSaveLastError() On-behalf-of: SAP leander.kohler@sap.com Signed-off-by: Leander Kohler --- src/rpc/virnetclient.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/rpc/virnetclient.c b/src/rpc/virnetclient.c index ee729d5e62..4838227f8d 100644 --- a/src/rpc/virnetclient.c +++ b/src/rpc/virnetclient.c @@ -757,6 +757,8 @@ void virNetClientDispose(void *obj) virObjectUnref(client->sasl); #endif =20 + g_clear_pointer(&client->error, virFreeError); + virNetMessageClear(&client->msg); } =20 --=20 2.51.2