From nobody Tue Mar 3 03:12:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772010326455805.0952637866002; Wed, 25 Feb 2026 01:05:26 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3177F41D5B; Wed, 25 Feb 2026 04:05:25 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 47C2B41D9F; Wed, 25 Feb 2026 04:03:37 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 483FC3FD0B; Wed, 25 Feb 2026 02:48:52 -0500 (EST) Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azon11011036.outbound.protection.outlook.com [40.107.208.36]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C02AB3FCB1 for ; Wed, 25 Feb 2026 02:48:51 -0500 (EST) Received: from BY5PR13CA0008.namprd13.prod.outlook.com (2603:10b6:a03:180::21) by CY3PR12MB9554.namprd12.prod.outlook.com (2603:10b6:930:109::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Wed, 25 Feb 2026 07:48:48 +0000 Received: from SJ5PEPF000001CF.namprd05.prod.outlook.com (2603:10b6:a03:180:cafe::7a) by BY5PR13CA0008.outlook.office365.com (2603:10b6:a03:180::21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.24 via Frontend Transport; Wed, 25 Feb 2026 07:48:49 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001CF.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Wed, 25 Feb 2026 07:48:47 +0000 Received: from lenovog2.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 25 Feb 2026 01:48:46 -0600 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BqWz1AAVH+u9L3I/LunuA5DvMm8aeE1Bu087egKiJv6UyRDfIe/rsXW1Xpuv3s6gVNpIJ690+8bbXK8YvrXtfJymyCuUkwMyn58IbDiyT03/9OzmIdK0qCVzsfGkqLYJSlQ73KUxOFHVy6RdtZkagJAWa+w9lLSGBS9KH3slK3gPNuIqEP3VzZiz5osl9D93rEg9DFvK2ud93nla8vM64u72yEKTbp34MH2D5xinRwSCitM2E2K/1WaWfG8indjguUFtj73FpzX8s5D1lpOKUJgdCQRMn9pjC0krNRvQGumZSs/gP6quF8iego08SiSnn1t4A9LF0SoeIKXMUxy3cA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3ezcnrwINEYM38u4XuleKem11D8nADT0WX6bi6bgP0k=; b=ZnU0tArqL6qnu1HF3QQ5iJ4fVgM45Xa++JtqmXACRytxGcfge54cKeDWVX0dSnswyMyvoHNF3gX++cwtzT8PjrlrsRy9Znspe6taO9yTbWIxteFBZmRMfwaZ3Sg99hp05bNROGlG1Ffm+NyiDNJ0G9MLxsjuWz6SVaMJuZLpSX1QB8hgywgkiAvhnQ5t+nRE1mMXzKMq3CLa+JC0tf+juQNrhDSO/ZvzEFptlUpWZdrcHcom5Q9UC6bD0OEd/5EmSe1Y3SCKU65jnZPd8kli6jkoc5/ryG4QiSPj+X9b1oRgzn7cG+9Ei2CC1LsbLmzRuZSTNhKTZTDyAVfqcgowXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.libvirt.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3ezcnrwINEYM38u4XuleKem11D8nADT0WX6bi6bgP0k=; b=ocZ85fcgelomjpX8wbOE7ZOghlwwiZlIDERAq5dL3GtSz6a18PqkPss6rx+2x3++hXk4PGw8jAGMai11k/71F1Uwj7Y68dXrSkjGJuRIcwKlX+nJjIA2iE8vp9q2+yHGzidVloj8GA4n3RkiSHctamVGItdubt2e94mb414DRMU= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C To: Subject: [PATCH 1/4] conf: fix virDomainIOMMUDefEquals for amd_iommu Date: Wed, 25 Feb 2026 07:48:18 +0000 Message-ID: <20260225074821.654557-2-Xiaotian.Feng@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260225074821.654557-1-Xiaotian.Feng@amd.com> References: <20260225074821.654557-1-Xiaotian.Feng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CF:EE_|CY3PR12MB9554:EE_ X-MS-Office365-Filtering-Correlation-Id: fc4cf54e-290f-45d6-ea3c-08de74424ee4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|82310400026|1800799024|376014|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0wolpZI7CxnzRpTX+9zw8iK6vtYR5y5UMHC+CrAdy5ZG7qFDx+O1KM3IuSRd?= =?us-ascii?Q?7IedOxnLuMIESpkt6KYw+r4EaEhWw3difv4yG67WNy4F+mHqLzFeo+X2jH2e?= =?us-ascii?Q?3dXMVXY9g0XGF52CvLBLYWhDfthuW/le4YbZjm8xSTAcghLPZgiedb6jA+Xc?= =?us-ascii?Q?tYiWNEdjJnRv+fZ0FqWUM57rKJczG0KlU91c6Os35Ucu/InJEpdjLghEw9xi?= =?us-ascii?Q?6+xfl+t6UdokUgQijMGPIGNPD2LMKuhiAkDaXfYCrMJ9LTO8/oR7f5iY4hI/?= =?us-ascii?Q?MKE2h3geVpPvQLI3GQFczKb5Gdu3TAKojq7ypswFPc22m9Pib9vORlNtz7iP?= =?us-ascii?Q?uE9XqYhKVyHHcOI5jb/YIVUbnVjyUNmMa+H2b/rENotz7eS7CYGc18vK4tDt?= =?us-ascii?Q?g0ZD6CNzGY0IsAUbyrN3Dgfgj1cfNECfAiceeAcckNiq4mgRts6swO5+jRJQ?= =?us-ascii?Q?PYDH4r36fxyfiEMINfQwQ9S53Mt7loE1sbzTHPB/b0bsnlAkubvYCN9Dhe/0?= =?us-ascii?Q?sVyPHC+BpabEoZyjsswqRv464qTSDuSaT8i2e+M79VD3k8h70Mewx3B2VDHC?= =?us-ascii?Q?kZL7nJXZTrUcm6zNk0GLRoRyFbeLks57v/ICgZaGIZE2bSLWBswnS/qBvqiY?= =?us-ascii?Q?9tyvhP9dPu8LMKBkmY3oYCkm01I2LGQrl7WpL3UOgeS2oY10Qoe22fVvquEA?= =?us-ascii?Q?jciU5lf6Qo3pdFfhmuQu30StLgVP2QOtqn/5x7uwkMhNMIgI9d3yhdfow0xx?= =?us-ascii?Q?yu2MYYE2kzKNogqEY0OVGIMWt/iyOItxReZOqpkYhYx49MTP4l39dpV+lfBw?= =?us-ascii?Q?Fhc+0pg9wrgI0ZFMAkKjbm5ymYJO/RFrI6757Z3Gq0YUc/nczhnM/0kzAcbw?= =?us-ascii?Q?ljrLXMoGYiUXlB9kUh5Ov62NhbtoNhtAX4WMCTVD10EuYF8II13MXpkKBSiN?= =?us-ascii?Q?BIHl1rDThGSz2onNaHDkE2FS/to4BhryaYkkUNZ9r0up/x9UoxFLG2xuM5a9?= =?us-ascii?Q?9fGWRBjtojwV7T4WcFOboPIQ+6vuyG3EB7M4r/RorEafW3hMyV8CgJ7liV/9?= =?us-ascii?Q?87sOXLjL1u4e0FQiJ6KAisgSp73QCRUxkcCT2Ob0QL65rmAFc6DvwaIWmhU9?= =?us-ascii?Q?YYVswYxyJL/IbC9AJL+iXLgqvUbsOogDbOWjnmPQWne6QR5LNdAxb8bKyAck?= =?us-ascii?Q?aFXeeQzglRlDllrDfmf4fdt+Nq5xGlC04j8vy/+WrP6DUgUIkbY52Az+MeVf?= =?us-ascii?Q?ycRv6HZa+WXRd2EmpL26cEyNJOw7YLXwGSnJlI8WS5GeWay5kbKTPAzyfLUt?= =?us-ascii?Q?w6SkqQ6zX+oQVXfpcBeSWJdnFXUpgBq3Sx44fJFGTkGEL0mVGsR9zmo/BbRP?= =?us-ascii?Q?ldPRKl6lugDP0UTxp/HJNsJemwCq8XDoPMZAiKFtAjF0GcLJjbxIWJ0TEReF?= =?us-ascii?Q?NoU6ujKJzGOeU8bCuXmuLSZ6Vvr6Vp0iD/dF1LlJEkUzhCi87YD7epQXuwhn?= =?us-ascii?Q?Ps1SV5Vxt7CsX+xBbXgUgJ5TH8rImr3wQ8tdhCE3ns2sNNstWXZfrs59RZDa?= =?us-ascii?Q?Q+SVy2A7tKWR5a7fvF4fDL/QwAZzOWrfO7Uqc5XHwBApysbbmbrbIUwHexk6?= =?us-ascii?Q?/dnicIXGxUUG1u9VlviNGBvB+/ReBT1iKHJzyuHtfQYb4qKTi7W8G7w1jd9w?= =?us-ascii?Q?u1GE9g=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(82310400026)(1800799024)(376014)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: elg5+nJl0aCQNoOML9wu8uZ1ZQmH9VGSAHTOgKclP+/gwLD3Ulxen0vgfKNptzSamNdl8wyMV/ysVOZLP4BoFbWGqRsyfnphtA/QfTA+QwXWtUul1dwZPXHa8RtQws7SJQrYgdkmSY3yt2uNWxroFPhnBOdCPNrvGQUHvpDqAT//kctb1wiUtHE5aL5SmWcleQGqmnaE78XOycflN7gvpGifratKSCZLoOG+vi2J1ZkpnT8e0/YevQSOUhiptqk6WLvEQXvr2YS4Rb4KzNxNDq8yhodbG0MNxUvo0GjHvlmL6MhxH41ATSTOHYsqMohezpluM/irpDfRO/koUPUwQrrhEk6ta4MtPHXEDO7ffa7moqBBEVzg1fls+6d/vIxVymzqy9gnL3vAL0DSiuOYcLjbPuwuLxmtfkPq/7iOYqQTXo88YaDDTn141DSp4Ddr X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2026 07:48:47.2137 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc4cf54e-290f-45d6-ea3c-08de74424ee4 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY3PR12MB9554 X-MailFrom: Xiaotian.Feng@amd.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: EL5JMLBUEBPOVIRJPX64567HYWGMRLNA X-Message-ID-Hash: EL5JMLBUEBPOVIRJPX64567HYWGMRLNA X-Mailman-Approved-At: Wed, 25 Feb 2026 09:03:30 +0000 CC: Xiaotian Feng , Ankit Soni X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Xiaotian Feng via Devel Reply-To: Xiaotian Feng X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772010327870158500 Content-Type: text/plain; charset="utf-8" iommu->pt and iommu->xtsup are missing in virDomainIOMMUDefEquals. Signed-off-by: Xiaotian Feng Reviewed-by: Ankit Soni Tested-by: Ankit Soni --- src/conf/domain_conf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 998b333c74..a64a1fd59d 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -16805,6 +16805,8 @@ virDomainIOMMUDefEquals(const virDomainIOMMUDef *a, a->iotlb !=3D b->iotlb || a->aw_bits !=3D b->aw_bits || a->dma_translation !=3D b->dma_translation || + a->xtsup !=3D b->xtsup || + a->pt !=3D b->pt || a->granule !=3D b->granule) return false; =20 --=20 2.34.1 From nobody Tue Mar 3 03:12:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772010371990268.0972630775857; Wed, 25 Feb 2026 01:06:11 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 0F05F41D12; Wed, 25 Feb 2026 04:06:11 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 5E9D041DEE; Wed, 25 Feb 2026 04:03:41 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id A3E593FCB1; Wed, 25 Feb 2026 02:49:10 -0500 (EST) Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012049.outbound.protection.outlook.com [52.101.48.49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 2166A3FCB5 for ; Wed, 25 Feb 2026 02:49:10 -0500 (EST) Received: from SJ0PR03CA0130.namprd03.prod.outlook.com (2603:10b6:a03:33c::15) by SA1PR12MB8743.namprd12.prod.outlook.com (2603:10b6:806:37c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Wed, 25 Feb 2026 07:49:05 +0000 Received: from SJ5PEPF000001C8.namprd05.prod.outlook.com (2603:10b6:a03:33c:cafe::4) by SJ0PR03CA0130.outlook.office365.com (2603:10b6:a03:33c::15) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.23 via Frontend Transport; Wed, 25 Feb 2026 07:49:04 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001C8.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Wed, 25 Feb 2026 07:49:03 +0000 Received: from lenovog2.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 25 Feb 2026 01:49:02 -0600 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mnFQYNm6VQIFoBeUhXWRGAVvcYxm2dHNvo+UAHclP7uPtbt91X6MsmH25ksx40ErvjHUKOiOzpsiRRiNlwaGDDJyBqebQwXxRsCOL1NvLEf0/uIlQO2/9NnPEhW4G2hKiZTcaB3ySGgzOjKuZ6mLPAKLBmvoxZV2JwmurzKtWiM23KPGRWgaOeg0sFDX5krPuuHge4bn+e8DGG4R+726G7/rhYoEauBJgiGrjon37NIgMvBjwaP32KmoHKGcUd36ljtHBeHJC16pAsefb/9wO0R+7hCKi8BRV42h8zB+BDkD1f0rXTFdFl82TrbW3s9zZioTM+m1rafCa38IY8s7VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=feVZxVXRDl1rQSwKXezNP78lqpvCz/1vQ2lPCP/DFL8=; b=ijiwkNzPcUxNw19+CTIPV/O2oMLJeWrmGBi0pvhLtWDdVUN8yftd8zfk56TlWnGeEFArtKVmavhycT/ZZDdXlLfcGFgYmOp3Kzmv/ngRqkYE1/JcP9ukdTdyHuVa9R2O1Onoyq6V/I3K2FdpDy6eGNIPShtN85Q0T8+C9tWp/VarnKPg3Rvu99kfVwmUsfBXAoNUQuEakH4CBT6spVZ/CFfekTjQikW+u9qlx4RjusTHJHVYzj7I3MEs9r2QiSeCXZnbdRa7xtgH+vMcn0F14pTqR+vYYvfOuM1FBQARuGNXIkSxVQCiBObF4NS9gp3uMizLXYJCCF6DTFilL8zhvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.libvirt.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=feVZxVXRDl1rQSwKXezNP78lqpvCz/1vQ2lPCP/DFL8=; b=AjCEJxBcnkLVKdNswnHdpXzuh+dNfWghS7CZ45OC1D9Iv7r4vceocbr9TZ3GnoI4wA8eT77bvejkNGZoOF17ivXckks9iLR0z8pzvvB533P2XMooNnbaVImWtGhZ+ulipMRPI0UkVO4iaD34sdASG+Bb5Rqr4awH3YHGJmeszSE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C To: Subject: [PATCH 2/4] conf: fix error log for passthrough and xtsup attributes Date: Wed, 25 Feb 2026 07:48:19 +0000 Message-ID: <20260225074821.654557-3-Xiaotian.Feng@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260225074821.654557-1-Xiaotian.Feng@amd.com> References: <20260225074821.654557-1-Xiaotian.Feng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C8:EE_|SA1PR12MB8743:EE_ X-MS-Office365-Filtering-Correlation-Id: 3193ef35-2642-4d68-f00b-08de744258ca X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qKRkgFZz8BU7D/FySduoY9mEMzm0axXVmLkMi0AXwY5MYxnTlh6YAtWwJDMf?= =?us-ascii?Q?DcB3BxzxtE0jfA/5cOuhWuk5YIB0Q3xMgMpRg7dGGmd3IzXZDEwVIDrvZe3v?= =?us-ascii?Q?Miuh5pZplKUq9nzURZpGjE09CmJ8MjfEPPq/MGe8AS4fS6jaWmiwHhbWOTEU?= =?us-ascii?Q?3zqlQqfwEMWSjwdREjLwMt5nFek5RHzSPvHkbR9vtoxIiUPiXn/XMXAH9y3J?= =?us-ascii?Q?/bTQ1rAVhchVYVuaMdXBENfkuBUsiJjwhhqlptk/bccWprD7tcm5Gy1X5Il9?= =?us-ascii?Q?bheolXBWNsOQT0vbeXwT+KrSRAGZvjWGh2Lj80/aYnw9ApovNSvxxxnORB1h?= =?us-ascii?Q?/DMGB9tcB6THtvkIt09My++F9V3AT3dAZaMSvgszfFUsow1WfQ4PHVTQ3VgR?= =?us-ascii?Q?LxBAgl1UsCH7HmiPuOOXhT7XSiTlbEB0S3kXni6OAUzZGFdBh8kpB4NMJRTv?= =?us-ascii?Q?ZgEMEqwcHlZtNBYtjUm/Ib+o7N4vCUlFRF6tJ0bRvaFC+H0WvBjTsmHecwUw?= =?us-ascii?Q?Yh090LNnWNufQFgbkSHXlsOPJVWpTO9RohWxlZvuZRrhvGi2nO8fdnMhcAWn?= =?us-ascii?Q?kUOIf1twbEXdOtt0mh0dja1Fz2u6qQkxnQLR9OOWj5xihgqw83hKSUM+H5xg?= =?us-ascii?Q?899rmtMi8DMhQGldZKU6we2TaKDuzbkoO3UInhMIHlU/QjVll9WqWz8Y/fi6?= =?us-ascii?Q?y5WTgUMikU/FzcVUE+dbOLfjxRotIlJNFxtrKsVTKK80RFOOFG7tFTqbtCga?= =?us-ascii?Q?uMXh8yDO7wQf3mJTrzhtw+zMHCRra4b5rbly2/Cs5ppuN8x3TDSX/or9K1yu?= =?us-ascii?Q?PRCDwubj9+Q4j06cjjZEphAv1QHhg6W82lsG+dmMdHTA9xwL5aCCIgkAdi43?= =?us-ascii?Q?X/8eonW8eUynIX1icfJaM8c88KC8pMdVznibYpLdr+44VtVadv0Sh2qeofBt?= =?us-ascii?Q?/48x5IlQnURPX8bkYGLjWUhSgAkQkHNhCwo+NQV4eJJ0spgbhzlxoWwW5wRJ?= =?us-ascii?Q?1SsaApTRD75s4uoAYFWGX7g8f9fZn1Jym6clXxKcEnegpJjypWjmR5J+yICS?= =?us-ascii?Q?Fj7vaPh1p6NS9WZpgVdo3iCW8KwDrNbU5nblFHrIvEXNRAAbE1EsnJB0uFLE?= =?us-ascii?Q?ZHzbETDkGAi2uQcUujOfUPUQyI5GV/wBnZ3/2quxPENHIyxggsPiPrkpJia+?= =?us-ascii?Q?n8K9pHlY155enrzoxElP3n29VLI2oARJ+/9REO8OvwX//DMz7nBul+seNzdU?= =?us-ascii?Q?+lRZVEQWkRZIjbY4451hW0/6qMlK/JWCZfpo6bJTnhgVgYEytyAfFtS1ajFP?= =?us-ascii?Q?asFSMh68M1x065oT5uYcVIDM7ogieMLyeWzwkZwn/Xo8bCx8anZjlIKE6lz4?= =?us-ascii?Q?xE1/gUbR9H9XoA9eAxw9qoswF4R+cQs+vOX5gpwVxXPn8yKj+36WPTWV95Ar?= =?us-ascii?Q?3J/RagXZVEeQKGOiN+3l1Tm5S3AygmDSAIDgFZK6jZAJ+4EiznL4qBjff2OE?= =?us-ascii?Q?5x9lVpwqJt5WIUjN+msbyVD0f2xAlWbA7ssXKmLYBW9F4e2b/223o1Xv9x5P?= =?us-ascii?Q?7CW6hDS77zF8/P2PBpqxWstz2DHufuj7tdKa4LcLKTuhAXu5/jOceKFlVUHm?= =?us-ascii?Q?JvSe88qznjaqKVKKAdF9cO8NVh51UyEZ42uuSg0sqonyUrM7t/w0JK1jzE+P?= =?us-ascii?Q?zUdtig=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(1800799024)(376014)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: P7+dYBTa39G3WDsloR8by/wOEW0DDt7W3Sw6uz45KTWYU0t4yzmFD+2haDe75vFQXY18Ff3kW+kGv0xRncfruO5eYURot1+uEJtS0D1v6oCEtNU/oaurypyX+6xyLJmkg1DFleRiJbqrKu4hiNq1KPKW7aVXRtPNAsvoWVzr6bmqS5CKz1Qh5cEM4Jy473DQDve4CpWcHqUtDikWvWE48j7r5y58r2CRJAv9fy3zpnfCO7k/93X+gaJxyOhHARJh3nUGOI4YI2CqB+ez4UAS872PhAr1BdR8h2EBoh7i+0BWdFbiff07M/t8i67FMSDfye/yK6G7XFBdAwx357YRs7tTNKDGh/jCPZ3jwF9cbxsWlpfIshFTih2cr3MnuZZzgTlfnM/MzcsWvgN5QLKPDZlVgovGseg09t5TTuZfAKSMAgILcVjxzmAjr/0avAUq X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2026 07:49:03.8441 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3193ef35-2642-4d68-f00b-08de744258ca X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8743 X-MailFrom: Xiaotian.Feng@amd.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: NZN5ZQLXI6WV6JPMPI25E6DNDV22YVVK X-Message-ID-Hash: NZN5ZQLXI6WV6JPMPI25E6DNDV22YVVK X-Mailman-Approved-At: Wed, 25 Feb 2026 09:03:31 +0000 CC: Xiaotian Feng , Xiaotian Feng , Ankit Soni X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Xiaotian Feng via Devel Reply-To: Xiaotian Feng X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772010375402158500 Content-Type: text/plain; charset="utf-8" Correct error messages for passthrough (pt) and xtsup attributes to reflect their actual names instead of "dma translation". Signed-off-by: Xiaotian Feng Reviewed-by: Ankit Soni Tested-by: Ankit Soni --- src/conf/domain_conf.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index a64a1fd59d..7f04eeb8b3 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -22596,14 +22596,14 @@ virDomainIOMMUDefCheckABIStability(virDomainIOMMU= Def *src, } if (src->pt !=3D dst->pt) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain IOMMU device dma translation '%1$s= ' does not match source '%2$s'"), + _("Target domain IOMMU device passthrough '%1$s' do= es not match source '%2$s'"), virTristateSwitchTypeToString(dst->pt), virTristateSwitchTypeToString(src->pt)); return false; } if (src->xtsup !=3D dst->xtsup) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("Target domain IOMMU device dma translation '%1$s= ' does not match source '%2$s'"), + _("Target domain IOMMU device xtsup '%1$s' does not= match source '%2$s'"), virTristateSwitchTypeToString(dst->xtsup), virTristateSwitchTypeToString(src->xtsup)); return false; --=20 2.34.1 From nobody Tue Mar 3 03:12:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177201042670056.596600308545476; Wed, 25 Feb 2026 01:07:06 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id AF236418E6; Wed, 25 Feb 2026 04:07:05 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 9DECB41E58; Wed, 25 Feb 2026 04:03:44 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 7A4763FD0B; Wed, 25 Feb 2026 02:49:19 -0500 (EST) Received: from PH7PR06CU001.outbound.protection.outlook.com (mail-westus3azon11010070.outbound.protection.outlook.com [52.101.201.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E40673FCB5 for ; Wed, 25 Feb 2026 02:49:18 -0500 (EST) Received: from SJ0PR03CA0127.namprd03.prod.outlook.com (2603:10b6:a03:33c::12) by DM4PR12MB6446.namprd12.prod.outlook.com (2603:10b6:8:be::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Wed, 25 Feb 2026 07:49:15 +0000 Received: from SJ5PEPF000001C8.namprd05.prod.outlook.com (2603:10b6:a03:33c:cafe::3f) by SJ0PR03CA0127.outlook.office365.com (2603:10b6:a03:33c::12) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Wed, 25 Feb 2026 07:49:05 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001C8.mail.protection.outlook.com (10.167.242.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Wed, 25 Feb 2026 07:49:14 +0000 Received: from lenovog2.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 25 Feb 2026 01:49:13 -0600 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MGAOzHd6qJcx5PJeDKtn8a4LLv7isLpR02clysi0KHvzhn4/6b4rUwoH1gE9xzVEqkDV50/AoxUuOikADjuvOd38rNho4mpHrOY9ypx1UU3Q62uhaiYwJqN02KXKazZLKJ4D7BnDDeResasoVXyaTWFCd3kbfX0DvMZXtV+hAaCulesF5YQL7Zc7eyXlPIz8EEIXIiqRjDXLauduEoiAz6zy+W0ztQkpmQmDJQu8/ET2nMD6gU92TkP4NwH8VMI5oRr+hS5uMVkNwWsOZB/y2UFehb7IELR5Ax0rk2qCbdv03OhNSk/fqUdqYUqdprRostEohDmJ5sHnIe+q04e0pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ohq4NsyqgsZygfY9JlB6FPNRLV683+Thmmx9Ru6bOV0=; b=fqz5TN/nQKi2O+qnD6Vh//+XExkpXGRIjsIw8dU+Jc+9kvQiiSTjtam0O6AjhnEIfje773vyPYWCibPrHyXNvkAM5rXWgSNvf3bPj+sNGXkiuYbxRaE/Vbn9rjt2D6OYBCwk7mVHFsbSHaQ9/0NjPvXxRna7NzCa5K6kFAb4uAEFPEUBhm4/tSUS3cAWSZMsNBRZfrUm+GncmDrMpWUckaTUPYFJLk9POx6tbArtK0011lZm2OIiHTBSBCFqvrjhMu6fKAOg1NK9oIWBEHYtR8b703S1WYtC96C/jAGCAbupXgGq4lAmiH7Vgm3lS2ecp1w9C7zPL0WhOm9/5JLQ4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.libvirt.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ohq4NsyqgsZygfY9JlB6FPNRLV683+Thmmx9Ru6bOV0=; b=v9xJbpYGKAVJ3alTCsU2Xgr47jo+3BZP/AhHHPGcxvqL85LIL6ZsjGyAiDKu3ttamuNDA19D8KgcigdNfQW4BmJLTL3Bv28TRIF51rz0MCY3VwA2HfXAQ9oc5krUuXVf6ubWphOOMzG/yfaz8oINkn92fOJvuPzgQotsWYJ6jHE= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C To: Subject: [PATCH 3/4] conf: support >255 vcpu w/ amd-iommu xtsup Date: Wed, 25 Feb 2026 07:48:20 +0000 Message-ID: <20260225074821.654557-4-Xiaotian.Feng@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260225074821.654557-1-Xiaotian.Feng@amd.com> References: <20260225074821.654557-1-Xiaotian.Feng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001C8:EE_|DM4PR12MB6446:EE_ X-MS-Office365-Filtering-Correlation-Id: 22eaadf8-a710-41ee-bb99-08de74425f3b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?LIPFewV9IePmvtHWxOfjw1srTketJ5YDNKDk2VQ17fq5klA2yy1vEtGakiFL?= =?us-ascii?Q?GMDNrEyDvCju8FvHsBDDf1jLaHcVhOx1PJxp0QnjPGLNH/iPN98GQ0/1w1uC?= =?us-ascii?Q?szpKG8xHUXWP9fKdBBFyiEfIl6dSlywnVRF8jz5HLAQEUieHT6/vpU7VIIHf?= =?us-ascii?Q?Xmy1+NWqCREGPMc8UJCRkBsfIhM8u9/eqHrz74dpk+k4KJkv8C6vPfxnUuLn?= =?us-ascii?Q?PvEaou1N1P0medXCQb9Lk7wYKD3s4NdoCscnCSJTT8VTfumNzqfBXr7Bycrd?= =?us-ascii?Q?Xpn7EhupkF9x9T+36WT31SkQ+jwjOJbBFkgBnrTgdIqJBwRwnuZf47oUvzMy?= =?us-ascii?Q?cJF/sjiqDWm5RORmY7mS+hFEVKN955vpbha9bPWlOF3xnK+NPJ+P82kMZD7M?= =?us-ascii?Q?4OsQ42XDENruy81ENadejy0XTQ/NslSUnRYVfH4P6v+9EwkYZJiJjYpcmbcW?= =?us-ascii?Q?7BaMYqf/1agK6u8WIDw7SlEvc4QjZTWYz9evAM++9CEUgu0syWlNQ9N/9Hzq?= =?us-ascii?Q?YXLWlmj+3baq8LXvWOmActkjZTkW++Jfn33iL631HRyRoYHdHkA2hXPO00+t?= =?us-ascii?Q?l9mGpyu31i0B/atQj0FF+3oMdR59knXv7BlAKIpNe/spBaHQ5R3aMTG5MVw6?= =?us-ascii?Q?ULJ8VrEtmpbzB/kxn4E1yPl7sulJXxgVu1p/6nx+DkPftnZ98Fw1BNXvaR7f?= =?us-ascii?Q?fM7SaoCoRGwJsYj4Ar0daNP41PzBqc8iYPE7WA6hskbcI7nVNs9vAEbmtI+M?= =?us-ascii?Q?wns/ETV0WR/FeCVTtAtck9iFqUUFjIN41So6z2Bd1rsswKPFXp8FqgDeDWzg?= =?us-ascii?Q?LC2JsLTts5Vd9MXx+sSO0GP7MSWbw5FHJtbgkAzBxofeKevLNU4NYHQVrvvU?= =?us-ascii?Q?2nTPKn6MHzYwp1D+it3hYFx3qt3l56Up/vaXwT0Ss/8rn5CNqL676x3glLZU?= =?us-ascii?Q?lirwLAoWixm1GTVN8hrHVrVuEcGh7KybpRi02mAcHgtTWKY0FY7jQtegdbGw?= =?us-ascii?Q?l02F5rTn6Qa4/x7hEcjIraNJ9Jy1CLxRIO3gDsilwnlkPnIHiXSlYkwZxpsj?= =?us-ascii?Q?sBq7wC8IvmmvcyBBeukyiXOXk31bV0D9Yq0PO6jVIAXtjolWnkopCp5pmdfh?= =?us-ascii?Q?kiKfAwmwm14/xTPlkA2CY4S197JCoWw2a4yrZpU7pyG1HV/85FdjkDJhVMIe?= =?us-ascii?Q?I7EJNFI1Nyptzxjwml8QkpRk+G1RBAtPshhF/nx3mg3wuJT2z1WxJE3lXBMt?= =?us-ascii?Q?dqiLeWlbN+kfxalg51c++zAhoT/LQ/kNKLrxx+HUQeBrvHc9Mnvl0bQzEusI?= =?us-ascii?Q?by8Fz8rVBO3fDTD0+71JONhYy6MvHlj8j02le6WAV5XSpH04D/FFqscXvWz9?= =?us-ascii?Q?uKuYb9WlC6E6a1Ue8FJhyZ8s6FpIF2eX6wa5rDA9llaJ4ergu2V9SeeJQiKV?= =?us-ascii?Q?gtOPZqEExs2ZrgaVo8q4PiEnZRMsicDirMbj7YWJ8+xNc9JrcocMLfgAEvEy?= =?us-ascii?Q?vh9joysNjERhIXOs8KxAns2qsqubMReMnEsEOeRuSXahdxWisIHD4lKzKHf7?= =?us-ascii?Q?wvuPimEwjzG7O0Bkl0lRW7zSt31/qqHam9ZLOETTasi33+w2kpeQdGCG86T4?= =?us-ascii?Q?ku2ICxlK2ICmF6myBH1j29WlfpYYosILaaC5vUvSSyF1?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: HUJV4Yi+8Aa3ilwRvwEVu2FtP54HBPVudYb0tp5fMi6VHDKN137RtYC6nNIez2/iD6VjfRqp69abXPV4Tay6VR/4ly+W3BLDg1XwIMqzz1VqUQRnDqWNR/E0RbDBIj/rn7B6YH2Zrw384mTOks0RlcMyjaAlNOEdEtlUq8envNFR8PCwITq2/pUI8sxJzgfgKKKdR4y27DRcrWrkDFDcD6QWY3JaQoicIH6IHNZB2VbJ2WrSjBsVol9HNqKEmoNXY5JqDjLmC37M+zUlfLW4rRlUhGIURX3PurYBzBNvo+/bGY3duTdYgsb+XLEv4Wgek130KJQIm56yS4IkQJ/BoPwvt18jgyW31/hzzkr78uJWkAOKnG7tdRMiyvTQzjjUTbkJb1O14v388B4u80hdLfP6mU3Z0qP+MGp9oecBSrotOxJ6s0L1lFfQxDpqBnSB X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2026 07:49:14.6259 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22eaadf8-a710-41ee-bb99-08de74425f3b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001C8.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6446 X-MailFrom: Xiaotian.Feng@amd.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: UGANRA3ADWN3WJUGERQZ2GQHCTZZASNM X-Message-ID-Hash: UGANRA3ADWN3WJUGERQZ2GQHCTZZASNM X-Mailman-Approved-At: Wed, 25 Feb 2026 09:03:31 +0000 CC: Xiaotian Feng , Xiaotian Feng , Ankit Soni X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Xiaotian Feng via Devel Reply-To: Xiaotian Feng X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772010429646158500 Content-Type: text/plain; charset="utf-8" Rename QEMU_MAX_VCPUS_WITHOUT_EIM to QEMU_MAX_VCPUS_WITHOUT_X2APIC to clarify the limit is tied to APIC ID width. Validation now accepts either: - intel-iommu with eim=3D'on', or - amd-iommu with xtsup=3D'on' for guests with more than 255 vCPUs on x86/q35. Update error messages to mention x2APIC mode instead of extended interrupt mode. This reflects that AMD platforms can satisfy the same requirement via xtsup property on amd-iommu. Signed-off-by: Xiaotian Feng Reviewed-by: Ankit Soni Tested-by: Ankit Soni --- src/qemu/qemu_postparse.c | 4 ++-- src/qemu/qemu_validate.c | 11 ++++++----- src/qemu/qemu_validate.h | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_postparse.c b/src/qemu/qemu_postparse.c index 8940cb09b3..58bd70c741 100644 --- a/src/qemu/qemu_postparse.c +++ b/src/qemu/qemu_postparse.c @@ -797,7 +797,7 @@ static bool qemuDomainNeedsIOMMUWithEIM(const virDomainDef *def) { return ARCH_IS_X86(def->os.arch) && - virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_EIM && + virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_X2APIC && qemuDomainIsQ35(def); } =20 @@ -1204,7 +1204,7 @@ qemuDomainDefAddDefaultDevices(virQEMUDriver *driver, addImplicitSATA =3D true; addITCOWatchdog =3D true; =20 - if (virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_EIM)= { + if (virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_X2AP= IC) { addIOMMU =3D true; } } diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 0eb5d5ea3b..fb7b2a4882 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -920,17 +920,18 @@ qemuValidateDomainVCpuTopology(const virDomainDef *de= f, virQEMUCaps *qemuCaps) } =20 if (ARCH_IS_X86(def->os.arch) && - virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_EIM) { + virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_X2APIC) { if (!qemuDomainIsQ35(def)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, _("more than %1$d vCPUs are only supported on q= 35-based machine types"), - QEMU_MAX_VCPUS_WITHOUT_EIM); + QEMU_MAX_VCPUS_WITHOUT_X2APIC); return -1; } - if (!def->iommus || def->iommus[0]->eim !=3D VIR_TRISTATE_SWITCH_O= N) { + if (!def->iommus || (def->iommus[0]->eim !=3D VIR_TRISTATE_SWITCH_= ON && + def->iommus[0]->xtsup !=3D VIR_TRISTATE_SWITCH_ON)) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, - _("more than %1$d vCPUs require extended interr= upt mode enabled on the iommu device"), - QEMU_MAX_VCPUS_WITHOUT_EIM); + _("more than %1$d vCPUs require EIM or XTSup mo= de enabled on the iommu device"), + QEMU_MAX_VCPUS_WITHOUT_X2APIC); return -1; } } diff --git a/src/qemu/qemu_validate.h b/src/qemu/qemu_validate.h index 9315be73f5..27dc120c3a 100644 --- a/src/qemu/qemu_validate.h +++ b/src/qemu/qemu_validate.h @@ -22,7 +22,7 @@ =20 #include "qemu_capabilities.h" =20 -#define QEMU_MAX_VCPUS_WITHOUT_EIM 255 +#define QEMU_MAX_VCPUS_WITHOUT_X2APIC 255 =20 int qemuValidateDomainDef(const virDomainDef *def, --=20 2.34.1 From nobody Tue Mar 3 03:12:39 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; arc=fail (Bad Signature); dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1772010471640831.3592932315079; Wed, 25 Feb 2026 01:07:51 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id C59E441D57; Wed, 25 Feb 2026 04:07:50 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 904F742408; Wed, 25 Feb 2026 04:03:45 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id A33BC3FCB1; Wed, 25 Feb 2026 02:49:39 -0500 (EST) Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011068.outbound.protection.outlook.com [40.93.194.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 186F13FCB5 for ; Wed, 25 Feb 2026 02:49:39 -0500 (EST) Received: from BY5PR04CA0020.namprd04.prod.outlook.com (2603:10b6:a03:1d0::30) by SA1PR12MB8721.namprd12.prod.outlook.com (2603:10b6:806:38d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.22; Wed, 25 Feb 2026 07:49:32 +0000 Received: from SJ5PEPF000001CE.namprd05.prod.outlook.com (2603:10b6:a03:1d0:cafe::84) by BY5PR04CA0020.outlook.office365.com (2603:10b6:a03:1d0::30) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.22 via Frontend Transport; Wed, 25 Feb 2026 07:49:30 +0000 Received: from satlexmb07.amd.com (165.204.84.17) by SJ5PEPF000001CE.mail.protection.outlook.com (10.167.242.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9632.12 via Frontend Transport; Wed, 25 Feb 2026 07:49:32 +0000 Received: from lenovog2.amd.com (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.17; Wed, 25 Feb 2026 01:49:29 -0600 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=lxqSnTmx5HJ4DC37jZaisAnqs67FhoYdMo5GgbGFNGJlGfAMDb8K8i94fv9l5zJ+Xc1dhBP3azXASBk22cmgFR7ZubclWLP0kMCx1P3Y954FDn2AEjqr5jqYdsmUxO6bvfQcUXowmwFYA5niusDAm9lV29nge8bWx5Vus7gz5dlpzty6K/vH+TBad7rKTofnMDKj+UVPY13FicsTTTPEy7no/lEIW+tgEnjOdr/UKCQfggkSTLtncMTgzWG2cCTTpGa9yjx1zKAlkBV6sNCnXb5LPHPK3iz0GWRclibcZgcqWSKETmK8KMUW+iq7lIFjtG4htUy1Z/+peasOJH69rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZLx7e/yeUMu+cJDLkZu/pPtdy4YY1hmOOfsx2iw1ZLM=; b=n5sMwFGGDCI0TKrPk6s+4Iwso3cw4PtCtgMuDBbz1mX1J5QRb6hbaIEJ4RpU1PSQHHVomEheLZdOgL+ydLqlOx0NIoqYWAfisTgDIP2FOejrKFum1jaK1DjQaJFzYJFXGhpDLL/O7OZC3SD1YxA+1XgWx1h0z5QQtr7/n8N3G/2UAamkeIfvMiDIbcN9qLOCDijw3Wcf7tgHZmhMdjD0kd4M/9G6ghbrNIoEvRD21LiJPETiuCV7cNDdwnzU6qkh2ioS9aRG/Z0jCI+K+U0fnUdwHfwBE/prk4WCdiCCGeY1T66tKLhJTewnMXSQiF/qW4mG7xxbKgbeJHP9sBuhpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.libvirt.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZLx7e/yeUMu+cJDLkZu/pPtdy4YY1hmOOfsx2iw1ZLM=; b=G1jDrdAypUeSsNDgq4uMr3l5/PpjB4wLU3f3nDsDAG7oF+beEaq24KUjYILWk2sdRg1IKjrStH5jddHoCUjB9DOFB2N4nQMWUAzsGRVcosLJi3tWAJ96wHmZNA6P1J/RPffw+ESH/Cp4bH2KaH/qRYlh+Acq9HyLf85MYSLKiO0= X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C To: Subject: [PATCH 4/4] qemu: Enable AMD IOMMU XTSUP by default Date: Wed, 25 Feb 2026 07:48:21 +0000 Message-ID: <20260225074821.654557-5-Xiaotian.Feng@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260225074821.654557-1-Xiaotian.Feng@amd.com> References: <20260225074821.654557-1-Xiaotian.Feng@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: satlexmb07.amd.com (10.181.42.216) To satlexmb07.amd.com (10.181.42.216) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CE:EE_|SA1PR12MB8721:EE_ X-MS-Office365-Filtering-Correlation-Id: ca0beb06-40cb-49bb-ae82-08de7442699b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|1800799024|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?J540QzGyKk2/BXfdgFQuSMkBy4vIyaoEDQ7tcCa2ya6VmSoSbWml9BAVTDbF?= =?us-ascii?Q?HcYB3+lFy3Kg2YdhHniLPsOgsuNyUC9qIqYsb7+mJ6oYtBX5tp8ZcYUS4pTq?= =?us-ascii?Q?/mFDCVXlrFwGSzCS2mC5lU76ZCNlAZY7lxC9b4zqNCXTCTMYn9jgK1vIwrAT?= =?us-ascii?Q?ppjJzAsi8FiSX68us8sxFgpsqPhDez3xsNrc1C7wxa56SEA+8yk/mjJ5KMEA?= =?us-ascii?Q?v7ATxnnGnfnU0WwX+MKCZ6oAmEA4mrVJpHeyyNtLycyxXq5aS3gV0b8GQOUY?= =?us-ascii?Q?9HoyDcgcwnb3u9j6KxawwpNLuD059R7rYpVRrhLqbVoHKXwwNqZS5IySE2aT?= =?us-ascii?Q?3jt0GBjo9vIFRx6wdPuzsyIlk41/Z10ECGodSUl7pTODz6pMAs+gbMpyXaYK?= =?us-ascii?Q?oz48Lk47gvpR7icStjZGuFE1u9OUwej1g/aic5asfTDAeqY1MPOnp12cvxPZ?= =?us-ascii?Q?M7azCffmssONyr1VYe/9KCWrw3YGOcVdcAlmjV2nrZ0NSXwL8yNVwl1TfMkA?= =?us-ascii?Q?aW2S5I1CsNcOcHgikgyQdJLKP/ju/AM44YNtEappc9no0cY3WqUEVMjsCpJn?= =?us-ascii?Q?x4HEcURx5yHsmA9OUMKcuGHHKopPqxyNcmI5287OFxddMu7lPDnPKnnuhBJA?= =?us-ascii?Q?JLDnYc/EhjYG71uWGw3/j2ECmoX6by8qbgVm0PjJIPHTVUMMso55Oz1YtBUc?= =?us-ascii?Q?rfV+QxRsLtUW73/Wo3EjBpM6SnJZ+Grd1n/EU5aWVfjhX4X1Dn5HYWYA36u/?= =?us-ascii?Q?CvRmpAOk6e4E8x8QE9RJ/nOQTcCkWqbTOBicxBCt2UzNNwIOwLgFvmmUS2Qa?= =?us-ascii?Q?B00xlBK2fT0K9FvVV+vhKxL6TGagEi4ARQobMbrv2x2UNXrBbemnFDACicrJ?= =?us-ascii?Q?ju3QjIpoY0vaXCifYdPOmQ5pyyMTPZor2aRU5urDCd89p5y/1do/+lkwUaL8?= =?us-ascii?Q?1grpFYiabqcn4FBqCfxNlLG0heIU5zaWNV7mEoLb23fQ+rX8nvsHBE5TdPFo?= =?us-ascii?Q?uUrSiNskUJnC1VCI8nQuf2QmlbXR5pj9by+eeP5jTcMajnzmMgCZGhUBbKtg?= =?us-ascii?Q?jGANEAYcuPMhuQ2luV7HbZgBZmpSK3Izvwoh4l8tsyZon7q2gJQWyJ3ij0wx?= =?us-ascii?Q?z/oSY43E8fgb/eZ3F1drXOx6Pt0lJBu8mCrvG1N/8ze79i0tGaC2ybCKJmCw?= =?us-ascii?Q?hzM+CbwkdRJr1PVznECIHZnuRv1rp95fbKI2Zk8XOCZJLV/UxL6fNjMbTJnw?= =?us-ascii?Q?VX9r42PYpVcpPjIPxltMd8gLdgj1+Jhq0Q2RzUTWTltmmhey9k4Wob4wYbGo?= =?us-ascii?Q?TZERCDrPLCLwAdYgNHENdosIlxMhbdZanwWKP9MGQHJZUespnhByxXyffjSr?= =?us-ascii?Q?t2gLKX39h+aeU2+ec1GAc58T3zvESQtiM5XNU8SPISo/iYbH35TiJOWqBG4R?= =?us-ascii?Q?XCN7hqdiLOllZHk97Hw2EENrG9W9dcIRFX9aJ4qT8q71NsrseakgnbdZQSes?= =?us-ascii?Q?9XHj4nPAFLtse3wZVCbS1GwQJzu/qmEhEE9O6A3HqzUXzk/cJDQpH2IoBZh7?= =?us-ascii?Q?9hKT/h0JKC7w5SAvrgEZ09WaISTkws51uxd9qbI/a36u9n3hCjOLq4/wkaHB?= =?us-ascii?Q?Hws93OiTHx8ihUEf4EbOIEOtFZi7BOmA9BNn2A0/qjiAQMgfjV7uoWDMJOf9?= =?us-ascii?Q?b2N6Cg=3D=3D?= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(1800799024)(36860700013);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: eYoy/U2zDYMtejvF+LhI6DyAuuifmeN18pexxKB1r5GMxaWMv26O+f086ms9GJc5hTiBWc5YNPb4IwEJbUYnBXcdFoSq4ajXMIz53FRkhUS7l4LTTGRGj+hwLhacYjBCzHsAVE3oMg/rE9nkXQg4FgCkgoSNliPC+/V0NBcTjSQcUynu9a1IEV1bK97ZUFNq8XVpRSdGKVBwYOn3tp8MWgWxYc312/AVUMMrbHETHbpV/Fv37ZbeJoWHAQfsHF+DpVnwQA/rj85xas9ahuOFgNDQd7T9UlZ3MbOpD9rftb92bx8ZRd4m48iG1j3mK9O8F8J7Mt5C3v9giO+Ibu13zCqNjHgpWxk7VVcPtORFSfM+z+d+buhmX/uoRr4pkisyPl7Pd6gzCmVAhntP/mNRYzPLD/wrpBVgHd2XfqSK5O8SouX3CTbJWnv2B0AxQy2u X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Feb 2026 07:49:32.0317 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ca0beb06-40cb-49bb-ae82-08de7442699b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CE.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8721 X-MailFrom: Xiaotian.Feng@amd.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation Message-ID-Hash: FNFMAU6M57O4Q52MZGVLRQM2CDDHEQJE X-Message-ID-Hash: FNFMAU6M57O4Q52MZGVLRQM2CDDHEQJE X-Mailman-Approved-At: Wed, 25 Feb 2026 09:03:31 +0000 CC: Xiaotian Feng , Xiaotian Feng , Ankit Soni X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Xiaotian Feng via Devel Reply-To: Xiaotian Feng X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1772010474021158500 Content-Type: text/plain; charset="utf-8" Add QEMU_CAPS_AMD_IOMMU_XTSUP capability and enable xtsup by default for AMD IOMMU when a Q35 domain has >255 vCPUs, similar to Intel EIM auto-enable logic. Also ensure intremap is turned on when required. Signed-off-by: Xiaotian Feng Reviewed-by: Ankit Soni Tested-by: Ankit Soni --- src/qemu/qemu_capabilities.c | 2 ++ src/qemu/qemu_capabilities.h | 1 + src/qemu/qemu_postparse.c | 38 ++++++++++++++++++++++++------------ 3 files changed, 28 insertions(+), 13 deletions(-) diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c index 5d75c23072..c8667fd77c 100644 --- a/src/qemu/qemu_capabilities.c +++ b/src/qemu/qemu_capabilities.c @@ -762,6 +762,7 @@ VIR_ENUM_IMPL(virQEMUCaps, "scsi-block.migrate-pr", /* QEMU_CAPS_DEVICE_SCSI_BLOCK_MIGR= ATE_PR */ "iommufd", /* QEMU_CAPS_OBJECT_IOMMUFD */ "uefi-vars", /* QEMU_CAPS_DEVICE_UEFI_VARS */ + "amd-iommu.xtsup", /* QEMU_CAPS_AMD_IOMMU_XTSUP */ ); =20 =20 @@ -1632,6 +1633,7 @@ static struct virQEMUCapsDevicePropsFlags virQEMUCaps= DevicePropsVirtioBlkCCW[] =3D =20 static struct virQEMUCapsDevicePropsFlags virQEMUCapsDevicePropsAMDIOMMU[]= =3D { { "pci-id", QEMU_CAPS_AMD_IOMMU_PCI_ID, NULL }, + { "xtsup", QEMU_CAPS_AMD_IOMMU_XTSUP, NULL }, }; =20 /* see documentation for virQEMUQAPISchemaPathGet for the query format */ diff --git a/src/qemu/qemu_capabilities.h b/src/qemu/qemu_capabilities.h index a48e1d0367..5662c81e71 100644 --- a/src/qemu/qemu_capabilities.h +++ b/src/qemu/qemu_capabilities.h @@ -736,6 +736,7 @@ typedef enum { /* virQEMUCapsFlags grouping marker for = syntax-check */ QEMU_CAPS_DEVICE_SCSI_BLOCK_MIGRATE_PR, /* persistent reservation migr= ation support */ QEMU_CAPS_OBJECT_IOMMUFD, /* -object iommufd */ QEMU_CAPS_DEVICE_UEFI_VARS, /* -device uefi-vars-{x64,sysbus} */ + QEMU_CAPS_AMD_IOMMU_XTSUP, /* amd-iommu.xtsup */ =20 QEMU_CAPS_LAST /* this must always be the last item */ } virQEMUCapsFlags; diff --git a/src/qemu/qemu_postparse.c b/src/qemu/qemu_postparse.c index 58bd70c741..79e02e34ac 100644 --- a/src/qemu/qemu_postparse.c +++ b/src/qemu/qemu_postparse.c @@ -794,7 +794,7 @@ qemuDomainPstoreDefPostParse(virDomainPstoreDef *pstore, =20 =20 static bool -qemuDomainNeedsIOMMUWithEIM(const virDomainDef *def) +qemuDomainNeedsIOMMUWithx2APIC(const virDomainDef *def) { return ARCH_IS_X86(def->os.arch) && virDomainDefGetVcpusMax(def) > QEMU_MAX_VCPUS_WITHOUT_X2APIC && @@ -808,22 +808,34 @@ qemuDomainIOMMUDefPostParse(virDomainIOMMUDef *iommu, virQEMUCaps *qemuCaps, unsigned int parseFlags) { - /* In case domain has huge number of vCPUS and Extended Interrupt Mode - * (EIM) is not explicitly turned off, let's enable it. If we didn't t= hen + /* In case domain has huge number of vCPUS and x2APIC (intel EIM or AMD + * XTSUP) is not explicitly turned off, let's enable it. If we didn't = then * guest will have troubles with interrupts. */ if (parseFlags & VIR_DOMAIN_DEF_PARSE_ABI_UPDATE && - qemuDomainNeedsIOMMUWithEIM(def) && - iommu && iommu->model =3D=3D VIR_DOMAIN_IOMMU_MODEL_INTEL) { + qemuDomainNeedsIOMMUWithx2APIC(def) && iommu) { + if (iommu->model =3D=3D VIR_DOMAIN_IOMMU_MODEL_INTEL) { + /* eim requires intremap. */ + if (iommu->intremap =3D=3D VIR_TRISTATE_SWITCH_ABSENT && + virQEMUCapsGet(qemuCaps, QEMU_CAPS_INTEL_IOMMU_INTREMAP)) { + iommu->intremap =3D VIR_TRISTATE_SWITCH_ON; + } =20 - /* eim requires intremap. */ - if (iommu->intremap =3D=3D VIR_TRISTATE_SWITCH_ABSENT && - virQEMUCapsGet(qemuCaps, QEMU_CAPS_INTEL_IOMMU_INTREMAP)) { - iommu->intremap =3D VIR_TRISTATE_SWITCH_ON; + if (iommu->eim =3D=3D VIR_TRISTATE_SWITCH_ABSENT && + virQEMUCapsGet(qemuCaps, QEMU_CAPS_INTEL_IOMMU_EIM)) { + iommu->eim =3D VIR_TRISTATE_SWITCH_ON; + } } =20 - if (iommu->eim =3D=3D VIR_TRISTATE_SWITCH_ABSENT && - virQEMUCapsGet(qemuCaps, QEMU_CAPS_INTEL_IOMMU_EIM)) { - iommu->eim =3D VIR_TRISTATE_SWITCH_ON; + if (iommu->model =3D=3D VIR_DOMAIN_IOMMU_MODEL_AMD) { + if (iommu->intremap =3D=3D VIR_TRISTATE_SWITCH_ABSENT && + virQEMUCapsGet(qemuCaps, QEMU_CAPS_INTEL_IOMMU_INTREMAP)) { + iommu->intremap =3D VIR_TRISTATE_SWITCH_ON; + } + + if (iommu->xtsup =3D=3D VIR_TRISTATE_SWITCH_ABSENT && + virQEMUCapsGet(qemuCaps, QEMU_CAPS_AMD_IOMMU_XTSUP)) { + iommu->xtsup =3D VIR_TRISTATE_SWITCH_ON; + } } } =20 @@ -1544,7 +1556,7 @@ qemuDomainDefEnableDefaultFeatures(virDomainDef *def, * modified so change it now. */ if (def->iommus && def->iommus[0]->pci_bus < 0 && (def->iommus[0]->intremap =3D=3D VIR_TRISTATE_SWITCH_ON || - qemuDomainNeedsIOMMUWithEIM(def)) && + qemuDomainNeedsIOMMUWithx2APIC(def)) && def->features[VIR_DOMAIN_FEATURE_IOAPIC] =3D=3D VIR_DOMAIN_IOAPIC_= NONE) { def->features[VIR_DOMAIN_FEATURE_IOAPIC] =3D VIR_DOMAIN_IOAPIC_QEM= U; } --=20 2.34.1