From nobody Tue Mar 3 04:52:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771921709; cv=none; d=zohomail.com; s=zohoarc; b=CZzKOckxm3P5dC3MU2a9Q6tPxJUnKRM+0tmbMa2kUorReM2OsQWvBn6iEnz+EE/iAHaWjn6otDEWf9dObGK+6Ua+TM41ynFxajLx0xH3DQkDoCDoAliQVVxpq+DaVpa5GR2YzIPzlESzpaGm9odf7W60ZtPAK8a7Uu14OEW1mYs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771921709; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=+vGZ3WndCRI8R6fueuTQV71t5cc5iVEor0Sa03mPjCE=; b=joIoa7aY22f2B27GyWwpK8lUn9rh52JtWL+DKv+U7cGW+0Lwm2qM/anUVkgTbgpIbe05HBcR7PDOQWTq9ddGe90V57biQ1RPTxmOceLrDDbBCGLVdmUqclmpzXQURtWl/5ZRoEB7LogTlhikQdzYbYDnlWwChd4pQ4Hdi6Y2Jpg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771921709391551.0527104160193; Tue, 24 Feb 2026 00:28:29 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id A168641CC6; Tue, 24 Feb 2026 03:28:28 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id DA05B41E4F; Tue, 24 Feb 2026 03:23:40 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6F93541B48; Tue, 24 Feb 2026 03:22:51 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 19C1341B66 for ; Tue, 24 Feb 2026 03:22:51 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-chxFuWRHNf2YbD3Be_mv5g-1; Tue, 24 Feb 2026 03:22:49 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B3796195609D for ; Tue, 24 Feb 2026 08:22:48 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.64.82]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 5C1E41800465 for ; Tue, 24 Feb 2026 08:22:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771921370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+vGZ3WndCRI8R6fueuTQV71t5cc5iVEor0Sa03mPjCE=; b=C6VSDcwIZ/lRgA1HLjwRUx9dr7seiRCYh77tX0X7DKhzS2VM/cjfQkL2TqSYkRDKcC0V4g d4nFXjZaP+AOi3+VacZRfmLufz1ENC/AdP1PxmGuUFYsLZn4McUemjf8I8VzcTr5cDNNfN tPdri2Z/04VcdYj7wAPRSG1xPXNnMKE= X-MC-Unique: chxFuWRHNf2YbD3Be_mv5g-1 X-Mimecast-MFC-AGG-ID: chxFuWRHNf2YbD3Be_mv5g_1771921368 To: devel@lists.libvirt.org Subject: [PATCH 8/8] tests: stop mocking virGetUserRuntimeDirectory() Date: Tue, 24 Feb 2026 03:22:42 -0500 Message-ID: <20260224082242.274009-9-laine@redhat.com> In-Reply-To: <20260224082242.274009-1-laine@redhat.com> References: <20260224082242.274009-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Bvj1ZUKR3_U8d8nRGVT8wzlzWDUPGaDa3O-wpBKBOas_1771921368 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: QH2JEXH6AMBZ2HKFN4WLG2YGKVBR2IGX X-Message-ID-Hash: QH2JEXH6AMBZ2HKFN4WLG2YGKVBR2IGX X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Laine Stump via Devel Reply-To: Laine Stump X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771921710415158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Laine Stump The same functionality has been achieved by setting the XDG_RUNTIME_DIR environment variable during the setup of the "fake root" directory in testutils.c Signed-off-by: Laine Stump --- tests/meson.build | 1 - tests/qemuhotplugtest.c | 1 - tests/virhostdevmock.c | 15 --------------- tests/virhostdevtest.c | 1 - 4 files changed, 18 deletions(-) delete mode 100644 tests/virhostdevmock.c diff --git a/tests/meson.build b/tests/meson.build index b28ad4a65b..847538d2e4 100644 --- a/tests/meson.build +++ b/tests/meson.build @@ -78,7 +78,6 @@ mock_libs =3D [ { 'name': 'virfilecachemock' }, { 'name': 'virfirewallmock' }, { 'name': 'virhostcpumock' }, - { 'name': 'virhostdevmock' }, { 'name': 'virnetdaemonmock' }, { 'name': 'virnetdevmock' }, { 'name': 'virnetserverclientmock' }, diff --git a/tests/qemuhotplugtest.c b/tests/qemuhotplugtest.c index 58413b6e0d..0cd738ae3d 100644 --- a/tests/qemuhotplugtest.c +++ b/tests/qemuhotplugtest.c @@ -799,7 +799,6 @@ mymain(void) } =20 VIR_TEST_MAIN_PRELOAD(mymain, - VIR_TEST_MOCK("virhostdev"), VIR_TEST_MOCK("virpci"), VIR_TEST_MOCK("domaincaps"), VIR_TEST_MOCK("virprocess"), diff --git a/tests/virhostdevmock.c b/tests/virhostdevmock.c deleted file mode 100644 index 9b0e4dc2b0..0000000000 --- a/tests/virhostdevmock.c +++ /dev/null @@ -1,15 +0,0 @@ -/* - * Copyright (C) 2020 Red Hat, Inc. - * SPDX-License-Identifier: LGPL-2.1-or-later - */ - -#include - -#include "virutil.h" - -char * -virGetUserRuntimeDirectory(void) -{ - return g_build_filename(g_getenv("LIBVIRT_FAKE_ROOT_DIR"), - "user-runtime-directory", NULL); -} diff --git a/tests/virhostdevtest.c b/tests/virhostdevtest.c index b0fb94e197..d52d549feb 100644 --- a/tests/virhostdevtest.c +++ b/tests/virhostdevtest.c @@ -613,7 +613,6 @@ mymain(void) } =20 VIR_TEST_MAIN_PRELOAD(mymain, - VIR_TEST_MOCK("virhostdev"), VIR_TEST_MOCK("virpci")) #else int --=20 2.52.0