From nobody Tue Mar 3 04:52:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771919759; cv=none; d=zohomail.com; s=zohoarc; b=Ki7y/eKCWQs8Fz6eU2DxouuB4Tn5bAfouJpcAZwYMiaf3VnKqRgyZ160EPyB5G4WHwuqDnzboL8tEuPPwVuQ461voz+5Isqr+7Sfigq4UwaSDJUGMNje9ErAy4dpzIFZUEzr3fvS3z4mwMqXEG0xx+BybBjym7Xpxoo6+xnp3uc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771919759; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=QGYL4sJ23Cb4K+H1zAbP6kS5yn7O1nOjQm1a4WZGBCg=; b=GonDeQ2nqQm13SSBMPBGSQ1h0/prEinX7XY/t36fbl7FteNAns1iFiLJ9GGtuK5ZYY1CqI1Q/qcgZGKYqMq1ujIWg/Oe2oIAR8+C77s1IfnVjHaoWAUD7mksAcPXXlc1evmjKR1apsuQnl522kYM21YhF8Vhv840RXcQ5xFH2dg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771919759549246.21070250144078; Mon, 23 Feb 2026 23:55:59 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id BB83241BF0; Tue, 24 Feb 2026 02:55:58 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id AD59E41DC3; Tue, 24 Feb 2026 02:52:26 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DC7EC41B5C; Tue, 24 Feb 2026 02:52:15 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 7715241B4C for ; Tue, 24 Feb 2026 02:52:15 -0500 (EST) Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-184-Wt8JHmAhNlSLzcWCCi2a9Q-1; Tue, 24 Feb 2026 02:52:12 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8761C1956073 for ; Tue, 24 Feb 2026 07:52:11 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.64.82]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 24CF21800370 for ; Tue, 24 Feb 2026 07:52:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771919535; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QGYL4sJ23Cb4K+H1zAbP6kS5yn7O1nOjQm1a4WZGBCg=; b=P0BkeHjjk3sbBf/awBbU6spdx8oFCv0RxziZuPUraUVcJbE3ucyZFsOhl3ogG2XVlc8N5l RWlzc5BAmREGphUfpGcyWAbNDCnBteT+lfqU3t7h2xm7NQMy7CEFv+kKtrIXDYwnmWW5J6 KUsch8Byb7fO0iDNpLBMhMvKenyqBmA= X-MC-Unique: Wt8JHmAhNlSLzcWCCi2a9Q-1 X-Mimecast-MFC-AGG-ID: Wt8JHmAhNlSLzcWCCi2a9Q_1771919531 To: devel@lists.libvirt.org Subject: [PATCH 3/6] qemu: only limit IPv4 prefix for slirp Date: Tue, 24 Feb 2026 02:52:05 -0500 Message-ID: <20260224075208.225959-4-laine@redhat.com> In-Reply-To: <20260224075208.225959-1-laine@redhat.com> References: <20260224075208.225959-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Pf6LVifQdBlwQWLgg1rNY5ZAkzviFqPNYZH_OCtc540_1771919531 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: XESH5ZXDLPU6TIDHVLWOVEW3PSKLCX36 X-Message-ID-Hash: XESH5ZXDLPU6TIDHVLWOVEW3PSKLCX36 X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Laine Stump via Devel Reply-To: Laine Stump X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771919761263158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Laine Stump The slirp backend is limited in what the netmask/prefix of a user-specified IP address can be, but passt doesn't have these artificial limitations - any valid prefix is okay with passt, so we shouldn't reject them Signed-off-by: Laine Stump --- src/qemu/qemu_validate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index a0ddf512f1..1c6662751b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -1926,8 +1926,9 @@ qemuValidateDomainDeviceDefNetwork(const virDomainNet= Def *net, } hasV4Addr =3D true; =20 - if (ip->prefix > 0 && - (ip->prefix < 4 || ip->prefix > 27)) { + if (net->backend.type !=3D VIR_DOMAIN_NET_BACKEND_PASST && + (ip->prefix > 0 && + (ip->prefix < 4 || ip->prefix > 27))) { virReportError(VIR_ERR_XML_ERROR, "%s", _("invalid prefix, must be in range of 4-27= ")); return -1; --=20 2.52.0