From nobody Tue Mar 3 04:52:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771919587; cv=none; d=zohomail.com; s=zohoarc; b=dvTg+SzjVC5jQMjIKf/hnAET3ef7r72Tm6sL+ub2SqB9Xb670p5US3f3AP8KaDRAW+MAY5+3a/yFXqymwSPnW/Z+/LGIXDWbY/og1r3vpNckQ45LoM5AjONexB/9Cb94/eSFMaRis7tHK3PVXjh7GNT6Y7Lb4vldqOW2WChUXOk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771919587; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=G/MDCpKe3JqXRoYX38irQzAKky+VR0lbQkA2sfhGzmk=; b=XjRKp+/cjNa/QrYK7G34z/bavULUJHnxCzN/lktPmkKG5Nb06iNO1VhpJ/5cPEdmEw6TT4EBF39dx9WuhhDelAslYdUsytp/3rK5FLYmUC4VqRFflyitGupBhZTaesyR2Ejn23VwiazN5O8fXxxvq4gnzKH2S6sL7h8aCbi/e4Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771919587170331.65091485495793; Mon, 23 Feb 2026 23:53:07 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id D0D6941C08; Tue, 24 Feb 2026 02:53:04 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id EE54841C4A; Tue, 24 Feb 2026 02:52:18 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id A779841B4C; Tue, 24 Feb 2026 02:52:13 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 48C4341A0A for ; Tue, 24 Feb 2026 02:52:13 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-483-GMjOvc8mMrqqxdXYuDRcNQ-1; Tue, 24 Feb 2026 02:52:11 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A88D180025F for ; Tue, 24 Feb 2026 07:52:10 +0000 (UTC) Received: from vhost3.router.laine.org (unknown [10.22.64.82]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E79EE1800370 for ; Tue, 24 Feb 2026 07:52:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771919532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=G/MDCpKe3JqXRoYX38irQzAKky+VR0lbQkA2sfhGzmk=; b=MFIJ/bhtLU+Rl77QwA885PhVouVBbuuP8HE3CLT82u41WCaCjVZNfCbevEwxBt1CTjDsF5 rO09ezTrYhqGrrNcabI/XqMA2JOJFFu9Hj29BA5ooJrbwD8EZYhr4oCxTQF7yr/TE0gDCw tg9WpOcRJEgwIDg/iT2gwvyYxf0c8fE= X-MC-Unique: GMjOvc8mMrqqxdXYuDRcNQ-1 X-Mimecast-MFC-AGG-ID: GMjOvc8mMrqqxdXYuDRcNQ_1771919530 To: devel@lists.libvirt.org Subject: [PATCH 1/6] qemu: delete passt "repair" socket when appropriate Date: Tue, 24 Feb 2026 02:52:03 -0500 Message-ID: <20260224075208.225959-2-laine@redhat.com> In-Reply-To: <20260224075208.225959-1-laine@redhat.com> References: <20260224075208.225959-1-laine@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PpCMid0dWo6m6FukG5I-p_KgyTLM6AdZfXVHnL9qhOE_1771919530 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: HGABZUXU3XTYCEXNI52AIV5DK4ZK53XR X-Message-ID-Hash: HGABZUXU3XTYCEXNI52AIV5DK4ZK53XR X-MailFrom: laine@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Laine Stump via Devel Reply-To: Laine Stump X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771919589709158500 Content-Type: text/plain; charset="utf-8"; x-default="true" From: Laine Stump When using a vhost-user connection between passt and QEMU, passt will autocreate a socket called ${socketname}.repair, but doesn't delete this socket when it exits, so to be a good citizen, libvirtshould delete it when we are tearing down the passt device plumbing. Resolves: https://issues.redhat.com/browse/RHEL-80285 Signed-off-by: Laine Stump Reviewed-by: Michal Privoznik --- src/qemu/qemu_passt.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/src/qemu/qemu_passt.c b/src/qemu/qemu_passt.c index 520eb1244a..56d048d585 100644 --- a/src/qemu/qemu_passt.c +++ b/src/qemu/qemu_passt.c @@ -121,7 +121,7 @@ qemuPasstAddNetProps(virDomainObj *vm, =20 =20 static void -qemuPasstKill(const char *pidfile, const char *passtSocketName) +qemuPasstKill(const virDomainNetDef *net, const char *pidfile, const char = *passtSocketName) { virErrorPtr orig_err; pid_t pid =3D 0; @@ -135,6 +135,14 @@ qemuPasstKill(const char *pidfile, const char *passtSo= cketName) =20 unlink(passtSocketName); =20 + /* repair socket is (always) created by passt only for vhostuser mode = */ + if (virDomainNetGetActualType(net) =3D=3D VIR_DOMAIN_NET_TYPE_VHOSTUSE= R) { + g_autofree char *passtRepairSocketName + =3D g_strdup_printf("%s.repair", passtSocketName); + + unlink(passtRepairSocketName); + } + virErrorRestore(&orig_err); } =20 @@ -146,7 +154,7 @@ qemuPasstStop(virDomainObj *vm, g_autofree char *pidfile =3D qemuPasstCreatePidFilename(vm, net); g_autofree char *passtSocketName =3D qemuPasstCreateSocketPath(vm, net= ); =20 - qemuPasstKill(pidfile, passtSocketName); + qemuPasstKill(net, pidfile, passtSocketName); } =20 =20 @@ -351,6 +359,6 @@ qemuPasstStart(virDomainObj *vm, return 0; =20 error: - qemuPasstKill(pidfile, passtSocketName); + qemuPasstKill(net, pidfile, passtSocketName); return -1; } --=20 2.52.0