From nobody Tue Mar 3 04:52:42 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771871779; cv=none; d=zohomail.com; s=zohoarc; b=cxJO2QuCxgKplKaahMkuuxliycir8n0vqreVO6d/qlFvTxBF9mKe9z1bI6YxHEu+9tkY2Ah0GDqpTCvC6tO/nro11Wzqm+RtZhgUfH3lwatA9SMYsACUHPzyOxECZ6kmpTtz5hmgIaSNsd5mDHHnQeHSep0U4CnWT59XpWcCXzc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771871779; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=yVHRSNbj3isDe27hDsdh/jwsSy+1ghh/6pnQHDl0Jo4=; b=QdvAIpjq8UMS9wWP+3qdeLJ2XfSthTsxmHfgF+9F3JRizZ2jsg6x1ukb3tfXFEnPWuH3mbp991SakLjVpZJSIK5nJepXnCdByeY6uR0ClDqMNAs/HKFArXrJQ3sqdr4PlqsXlowD5Csh/1KHdptEzt/ptCNVLknyqZAmVeZ/RQc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771871779004321.5352336328814; Mon, 23 Feb 2026 10:36:19 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 4172841C09; Mon, 23 Feb 2026 13:36:18 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 9A33A41C7F; Mon, 23 Feb 2026 13:32:08 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 7352241C2C; Mon, 23 Feb 2026 13:32:04 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 078FF41B02 for ; Mon, 23 Feb 2026 13:31:33 -0500 (EST) Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-SnWVwqq4OVekxwi1CwJDEQ-1; Mon, 23 Feb 2026 13:31:32 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 68305195608A for ; Mon, 23 Feb 2026 18:31:31 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.44.32.20]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5BAD01955D71 for ; Mon, 23 Feb 2026 18:31:29 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771871493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=yVHRSNbj3isDe27hDsdh/jwsSy+1ghh/6pnQHDl0Jo4=; b=fxKv05o2P9y+A+F6qxqHJdAi/cQGzYQ3X4cwR0pbQ6YLQ3Q9Kkq2ADOxKfzULMjsXrgzK/ f9QNe5l1wgKSlBYb2w7bp3uuhL4Co+i9pAD25QoGnhiaq2u29SNYlRsjdd6NR4+TX/Q9Cz lN/SiXK9B2ytPmQIHQZ5G++8EFlJIhc= X-MC-Unique: SnWVwqq4OVekxwi1CwJDEQ-1 X-Mimecast-MFC-AGG-ID: SnWVwqq4OVekxwi1CwJDEQ_1771871491 To: devel@lists.libvirt.org Subject: [PATCH v4 03/36] qemu_firmware: Only set format for custom loader if path is present Date: Mon, 23 Feb 2026 19:30:46 +0100 Message-ID: <20260223183119.501349-4-abologna@redhat.com> In-Reply-To: <20260223183119.501349-1-abologna@redhat.com> References: <20260223183119.501349-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: F7GXrfGRelnb2s2lDhgjnpStJQPPZUETNxd1k1GJSZE_1771871491 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MNNINCGEJD3ZTFAYFOK6ZA7NPT6TGTI2 X-Message-ID-Hash: MNNINCGEJD3ZTFAYFOK6ZA7NPT6TGTI2 X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771871780512158500 We only set the template format if the template path is present, and we should be consistent with that. The format on its own is not very interesting anyway. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Acked-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 436b06c388..519828f6f9 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1662,8 +1662,10 @@ qemuFirmwareFillDomainCustom(virDomainDef *def) if (!loader) return; =20 - if (!loader->format) + if (loader->path && + !loader->format) { loader->format =3D VIR_STORAGE_FILE_RAW; + } =20 if (loader->nvramTemplate && !loader->nvramTemplateFormat) { --=20 2.53.0