From nobody Tue Mar 3 04:54:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771872767; cv=none; d=zohomail.com; s=zohoarc; b=V+sONmaC3FrrHzhwwctZBZ2MtkCCB4/FUeW7gYW6RX4AxhdyFR7kVwAukBu34W4ZbRZdOPYzq5HOltxC7d4VGiFWA7i3b6sYDOaOrt6n6LNSTHc56oooRbjs1Trhp9Q61oYTbCJBSQ6tEBDe+Ls7hIzu20BheHZ/nchOf95MlAU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771872767; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=2XCv1LcfWJe0MrDkKYMDkOVwhpxPmGYQzNYUBNapJCw=; b=jKphEqxLtojJS53tyelaaCDfXBfmZzOkhVq92LxLfgnt6l+cFxclE5Rfmqzlo7T/wZzvlU1pFoqDQYjSnN4HAeR7AGEqxxHeUD/fIBpigT0D7WA+cGQvcEHKcFS4y8CnaJS8DBx0kaDBZ0qYaOhr8JpsO4bQvjuChVlThe6oKl8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771872767282124.48409246840879; Mon, 23 Feb 2026 10:52:47 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 69A2B419C0; Mon, 23 Feb 2026 13:52:46 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 18E3A44042; Mon, 23 Feb 2026 13:36:34 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 5367241A4F; Mon, 23 Feb 2026 13:36:22 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 98897419FE for ; Mon, 23 Feb 2026 13:32:12 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-NIrALWpGM9aOC4n7jUbCIA-1; Mon, 23 Feb 2026 13:32:11 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 73E5E1955E7E for ; Mon, 23 Feb 2026 18:32:09 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.44.32.20]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4D79E195419E for ; Mon, 23 Feb 2026 18:32:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771871532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2XCv1LcfWJe0MrDkKYMDkOVwhpxPmGYQzNYUBNapJCw=; b=A7E6qIwxCLNKGL8zD5NOAU3+DPU3mm6nBZJTdhXdn+hYllegCZ7tfwSBgl8vVXEFrxaNj0 dBi4tdAQfygNTTef4cxO8Bt6RR/oevKD4fxQEKJvZd+E4G/asWr22LTEg0+Fjs5na9yb/o ecBNXhDlhdOYSX8HFxkZXgfIsfBwffI= X-MC-Unique: NIrALWpGM9aOC4n7jUbCIA-1 X-Mimecast-MFC-AGG-ID: NIrALWpGM9aOC4n7jUbCIA_1771871530 To: devel@lists.libvirt.org Subject: [PATCH v4 23/36] qemu_firmware: Use of NVRAM implies stateful firmware Date: Mon, 23 Feb 2026 19:31:06 +0100 Message-ID: <20260223183119.501349-24-abologna@redhat.com> In-Reply-To: <20260223183119.501349-1-abologna@redhat.com> References: <20260223183119.501349-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nY1qrDMakdPr283bda6VJd9agsu0P2NrZ148TsuEQB4_1771871530 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 2LEGZMGNQL7PDNNMUU3VR3OYSDZCN2PZ X-Message-ID-Hash: 2LEGZMGNQL7PDNNMUU3VR3OYSDZCN2PZ X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771872767600158500 Currently we only look at the value for the stateless attribute itself when matching, but the element being included in the input XML is likewise a clear sign that a stateless firmware build will not satisfy the user's requirements. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Acked-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_firmware.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 60cc92e46a..1851ed4a80 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1288,13 +1288,19 @@ qemuFirmwareMatchDomain(const virDomainDef *def, /* Explicit requests for either a stateless or stateful * firmware should be fulfilled, but if no preference is * provided either one is fine as long as the other match - * criteria are satisfied */ + * criteria are satisfied. NVRAM implies stateful */ if (loader && loader->stateless =3D=3D VIR_TRISTATE_BOOL_NO && flash->mode =3D=3D QEMU_FIRMWARE_FLASH_MODE_STATELESS) { VIR_DEBUG("Discarding stateless loader"); return false; } + if (loader && + loader->nvram && + flash->mode =3D=3D QEMU_FIRMWARE_FLASH_MODE_STATELESS) { + VIR_DEBUG("Discarding stateless loader"); + return false; + } if (loader && loader->stateless =3D=3D VIR_TRISTATE_BOOL_YES && flash->mode !=3D QEMU_FIRMWARE_FLASH_MODE_STATELESS) { --=20 2.53.0