From nobody Tue Mar 3 04:55:51 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771872733; cv=none; d=zohomail.com; s=zohoarc; b=YCXIEkTpK0KgHEmXrmXxXFCyUXmuq7axS7WkofmDSKRKF/9qmhZDw+SatFMLqxMhKAM6WTqsKf0y7+EJaSoUzOMQqFt9onPb76nGb8mMI6fukflbsOnc3oyKfovVCuFPv3xTPHLOuwLExN8cF/zarpSB6v3115jCKCOgoCzRSec= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771872733; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=unZ8Zka7LBAHWSiQED94RGCqC24W/ZDTcw5cEJXV6Ig=; b=PFx5datjGmzKg/8bnksLQfeBB0kb2fYj5YQInQ1F1gbj3geInNJc0cBtecw/1IEWfy2ZkoCxsqymphKjjYaxfHVv00edEKlXZGmEbJ0XKqj3x/DJv8rjdQPweTjeyfHCkD7elsH4o/iH1gheihQNtvWSpfFeqMXceeNuFzBKg74= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 177187273337031.619200086748606; Mon, 23 Feb 2026 10:52:13 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 6609A41B53; Mon, 23 Feb 2026 13:52:12 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8555A43FFD; Mon, 23 Feb 2026 13:36:32 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 21ED941A4F; Mon, 23 Feb 2026 13:36:22 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0FE0041A0C for ; Mon, 23 Feb 2026 13:32:15 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-108-AUwLXQvsOLC8G0jwdXt-sw-1; Mon, 23 Feb 2026 13:32:13 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4A7CD1828A96 for ; Mon, 23 Feb 2026 18:32:02 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.44.32.20]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EA50F1955D71 for ; Mon, 23 Feb 2026 18:32:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771871534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=unZ8Zka7LBAHWSiQED94RGCqC24W/ZDTcw5cEJXV6Ig=; b=NrJ3/0jH2/iy9WdUYwmEz3vQ1yqeumaWhSB6oULyRB1eGmPu6JorZv66sSLU6yynCVqEIi ymE2Lx5sVrIN9MDHnvMuxSsTgZ4BtaVVybVLw7p1zLzmpiCBzqrBPl7qpwlmNsP1kl3vnf SALyjOriNn5nJV3lYi2XylpVBLL+Cvs= X-MC-Unique: AUwLXQvsOLC8G0jwdXt-sw-1 X-Mimecast-MFC-AGG-ID: AUwLXQvsOLC8G0jwdXt-sw_1771871532 To: devel@lists.libvirt.org Subject: [PATCH v4 20/36] qemu_firmware: Report NVRAM template path for ROMs Date: Mon, 23 Feb 2026 19:31:03 +0100 Message-ID: <20260223183119.501349-21-abologna@redhat.com> In-Reply-To: <20260223183119.501349-1-abologna@redhat.com> References: <20260223183119.501349-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: M4k9FYcCe5yKKkITtIerkX5Ht-1TbxJmFrm_5E13ZTY_1771871532 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: TSA6SPSLL6SOCM54WCQH3UV5WSTMQTHP X-Message-ID-Hash: TSA6SPSLL6SOCM54WCQH3UV5WSTMQTHP X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771872735448158500 This was not necessary until now since ROMs couldn't have an associate NVRAM template, and technically speaking they still can't; however, the varstore template serves essentialy the same purpose. The qemuFirmwareGetSupported() helper is used in two places: one is the code that is responsible for filling in domaincaps, where templates are ignored so this change has no impact on it; the other is the qemufirmware test program, where this value being reported is useful as it will allow us to confirm that the JSON firmware descriptors for uefi-vars enabled builds are parsed correctly. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Acked-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_firmware.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 7af3f32b85..72aae73dcb 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -2161,6 +2161,7 @@ qemuFirmwareGetSupported(const char *machine, =20 case QEMU_FIRMWARE_DEVICE_MEMORY: fwpath =3D memory->filename; + nvrampath =3D memory->template; break; =20 case QEMU_FIRMWARE_DEVICE_NONE: --=20 2.53.0