From nobody Tue Mar 3 04:54:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771872662; cv=none; d=zohomail.com; s=zohoarc; b=V4RAO2wh4kMMIPxu2CuEPcKsd4D5sjCjs29TE4TOU5JnEhanmPs8RvN4gbpBTSERiK9JqhqX5w4VVOWbShJiA1wVmYNHQ2o67S9IFlQN9lPVc7TkL6OK51Xf1R3GQHhfK2KmmTiPlnMTFXBVZ8uQ4N9u+CTGw78hNdz+2kRmyQQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771872662; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=THferTqnNGyvOsgDxWDZMIiKUHmYEIEixaxlqT3aL7o=; b=Jq6L6hKdWSy/XdJkfmAoy3YwSx63cxqaCF8NqJtF1setIJC6CFo1mYXTGviCT2DGcLSL1tjDsMl2JOWkkFKSoHBlLFpW5YP2q/3/jvZ6KL+6Fryn9wfX8LB27DKYPiWuIDJfkyQLvUFd53IcM1Eouy8/wOZIfvBwC7Qhx3XNK6U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771872662497810.0860543693586; Mon, 23 Feb 2026 10:51:02 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9F58E3F367; Mon, 23 Feb 2026 13:51:01 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 3F38543F6C; Mon, 23 Feb 2026 13:36:26 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id A531D41C20; Mon, 23 Feb 2026 13:36:21 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id AD25B41C85 for ; Mon, 23 Feb 2026 13:32:08 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-fH9U2wsON6SdF-vNTH14oA-1; Mon, 23 Feb 2026 13:32:06 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9C6071845430 for ; Mon, 23 Feb 2026 18:31:58 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.44.32.20]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D064A1955D71 for ; Mon, 23 Feb 2026 18:31:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771871528; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=THferTqnNGyvOsgDxWDZMIiKUHmYEIEixaxlqT3aL7o=; b=exQhmCcH21vWbAIInRa7Gdc5uVKm9rTIB0a5xp+RONCr1e0uXd8OQtCWhcI0chRp55vwho P8m+I3DYFqrpsnBWwmblKQ043CzobwVlFYVWVoHKd2yaakF2I9n+VaGaIZVuTDf1FGUWrE Jwwj+mLQQ3EuqjBOOvy8LmWIYFTsjuI= X-MC-Unique: fH9U2wsON6SdF-vNTH14oA-1 X-Mimecast-MFC-AGG-ID: fH9U2wsON6SdF-vNTH14oA_1771871526 To: devel@lists.libvirt.org Subject: [PATCH v4 18/36] qemu_firmware: Consider host-uefi-vars feature in sanity check Date: Mon, 23 Feb 2026 19:31:01 +0100 Message-ID: <20260223183119.501349-19-abologna@redhat.com> In-Reply-To: <20260223183119.501349-1-abologna@redhat.com> References: <20260223183119.501349-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 0-iNQVJztqy2HFkioHo4peqgHHM5LIdi1_jAh-qtRok_1771871526 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: USGZS2YUS5HZQJ6WE5A4BGFZOMXZWDP6 X-Message-ID-Hash: USGZS2YUS5HZQJ6WE5A4BGFZOMXZWDP6 X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771872663126158500 Just like with firmware builds targeting the confidential use case, use of the uefi-vars device obviates the need to have SMM emulation enabled while still guaranteeing that protected EFI variables work as intended. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Acked-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_firmware.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 5c923b5a02..f9cb9058ac 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1552,6 +1552,7 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, bool requiresSMM =3D false; bool supportsSecureBoot =3D false; bool hasEnrolledKeys =3D false; + bool usesUefiVarsDevice =3D false; bool isConfidential =3D false; =20 for (i =3D 0; i < fw->nfeatures; i++) { @@ -1565,6 +1566,9 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, case QEMU_FIRMWARE_FEATURE_ENROLLED_KEYS: hasEnrolledKeys =3D true; break; + case QEMU_FIRMWARE_FEATURE_HOST_UEFI_VARS: + usesUefiVarsDevice =3D true; + break; case QEMU_FIRMWARE_FEATURE_AMD_SEV: case QEMU_FIRMWARE_FEATURE_AMD_SEV_ES: case QEMU_FIRMWARE_FEATURE_AMD_SEV_SNP: @@ -1574,7 +1578,6 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, case QEMU_FIRMWARE_FEATURE_NONE: case QEMU_FIRMWARE_FEATURE_ACPI_S3: case QEMU_FIRMWARE_FEATURE_ACPI_S4: - case QEMU_FIRMWARE_FEATURE_HOST_UEFI_VARS: case QEMU_FIRMWARE_FEATURE_VERBOSE_DYNAMIC: case QEMU_FIRMWARE_FEATURE_VERBOSE_STATIC: case QEMU_FIRMWARE_FEATURE_LAST: @@ -1588,14 +1591,21 @@ qemuFirmwareSanityCheck(const qemuFirmware *fw, * support SMM. This is OK, because EFI binaries for confidential * VMs also don't support EFI variable storage in NVRAM, instead * the secureboot state is hardcoded to enabled. + * + * Similarly, use of the uefi-vars QEMU device guarantees that + * protected EFI variables work as expected without requiring SMM + * emulation. */ if (!isConfidential && + !usesUefiVarsDevice && supportsSecureBoot !=3D requiresSMM) { VIR_WARN("Firmware description '%s' has invalid set of features: " - "%s =3D %d, %s =3D %d (isConfidential =3D %d)", + "%s =3D %d, %s =3D %d, %s =3D %d (isConfidential =3D %d)", filename, qemuFirmwareFeatureTypeToString(QEMU_FIRMWARE_FEATURE_REQ= UIRES_SMM), requiresSMM, + qemuFirmwareFeatureTypeToString(QEMU_FIRMWARE_FEATURE_HOS= T_UEFI_VARS), + usesUefiVarsDevice, qemuFirmwareFeatureTypeToString(QEMU_FIRMWARE_FEATURE_SEC= URE_BOOT), supportsSecureBoot, isConfidential); --=20 2.53.0