From nobody Tue Mar 3 04:54:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771872294; cv=none; d=zohomail.com; s=zohoarc; b=QkcIDyX5m/6YaK+xBKfqlPJBVbl6h7vOgWi/jXa/2/NsnJJ/CXzoQLPhutq4cWcHD0Y18Cwr50Owp5tKJx94eeqxDStWcNicPOMnKVajXuc4g0SpzE5Ww5h4EXbjZg3Kzpy7XHQqhXarw72OgmGj6b/aqtcSR78hNrxpR1aFt2E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771872294; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=sK7wcwCDMXcrYO88DqmeagENtPerq436nVfMWIZ1J/w=; b=UQv2FgrMih67G57cVlF6qzHg5AsTzWJoDS8E5wsmMNUW83Ht78PlVq1bzqmAZbc2fBH5vzYho7hzxOODSZo8DzsjM3wYLLvLxD25iXM1WIg7QHHEzHeE51WX9lLqtV9dBJh14vzDisra2ND8oGWUmTvKgQ4OK512NfVI0VyRr1M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771872294364536.3334924467872; Mon, 23 Feb 2026 10:44:54 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 7886E41A20; Mon, 23 Feb 2026 13:44:53 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 852A741E28; Mon, 23 Feb 2026 13:34:32 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 28D4541CFA; Mon, 23 Feb 2026 13:34:23 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 4CA1741BBA for ; Mon, 23 Feb 2026 13:31:48 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-484-btLZ-upqOeOz9o2_u30Mig-1; Mon, 23 Feb 2026 13:31:45 -0500 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E3F6318002C1 for ; Mon, 23 Feb 2026 18:31:44 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.44.32.20]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C05F3195419A for ; Mon, 23 Feb 2026 18:31:43 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771871508; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sK7wcwCDMXcrYO88DqmeagENtPerq436nVfMWIZ1J/w=; b=SZ/5e7aXHqi1f+bLxSKnHpe59ZmdQl69/PT3rS8ve4cngWu2GLwuWMVfeoi/sDILa2DvTd ABZ6oXIFhTHU0lK6g4w/fEXlff3K8qGecfvueQyvEcksZLEdmllCRrgm3GT4b0OEvSKPfw Dt90KEv2JWWiWfQVovZ7p0V0BLV6C+o= X-MC-Unique: btLZ-upqOeOz9o2_u30Mig-1 X-Mimecast-MFC-AGG-ID: btLZ-upqOeOz9o2_u30Mig_1771871505 To: devel@lists.libvirt.org Subject: [PATCH v4 10/36] qemu: Validate presence of uefi-vars device Date: Mon, 23 Feb 2026 19:30:53 +0100 Message-ID: <20260223183119.501349-11-abologna@redhat.com> In-Reply-To: <20260223183119.501349-1-abologna@redhat.com> References: <20260223183119.501349-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AtXHA3EPXrxgeRdtMPluZaSqVmxVm-YUKeYuo3OMw80_1771871505 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: JK2TIQCXCEMN6XUX7D474V6RFCBNQDOY X-Message-ID-Hash: JK2TIQCXCEMN6XUX7D474V6RFCBNQDOY X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771872295107158500 The use of varstore requires the uefi-vars device to be present in the QEMU binary. Signed-off-by: Andrea Bolognani Reviewed-by: Michal Privoznik Acked-by: Gerd Hoffmann Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_validate.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 16dd5fef1a..0eb5d5ea3b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -753,6 +753,23 @@ qemuValidateDomainDefNvram(const virDomainDef *def, } =20 =20 +static int +qemuValidateDomainDefVarstore(const virDomainDef *def, + virQEMUCaps *qemuCaps) +{ + if (!def->os.varstore) + return 0; + + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_UEFI_VARS)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("The uefi-vars device is not supported by this QE= MU binary")); + return -1; + } + + return 0; +} + + static int qemuValidateDomainDefBoot(const virDomainDef *def, virQEMUCaps *qemuCaps) @@ -796,6 +813,9 @@ qemuValidateDomainDefBoot(const virDomainDef *def, =20 if (qemuValidateDomainDefNvram(def, qemuCaps) < 0) return -1; + + if (qemuValidateDomainDefVarstore(def, qemuCaps) < 0) + return -1; } =20 for (i =3D 0; i < def->os.nacpiTables; i++) { --=20 2.53.0