From nobody Tue Mar 3 04:54:10 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771418274; cv=none; d=zohomail.com; s=zohoarc; b=BmP2JXmo4eJ7XRD0ogHmZMNEYkOP4kJpivo8Sl4RJFwX6qqUk1o9hIZNJgSTquU/DYi56TjCitDlVq7sXztwhTR6DKhQV91UKMFCOEK9hwW0pBqjvqiTjLLaig/xUpzHwNfhbqUzTRwtI0GYn6E4kAe4tybZlmViIUO9/9O93/M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771418274; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=cfK4ixwdQqgGDl+2hbZZF9dUvXlt/5r7XWzTNDvwHm8=; b=ZMbn+9rVQ4ym9mSUNKP1WRiQpEMd0q7/pPDNoEqnrj+XM5KGWOPxdUCNCvsVtwJgTVE+2jWbnfhkPSBYnfYG9kUPr0AWLjPF4tndDWD49cPVicNA9ltiQd8xn2AveGCwhZDdQFzqXgZr12ZxiOVKZbMXuSjKGYArPktGfITpbwo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771418274957754.5548560974191; Wed, 18 Feb 2026 04:37:54 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3036043DCA; Wed, 18 Feb 2026 07:37:54 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id DFD184416F; Wed, 18 Feb 2026 07:11:03 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 90A584418A; Wed, 18 Feb 2026 07:10:55 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 68A3E419B6 for ; Wed, 18 Feb 2026 07:07:02 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-640-wio_4_IhMm20HgVPevyxBQ-1; Wed, 18 Feb 2026 07:07:01 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 41A5818002F2 for ; Wed, 18 Feb 2026 12:07:00 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.45.226.171]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4C77C30001BF for ; Wed, 18 Feb 2026 12:06:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771416422; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cfK4ixwdQqgGDl+2hbZZF9dUvXlt/5r7XWzTNDvwHm8=; b=AZsZi2gCHPg6vosUusNy8wX9RsEEBiSv1B1RONQkyH0nSRr8fi8ScMRgBwiPPsW6gE1A7w 0B5BvB/97ueCnb0pM7zhErZmJYAB2Yi6wuDMilGsHBU90aQ1obKDxE9aITdWu8ig/7SpLA hEYEZegwCCXlFdh/PSAgPwGzgWOYHgI= X-MC-Unique: wio_4_IhMm20HgVPevyxBQ-1 X-Mimecast-MFC-AGG-ID: wio_4_IhMm20HgVPevyxBQ_1771416420 To: devel@lists.libvirt.org Subject: [PATCH v3 33/38] security: Mark ROMs as read only when using AppArmor Date: Wed, 18 Feb 2026 13:05:56 +0100 Message-ID: <20260218120601.230343-34-abologna@redhat.com> In-Reply-To: <20260218120601.230343-1-abologna@redhat.com> References: <20260218120601.230343-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: WvqwccD5LJKxfGxfx0mo0IQ3_Jdd9D54eaq5MonW_t8_1771416420 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: IYC5QCVVVVWOLYOSPYHBPCS2TVLJMO27 X-Message-ID-Hash: IYC5QCVVVVWOLYOSPYHBPCS2TVLJMO27 X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771418276756154100 Content-Type: text/plain; charset="utf-8"; x-default="true" Before this, attempting to use a ROM that was not explictly marked at read only resulted in an error at startup time. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/security/virt-aa-helper.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/security/virt-aa-helper.c b/src/security/virt-aa-helper.c index f4ec6b7826..3ac4740fb5 100644 --- a/src/security/virt-aa-helper.c +++ b/src/security/virt-aa-helper.c @@ -1021,7 +1021,15 @@ get_files(vahControl * ctl) =20 if (ctl->def->os.loader && ctl->def->os.loader->path) { bool readonly =3D false; + + /* Look at the readonly attribute, but also keep in mind that ROMs + * are always loaded read-only regardless of whether the attribute + * is present. Validation ensures that nonsensical configurations + * (type=3Drom readonly=3Dno) are rejected long before we get here= */ virTristateBoolToBool(ctl->def->os.loader->readonly, &readonly); + if (ctl->def->os.loader->type =3D=3D VIR_DOMAIN_LOADER_TYPE_ROM) + readonly =3D true; + if (vah_add_file(&buf, ctl->def->os.loader->path, readonly ? "rk" : "rwk") !=3D 0) { --=20 2.53.0