From nobody Tue Mar 3 04:52:36 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771416511; cv=none; d=zohomail.com; s=zohoarc; b=GQbsp94wgDpb7Uuxwks60Zv6jNJ8wGbDnD3qJeH2WlJ6N4DLFjrZ8to2xmA8ukybl5aP9vr0J/Y0rUzC+ImQ5WRP03e1PnZpAANf1DRdbM1F2r7MgwCZP75qPdhWQ/D89gp4SU4WHvZc6OBxueu9bexVaZiUyZ8DVS5r5VmWHZw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771416511; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=SgqmEylf+cV8qdrDc1g6Vm40+eCBTQWKjaJtrO4FTz0=; b=ZgcaQIr6aklFlzCRgbFwmYLu1ttiKmSfyUSUMwZOYQZKHA1mFjaD3144F4MudINCZB3t/j3sL01h1gOo9+GnqfRLsSR96HKWU5vQjpMYIG6lhexYdqHrCYIq/sJoVMi13vCqjM6HJewcp5l86uifNUkgkVXatL9WQOqFwZ9iloY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771416511270109.96193796899104; Wed, 18 Feb 2026 04:08:31 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id F354B41A20; Wed, 18 Feb 2026 07:08:29 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 8674141B05; Wed, 18 Feb 2026 07:06:17 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 823DB418F4; Wed, 18 Feb 2026 07:06:11 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits)) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 0AA66418E7 for ; Wed, 18 Feb 2026 07:06:11 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-8iWsRSeHMDWyjiNmpzyD3Q-1; Wed, 18 Feb 2026 07:06:09 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D18131800266 for ; Wed, 18 Feb 2026 12:06:08 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.45.226.171]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DEFE730001A5 for ; Wed, 18 Feb 2026 12:06:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771416370; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SgqmEylf+cV8qdrDc1g6Vm40+eCBTQWKjaJtrO4FTz0=; b=XltZiYlJZ+7rUyx9rIMXqofv2/ACBcnsOH5pcqr4i2DIZ2EuijOhPaHjC7p2sXU4B0Gpmk gfhPqPb04JE4GnPsXT9o1iRnO/acfzZh5EQxWs7iEBpuxNOjicPb09HaqmYv+ceZnjdOtw wIa1umpooiCKvY8JvYXh4gkG+5zHlfI= X-MC-Unique: 8iWsRSeHMDWyjiNmpzyD3Q-1 X-Mimecast-MFC-AGG-ID: 8iWsRSeHMDWyjiNmpzyD3Q_1771416368 To: devel@lists.libvirt.org Subject: [PATCH v3 01/38] qemu_firmware: Only set format for custom loader if path is present Date: Wed, 18 Feb 2026 13:05:24 +0100 Message-ID: <20260218120601.230343-2-abologna@redhat.com> In-Reply-To: <20260218120601.230343-1-abologna@redhat.com> References: <20260218120601.230343-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AjMDO4SlwQGRZYf6GUjRYqZ_7zJ0Lb1xfo1ymjciquY_1771416368 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: AHYK5BEXKW6OARJKAII4ABXS4KEHZUWY X-Message-ID-Hash: AHYK5BEXKW6OARJKAII4ABXS4KEHZUWY X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771416513346154100 Content-Type: text/plain; charset="utf-8"; x-default="true" We only set the template format if the template path is present, and we should be consistent with that. The format on its own is not very interesting anyway. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_firmware.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/qemu/qemu_firmware.c b/src/qemu/qemu_firmware.c index 436b06c388..519828f6f9 100644 --- a/src/qemu/qemu_firmware.c +++ b/src/qemu/qemu_firmware.c @@ -1662,8 +1662,10 @@ qemuFirmwareFillDomainCustom(virDomainDef *def) if (!loader) return; =20 - if (!loader->format) + if (loader->path && + !loader->format) { loader->format =3D VIR_STORAGE_FILE_RAW; + } =20 if (loader->nvramTemplate && !loader->nvramTemplateFormat) { --=20 2.53.0