From nobody Tue Mar 3 04:54:34 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771417043; cv=none; d=zohomail.com; s=zohoarc; b=af1yhlFt1/Gp40VryJ3BJ9wQ1oWfMEH90HxGSUOp0nLgu4UFRk3269cQmdq/dVVLJsoCACmiS+opfN9RMMhibg/AcQ1yogRpY0BnGJfRS6bq+Ds0W8Bh54uJ+6bfa+fsSlkvMKV3P/SdMisZyBJG4l9So2D2ZeqB53Lsu0POyTg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771417043; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Subject:Subject:To:To:Message-Id:Cc; bh=F87Ccu+Q5OXIC1qXXwoouSYy5jM6HUB+qm1ojBx2a2o=; b=oCP9sEg53y7kO9OuSQ5DcA8a4d4JuUQondJ9Pzf/DWC/Qin7XMVKAA84IE2wI4Brfo9GB7B1NwjBpXU7LoJFR+omj8sKCTgva8vlsxgmXw2fpL9IRBbbxKIo0WtbWMmAg6jiH7FkBDuq3Vu6Hty7JQd8z62bc/iqno5bOulEJLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1771417043892946.2655358250884; Wed, 18 Feb 2026 04:17:23 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 1B0BF41B37; Wed, 18 Feb 2026 07:17:23 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 0081141D11; Wed, 18 Feb 2026 07:09:42 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 8675841AB8; Wed, 18 Feb 2026 07:09:31 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id 568EF41B75 for ; Wed, 18 Feb 2026 07:06:25 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-513-cWmoklQiMgi8OvYs7BcFJA-1; Wed, 18 Feb 2026 07:06:23 -0500 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 193891800613 for ; Wed, 18 Feb 2026 12:06:23 +0000 (UTC) Received: from kinshicho.usersys.redhat.com (unknown [10.45.226.171]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0AACC30001A5 for ; Wed, 18 Feb 2026 12:06:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771416385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=F87Ccu+Q5OXIC1qXXwoouSYy5jM6HUB+qm1ojBx2a2o=; b=ScjPHPSAMkHnmKuOGF6TZN2yBQFiqyvhOSBXPwMti9u0smJYRIbXEx9uiAOLJeW9PxHS3l 9jRDXl0BCl9zRowyM6crtzxw47ns11MBXgfvIhY7TtFUA6Hqe0bFbhncKHBUUD4v2Uspn3 jaBoFo2GOoTRlgzxhU2LZISM6e2V3iw= X-MC-Unique: cWmoklQiMgi8OvYs7BcFJA-1 X-Mimecast-MFC-AGG-ID: cWmoklQiMgi8OvYs7BcFJA_1771416383 To: devel@lists.libvirt.org Subject: [PATCH v3 10/38] qemu: Validate presence of uefi-vars device Date: Wed, 18 Feb 2026 13:05:33 +0100 Message-ID: <20260218120601.230343-11-abologna@redhat.com> In-Reply-To: <20260218120601.230343-1-abologna@redhat.com> References: <20260218120601.230343-1-abologna@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 9aV4lxTZD_xcRiVfhUl5JQ14dfzeZvWWRAZIWXwDbaA_1771416383 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: 4UCJHDNKXCGGDGZXMDYTUW5QGJHMBW7G X-Message-ID-Hash: 4UCJHDNKXCGGDGZXMDYTUW5QGJHMBW7G X-MailFrom: abologna@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Andrea Bolognani via Devel Reply-To: Andrea Bolognani X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771417044408158500 Content-Type: text/plain; charset="utf-8"; x-default="true" The use of varstore requires the uefi-vars device to be present in the QEMU binary. Signed-off-by: Andrea Bolognani Reviewed-by: Daniel P. Berrang=C3=A9 --- src/qemu/qemu_validate.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/src/qemu/qemu_validate.c b/src/qemu/qemu_validate.c index 16dd5fef1a..0eb5d5ea3b 100644 --- a/src/qemu/qemu_validate.c +++ b/src/qemu/qemu_validate.c @@ -753,6 +753,23 @@ qemuValidateDomainDefNvram(const virDomainDef *def, } =20 =20 +static int +qemuValidateDomainDefVarstore(const virDomainDef *def, + virQEMUCaps *qemuCaps) +{ + if (!def->os.varstore) + return 0; + + if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_UEFI_VARS)) { + virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", + _("The uefi-vars device is not supported by this QE= MU binary")); + return -1; + } + + return 0; +} + + static int qemuValidateDomainDefBoot(const virDomainDef *def, virQEMUCaps *qemuCaps) @@ -796,6 +813,9 @@ qemuValidateDomainDefBoot(const virDomainDef *def, =20 if (qemuValidateDomainDefNvram(def, qemuCaps) < 0) return -1; + + if (qemuValidateDomainDefVarstore(def, qemuCaps) < 0) + return -1; } =20 for (i =3D 0; i < def->os.nacpiTables; i++) { --=20 2.53.0