From nobody Tue Mar 3 03:24:24 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771350997; cv=none; d=zohomail.com; s=zohoarc; b=oFYscKfTFW+owSbRobovYi8kwHXNmx677iT8Vd1hzOBUVxsidYaoqIrdboEEmtxKFdBYdEg+kuc96ZVrUCf78q0CcJG3ipOdodMa9L0+ruueCV4TsmGcOxCfLanngpeX+WSktzk30M0h39JF/AvXd54YVkaHFJI9EVk00es1Ugw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771350997; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=7Vp51W0wWu/941tLvMaR+hFypc5pwnR5yy6I8bdCaSE=; b=gqr0fdFZ+l8qpLY2U9ZSpL8TGdqv/B7Ul5HmXML0ul7UVDJo9P6XK/F2F+WtIXSqGX7LGrj7hE0T3v3BfFhn7pf6FobGO5bI2D+0bYwxjhCIlQSIZSGVmGKogZvGulCsrAHxIFrO/u9XC6dYWLY6Tvqaq+ceUNhyc4ST/6QgA0E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17713509973711004.9718431208903; Tue, 17 Feb 2026 09:56:37 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 31BD23F886; Tue, 17 Feb 2026 12:56:36 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id EDFE4418BD; Tue, 17 Feb 2026 12:55:51 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id DBCEB3F34E; Tue, 17 Feb 2026 12:55:46 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id E161F3F252 for ; Tue, 17 Feb 2026 12:55:45 -0500 (EST) Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-519-2zZSmpCdOiqcSqehz4MGbw-1; Tue, 17 Feb 2026 12:55:44 -0500 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8D2AB1800464 for ; Tue, 17 Feb 2026 17:55:43 +0000 (UTC) Received: from himantopus.redhat.com (unknown [10.22.80.90]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A7251800348 for ; Tue, 17 Feb 2026 17:55:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HELO_MISC_IP,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771350945; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=7Vp51W0wWu/941tLvMaR+hFypc5pwnR5yy6I8bdCaSE=; b=NYkn2ZreZiDUlRvSEupzx3tn2WIm2t+eGF+LAqlsNzxpAakcrbg1yskuqu1HtX466FRqD7 SmHqYX0rQhhbpOGP4bZaI3A3tC/WNlgw8Gsvia9GXF/cKh9IxgAQYgDYmxPOO/InDmVFYL IrZHIc7tFmdxkHqtZLk04HUKNpSKtKY= X-MC-Unique: 2zZSmpCdOiqcSqehz4MGbw-1 X-Mimecast-MFC-AGG-ID: 2zZSmpCdOiqcSqehz4MGbw_1771350943 To: devel@lists.libvirt.org Subject: [PATCH] hyperv: add support for secure boot configuration Date: Tue, 17 Feb 2026 11:55:41 -0600 Message-ID: <20260217175541.3030749-1-jjongsma@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Mq31TSaB_80bl1aFZmLJoOWiNLGc66Kaq_TOKeBcLFg_1771350943 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable Message-ID-Hash: C4J2XM4PJG6WNKE4SQRM3N7DR6L3OW2I X-Message-ID-Hash: C4J2XM4PJG6WNKE4SQRM3N7DR6L3OW2I X-MailFrom: jjongsma@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jonathon Jongsma via Devel Reply-To: Jonathon Jongsma X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771351000767158500 Content-Type: text/plain; charset="utf-8"; x-default="true" When getting the xml description of a guest, check if secure boot is enabled and set firmware features accordingly. Also support firmware autoselection and honor the secure boot setting when defining new vms from xml. Signed-off-by: Jonathon Jongsma Reviewed-by: Michal Privoznik --- src/hyperv/hyperv_driver.c | 33 ++++++++++++++++++++++++++++++++- src/hyperv/hyperv_driver.h | 3 +++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/src/hyperv/hyperv_driver.c b/src/hyperv/hyperv_driver.c index eb28093028..ae9502404c 100644 --- a/src/hyperv/hyperv_driver.c +++ b/src/hyperv/hyperv_driver.c @@ -2743,6 +2743,22 @@ hypervDomainGetXMLDesc(virDomainPtr domain, unsigned= int flags) =20 def->os.type =3D VIR_DOMAIN_OSTYPE_HVM; =20 + /* Generation 2 VMs use UEFI firmware */ + if (STREQ_NULLABLE(virtualSystemSettingData->data->VirtualSystemSubTyp= e, HYPERV_VM_GEN2)) { + def->os.firmware =3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI; + + if (virtualSystemSettingData->data->SecureBootEnabled) { + int *features =3D g_new0(int, VIR_DOMAIN_OS_DEF_FIRMWARE_FEATU= RE_LAST); + + /* Hyper-V doesn't distinguish between secure-boot and enrolle= d-keys, + * so set both when SecureBootEnabled is true */ + features[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_SECURE_BOOT] =3D V= IR_TRISTATE_BOOL_YES; + features[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_ENROLLED_KEYS] =3D= VIR_TRISTATE_BOOL_YES; + + def->os.firmwareFeatures =3D features; + } + } + /* Allocate space for all potential devices */ =20 /* 256 scsi drives + 4 ide drives */ @@ -2948,6 +2964,20 @@ hypervDomainDefineXML(virConnectPtr conn, const char= *xml) if (hypervSetEmbeddedProperty(defineSystemParam, "ElementName", def->n= ame) < 0) goto error; =20 + /* Set firmware settings */ + if (def->os.firmware =3D=3D VIR_DOMAIN_OS_DEF_FIRMWARE_EFI) { + /* Generation 2 VM (UEFI) */ + if (hypervSetEmbeddedProperty(defineSystemParam, "VirtualSystemSub= Type", HYPERV_VM_GEN2) < 0) + goto error; + + if (def->os.firmwareFeatures && + (def->os.firmwareFeatures[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_S= ECURE_BOOT] =3D=3D VIR_TRISTATE_BOOL_YES || + def->os.firmwareFeatures[VIR_DOMAIN_OS_DEF_FIRMWARE_FEATURE_E= NROLLED_KEYS] =3D=3D VIR_TRISTATE_BOOL_YES)) { + if (hypervSetEmbeddedProperty(defineSystemParam, "SecureBootEn= abled", "true") < 0) + goto error; + } + } + if (hypervAddEmbeddedParam(params, "SystemSettings", &defineSystemParam, Msvm_VirtualSystemSetti= ngData_WmiInfo) < 0) goto error; @@ -3889,7 +3919,8 @@ static virHypervisorDriver hypervHypervisorDriver =3D= { =20 =20 virDomainDefParserConfig hypervDomainDefParserConfig =3D { - .features =3D VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG, + .features =3D VIR_DOMAIN_DEF_FEATURE_MEMORY_HOTPLUG | + VIR_DOMAIN_DEF_FEATURE_FW_AUTOSELECT, }; =20 =20 diff --git a/src/hyperv/hyperv_driver.h b/src/hyperv/hyperv_driver.h index 3764844494..aa2a820830 100644 --- a/src/hyperv/hyperv_driver.h +++ b/src/hyperv/hyperv_driver.h @@ -27,4 +27,7 @@ #define HYPERV_MAX_IDE_CHANNELS 2 #define HYPERV_MAX_DRIVES_PER_IDE_CHANNEL 2 =20 +#define HYPERV_VM_GEN1 "Microsoft:Hyper-V:SubType:1" +#define HYPERV_VM_GEN2 "Microsoft:Hyper-V:SubType:2" + int hypervRegister(void); --=20 2.53.0