From nobody Tue Mar 3 03:02:47 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1771236205; cv=none; d=zohomail.com; s=zohoarc; b=PhKzaaOfkGXMMV2rz/QIX1L+AYlvX/K53YFa+Jfyk8r3FrJi70fAnzHB1mJ1n2czTOmd8dkhmq6pJ4nsUqOqE9rXYvyalXIEPbS+RCd8bkV8dtsj3Wgs35si6uUuS0J+v3zNOt+yMQGQw0O+ABMy+xqXDtBjOqnSVtKn74BbEtM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1771236205; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=xpl6UbdGZDLqjlMgw5QBLbzYerCqQwWHfBD3Xt1n4Ak=; b=f6Cyj6pgUNqmcoTKq2qPr/fikNm0EobQX85Q2E+4InvRY4BXYdZTo4HyF+ZhiWq2K9qUqdsvQRG+JDnvFMt9cgxMHjdtDPVsV3us8x9X6jsvQa8JVZHhuDTbfpQQYU8bKZDb1GHqMfU0zzWubWr1HUeQ3XgNM9QTU9TbVKW2QUY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 17712362049931008.1119391021853; Mon, 16 Feb 2026 02:03:24 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 9B48C3F8AD; Mon, 16 Feb 2026 05:03:23 -0500 (EST) Received: from [172.19.199.9] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 568F23FBB5; Mon, 16 Feb 2026 05:02:47 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id D2B3F3F802; Mon, 16 Feb 2026 05:02:43 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id C3EC23F817 for ; Mon, 16 Feb 2026 05:02:42 -0500 (EST) Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-cDzj-QeQPaOEDpvMP70Uog-1; Mon, 16 Feb 2026 05:02:40 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0055F180061C for ; Mon, 16 Feb 2026 10:02:40 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.45.225.52]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id BE1521800465; Mon, 16 Feb 2026 10:02:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771236162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=xpl6UbdGZDLqjlMgw5QBLbzYerCqQwWHfBD3Xt1n4Ak=; b=ZHVsamh+zlgN1xdw4olLK2RzUJCQIG3BuuntdFRGNugBZnll6/+Y5+a8yW6PewMWsULvvD otLUt0WCLGk5SrF9LDG2phw9zJhhwF4nytY0nLL1Rly+LXXf7QsxMkIZgMYFckSkMpvwZ2 0lcshFPFzZHP/QB1mw+mxFQzubISVAs= X-MC-Unique: cDzj-QeQPaOEDpvMP70Uog-1 X-Mimecast-MFC-AGG-ID: cDzj-QeQPaOEDpvMP70Uog_1771236160 To: devel@lists.libvirt.org Subject: [PATCH] scripts: avoid matching 'char **' as string for systemtap Date: Mon, 16 Feb 2026 10:02:37 +0000 Message-ID: <20260216100237.3635997-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3X529AG45Ll_8IlALvfjhmW35js9t7y7TYBpX6758p0_1771236160 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: MNNUHN7ADPSOPM6TE3FVY2CQXAQV6ALR X-Message-ID-Hash: MNNUHN7ADPSOPM6TE3FVY2CQXAQV6ALR X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1771236207690158500 From: Daniel P. Berrang=C3=A9 When a probe argument is declared "char *" we reference the userspace string value using 'user_string(...)' for systemtap. Unfortunately our code generator also matches on args declared "char **" and generates bogus code *cert =3D user_string($arg4); which is a syntax error for systemtap. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik --- scripts/dtrace2systemtap.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/dtrace2systemtap.py b/scripts/dtrace2systemtap.py index 506db9c503..361dab1075 100755 --- a/scripts/dtrace2systemtap.py +++ b/scripts/dtrace2systemtap.py @@ -124,7 +124,7 @@ for file in filelist: for idx in range(len(argbits)): arg =3D argbits[idx] isstr =3D False - if 'char *' in arg: + if re.match(r'''.*char\s\*[^\*].*''', arg) is not None: isstr =3D True =20 m =3D re.search(r'''^.*\s\*?(\S+)$''', arg) --=20 2.53.0