From nobody Wed Apr 15 07:02:45 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) client-ip=8.43.85.245; envelope-from=devel-bounces@lists.libvirt.org; helo=lists.libvirt.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass(p=reject dis=none) header.from=lists.libvirt.org ARC-Seal: i=1; a=rsa-sha256; t=1770905964; cv=none; d=zohomail.com; s=zohoarc; b=hQ0JUN7YbSAhOo+Bttp9ZgHTu+O/b9CSoN8N989YRBtjKK354mcY3vo7EbUeF8kQbuoBDIhRJXa9RpaGfBq1FC1BywHGJqfdH/iv7xLAgx8I6WgxM1YbCZhcqwVrYxf/oofcz+GIYyy9Wqs9kyUwrQqKFyv5Uqi1hBFbKNIKbOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1770905964; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Owner:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Subject:Subject:To:To:Message-Id:Cc; bh=wFMDrNCncHNArZJVh0lCbWe2THgaAbNgda9oDA3pmmw=; b=U/VUZzHSfHijWVDt9rgp5oqN7ix2plljNUQhvZMMPN37DWRfvWND+zPuUSqyaIdmjHZPN9c0RKy6R1i7RWZV8aE0PqlCvzHhci2cC8VlcjHJG/1miKtUuNxF0Rbps4lw8ARWEyxHZAhVO5Zn6olABbvD6CD6QkCAWRQ+91eYXj0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of lists.libvirt.org designates 8.43.85.245 as permitted sender) smtp.mailfrom=devel-bounces@lists.libvirt.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.libvirt.org (lists.libvirt.org [8.43.85.245]) by mx.zohomail.com with SMTPS id 1770905964822816.9842939873479; Thu, 12 Feb 2026 06:19:24 -0800 (PST) Received: by lists.libvirt.org (Postfix, from userid 993) id 400E4446A1; Thu, 12 Feb 2026 09:19:24 -0500 (EST) Received: from [172.19.199.6] (lists.libvirt.org [8.43.85.245]) by lists.libvirt.org (Postfix) with ESMTP id 3A5A744D3C; Thu, 12 Feb 2026 07:53:17 -0500 (EST) Received: by lists.libvirt.org (Postfix, from userid 993) id 3145E41A0F; Thu, 12 Feb 2026 07:51:48 -0500 (EST) Received: from mx1.osci.io (unknown [8.43.85.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (3072 bits) server-digest SHA256) (No client certificate requested) by lists.libvirt.org (Postfix) with ESMTPS id CB96A46439 for ; Thu, 12 Feb 2026 07:40:15 -0500 (EST) Received: by mx1.osci.io (Postfix, from userid 995) id 4D6502BDD3; Wed, 11 Feb 2026 15:20:18 -0500 (EST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mx1.osci.io (Postfix) with ESMTPS id D6DC52BCA1 for ; Wed, 11 Feb 2026 15:20:17 -0500 (EST) Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-658-9yHuJxYENmyG2mCjJhZmHw-1; Wed, 11 Feb 2026 15:20:15 -0500 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id B2BE11956068 for ; Wed, 11 Feb 2026 20:20:14 +0000 (UTC) Received: from toolbx.redhat.com (unknown [10.45.227.9]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AF47C1800296; Wed, 11 Feb 2026 20:20:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on lists.libvirt.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED,SPF_PASS autolearn=unavailable autolearn_force=no version=4.0.1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770841217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wFMDrNCncHNArZJVh0lCbWe2THgaAbNgda9oDA3pmmw=; b=cvI2I1U590ci67mQLDRrO6ocRTS4lhm1RYSdISTid/w1Qt/eoFSQ/FiTHFaLgEU3sJdi61 Gr+yATVKvMo1hfPV8I9A3eLykpz44Lc6MmH/oFXf8BapVUSC5t78ooO24ylekTdxJEJ2Kp tzZruFuP+H0nBlihDM/S+0dKigJSohk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770841217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wFMDrNCncHNArZJVh0lCbWe2THgaAbNgda9oDA3pmmw=; b=cvI2I1U590ci67mQLDRrO6ocRTS4lhm1RYSdISTid/w1Qt/eoFSQ/FiTHFaLgEU3sJdi61 Gr+yATVKvMo1hfPV8I9A3eLykpz44Lc6MmH/oFXf8BapVUSC5t78ooO24ylekTdxJEJ2Kp tzZruFuP+H0nBlihDM/S+0dKigJSohk= X-MC-Unique: 9yHuJxYENmyG2mCjJhZmHw-1 X-Mimecast-MFC-AGG-ID: 9yHuJxYENmyG2mCjJhZmHw_1770841214 To: devel@lists.libvirt.org Subject: [PATCH] network: add comment to table that it belongs to libvirt Date: Wed, 11 Feb 2026 20:19:19 +0000 Message-ID: <20260211201919.1223165-1-berrange@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FL8HR0l_je8CzptdwGrdsQwwci602SUszkTOxq0Ov7U_1770841214 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-ID-Hash: PX3S6JMSOXHKGT4XWBO45JPMI3JRT3E2 X-Message-ID-Hash: PX3S6JMSOXHKGT4XWBO45JPMI3JRT3E2 X-MailFrom: berrange@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-devel.lists.libvirt.org-0; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Development discussions about the libvirt library & tools Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: =?utf-8?q?Daniel_P=2E_Berrang=C3=A9_via_Devel?= Reply-To: =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1770905966205154100 From: Daniel P. Berrang=C3=A9 The result looks like $ nft list ruleset ...snip... table ip6 libvirt_network { comment "Managed by libvirt for virtual networks: https://libvirt.org/fi= rewall.html#the-virtual-network-driver" chain forward { ...snip... This should reduce the number of people wondering why these rules exists. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Michal Privoznik Reviewed-by: Peter Krempa --- src/network/network_nftables.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/network/network_nftables.c b/src/network/network_nftables.c index cffe8072f5..cd46ff8d83 100644 --- a/src/network/network_nftables.c +++ b/src/network/network_nftables.c @@ -61,6 +61,10 @@ VIR_LOG_INIT("network.nftables"); =20 #define VIR_NFTABLES_PRIVATE_TABLE "libvirt_network" =20 +#define VIR_NFTABLES_COMMENT \ + "{ comment \"Managed by libvirt for virtual networks: " \ + "https://libvirt.org/firewall.html#the-virtual-network-driver\"; }" + /* nftables backend uses the same binary (nft) for all layers, but * IPv4 and IPv6 have their rules in separate classes of tables, * either "ip" or "ip6". (there is also an "inet" class of tables that @@ -165,7 +169,9 @@ nftablesPrivateChainCreate(virFirewall *fw, =20 if (!tableMatch) { virFirewallAddCmd(fw, layer, "add", "table", - layerStr, VIR_NFTABLES_PRIVATE_TABLE, NULL); + layerStr, VIR_NFTABLES_PRIVATE_TABLE, + VIR_NFTABLES_COMMENT, + NULL); } =20 for (i =3D 0; i < data->nchains; i++) { --=20 2.53.0